51667 2010-12-27 21:56:08 -0800 JSON.stringify must exist as a function taking 3 parameters 2010-12-29 23:14:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 51666 41876 0 helder webkit-unassigned commit-queue oldest_to_newest 327192 0 helder 2010-12-27 21:56:08 -0800 The reported function length is 1 instead. 327193 1 77537 helder 2010-12-27 22:15:55 -0800 Created attachment 77537 Patch Diff is applied to patch 77536 from bug 51666. 327348 2 77537 eric 2010-12-28 13:55:13 -0800 Comment on attachment 77537 Patch It appears it does actually take 3 values: // ECMA-262 v5 15.12.3 EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState* exec) { if (!exec->argumentCount()) return throwVMError(exec, createError(exec, "No input to stringify")); JSValue value = exec->argument(0); JSValue replacer = exec->argument(1); JSValue space = exec->argument(2); return JSValue::encode(Stringifier(exec, replacer, space).stringify(value)); } We need to find a way to catch this class of bugs somehow. 327387 3 commit-queue 2010-12-28 14:44:26 -0800 The commit-queue encountered the following flaky tests while processing attachment 77537: java/java-and-plugins.html bug 51690 (authors: ap@webkit.org and barraclough@apple.com) The commit-queue is continuing to process your patch. 327388 4 77537 commit-queue 2010-12-28 14:45:32 -0800 Comment on attachment 77537 Patch Clearing flags on attachment: 77537 Committed r74727: <http://trac.webkit.org/changeset/74727> 327389 5 commit-queue 2010-12-28 14:45:38 -0800 All reviewed patches have been landed. Closing bug. 77537 2010-12-27 22:15:55 -0800 2010-12-28 14:45:32 -0800 Patch stringify-final.patch text/plain 2400 helder ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlM2RkZWIxLi5lZjI3ZWM5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTAtMTItMjcgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNPTi5zdHJpbmdp ZnkgbXVzdCBleGlzdCBhcyBhIGZ1bmN0aW9uIHRha2luZyAzIHBhcmFtZXRlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjY3CisKKyAgICAgICAg VGhlIHJlcG9ydGVkIGZ1bmN0aW9uIGxlbmd0aCBpcyAxIGluc3RlYWQuCisKKyAgICAgICAgVGVz dDogaWV0ZXN0Y2VudGVyL0phdmFzY3JpcHQvMTUuMTIuMy0wLTIuaHRtbAorCisgICAgICAgICog cnVudGltZS9KU09OT2JqZWN0LmNwcDoKKwogMjAxMC0xMi0yNiAgWGFuIExvcGV6ICA8eGxvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwIGIvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAppbmRleCBiNTQ3N2ExLi4zOGQ3NjU3IDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCisrKyBiL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKQEAgLTYwNyw3ICs2MDcsNyBAQCBjb25zdCBD bGFzc0luZm8gSlNPTk9iamVjdDo6aW5mbyA9IHsgIkpTT04iLCAwLCAwLCBFeGVjU3RhdGU6Ompz b25UYWJsZSB9OwogLyogU291cmNlIGZvciBKU09OT2JqZWN0Lmx1dC5oCiBAYmVnaW4ganNvblRh YmxlCiAgIHBhcnNlICAgICAgICAgSlNPTlByb3RvRnVuY1BhcnNlICAgICAgICAgICAgIERvbnRF bnVtfEZ1bmN0aW9uIDIKLSAgc3RyaW5naWZ5ICAgICBKU09OUHJvdG9GdW5jU3RyaW5naWZ5ICAg ICAgICAgRG9udEVudW18RnVuY3Rpb24gMQorICBzdHJpbmdpZnkgICAgIEpTT05Qcm90b0Z1bmNT dHJpbmdpZnkgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAzCiBAZW5kCiAqLwogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MDlhM2U2ZS4uYjQxYjVhMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTEyLTI3ICBIZWxk ZXIgQ29ycmVpYSAgPGhlbGRlckBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTT04uc3RyaW5naWZ5IG11c3QgZXhpc3QgYXMgYSBm dW5jdGlvbiB0YWtpbmcgMyBwYXJhbWV0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTY2NworCisgICAgICAgIFRoZSByZXBvcnRlZCBmdW5jdGlv biBsZW5ndGggaXMgMSBpbnN0ZWFkLgorCisgICAgICAgICogaWV0ZXN0Y2VudGVyL0phdmFzY3Jp cHQvMTUuMTIuMy0wLTItZXhwZWN0ZWQudHh0OgorCiAyMDEwLTEyLTI3ICBLZW5qaSBJbWFzYWtp ICA8aW1hc2FraUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2 aW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pZXRlc3RjZW50ZXIvSmF2YXNjcmlwdC8xNS4x Mi4zLTAtMi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pZXRlc3RjZW50ZXIvSmF2YXNjcmlw dC8xNS4xMi4zLTAtMi1leHBlY3RlZC50eHQKaW5kZXggMTVmMjY0ZC4uOTE2MDYwZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaWV0ZXN0Y2VudGVyL0phdmFzY3JpcHQvMTUuMTIuMy0wLTItZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2lldGVzdGNlbnRlci9KYXZhc2NyaXB0LzE1LjEy LjMtMC0yLWV4cGVjdGVkLnR4dApAQCAtNCw3ICs0LDcgQEAgT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUKIAogCiBQQVNTIEVTNUhhcm5lc3MucHJlY29uZGl0aW9uUGFzc2VkIGlzIHRydWUKLUZBSUwg RVM1SGFybmVzcy50ZXN0UGFzc2VkIHNob3VsZCBiZSB0cnVlIChvZiB0eXBlIGJvb2xlYW4pLiBX YXMgdW5kZWZpbmVkIChvZiB0eXBlIHVuZGVmaW5lZCkuCitQQVNTIEVTNUhhcm5lc3MudGVzdFBh c3NlZCBpcyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09N UExFVEUK