5160 2005-09-27 22:26:19 -0700 REGRESSION: text inside inline-block DIV changes the DIV's baseline for vertical-align:baseline 2006-12-15 11:26:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED INVALID InRadar, Regression P1 Normal --- 1 mitz hyatt alice.barraclough darin ian oldest_to_newest 20710 0 mitz 2005-09-27 22:26:19 -0700 Summary: When vertical-align:baseline is used, a DIV with display:inline-block containing text behaves like it has a baseline, which is the baseline of one of its contained inline boxes. It should behave like the DIV's bottom is its baseline. To reproduce: open the testcase. Expected: The red shapes to be identical to the green shape. Actual: In the second case, the first lines of contained text are aligned with each other and with the bottom of the DIVs not containing text. In the third case, the last lines of contained text are aligned with each other and with the bottom of the DIVs not containing text. 20711 1 4075 mitz 2005-09-27 22:26:58 -0700 Created attachment 4075 testcase 20712 2 mitz 2005-09-27 23:04:19 -0700 This is a regression from the last released version. 20750 3 hyatt 2005-09-28 11:17:30 -0700 See: http://www.w3.org/TR/CSS21/visudet.html Scroll to the very bottom of that document: "A UA should use the baseline of the last line box in the normal flow in the element as the baseline of an 'inline-block', or the element's bottom margin edge, if there is none." I made this change deliberately to be compliant with this part of the spec (despite the spec being pathetically ambiguous and not addressing what to do if the inline block has overflow or the line is outside its bounds, etc.). 20754 4 mitz 2005-09-28 11:33:16 -0700 Heh, I spent an hour staring at the part of the spec just above the last 2 paragraphs, wondering if this was a deliberate change or a regression, before opening this bug. I'm not sure why you didn't close it (perhaps because in the middle case it uses the first line rather than the last?). 20850 5 hyatt 2005-09-28 14:07:04 -0700 I didn't close it because it's kind of an issue. For example, several Dashboard widgets have been broken by this change, despite being in strict mode. We're going to have to figure something out. Note this change was necessary for the new button controls, which are inline blocks that need to properly support baseline alignment. 26960 6 4075 eric 2005-12-28 01:44:58 -0800 Comment on attachment 4075 testcase I'm marking this test case for review. The bug seems to be already fixed. This test case might still be useful however. 27019 7 joost 2005-12-28 07:11:24 -0800 The bug is definitly not fixed for me... 27037 8 4075 darin 2005-12-28 10:38:15 -0800 Comment on attachment 4075 testcase It's fine to land this test case, but marking it as review+ is going to misleadingly put this bug into the "needs commit" query. 27217 9 mjs 2005-12-30 00:25:31 -0800 The test case doesn't look the way it is describes itself in TOT. While landing a test that documents our inline block behavior seems good, we should probably have one that describes our current result as the correct one, if we think it is correct. 28170 10 alice.barraclough 2006-01-10 10:35:32 -0800 <rdar://problem/4404322> 28364 11 4075 darin 2006-01-13 08:55:00 -0800 Comment on attachment 4075 testcase Given Maciej's comments, I'm setting the patch to review-. We can land a test for this if we revise it to no longer be misleading. 29348 12 joost 2006-01-22 04:35:22 -0800 Adding Regression keyword. 41971 13 hyatt 2006-12-14 22:45:04 -0800 We're keeping this new behavior. 41928 14 darin 2006-12-15 11:25:36 -0800 Changing resolution from FIXED to more appropriate one. 4075 2005-09-27 22:26:58 -0700 2006-01-13 08:55:00 -0800 testcase inlineBlocks.html text/html 1912 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPFRJVExFPmlubGluZSBibG9ja3M8L1RJVExFPgo8L0hFQUQ+DQo8Qk9EWT4KPHA+VGhl IHJlZCBzaGFwZXMgc2hvdWxkIGJlIGlkZW50aWNhbCB0byB0aGUgZ3JlZW4gc2hhcGUuPC9wPgo8 cD52ZXJ0aWNhbC1hbGlnbjpib3R0b208L3A+CjxkaXYgc3R5bGU9InZlcnRpY2FsLWFsaWduOmJv dHRvbTsgZGlzcGxheTppbmxpbmUtYmxvY2s7IGhlaWdodDoxMDBweDsgYmFja2dyb3VuZDpncmVl bjsgd2lkdGg6NTBweDsiPkp1c3QgYSBmZXcgd29yZHM8L2Rpdj48ZGl2IHN0eWxlPSJ2ZXJ0aWNh bC1hbGlnbjpib3R0b207IGRpc3BsYXk6aW5saW5lLWJsb2NrOyBoZWlnaHQ6MTAwcHg7IGJhY2tn cm91bmQ6Z3JlZW47IHdpZHRoOjUwcHg7Ij5BPC9kaXY+PGRpdiBzdHlsZT0idmVydGljYWwtYWxp Z246Ym90dG9tOyBkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0OjUwcHg7IGJhY2tncm91bmQ6 Z3JlZW47IHdpZHRoOjUwcHg7Ij5CPC9kaXY+PGRpdiBzdHlsZT0idmVydGljYWwtYWxpZ246Ym90 dG9tOyBkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0OjEwMHB4OyBiYWNrZ3JvdW5kOmdyZWVu OyB3aWR0aDo1MHB4OyI+PC9kaXY+PGRpdiBzdHlsZT0idmVydGljYWwtYWxpZ246Ym90dG9tOyBk aXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0OjUwcHg7IGJhY2tncm91bmQ6Z3JlZW47IHdpZHRo OjUwcHg7Ij48L2Rpdj4KPHA+dmVydGljYWwtYWxpZ246YmFzZWxpbmU8L3A+CjxkaXYgc3R5bGU9 InZlcnRpY2FsLWFsaWduOmJvdHRvbTsgZGlzcGxheTppbmxpbmUtYmxvY2s7IGhlaWdodDoxMDBw eDsgYmFja2dyb3VuZDpyZWQ7IHdpZHRoOjUwcHg7Ij5KdXN0IGEgZmV3IHdvcmRzPC9kaXY+PGRp diBzdHlsZT0idmVydGljYWwtYWxpZ246YmFzZWxpbmU7IGRpc3BsYXk6aW5saW5lLWJsb2NrOyBo ZWlnaHQ6MTAwcHg7IGJhY2tncm91bmQ6cmVkOyB3aWR0aDo1MHB4OyI+QTwvZGl2PjxkaXYgc3R5 bGU9InZlcnRpY2FsLWFsaWduOmJhc2VsaW5nOyBkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0 OjUwcHg7IGJhY2tncm91bmQ6cmVkOyB3aWR0aDo1MHB4OyI+QjwvZGl2PjxkaXYgc3R5bGU9InZl cnRpY2FsLWFsaWduOmJhc2VsaW5lOyBkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0OjEwMHB4 OyBiYWNrZ3JvdW5kOnJlZDsgd2lkdGg6NTBweDsiPjwvZGl2PjxkaXYgc3R5bGU9InZlcnRpY2Fs LWFsaWduOmJhc2VsaW5lOyBkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0OjUwcHg7IGJhY2tn cm91bmQ6cmVkOyB3aWR0aDo1MHB4OyI+PC9kaXY+CjxwPgp2ZXJ0aWNhbC1hbGlnbjpiYXNlbGlu ZSBpbnNpZGUgYSAmbHQ7UCZndDsgKGludmFsaWQgSFRNTCkKPGRpdiBzdHlsZT0iZGlzcGxheTpp bmxpbmUtYmxvY2s7IGhlaWdodDoxMDBweDsgYmFja2dyb3VuZDpyZWQ7IHdpZHRoOjUwcHg7Ij5K dXN0IGEgZmV3IHdvcmRzPC9kaXY+PGRpdiBzdHlsZT0iZGlzcGxheTppbmxpbmUtYmxvY2s7IGhl aWdodDoxMDBweDsgYmFja2dyb3VuZDpyZWQ7IHdpZHRoOjUwcHg7Ij5BPC9kaXY+PGRpdiBzdHls ZT0iZGlzcGxheTppbmxpbmUtYmxvY2s7IGhlaWdodDo1MHB4OyBiYWNrZ3JvdW5kOnJlZDsgd2lk dGg6NTBweDsiPkI8L2Rpdj48ZGl2IHN0eWxlPSJkaXNwbGF5OmlubGluZS1ibG9jazsgaGVpZ2h0 OjEwMHB4OyBiYWNrZ3JvdW5kOnJlZDsgd2lkdGg6NTBweDsiPjwvZGl2PjxkaXYgc3R5bGU9ImRp c3BsYXk6aW5saW5lLWJsb2NrOyBoZWlnaHQ6NTBweDsgYmFja2dyb3VuZDpyZWQ7IHdpZHRoOjUw cHg7Ij48L2Rpdj4KPC9wPgo8L0JPRFk+PC9IVE1MPg==