51554 2010-12-23 12:38:48 -0800 Compiler warning in double->int conversion in TestNetscapePlugIn 2011-06-18 13:10:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 51551 1 evan evan eric webkit.review.bot oldest_to_newest 326223 0 evan 2010-12-23 12:38:48 -0800 Compiler warning in double->int conversion in TestNetscapePlugIn 326224 1 77360 evan 2010-12-23 12:39:55 -0800 Created attachment 77360 Patch 326227 2 evan 2010-12-23 12:41:12 -0800 I'm not sure this is correct, but the npruntime.h docs list JS to NPVariant type mappings, and it says: Number NPVariantType_Double or NPVariantType_Int32 Does that mean both the doubleValue and the intValue are filled in? ...wait a sec, it's a union, this can't be right. Let me retry. 326230 3 77361 evan 2010-12-23 12:43:04 -0800 Created attachment 77361 Patch 326231 4 77360 darin 2010-12-23 12:43:17 -0800 Comment on attachment 77360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77360&action=review This change is wrong. I have no idea why the test case works! > Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:66 > - int32_t number = arguments[1].value.doubleValue; > + int32_t number = arguments[1].value.intValue; This is incorrect. The code above checks for NPVARIANT_IS_DOUBLE, and it won’t work to just read intValue in that case. You can only read the union member that correctly corresponds to the variant that was used. For example, if you call NPVARIANT_IS_INT32 then you can read intValue. 326232 5 evan 2010-12-23 12:45:26 -0800 (I'm hoping the bots try this change for me, which is how I managed to upload the previous change which was totally wrong.) 326432 6 eric 2010-12-23 19:09:09 -0800 You can force the bots to try a patch with queues.webkit.org/submit-to-ews 423203 7 77361 webkit.review.bot 2011-06-18 13:10:27 -0700 Comment on attachment 77361 Patch Clearing flags on attachment: 77361 Committed r89202: <http://trac.webkit.org/changeset/89202> 423204 8 webkit.review.bot 2011-06-18 13:10:32 -0700 All reviewed patches have been landed. Closing bug. 77360 2010-12-23 12:39:55 -0800 2010-12-23 12:43:17 -0800 Patch bug-51554-20101223123951.patch text/plain 1690 evan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODYx ZGMwZjE1MWZmN2QxZTE0ZDZlYmYwZWI0Y2Q4MjVlYmRiNjY5Li40MGM4NzgwOWU3YTY4OTIzMTAz NDIwMDVlZGUxNDg2NmQ1ZTJlYjNhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMjMgIEV2YW4gTWFydGlu ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ29tcGlsZXIgd2FybmluZyBpbiBkb3VibGUtPmludCBjb252ZXJzaW9u IGluIFRlc3ROZXRzY2FwZVBsdWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE1NTQKKworICAgICAgICBUaGlzIGNvZGUgaXMgcHJvdmlkaW5nIGEg SlMgQVBJIGZvciByZW1vdmluZyBhIHByb3BlcnR5IGJ5IG51bWVyaWMgSUQuCisgICAgICAgIFJh dGhlciB0aGFuIHJlYWQgb3V0IHRoZSBwYXJhbWV0ZXIgYXMgYSBkb3VibGUsIHJlYWQgaXQgYXMg YW4gaW50LgorCisgICAgICAgIFRlc3Q6IExheW91dFRlc3RzL3BsdWdpbnMvbnBydW50aW1lL3Jl bW92ZS1wcm9wZXJ0eS5odG1sCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vVGVzdHMvTlBSdW50aW1lUmVtb3ZlUHJvcGVydHkuY3BwOgorICAgICAgICAoTlBS dW50aW1lUmVtb3ZlUHJvcGVydHk6OlRlc3RPYmplY3Q6Omludm9rZSk6CisKIDIwMTAtMTItMjMg IEx1Y2FzIEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVz dE5ldHNjYXBlUGx1Z0luL1Rlc3RzL05QUnVudGltZVJlbW92ZVByb3BlcnR5LmNwcCBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9OUFJ1bnRpbWVSZW1vdmVQ cm9wZXJ0eS5jcHAKaW5kZXggNGQ0MTdkMTI4OTYwNGI5NGQxOTBmNjJkZTlkNWNkNmM4NTFhY2Yz MS4uNmU4NDRlODBiNjJhMmRkZDU5ZjA2ZTJlMjM2ZDgzMWJkNzg1ZTRhMSAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Rlc3RzL05QUnVudGltZVJl bW92ZVByb3BlcnR5LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4vVGVzdHMvTlBSdW50aW1lUmVtb3ZlUHJvcGVydHkuY3BwCkBAIC02Myw3ICs2Myw3IEBA IHByaXZhdGU6CiAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBwcm9wZXJ0eU5hbWUgPSBw bHVnaW5UZXN0KCktPk5QTl9HZXRTdHJpbmdJZGVudGlmaWVyKHByb3BlcnR5TmFtZVN0cmluZy5j X3N0cigpKTsKICAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgaW50MzJfdCBu dW1iZXIgPSBhcmd1bWVudHNbMV0udmFsdWUuZG91YmxlVmFsdWU7CisgICAgICAgICAgICAgICAg aW50MzJfdCBudW1iZXIgPSBhcmd1bWVudHNbMV0udmFsdWUuaW50VmFsdWU7CiAgICAgICAgICAg ICAgICAgcHJvcGVydHlOYW1lID0gcGx1Z2luVGVzdCgpLT5OUE5fR2V0SW50SWRlbnRpZmllcihu dW1iZXIpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgCg== 77361 2010-12-23 12:43:04 -0800 2011-06-18 13:10:27 -0700 Patch bug-51554-20101223124258.patch text/plain 1726 evan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODYx ZGMwZjE1MWZmN2QxZTE0ZDZlYmYwZWI0Y2Q4MjVlYmRiNjY5Li4yMDgyMjkyOWFhM2Y5YjZjYTU3 YzkwYjAzNmQwYzMzN2MyNTdmNjkxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMjMgIEV2YW4gTWFydGlu ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ29tcGlsZXIgd2FybmluZyBpbiBkb3VibGUtPmludCBjb252ZXJzaW9u IGluIFRlc3ROZXRzY2FwZVBsdWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE1NTQKKworICAgICAgICBUaGlzIGNvZGUgaXMgcHJvdmlkaW5nIGEg SlMgQVBJIGZvciByZW1vdmluZyBhIHByb3BlcnR5IGJ5IG51bWVyaWMgSUQuCisgICAgICAgIFdl IGdldCBpdCBmcm9tIEpTIGFzIGEgZG91YmxlLCBhbmQgbXVzdCBjb252ZXJ0IGl0IHRvIGFuIGlu dCBiZWZvcmUgdXNpbmcgaXQuCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvcGx1Z2lucy9u cHJ1bnRpbWUvcmVtb3ZlLXByb3BlcnR5Lmh0bWwKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L1Rlc3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9OUFJ1bnRpbWVSZW1vdmVQcm9wZXJ0eS5jcHA6Cisg ICAgICAgIChOUFJ1bnRpbWVSZW1vdmVQcm9wZXJ0eTo6VGVzdE9iamVjdDo6aW52b2tlKToKKwog MjAxMC0xMi0yMyAgTHVjYXMgRm9yc2NobGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMvTlBSdW50aW1lUmVtb3ZlUHJvcGVydHku Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Rlc3RzL05QUnVu dGltZVJlbW92ZVByb3BlcnR5LmNwcAppbmRleCA0ZDQxN2QxMjg5NjA0Yjk0ZDE5MGY2MmRlOWQ1 Y2Q2Yzg1MWFjZjMxLi4wZWY2MGI2MzgyMGNjNjkyMjFiOTcyZjIzNDFlMmMzZWM1ZjIzOGIxIDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMv TlBSdW50aW1lUmVtb3ZlUHJvcGVydHkuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9OUFJ1bnRpbWVSZW1vdmVQcm9wZXJ0eS5jcHAKQEAgLTYz LDcgKzYzLDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIHByb3Bl cnR5TmFtZSA9IHBsdWdpblRlc3QoKS0+TlBOX0dldFN0cmluZ0lkZW50aWZpZXIocHJvcGVydHlO YW1lU3RyaW5nLmNfc3RyKCkpOwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAg ICBpbnQzMl90IG51bWJlciA9IGFyZ3VtZW50c1sxXS52YWx1ZS5kb3VibGVWYWx1ZTsKKyAgICAg ICAgICAgICAgICBpbnQzMl90IG51bWJlciA9IHN0YXRpY19jYXN0PGludDMyX3Q+KGFyZ3VtZW50 c1sxXS52YWx1ZS5kb3VibGVWYWx1ZSk7CiAgICAgICAgICAgICAgICAgcHJvcGVydHlOYW1lID0g cGx1Z2luVGVzdCgpLT5OUE5fR2V0SW50SWRlbnRpZmllcihudW1iZXIpOwogICAgICAgICAgICAg fQogICAgICAgICAgICAgCg==