51553 2010-12-23 12:32:33 -0800 [chromium] LayoutTestController warning in float->int conversion 2010-12-23 17:19:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 51551 1 evan evan commit-queue fishd rniwa tony oldest_to_newest 326218 0 evan 2010-12-23 12:32:33 -0800 [chromium] LayoutTestController warning in float->int conversion 326219 1 77359 evan 2010-12-23 12:34:43 -0800 Created attachment 77359 Patch 326222 2 evan 2010-12-23 12:37:25 -0800 Who does Chromium LayoutTestController reviews? Help me find a reviewer. :) 326258 3 77359 rniwa 2010-12-23 13:23:16 -0800 Comment on attachment 77359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77359&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1383 > - float* pageWidthInPixels, > - float* pageHeightInPixels) > + int* pageWidthInPixels, > + int* pageHeightInPixels) Why don't we use reference? 326259 4 evan 2010-12-23 13:26:43 -0800 I don't know, is that more common in WebKit? I didn't do it because 1) I wanted to stick the the behavior of the old code and 2) using references for that isn't allowed in Google style, so it didn't occur to me. :) 326261 5 77359 rniwa 2010-12-23 13:32:29 -0800 Comment on attachment 77359 Patch (In reply to comment #4) > I don't know, is that more common in WebKit? I think so. > 1) I wanted to stick the the behavior of the old code and > 2) using references for that isn't allowed in Google style, so it didn't occur to me. :) Ok, r=me. This change is simple enough. 326263 6 rniwa 2010-12-23 13:34:16 -0800 By the way, you should add yourself to http://trac.webkit.org/wiki/WebKit%20Team. 326381 7 77359 commit-queue 2010-12-23 17:19:15 -0800 Comment on attachment 77359 Patch Clearing flags on attachment: 77359 Committed r74598: <http://trac.webkit.org/changeset/74598> 326382 8 commit-queue 2010-12-23 17:19:22 -0800 All reviewed patches have been landed. Closing bug. 77359 2010-12-23 12:34:43 -0800 2010-12-23 17:19:15 -0800 Patch bug-51553-20101223123439.patch text/plain 3837 evan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODYx ZGMwZjE1MWZmN2QxZTE0ZDZlYmYwZWI0Y2Q4MjVlYmRiNjY5Li40NDY1NjkxYmNmYmEzMTgwZjNl ODQ1MjNiNmFhNTU5YWZmYTk3N2QwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMjMgIEV2YW4gTWFydGlu ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBMYXlvdXRUZXN0Q29udHJvbGxlciB3YXJuaW5nIGlu IGZsb2F0LT5pbnQgY29udmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE1NTMKKworICAgICAgICBSYXRoZXIgdGhhbiByZWFkaW5nIGFuIGlu dCwgY29udmVydGluZyB0byBhIGZsb2F0LCB0aGVuIGdldHRpbmcgYSBjb21waWxlcgorICAgICAg ICB3YXJuaW5nIG9uIHBhc3NpbmcgdGhlIGZsb2F0IHRvIHNvbWV0aGluZyB0aGF0IGV4cGVjdHMg YW4gaW50LCBpbnN0ZWFkCisgICAgICAgIGp1c3QgcGFzcyBhcm91bmQgaW50cy4KKworICAgICAg ICBObyB0ZXN0cywgZml4ZXMgYSBjb21waWxlciB3YXJuaW5nLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAocGFy c2VQYWdlU2l6ZVBhcmFtZXRlcnMpOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnBh Z2VOdW1iZXJGb3JFbGVtZW50QnlJZCk6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6 bnVtYmVyT2ZQYWdlcyk6CisKIDIwMTAtMTItMjMgIEx1Y2FzIEZvcnNjaGxlciAgPGxmb3JzY2hs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIu Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIu Y3BwCmluZGV4IGUzYWY3MzgzMTNmZmE5OWJjZDFiZTA2YzEzMWU1YmYyNGRkMzBmOTEuLjgzZTIz ODljYTQ3ZmU1ZDBlZGZmZWRhY2Y0YjdhYzEwYzY2MGI1MTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAgLTEz NzksOCArMTM3OSw4IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNvdW50ZXJWYWx1ZUZv ckVsZW1lbnRCeUlkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJnCiAKIHN0YXRpYyBib29sIHBh cnNlUGFnZVNpemVQYXJhbWV0ZXJzKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGFyZ09mZnNldCwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0KiBwYWdlV2lkdGhJblBpeGVscywK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0KiBwYWdlSGVpZ2h0SW5Q aXhlbHMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQqIHBhZ2VXaWR0 aEluUGl4ZWxzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50KiBwYWdl SGVpZ2h0SW5QaXhlbHMpCiB7CiAgICAgLy8gV2ViS2l0IGlzIHVzaW5nIHRoZSB3aW5kb3cgd2lk dGgvaGVpZ2h0IG9mIER1bXBSZW5kZXJUcmVlIGFzIHRoZQogICAgIC8vIGRlZmF1bHQgdmFsdWUg b2YgdGhlIHBhZ2Ugc2l6ZS4KQEAgLTEzOTEsOCArMTM5MSw4IEBAIHN0YXRpYyBib29sIHBhcnNl UGFnZVNpemVQYXJhbWV0ZXJzKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLAogICAg IGNhc2UgMjoKICAgICAgICAgaWYgKCFhcmd1bWVudHNbYXJnT2Zmc2V0XS5pc051bWJlcigpIHx8 ICFhcmd1bWVudHNbMSArIGFyZ09mZnNldF0uaXNOdW1iZXIoKSkKICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKLSAgICAgICAgKnBhZ2VXaWR0aEluUGl4ZWxzID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+ KGFyZ3VtZW50c1thcmdPZmZzZXRdLnRvSW50MzIoKSk7Ci0gICAgICAgICpwYWdlSGVpZ2h0SW5Q aXhlbHMgPSBzdGF0aWNfY2FzdDxmbG9hdD4oYXJndW1lbnRzWzEgKyBhcmdPZmZzZXRdLnRvSW50 MzIoKSk7CisgICAgICAgICpwYWdlV2lkdGhJblBpeGVscyA9IGFyZ3VtZW50c1thcmdPZmZzZXRd LnRvSW50MzIoKTsKKyAgICAgICAgKnBhZ2VIZWlnaHRJblBpeGVscyA9IGFyZ3VtZW50c1sxICsg YXJnT2Zmc2V0XS50b0ludDMyKCk7CiAgICAgICAgIC8vIGZhbGwgdGhyb3VnaC4KICAgICBjYXNl IDA6CiAgICAgICAgIGJyZWFrOwpAQCAtMTQwNSw4ICsxNDA1LDggQEAgc3RhdGljIGJvb2wgcGFy c2VQYWdlU2l6ZVBhcmFtZXRlcnMoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsCiB2 b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoY29uc3Qg Q3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKICAgICBy ZXN1bHQtPnNldE51bGwoKTsKLSAgICBmbG9hdCBwYWdlV2lkdGhJblBpeGVscyA9IDA7Ci0gICAg ZmxvYXQgcGFnZUhlaWdodEluUGl4ZWxzID0gMDsKKyAgICBpbnQgcGFnZVdpZHRoSW5QaXhlbHMg PSAwOworICAgIGludCBwYWdlSGVpZ2h0SW5QaXhlbHMgPSAwOwogICAgIGlmICghcGFyc2VQYWdl U2l6ZVBhcmFtZXRlcnMoYXJndW1lbnRzLCAxLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnBhZ2VXaWR0aEluUGl4ZWxzLCAmcGFnZUhlaWdodEluUGl4ZWxzKSkKICAgICAgICAg cmV0dXJuOwpAQCAtMTQxNiwxNCArMTQxNiwxNSBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVy OjpwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bQog ICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKICAgICByZXN1bHQtPnNldChmcmFtZS0+ cGFnZU51bWJlckZvckVsZW1lbnRCeUlkKGNwcFZhcmlhbnRUb1dlYlN0cmluZyhhcmd1bWVudHNb MF0pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFn ZVdpZHRoSW5QaXhlbHMsIHBhZ2VIZWlnaHRJblBpeGVscykpOworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8ZmxvYXQ+KHBhZ2VXaWR0 aEluUGl4ZWxzKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0YXRpY19jYXN0PGZsb2F0PihwYWdlSGVpZ2h0SW5QaXhlbHMpKSk7CiB9CiAKIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6Om51bWJlck9mUGFnZXMoY29uc3QgQ3BwQXJndW1lbnRMaXN0 JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKICAgICByZXN1bHQtPnNldE51bGwo KTsKLSAgICBmbG9hdCBwYWdlV2lkdGhJblBpeGVscyA9IDA7Ci0gICAgZmxvYXQgcGFnZUhlaWdo dEluUGl4ZWxzID0gMDsKKyAgICBpbnQgcGFnZVdpZHRoSW5QaXhlbHMgPSAwOworICAgIGludCBw YWdlSGVpZ2h0SW5QaXhlbHMgPSAwOwogICAgIGlmICghcGFyc2VQYWdlU2l6ZVBhcmFtZXRlcnMo YXJndW1lbnRzLCAwLCAmcGFnZVdpZHRoSW5QaXhlbHMsICZwYWdlSGVpZ2h0SW5QaXhlbHMpKQog ICAgICAgICByZXR1cm47CiAK