51551 2010-12-23 12:12:32 -0800 [chromium] warnings when building on Windows 2013-04-11 13:00:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED WONTFIX P2 Normal --- 50982 51553 51554 51566 51963 51964 51965 1 evan webkit-unassigned jamesr schenney thakis oldest_to_newest 326204 0 evan 2010-12-23 12:12:32 -0800 We still get a few warnings when we build on Windows. We should fix these, and then make warnings into errors so that they don't regress. Here is a full list from a recent run: e:\b\build\slave\win\build\src\third_party\WebKit\Tools\DumpRenderTree\TestNetscapePlugIn\Tests\NPRuntimeRemoveProperty.cpp(66) : warning C4244: 'initializing' : conversion from 'const double' to 'int32_t', possible loss of data e:\b\build\slave\win\build\src\third_party\webkit\webcore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool' (this is bug 50982 and the code is truly wrong, possibly causing real problems) e:\b\build\slave\win\build\src\third_party\WebKit\Tools\DumpRenderTree\chromium\LayoutTestController.cpp(1433) : warning C4244: 'argument' : conversion from 'float' to 'int', possible loss of data 326253 1 evan 2010-12-23 13:17:10 -0800 Oops, left one out: ..\html\TextMetrics.h(39) : warning C4244: 'return' : conversion from 'const float' to 'unsigned int', possible loss of data 326255 2 evan 2010-12-23 13:19:19 -0800 James, I'm trying to fix all the Windows build warnings. One of the last one is near a comment you added: + // FIXME: Is coercing to an integer value intentional? If so, there should be a static_cast<unsigned>() here. unsigned width() const { return m_width; } Did you ever track down that issue? 326256 3 evan 2010-12-23 13:19:36 -0800 (see bug 38073 for more context) 326322 4 evan 2010-12-23 15:25:32 -0800 CC original author of the mystery code. 326323 5 evan 2010-12-23 15:25:48 -0800 Oops, sorry hyatt, wrong bug. :(