51548 2010-12-23 11:33:31 -0800 check-webkit-style doesn't check all of the ports when linting test expectations 2012-09-27 12:34:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED NRWT P2 Normal --- 51222 1 dpranke webkit-unassigned abarth eric jchaffraix levin ojan oldest_to_newest 326180 0 dpranke 2010-12-23 11:33:31 -0800 The code in the TestExpectations style checker only lints the test expectations file against the port it is running on. It really should be linting against all ports, like new-run-webkit-tests --lint-test-files does. The easiest fix is to just have it call into the lint routines in webkitpy/layout_tests ... I should probably refactor that logic out of TestRunner and into test_expectations. 326182 1 dpranke 2010-12-23 11:34:21 -0800 There's no point in fixing this before we fix/land 51222, since all of the logic changes in that fix. 326185 2 dpranke 2010-12-23 11:42:10 -0800 Bug 51500 gave a false positive on the style bot because of this (as an example). 326187 3 dpranke 2010-12-23 11:43:53 -0800 There's also a lot of testing duplicated between the style checker and the unit tests for the expectations parser that's kind of unnecessary and can lead to confusion (see, e.g. bug 48426 for an example where one set of tests was updated but the other wasn't). 729773 4 dpranke 2012-09-27 12:34:48 -0700 I'm pretty sure I fixed this a while ago. It seems to e be working now.