51535 2010-12-23 06:06:03 -0800 [GTK] Show current time / total in media player 2010-12-24 12:40:16 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned abarth commit-queue eric pnormand webkit.review.bot oldest_to_newest 326052 0 cgarcia 2010-12-23 06:06:03 -0800 Current media player doesn't show information about the current and total time. 326053 1 77330 cgarcia 2010-12-23 06:08:00 -0800 Created attachment 77330 Patch to show current time/total in media player 326645 2 77330 xan.lopez 2010-12-24 09:27:00 -0800 Comment on attachment 77330 Patch to show current time/total in media player View in context: https://bugs.webkit.org/attachment.cgi?id=77330&action=review > WebCore/css/mediaControlsGtk.css:63 > + As a bikeshed comment I'd say hardcoding stuff in pixels in our css files is less than ideal, but I see we are already doing it everywhere. 326677 3 commit-queue 2010-12-24 10:58:24 -0800 The commit-queue encountered the following flaky tests while processing attachment 77330: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 326678 4 77330 commit-queue 2010-12-24 11:02:42 -0800 Comment on attachment 77330 Patch to show current time/total in media player Clearing flags on attachment: 77330 Committed r74643: <http://trac.webkit.org/changeset/74643> 326679 5 commit-queue 2010-12-24 11:02:46 -0800 All reviewed patches have been landed. Closing bug. 326684 6 commit-queue 2010-12-24 11:11:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 77330: http/tests/xmlhttprequest/open-async-overload.html bug 51594 (author: morrita@google.com) The commit-queue is continuing to process your patch. 326724 7 webkit.review.bot 2010-12-24 12:40:16 -0800 http://trac.webkit.org/changeset/74643 might have broken GTK Linux 32-bit Release 77330 2010-12-23 06:08:00 -0800 2010-12-24 11:02:42 -0800 Patch to show current time/total in media player current-time-media-player.diff text/plain 3509 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjVkMDdlMC4uZDc0YmFiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0yMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gU2hvdyBjdXJyZW50IHRpbWUgLyB0b3RhbCBp biBtZWRpYSBwbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNTM1CisKKyAgICAgICAgKiBjc3MvbWVkaWFDb250cm9sc0d0ay5jc3M6CisgICAg ICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheSwg dmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkpOgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUaGVtZUd0azo6Zm9ybWF0TWVkaWFDb250cm9sc0N1cnJlbnRUaW1lKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwYWludE1lZGlhQ3VycmVudFRpbWUpOgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oOgorCiAyMDEwLTEyLTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0d0ay5j c3MgYi9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzR3RrLmNzcwppbmRleCBjYzZkYTE0Li4xOGI3 ZGNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzR3RrLmNzcworKysgYi9X ZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzR3RrLmNzcwpAQCAtNDksNiArNDksMTggQEAgYXVkaW86 Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUsIHZpZGVvOjotd2Via2l0LW1lZGlhLWNv bnRyb2xzLXRpbWVsaW5lIHsKICAgICBoZWlnaHQ6IDIwcHg7CiB9CiAKK2F1ZGlvOjotd2Via2l0 LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRp YS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheSB7CisgICAgLXdlYmtpdC1hcHBlYXJhbmNl OiBtZWRpYS1jdXJyZW50LXRpbWUtZGlzcGxheTsKKyAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBu b25lOworICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICBoZWlnaHQ6IDIwcHg7CisKKyAg ICBwYWRkaW5nOiA1cHg7CisKKyAgICB0ZXh0LWFsaWduOiBjZW50ZXI7CisgICAgZm9udC1zaXpl OiAxMHB4OworfQorCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1zZWVrLWJhY2stYnV0 dG9uLCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1zZWVrLWJhY2stYnV0dG9uIHsKICAg ICB3aWR0aDogMjBweDsKICAgICBoZWlnaHQ6IDIwcHg7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5jcHAKaW5kZXggNzNiMmQ2Yi4uZDM0ODQ3ZCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtMTAwNiw2ICsxMDA2LDE5IEBAIGJvb2wgUmVuZGVy VGhlbWVHdGs6OnBhaW50TWVkaWFTbGlkZXJUaHVtYihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBh aW50SW5mbyYgcGFpCiAgICAgcGFpbnRJbmZvLmNvbnRleHQtPmZpbGxSb3VuZGVkUmVjdChyLCBJ bnRTaXplKDMsIDMpLCBJbnRTaXplKDMsIDMpLCBJbnRTaXplKDMsIDMpLCBJbnRTaXplKDMsIDMp LCBtX3NsaWRlclRodW1iQ29sb3IsIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIHJldHVybiBm YWxzZTsKIH0KKworU3RyaW5nIFJlbmRlclRoZW1lR3RrOjpmb3JtYXRNZWRpYUNvbnRyb2xzQ3Vy cmVudFRpbWUoZmxvYXQgY3VycmVudFRpbWUsIGZsb2F0IGR1cmF0aW9uKSBjb25zdAoreworICAg IHJldHVybiBmb3JtYXRNZWRpYUNvbnRyb2xzVGltZShjdXJyZW50VGltZSkgKyAiIC8gIiArIGZv cm1hdE1lZGlhQ29udHJvbHNUaW1lKGR1cmF0aW9uKTsKK30KKworYm9vbCBSZW5kZXJUaGVtZUd0 azo6cGFpbnRNZWRpYUN1cnJlbnRUaW1lKFJlbmRlck9iamVjdCogcmVuZGVyT2JqZWN0LCBjb25z dCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcmVjdCkKK3sKKyAgICBHcmFw aGljc0NvbnRleHQqIGNvbnRleHQgPSBwYWludEluZm8uY29udGV4dDsKKworICAgIGNvbnRleHQt PmZpbGxSZWN0KEZsb2F0UmVjdChyZWN0KSwgbV9wYW5lbENvbG9yLCBDb2xvclNwYWNlRGV2aWNl UkdCKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CiAjZW5kaWYKIAogI2lmIEVOQUJMRShQUk9HUkVT U19UQUcpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5o IGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaAppbmRleCBkMzc3YzQ1Li4y ZWMxODgxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5o CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKQEAgLTgxLDYgKzgx LDcgQEAgcHVibGljOgogCiAjaWYgRU5BQkxFKFZJREVPKQogICAgIHZpcnR1YWwgU3RyaW5nIGV4 dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKTsKKyAgICB2aXJ0dWFsIFN0cmluZyBmb3JtYXRN ZWRpYUNvbnRyb2xzQ3VycmVudFRpbWUoZmxvYXQgY3VycmVudFRpbWUsIGZsb2F0IGR1cmF0aW9u KSBjb25zdDsKICNlbmRpZgogCiAgICAgdm9pZCBnZXRJbmRpY2F0b3JNZXRyaWNzKENvbnRyb2xQ YXJ0LCBpbnQmIGluZGljYXRvclNpemUsIGludCYgaW5kaWNhdG9yU3BhY2luZykgY29uc3Q7CkBA IC0xNDcsNiArMTQ4LDcgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlh U2Vla0ZvcndhcmRCdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3Qg SW50UmVjdCYpOwogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhU2xpZGVyVHJhY2soUmVuZGVy T2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1YWwg Ym9vbCBwYWludE1lZGlhU2xpZGVyVGh1bWIoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZv JiwgY29uc3QgSW50UmVjdCYpOworICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhQ3VycmVudFRp bWUoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogI2Vu ZGlmCiAKICNpZiBFTkFCTEUoUFJPR1JFU1NfVEFHKQo=