51360 2010-12-20 15:56:26 -0800 [chromium] Media player styles being overridden 2010-12-20 19:21:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 sjl webkit-unassigned commit-queue levin webkit.review.bot oldest_to_newest 324615 0 sjl 2010-12-20 15:56:26 -0800 media/controls-styling.html is failing for chromium due to missing base styles in mediaControlsChromium.css. Fix is underway. 324648 1 77053 sjl 2010-12-20 16:37:58 -0800 Created attachment 77053 Patch 324651 2 webkit.review.bot 2010-12-20 16:42:03 -0800 Attachment 77053 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/css/mediaControlsChromium.css']" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 324659 3 77053 levin 2010-12-20 16:50:50 -0800 Comment on attachment 77053 Patch Tabs in changelog (and this needs to be perfect to go through the commit queue). 324662 4 77056 sjl 2010-12-20 16:55:24 -0800 Created attachment 77056 Patch 324682 5 77056 commit-queue 2010-12-20 18:25:04 -0800 Comment on attachment 77056 Patch Clearing flags on attachment: 77056 Committed r74381: <http://trac.webkit.org/changeset/74381> 324683 6 commit-queue 2010-12-20 18:25:11 -0800 All reviewed patches have been landed. Closing bug. 324716 7 commit-queue 2010-12-20 19:21:54 -0800 The commit-queue encountered the following flaky tests while processing attachment 77056: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 77053 2010-12-20 16:37:58 -0800 2010-12-20 16:55:21 -0800 Patch bug-51360-20101220163757.patch text/plain 2443 sjl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmY1MDBlNGYzOWE0ZDUwNGU4NzgwM2I3NGNjMmQ3YWYzMDc2ZWE2Zi4uOTI1OGU1MjE0NmRmOWU5 YmM3MGY5NDc1YTcwMTM5ZjVhNGZhNjA0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0yMCAgU3Rl dmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIGRlZmF1bHQgc3R5bGVzIGluIG1lZGlh Q29udHJvbHNDaHJvbWl1bS5jc3MgdG8gcHJldmVudAorCXVzZXIgb3ZlcnJpZGVzLgorCWh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTM2MAorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBuZWVkZWQgYXMgZnVuY3Rpb25hbGl0eSBpcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIGxh eW91dAorCXRlc3RzLgorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3M6 CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlz cGxheSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkp OgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmct ZGlzcGxheSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmctZGlz cGxheSk6CisKIDIwMTAtMTItMTcgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3MgYi9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRy b2xzQ2hyb21pdW0uY3NzCmluZGV4IDBmNjY3YmRlNGU0YzI2OGQ3NWVjNDY5OTIwNGFkYTU5MTEy OTcwYTAuLjg3MWEzMjQ5ZDgzZjgyZWVhN2NhNTBlODdmYTdhYjRkNGU2ODI2NjQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3MKKysrIGIvV2ViQ29yZS9j c3MvbWVkaWFDb250cm9sc0Nocm9taXVtLmNzcwpAQCAtMjAsNyArMjAsNyBAQAogICogUFJPRklU UzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRI RU9SWQogICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLCBPUiBUT1JUCiAgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT SU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuIAorICogT0YgVEhJ UyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KICAqLwogCiAvKiBDaHJvbWl1bSBkZWZhdWx0IG1lZGlhIGNvbnRyb2xzICovCkBAIC0x MTAsNiArMTEwLDEzIEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGlt ZS1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9sCiAgICAgZm9udC1zaXplOiAx NnB4OwogICAgIGZvbnQtd2VpZ2h0OiBib2xkOwogICAgIGNvbG9yOiB3aGl0ZTsKKworICAgIGxl dHRlci1zcGFjaW5nOiBub3JtYWw7CisgICAgd29yZC1zcGFjaW5nOiBub3JtYWw7CisgICAgdGV4 dC10cmFuc2Zvcm06IG5vbmU7CisgICAgdGV4dC1pbmRlbnQ6IDA7CisgICAgdGV4dC1zaGFkb3c6 IG5vbmU7CisgICAgdGV4dC1kZWNvcmF0aW9uOiBub25lOwogfQogCiBhdWRpbzo6LXdlYmtpdC1t ZWRpYS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRp YS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5IHsKQEAgLTEzNSw2ICsxNDIsMTMgQEAg YXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmctZGlzcGxheSwgdmlk ZW86Oi13ZWJraXQtbWVkaWEtY29udHIKICAgICBmb250LXNpemU6IDE2cHg7CiAgICAgZm9udC13 ZWlnaHQ6IGJvbGQ7CiAgICAgY29sb3I6IHdoaXRlOworCisgICAgbGV0dGVyLXNwYWNpbmc6IG5v cm1hbDsKKyAgICB3b3JkLXNwYWNpbmc6IG5vcm1hbDsKKyAgICB0ZXh0LXRyYW5zZm9ybTogbm9u ZTsKKyAgICB0ZXh0LWluZGVudDogMDsKKyAgICB0ZXh0LXNoYWRvdzogbm9uZTsKKyAgICB0ZXh0 LWRlY29yYXRpb246IG5vbmU7CiB9CiAKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRp bWVsaW5lLCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSB7Cg== 77056 2010-12-20 16:55:24 -0800 2010-12-20 18:25:04 -0800 Patch bug-51360-20101220165523.patch text/plain 2466 sjl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmY1MDBlNGYzOWE0ZDUwNGU4NzgwM2I3NGNjMmQ3YWYzMDc2ZWE2Zi4uMWI4MzQ3NzBjZTNmMDA3 OWNjMGRiMjRiODlkMTIwZDM0NDI5MDY1ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yMCAgU3Rl dmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIGRlZmF1bHQgc3R5bGVzIGluIG1lZGlh Q29udHJvbHNDaHJvbWl1bS5jc3MgdG8gcHJldmVudAorICAgICAgICB1c2VyIG92ZXJyaWRlcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMzYwCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZCBhcyBmdW5jdGlvbmFsaXR5IGlzIGNvdmVyZWQg YnkgZXhpc3RpbmcgbGF5b3V0CisgICAgICAgIHRlc3RzLgorCisKKyAgICAgICAgKiBjc3MvbWVk aWFDb250cm9sc0Nocm9taXVtLmNzczoKKyAgICAgICAgKGF1ZGlvOjotd2Via2l0LW1lZGlhLWNv bnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9s cy1jdXJyZW50LXRpbWUtZGlzcGxheSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1j b250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250 cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5KToKKwogMjAxMC0xMi0xNyAgSnVzdGluIFNjaHVo ICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEts aW5nLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0Nocm9taXVtLmNzcyBi L1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3MKaW5kZXggMGY2NjdiZGU0ZTRj MjY4ZDc1ZWM0Njk5MjA0YWRhNTkxMTI5NzBhMC4uODcxYTMyNDlkODNmODJlZWE3Y2E1MGU4N2Zh N2FiNGQ0ZTY4MjY2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0Nocm9t aXVtLmNzcworKysgYi9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3NzCkBAIC0y MCw3ICsyMCw3IEBACiAgKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VW RVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCiAgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKICAqIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICog T0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBT VUNIIERBTUFHRS4gCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKIC8qIENocm9taXVtIGRlZmF1bHQg bWVkaWEgY29udHJvbHMgKi8KQEAgLTExMCw2ICsxMTAsMTMgQEAgYXVkaW86Oi13ZWJraXQtbWVk aWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXksIHZpZGVvOjotd2Via2l0LW1lZGlhLWNv bnRyb2wKICAgICBmb250LXNpemU6IDE2cHg7CiAgICAgZm9udC13ZWlnaHQ6IGJvbGQ7CiAgICAg Y29sb3I6IHdoaXRlOworCisgICAgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsKKyAgICB3b3JkLXNw YWNpbmc6IG5vcm1hbDsKKyAgICB0ZXh0LXRyYW5zZm9ybTogbm9uZTsKKyAgICB0ZXh0LWluZGVu dDogMDsKKyAgICB0ZXh0LXNoYWRvdzogbm9uZTsKKyAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7 CiB9CiAKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWUtcmVtYWluaW5nLWRpc3Bs YXksIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWUtcmVtYWluaW5nLWRpc3BsYXkg ewpAQCAtMTM1LDYgKzE0MiwxMyBAQCBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1l LXJlbWFpbmluZy1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cgogICAgIGZvbnQt c2l6ZTogMTZweDsKICAgICBmb250LXdlaWdodDogYm9sZDsKICAgICBjb2xvcjogd2hpdGU7CisK KyAgICBsZXR0ZXItc3BhY2luZzogbm9ybWFsOworICAgIHdvcmQtc3BhY2luZzogbm9ybWFsOwor ICAgIHRleHQtdHJhbnNmb3JtOiBub25lOworICAgIHRleHQtaW5kZW50OiAwOworICAgIHRleHQt c2hhZG93OiBub25lOworICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsKIH0KIAogYXVkaW86Oi13 ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUsIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRy b2xzLXRpbWVsaW5lIHsK