51256 2010-12-17 08:26:26 -0800 Fix test failures where NULL GeolocationClient is provided 2010-12-17 09:37:26 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jknotten webkit-unassigned commit-queue jorlow steveblock oldest_to_newest 323788 0 jknotten 2010-12-17 08:26:26 -0800 We need to test for NULL m_client on GeolocationClientProxy::geolocationDestroyed() as well because GeolocationClientProxy::geolocationDestroyed() is called unconditionally from the Page destructor. e.g. webkit_unit_tests on Win. Test SelectPopupMenuTest.ShowThenHide Backtrace: WebKit::GeolocationClientProxy::geolocationDestroyed [0x01E802D3+3] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\geolocationclientproxy.cpp:58) Backtrace: WebKit::GeolocationClientProxy::geolocationDestroyed [0x01E802D3+3] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\geolocationclientproxy.cpp:58) WebCore::GeolocationController::~GeolocationController [0x015F3062+18] (d:\google-windows-2\chromium-win-release-tests\build\webcore\page\geolocationcontroller.cpp:46) WebCore::Page::~Page [0x0143CAC7+711] (d:\google-windows-2\chromium-win-release-tests\build\webcore\page\page.cpp:228) WebKit::WebViewImpl::close [0x01E5C330+96] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\webviewimpl.cpp:937) testing::TestInfo::Run [0x01E4D13D+269] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:2322) testing::TestCase::Run [0x01E4D2FF+239] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:2423) testing::internal::UnitTestImpl::RunAllTests [0x01E4D683+499] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:4199) testing::UnitTest::Run [0x01E4E0C9+137] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:3838) base::TestSuite::Run [0x01DE1468+216] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\base\test\test_suite.cc:127) main [0x0133AC75+37] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\tests\runalltests.cpp:54) 323791 1 76884 jknotten 2010-12-17 08:29:20 -0800 Created attachment 76884 Patch 323795 2 76884 jorlow 2010-12-17 08:36:37 -0800 Comment on attachment 76884 Patch Pretty sure this is right and things are currently broken, so r=me. Steve please take a look tho. 323806 3 steveblock 2010-12-17 08:51:36 -0800 LGTM 323832 4 commit-queue 2010-12-17 09:35:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 76884: http/tests/navigation/target-frame-from-window.html bug 51098 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch. 323837 5 76884 commit-queue 2010-12-17 09:37:21 -0800 Comment on attachment 76884 Patch Clearing flags on attachment: 76884 Committed r74274: <http://trac.webkit.org/changeset/74274> 323838 6 commit-queue 2010-12-17 09:37:26 -0800 All reviewed patches have been landed. Closing bug. 76884 2010-12-17 08:29:20 -0800 2010-12-17 09:37:21 -0800 Patch bug-51256-20101217162918.patch text/plain 1287 jknotten ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDU5MjU4NDkwMDY5YjllZjAzMTZmMTcxNjZiYmNlYTAwMTI3YTcyOGUu LjdiMGIzZmMzZWE0OTIzZGZmOWU0MWZmNTEwMjQ4NzRlMmZlNmRhYzUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTEyLTE3ICBKb2huIEtub3R0ZW5iZWx0ICA8amtub3R0ZW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCB0ZXN0IGZhaWx1cmVzIHdoZXJlIE5VTEwgR2VvbG9jYXRpb25DbGllbnQgaXMg cHJvdmlkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUxMjU2CisKKyAgICAgICAgKiBzcmMvR2VvbG9jYXRpb25DbGllbnRQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6Okdlb2xvY2F0aW9uQ2xpZW50UHJveHk6Omdlb2xvY2F0aW9uRGVzdHJveWVk KToKKwogMjAxMC0xMi0xNiAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vc3JjL0dlb2xvY2F0aW9uQ2xpZW50UHJveHkuY3BwIGIvV2ViS2l0L2Nocm9t aXVtL3NyYy9HZW9sb2NhdGlvbkNsaWVudFByb3h5LmNwcAppbmRleCA3M2E4NjkwZjI2NDc0Y2Vl NGZiNWExZDRlOGEzZmM4ODE5MjIzOTY5Li5iMjUzNmRkNmQ2MThmMjhhYmI5MmQ0NjhiZmJjZWM2 MzY5MDIxNDIyIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL0dlb2xvY2F0aW9uQ2xp ZW50UHJveHkuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvR2VvbG9jYXRpb25DbGllbnRQ cm94eS5jcHAKQEAgLTU1LDcgKzU1LDggQEAgdm9pZCBHZW9sb2NhdGlvbkNsaWVudFByb3h5Ojpz ZXRDb250cm9sbGVyKFdlYkNvcmU6Okdlb2xvY2F0aW9uQ29udHJvbGxlciogY29udHIKIAogdm9p ZCBHZW9sb2NhdGlvbkNsaWVudFByb3h5OjpnZW9sb2NhdGlvbkRlc3Ryb3llZCgpCiB7Ci0gICAg bV9jbGllbnQtPmdlb2xvY2F0aW9uRGVzdHJveWVkKCk7CisgICAgaWYgKG1fY2xpZW50KQorICAg ICAgICBtX2NsaWVudC0+Z2VvbG9jYXRpb25EZXN0cm95ZWQoKTsKIH0KIAogdm9pZCBHZW9sb2Nh dGlvbkNsaWVudFByb3h5OjpzdGFydFVwZGF0aW5nKCkK