51236 2010-12-17 00:40:11 -0800 Make java/argument-to-object-type.html use shouldBeEqualToString to make it easier to debug 2010-12-17 12:57:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED INVALID P2 Normal --- 51102 1 eric eric abarth ap commit-queue ggaren mrowe oldest_to_newest 323636 0 eric 2010-12-17 00:40:11 -0800 Make java/argument-to-object-type.html use shouldBeEqualToString to make it easier to debug 323637 1 76854 eric 2010-12-17 00:41:53 -0800 Created attachment 76854 Patch 323638 2 eric 2010-12-17 00:42:34 -0800 I've not actually run this (since I don't have a copy of webkit built), but the cq will build and run the tests for me. This should make it easier to solve bug 51102. 323687 3 commit-queue 2010-12-17 02:56:51 -0800 The commit-queue encountered the following flaky tests while processing attachment 76854: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) java/argument-to-object-type.html bug 51102 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 323693 4 76854 commit-queue 2010-12-17 03:23:06 -0800 Comment on attachment 76854 Patch Rejecting attachment 76854 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ......................................................................................................................................................................... inspector ................................................................................. java . java/argument-to-object-type.html -> failed Exiting early after 1 failures. 17897 tests run. 292.72s total testing time 17896 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 8 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7290011 323695 5 eric 2010-12-17 03:52:37 -0800 The failure can be seen here: https://bugs.webkit.org/attachment.cgi?id=76861 I guess that's why we didn't shouldBeEqualToSTring. 323913 6 ap 2010-12-17 12:04:01 -0800 Eric, has this been rolled out? 323926 7 eric 2010-12-17 12:30:10 -0800 It was never rolled in. :) 323934 8 ap 2010-12-17 12:43:42 -0800 Oh, ok. I was looking at <https://bug-51102-attachments.webkit.org/attachment.cgi?id=76861>, and didn't realize that it was from a failed attempt to commit this change. 323943 9 eric 2010-12-17 12:53:15 -0800 Yeah. It's slightly concerning that the queue thought that the failed attempt was a flaky test. Calls our flaky test detection into question. But as far as I know this was never committed. Looks like our flaky test detection code will report a constant failure as a flaky test if another test happens to flake at the same time: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py#L171 Notice how if first_failing_tests is non-empty, we run the tests again, if a different set of tests fail, we report them all as flaky (which is wrong!). I'll file a separate bug to fix. 323951 10 eric 2010-12-17 12:57:54 -0800 Filed bug 51272 about the flaky test detection code being wrong. 76854 2010-12-17 00:41:53 -0800 2010-12-17 03:23:05 -0800 Patch bug-51236-20101217004152.patch text/plain 1784 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNTA5NDNkNTA0Mzg4YzI4NDc2MDY4ODc1ZDQ2MTQwZmJiZTQ0ZGZlLi4zZjAxNTUw ZjAyZjBkNGNiMDI3M2IwNTg2NWQyMTFhOWE1YzkxMmNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMTItMTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgamF2YS9hcmd1bWVudC10 by1vYmplY3QtdHlwZS5odG1sIHVzZSBzaG91bGRCZUVxdWFsVG9TdHJpbmcgdG8gbWFrZSBpdCBl YXNpZXIgdG8gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxMjM2CisKKyAgICAgICAgKiBqYXZhL2FyZ3VtZW50LXRvLW9iamVjdC10eXBlLmh0 bWw6CisKKzIwMTAtMTItMTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NDIyOS4KICAgICAgICAgaHR0cDovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvNzQyMjkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUwNTM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qYXZhL2Fy Z3VtZW50LXRvLW9iamVjdC10eXBlLmh0bWwgYi9MYXlvdXRUZXN0cy9qYXZhL2FyZ3VtZW50LXRv LW9iamVjdC10eXBlLmh0bWwKaW5kZXggMDg0OGNmMmFkZjE4ZjdhZWY1OGVhMWQwMGVmZmM1OGQ4 MjU3OGVmYi4uZTY4MjE4YTFmNmEzZDQzYWQyYWI0MzljOTJmNTRlZGYzM2E5N2Y0ZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvamF2YS9hcmd1bWVudC10by1vYmplY3QtdHlwZS5odG1sCisrKyBi L0xheW91dFRlc3RzL2phdmEvYXJndW1lbnQtdG8tb2JqZWN0LXR5cGUuaHRtbApAQCAtMTksOSAr MTksOSBAQCBDYWxsaW5nIEphdmEgbWV0aG9kIHdoaWNoIGFjY2VwdHMgT2JqZWN0IGFsd2F5cyBw YXNzZXMgYSBudWxsIGFyZ3VtZW50LjwvcD4KIAogLy8gVGhlIHJldHVybmVkIHJlc3VsdCBzaG91 bGQgYmUgYSBwcmltaXRpdmUsIGJ1dCBXZWJLaXQgbWFrZXMgYSBzdHJpbmcgb2JqZWN0IG91dCBv ZiBpdC4KIC8vIFVudGlsIHRoaXMgaXMgZml4ZWQsIGNoZWNraW5nIHRoZSByZXN1bHQgd2l0aCA9 PSBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gc2hvdWxkQmUuCi1zaG91bGRCZSgnZG9jdW1lbnQuamF2 YVRlc3Qub2JqZWN0VG9TdHJpbmcoIlDQkFNTIikgPT0gIlDQkFNTIicsICd0cnVlJyk7Ci1zaG91 bGRCZSgnZG9jdW1lbnQuamF2YVRlc3Qub2JqZWN0VG9TdHJpbmcodW5kZWZpbmVkKSA9PSAidW5k ZWZpbmVkIicsICd0cnVlJyk7Ci1zaG91bGRCZSgnZG9jdW1lbnQuamF2YVRlc3Qub2JqZWN0VG9T dHJpbmcoNSkgPT0gIjUuMCInLCAndHJ1ZScpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdkb2N1 bWVudC5qYXZhVGVzdC5vYmplY3RUb1N0cmluZygiUNCQU1MiKScsICdQ0JBTUycpOworc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCdkb2N1bWVudC5qYXZhVGVzdC5vYmplY3RUb1N0cmluZyh1bmRlZmlu ZWQpJywgJ3VuZGVmaW5lZCcpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdkb2N1bWVudC5qYXZh VGVzdC5vYmplY3RUb1N0cmluZyg1KScsICc1LjAnKTsKIAogc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsKIDwvc2NyaXB0Pgo=