51200 2010-12-16 11:09:39 -0800 [Web Timing] Navigation type enums should begin with TYPE_ 2010-12-17 02:20:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.w3.org/TR/navigation-timing/ P2 Normal --- 30685 48922 0 simonjam webkit-unassigned commit-queue dglazkov fishd tonyg oldest_to_newest 323297 0 simonjam 2010-12-16 11:09:39 -0800 According to the spec, the Navigation Type enums should all begin with TYPE_. Ours don't. 323459 1 simonjam 2010-12-16 15:36:04 -0800 Also, TYPE_RESERVED is missing. 323481 2 76821 simonjam 2010-12-16 15:39:52 -0800 Created attachment 76821 Patch 323527 3 tonyg 2010-12-16 17:15:39 -0800 LGTM I have a weak preference that we get don't add TYPE_RESERVED. I just don't think it provides any real value. But it may or may not be worth changing the spec at this point and we should pass the compliance tests. 323529 4 simonjam 2010-12-16 17:21:28 -0800 (In reply to comment #3) > LGTM > > I have a weak preference that we get don't add TYPE_RESERVED. I just don't think it provides any real value. But it may or may not be worth changing the spec at this point and we should pass the compliance tests. Agreed. They're really rushing to get this to last call and I don't think this is worth holding them up. Can I get an r+ from a reviewer? 323665 5 commit-queue 2010-12-17 02:02:37 -0800 The commit-queue encountered the following flaky tests while processing attachment 76821: inspector/styles-new-API.html bug 50889 (authors: apavlov@chromium.org and pfeldman@chromium.org) http/tests/inspector/extensions-headers.html bug 51239 (author: caseq@chromium.org) The commit-queue is continuing to process your patch. 323669 6 76821 commit-queue 2010-12-17 02:20:04 -0800 Comment on attachment 76821 Patch Clearing flags on attachment: 76821 Committed r74241: <http://trac.webkit.org/changeset/74241> 323670 7 commit-queue 2010-12-17 02:20:10 -0800 All reviewed patches have been landed. Closing bug. 76821 2010-12-16 15:39:52 -0800 2010-12-17 02:20:04 -0800 Patch bug-51200-20101216153951.patch text/plain 6982 simonjam ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2Mzg2Y2QxZWEzNmFjY2Q3OTIxYmRkYmE3NTMyNGIzZDBkZTM4ODk2Li5jNmVjMjQ4 YTRjMTI3NDlmN2NjMmM1Y2Y1YTYzMjNlMTNkYmE2ZjJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMTYgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXZWIgVGltaW5n XSBOYXZpZ2F0aW9uIHR5cGUgZW51bXMgc2hvdWxkIGJlZ2luIHdpdGggVFlQRV8KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMjAwCisKKyAgICAgICAg KiBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtcGVyZm9ybWFuY2UtZXhwZWN0ZWQu dHh0OiBBZGRlZCBUWVBFXyB0byBuYXZpZ2F0aW9uIHR5cGVzIGFuZCBhZGRlZCBUWVBFX1JFU0VS VkVELgorCiAyMDEwLTEyLTE2ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBDaHJvbWl1bSB0ZXN0IGV4cGVjdGF0aW9u cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVy dGllcy1wZXJmb3JtYW5jZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXByb3BlcnRpZXMtcGVyZm9ybWFuY2UtZXhwZWN0ZWQudHh0CmluZGV4IGU2YWU4 NGFiMDBkNjFmYzkzMmIxZDE1NGNjZGRmMGIwYmFlODVhZjguLjFiNjA4Y2I1OTliNWE5MDE5ZDgx MWY5M2VkNWU0Yzc3YzMyMTBkN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dp bmRvdy93aW5kb3ctcHJvcGVydGllcy1wZXJmb3JtYW5jZS1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLXBlcmZvcm1hbmNlLWV4 cGVjdGVkLnR4dApAQCAtNSw5ICs1LDEwIEBAIHdpbmRvdy53ZWJraXRQZXJmb3JtYW5jZS5tZW1v cnkgW29iamVjdCBNZW1vcnlJbmZvXQogd2luZG93LndlYmtpdFBlcmZvcm1hbmNlLm1lbW9yeS50 b3RhbEpTSGVhcFNpemUgW251bWJlcl0KIHdpbmRvdy53ZWJraXRQZXJmb3JtYW5jZS5tZW1vcnku dXNlZEpTSGVhcFNpemUgW251bWJlcl0KIHdpbmRvdy53ZWJraXRQZXJmb3JtYW5jZS5uYXZpZ2F0 aW9uIFtvYmplY3QgUGVyZm9ybWFuY2VOYXZpZ2F0aW9uXQotd2luZG93LndlYmtpdFBlcmZvcm1h bmNlLm5hdmlnYXRpb24uQkFDS19GT1JXQVJEIFtudW1iZXJdCi13aW5kb3cud2Via2l0UGVyZm9y bWFuY2UubmF2aWdhdGlvbi5OQVZJR0FURSBbbnVtYmVyXQotd2luZG93LndlYmtpdFBlcmZvcm1h bmNlLm5hdmlnYXRpb24uUkVMT0FEIFtudW1iZXJdCit3aW5kb3cud2Via2l0UGVyZm9ybWFuY2Uu bmF2aWdhdGlvbi5UWVBFX0JBQ0tfRk9SV0FSRCBbbnVtYmVyXQord2luZG93LndlYmtpdFBlcmZv cm1hbmNlLm5hdmlnYXRpb24uVFlQRV9OQVZJR0FURSBbbnVtYmVyXQord2luZG93LndlYmtpdFBl cmZvcm1hbmNlLm5hdmlnYXRpb24uVFlQRV9SRUxPQUQgW251bWJlcl0KK3dpbmRvdy53ZWJraXRQ ZXJmb3JtYW5jZS5uYXZpZ2F0aW9uLlRZUEVfUkVTRVJWRUQgW251bWJlcl0KIHdpbmRvdy53ZWJr aXRQZXJmb3JtYW5jZS5uYXZpZ2F0aW9uLnJlZGlyZWN0Q291bnQgW251bWJlcl0KIHdpbmRvdy53 ZWJraXRQZXJmb3JtYW5jZS5uYXZpZ2F0aW9uLnR5cGUgW251bWJlcl0KIHdpbmRvdy53ZWJraXRQ ZXJmb3JtYW5jZS50aW1pbmcgW29iamVjdCBQZXJmb3JtYW5jZVRpbWluZ10KZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZmOWJlODk0NzZm MTEzZjZiZDRkNzFkODZmNjgwNGFmZGM5ODUxYy4uNjNlOGNlMDAxNGE3ZGIyOTFjNDYxZWNlNTI4 NGM1ZDlkYzIwZjY1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xNiAgSmFtZXMgU2ltb25zZW4g IDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1dlYiBUaW1pbmddIE5hdmlnYXRpb24gdHlwZSBlbnVtcyBzaG91 bGQgYmVnaW4gd2l0aCBUWVBFXworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTEyMDAKKworICAgICAgICAqIHBhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0aW9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlTmF2aWdhdGlvbjo6dHlwZSk6IEFk ZGVkIFRZUEVfIHRvIG5hdmlnYXRpb24gdHlwZXMuCisgICAgICAgICogcGFnZS9QZXJmb3JtYW5j ZU5hdmlnYXRpb24uaDogRGl0dG8gYW5kIGFkZGVkIFRZUEVfUkVTRVJWRUQuCisgICAgICAgICog cGFnZS9QZXJmb3JtYW5jZU5hdmlnYXRpb24uaWRsOiBEaXR0by4KKwogMjAxMC0xMi0xNiAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LiBGaXggQ2hyb21pdW0gRGVidWcgY29tcGlsYXRpb24gYWZ0ZXIgcjc0MTc3IApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvbi5jcHAgYi9XZWJDb3JlL3BhZ2Uv UGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmNwcAppbmRleCBkNTcwNTYxNTg4ZWJjYjQ3MjU4YmRkYzM3 YWQ1YTE5Zjg2MDAzZjI4Li41OTdhZjIwOGY1YjA4YjM5YmU1MWI3YmIwMGRkMGRjY2MzNWI0NDRj IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmNwcAorKysg Yi9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmNwcApAQCAtNTcsMjAgKzU3LDIw IEBAIHZvaWQgUGVyZm9ybWFuY2VOYXZpZ2F0aW9uOjpkaXNjb25uZWN0RnJhbWUoKQogdW5zaWdu ZWQgc2hvcnQgUGVyZm9ybWFuY2VOYXZpZ2F0aW9uOjp0eXBlKCkgY29uc3QKIHsKICAgICBpZiAo IW1fZnJhbWUpCi0gICAgICAgIHJldHVybiBOQVZJR0FURTsKKyAgICAgICAgcmV0dXJuIFRZUEVf TkFWSUdBVEU7CiAKICAgICBEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIgPSBtX2ZyYW1l LT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKTsKICAgICBpZiAoIWRvY3VtZW50TG9hZGVyKQot ICAgICAgICByZXR1cm4gTkFWSUdBVEU7CisgICAgICAgIHJldHVybiBUWVBFX05BVklHQVRFOwog CiAgICAgV2ViQ29yZTo6TmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGUgPSBkb2N1bWVudExv YWRlci0+dHJpZ2dlcmluZ0FjdGlvbigpLnR5cGUoKTsKICAgICBzd2l0Y2ggKG5hdmlnYXRpb25U eXBlKSB7CiAgICAgY2FzZSBOYXZpZ2F0aW9uVHlwZVJlbG9hZDoKLSAgICAgICAgcmV0dXJuIFJF TE9BRDsKKyAgICAgICAgcmV0dXJuIFRZUEVfUkVMT0FEOwogICAgIGNhc2UgTmF2aWdhdGlvblR5 cGVCYWNrRm9yd2FyZDoKLSAgICAgICAgcmV0dXJuIEJBQ0tfRk9SV0FSRDsKKyAgICAgICAgcmV0 dXJuIFRZUEVfQkFDS19GT1JXQVJEOwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBOQVZJ R0FURTsKKyAgICAgICAgcmV0dXJuIFRZUEVfTkFWSUdBVEU7CiAgICAgfQogfQogCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmggYi9XZWJDb3JlL3BhZ2Uv UGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmgKaW5kZXggMmJhOWI5Yzg1MWY4OGU4ZDFmZWRkOTlhMWNm MDJmNGM0NWJmOWQ2NS4uYmRmNmVhYTkzYTE0ZGJjZjdiNzg4MTQ5OWY1Mjk3N2ZiMzk4NDliNSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvbi5oCisrKyBiL1dl YkNvcmUvcGFnZS9QZXJmb3JtYW5jZU5hdmlnYXRpb24uaApAQCAtNDgsOSArNDgsMTAgQEAgcHVi bGljOgogICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCk7CiAKICAgICBlbnVtIFBlcmZvcm1hbmNl TmF2aWdhdGlvblR5cGUgewotICAgICAgICBOQVZJR0FURSwKLSAgICAgICAgUkVMT0FELAotICAg ICAgICBCQUNLX0ZPUldBUkQKKyAgICAgICAgVFlQRV9OQVZJR0FURSwKKyAgICAgICAgVFlQRV9S RUxPQUQsCisgICAgICAgIFRZUEVfQkFDS19GT1JXQVJELAorICAgICAgICBUWVBFX1JFU0VSVkVE ID0gMjU1CiAgICAgfTsKIAogICAgIHVuc2lnbmVkIHNob3J0IHR5cGUoKSBjb25zdDsKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU5hdmlnYXRpb24uaWRsIGIvV2ViQ29yZS9w YWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvbi5pZGwKaW5kZXggNWMwNjA1MDNiMGU0YzZkYTc3MmZl ZjU0YzI4MzhlNDI4N2RlN2Q2OS4uZDE2YmNiYTBhNDc5YjNjYTcyMTQwMmEyNTc3NDBjZTdiNmJl NDdjNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvbi5pZGwK KysrIGIvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTmF2aWdhdGlvbi5pZGwKQEAgLTMwLDExICsz MCwxMiBAQAogCiBtb2R1bGUgd2luZG93IHsKIAotICAgIC8vIFNlZTogaHR0cDovL2Rldi53My5v cmcvMjAwNi93ZWJhcGkvV2ViVGltaW5nLworICAgIC8vIFNlZTogaHR0cDovL3d3dy53My5vcmcv VFIvbmF2aWdhdGlvbi10aW1pbmcvCiAgICAgaW50ZXJmYWNlIFtDb25kaXRpb25hbD1XRUJfVElN SU5HLCBPbWl0Q29uc3RydWN0b3JdIFBlcmZvcm1hbmNlTmF2aWdhdGlvbiB7Ci0gICAgICAgIGNv bnN0IHVuc2lnbmVkIHNob3J0IE5BVklHQVRFID0gMDsKLSAgICAgICAgY29uc3QgdW5zaWduZWQg c2hvcnQgUkVMT0FEID0gMTsKLSAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgQkFDS19GT1JX QVJEID0gMjsKKyAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgVFlQRV9OQVZJR0FURSA9IDA7 CisgICAgICAgIGNvbnN0IHVuc2lnbmVkIHNob3J0IFRZUEVfUkVMT0FEID0gMTsKKyAgICAgICAg Y29uc3QgdW5zaWduZWQgc2hvcnQgVFlQRV9CQUNLX0ZPUldBUkQgPSAyOworICAgICAgICBjb25z dCB1bnNpZ25lZCBzaG9ydCBUWVBFX1JFU0VSVkVEID0gMjU1OwogICAgICAgICByZWFkb25seSBh dHRyaWJ1dGUgdW5zaWduZWQgc2hvcnQgdHlwZTsKIAogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgdW5zaWduZWQgc2hvcnQgcmVkaXJlY3RDb3VudDsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDk1ZTM3N2Fi YmU3MTAwZWI5ZThhZjBjMmRmMmIwOWI3ZDEwY2Q2MjMuLmMyYzlmMTEzOGJkMTMyZTU5MTNiM2Qy NjU2NDBhNGNkMThhYzhhOGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEy LTE2ICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbV2ViIFRpbWluZ10gTmF2aWdh dGlvbiB0eXBlIGVudW1zIHNob3VsZCBiZWdpbiB3aXRoIFRZUEVfCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTIwMAorCisgICAgICAgICogc3JjL1dl YlBlcmZvcm1hbmNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGVyZm9ybWFuY2U6Om5hdmln YXRpb25UeXBlKTogQWRkZWQgVFlQRV8gdG8gbmF2aWdhdGlvbiB0eXBlcy4KKwogMjAxMC0xMi0x NSAgQ2hyaXMgR3VpbGxvcnkgIDxjaHJpcy5ndWlsbG9yeUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViUGVyZm9ybWFuY2UuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQZXJmb3JtYW5j ZS5jcHAKaW5kZXggZGU5YzFmNmQ3ZGMzMjM5ZGNkMzc0ZTQwZmM3ODc0NDM5OTAwZGMzMi4uMTBk ZjRjNzM4NGQyNGUzYjcwMzdkMDBlNjBkMjM4ODFlM2M3MTJiYiAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJQZXJmb3JtYW5jZS5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQZXJmb3JtYW5jZS5jcHAKQEAgLTU1LDEyICs1NSwxNCBAQCB2b2lkIFdlYlBlcmZvcm1h bmNlOjphc3NpZ24oY29uc3QgV2ViUGVyZm9ybWFuY2UmIG90aGVyKQogV2ViTmF2aWdhdGlvblR5 cGUgV2ViUGVyZm9ybWFuY2U6Om5hdmlnYXRpb25UeXBlKCkgY29uc3QKIHsKICAgICBzd2l0Y2gg KG1fcHJpdmF0ZS0+bmF2aWdhdGlvbigpLT50eXBlKCkpIHsKLSAgICBjYXNlIFBlcmZvcm1hbmNl TmF2aWdhdGlvbjo6TkFWSUdBVEU6CisgICAgY2FzZSBQZXJmb3JtYW5jZU5hdmlnYXRpb246OlRZ UEVfTkFWSUdBVEU6CiAgICAgICAgIHJldHVybiBXZWJOYXZpZ2F0aW9uVHlwZU90aGVyOwotICAg IGNhc2UgUGVyZm9ybWFuY2VOYXZpZ2F0aW9uOjpSRUxPQUQ6CisgICAgY2FzZSBQZXJmb3JtYW5j ZU5hdmlnYXRpb246OlRZUEVfUkVMT0FEOgogICAgICAgICByZXR1cm4gV2ViTmF2aWdhdGlvblR5 cGVSZWxvYWQ7Ci0gICAgY2FzZSBQZXJmb3JtYW5jZU5hdmlnYXRpb246OkJBQ0tfRk9SV0FSRDoK KyAgICBjYXNlIFBlcmZvcm1hbmNlTmF2aWdhdGlvbjo6VFlQRV9CQUNLX0ZPUldBUkQ6CiAgICAg ICAgIHJldHVybiBXZWJOYXZpZ2F0aW9uVHlwZUJhY2tGb3J3YXJkOworICAgIGNhc2UgUGVyZm9y bWFuY2VOYXZpZ2F0aW9uOjpUWVBFX1JFU0VSVkVEOgorICAgICAgICByZXR1cm4gV2ViTmF2aWdh dGlvblR5cGVPdGhlcjsKICAgICB9CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgcmV0 dXJuIFdlYk5hdmlnYXRpb25UeXBlT3RoZXI7Cg==