51100 2010-12-15 02:46:09 -0800 [QT] QtWebkit geolocation's position.timestamp is not in miliseconds 2011-01-03 05:32:24 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 maheshk maheshk ademar bulach commit-queue hausmann jarred laszlo.gombos mitz steveblock oldest_to_newest 322555 0 maheshk 2010-12-15 02:46:09 -0800 According to HTML5 GeoLocation standards, (Geo)Position interface’s timestamp should be of DOMTimestamp type and DOMTimestamp represents a number of milliseconds. Ref: http://dev.w3.org/geo/api/spec-source.html#position_interface http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp However in QTWebKit code while creating Geoposition object, timestamp was in ‘seconds ‘ (using QDateTime::toTime_t() function which returns the datetime as the number of seconds that have passed since 1970-01-01T00:00:00 UTC ) instead of ‘miliseconds’ (QDateTime:: toMSecsSinceEpoch() which returns the datetime as the number of milliseconds that have passed since 1970-01-01T00:00:00.000). So patched GeolocationServiceQt::positionUpdated() function to create Geoposition object using milliseconds. 322584 1 jarred 2010-12-15 06:22:40 -0800 diff --git a/WebCore/platform/qt/GeolocationServiceQt.cpp b/WebCore/platform/qt/GeolocationServiceQt.cpp index 3562eb9..2cccee6 100644 --- a/WebCore/platform/qt/GeolocationServiceQt.cpp +++ b/WebCore/platform/qt/GeolocationServiceQt.cpp @@ -83,7 +83,7 @@ void GeolocationServiceQt::positionUpdated(const QGeoPositionInfo &geoPosition) RefPtr<Coordinates> coordinates = Coordinates::create(latitude, longitude, providesAltitude, altitude, accuracy, providesAltitudeAccuracy, altitudeAccuracy, providesHeading, heading, providesSpeed, speed); - m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toTime_t()); + m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toMSecsSinceEpoch()); positionChanged(); } LayoutTests/fast/dom/Geolocation/timestamp.html appears to pass. Nice catch. 324302 2 76979 maheshk 2010-12-20 00:21:21 -0800 Created attachment 76979 patch Proposing patch, now qtwebkit milisec timestamp from GeoPosition. Please review 324303 3 76979 kling 2010-12-20 00:45:28 -0800 Comment on attachment 76979 patch View in context: https://bugs.webkit.org/attachment.cgi?id=76979&action=review > WebCore/platform/qt/GeolocationServiceQt.cpp:86 > - m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toTime_t()); > + m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toMSecsSinceEpoch()); toMSecsSinceEpoch() is new in Qt 4.7. Since we still support building QtWebKit against Qt 4.6, this needs a QT_VERSION check and something for 4.6. 324343 4 76991 maheshk 2010-12-20 05:40:28 -0800 Created attachment 76991 patch Thanks Kling for review. Incorporated review comments as per comment 3. 324357 5 76991 kling 2010-12-20 06:27:58 -0800 Comment on attachment 76991 patch LGTM. 324386 6 76991 commit-queue 2010-12-20 07:34:03 -0800 Comment on attachment 76991 patch Rejecting attachment 76991 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76991]" exit_code: 2 Last 500 characters of output: /ChangeLog Failed to merge in the changes. Patch failed at 0001 2010-12-20 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 132. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7269066 324409 7 commit-queue 2010-12-20 08:23:51 -0800 The commit-queue encountered the following flaky tests while processing attachment 76991: inspector/elements-panel-rewrite-href.html bug 51337 (authors: apavlov@chromium.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch. 324851 8 76991 eric 2010-12-20 23:05:59 -0800 Comment on attachment 76991 patch That cq bug has finally been fixed. Sorry for the trouble. 324877 9 commit-queue 2010-12-20 23:49:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 76991: inspector/styles-disable-then-enable.html bug 51384 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. 324879 10 76991 commit-queue 2010-12-20 23:50:28 -0800 Comment on attachment 76991 patch Clearing flags on attachment: 76991 Committed r74404: <http://trac.webkit.org/changeset/74404> 324880 11 commit-queue 2010-12-20 23:50:34 -0800 All reviewed patches have been landed. Closing bug. 328538 12 ademar 2011-01-03 05:32:15 -0800 Revision r74404 cherry-picked into qtwebkit-2.2 with commit be21b13 <http://gitorious.org/webkit/qtwebkit/commit/be21b13> 76979 2010-12-20 00:21:21 -0800 2010-12-20 05:40:28 -0800 patch 51100.patch text/plain 1914 maheshk ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmE0NDU0ZS4uMTAyM2E0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMi0yMCAgTWFoZXNoIEt1bGth cm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCBwb3J0IG9mIGdlb2xvY2F0aW9uLCBnZW9wb3Np dGlvbiBvYmplY3RzIHRpbWVzdGFtcCB3YXMgaW4gc2Vjb25kcworICAgICAgICBpbnN0ZWFkIG9m IG1pbGlzZWNvbmRzIGFzIHBlciBIVE1MNSBHZW9sb2NhdGlvbiBzdGFuZGFyZHMuCisgICAgICAg IFJlZjogaHR0cDovL2Rldi53My5vcmcvZ2VvL2FwaS9zcGVjLXNvdXJjZS5odG1sI3Bvc2l0aW9u X2ludGVyZmFjZSAKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvRE9NLUxldmVsLTMtQ29y ZS9jb3JlLmh0bWwjQ29yZS1ET01UaW1lU3RhbXAgCisKKyAgICAgICAgSW1wbGVtZW50ZWQgYnkg QXNoZWVzaCBTcml2YXN0YXZhLgorCisgICAgICAgIFtRVF0gUXRXZWJraXQgZ2VvbG9jYXRpb24n cyBwb3NpdGlvbi50aW1lc3RhbXAgaXMgbm90IGluIG1pbGlzZWNvbmRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTEwMAorCisgICAgICAgIFBvcnRp bmcgY29kZSBub3QgY292ZXJlZCBpbiBsYXlvdXQgdGVzdGluZy4gTm8gbmV3IHRlc3RzIGFkZGVk LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvR2VvbG9jYXRpb25TZXJ2aWNlUXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25TZXJ2aWNlUXQ6OnBvc2l0aW9uVXBkYXRlZCk6CisK IDIwMTAtMTItMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vcXQvR2VvbG9jYXRpb25TZXJ2aWNlUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKaW5kZXggMzU2MmViOS4uMmNjY2VlNiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKQEAgLTgzLDcg KzgzLDcgQEAgdm9pZCBHZW9sb2NhdGlvblNlcnZpY2VRdDo6cG9zaXRpb25VcGRhdGVkKGNvbnN0 IFFHZW9Qb3NpdGlvbkluZm8gJmdlb1Bvc2l0aW9uKQogICAgIFJlZlB0cjxDb29yZGluYXRlcz4g Y29vcmRpbmF0ZXMgPSBDb29yZGluYXRlczo6Y3JlYXRlKGxhdGl0dWRlLCBsb25naXR1ZGUsIHBy b3ZpZGVzQWx0aXR1ZGUsIGFsdGl0dWRlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFjY3VyYWN5LCBwcm92aWRlc0FsdGl0dWRlQWNj dXJhY3ksIGFsdGl0dWRlQWNjdXJhY3ksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvdmlkZXNIZWFkaW5nLCBoZWFkaW5nLCBwcm92 aWRlc1NwZWVkLCBzcGVlZCk7Ci0gICAgbV9sYXN0UG9zaXRpb24gPSBHZW9wb3NpdGlvbjo6Y3Jl YXRlKGNvb3JkaW5hdGVzLnJlbGVhc2UoKSwgZ2VvUG9zaXRpb24udGltZXN0YW1wKCkudG9UaW1l X3QoKSk7CisgICAgbV9sYXN0UG9zaXRpb24gPSBHZW9wb3NpdGlvbjo6Y3JlYXRlKGNvb3JkaW5h dGVzLnJlbGVhc2UoKSwgZ2VvUG9zaXRpb24udGltZXN0YW1wKCkudG9NU2Vjc1NpbmNlRXBvY2go KSk7CiAgICAgcG9zaXRpb25DaGFuZ2VkKCk7CiB9CiAK 76991 2010-12-20 05:40:28 -0800 2010-12-20 23:50:28 -0800 patch 51100.patch text/plain 2155 maheshk ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmE0NDU0ZS4uMTAyM2E0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMi0yMCAgTWFoZXNoIEt1bGth cm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCBwb3J0IG9mIGdlb2xvY2F0aW9uLCBnZW9wb3Np dGlvbiBvYmplY3RzIHRpbWVzdGFtcCB3YXMgaW4gc2Vjb25kcworICAgICAgICBpbnN0ZWFkIG9m IG1pbGlzZWNvbmRzIGFzIHBlciBIVE1MNSBHZW9sb2NhdGlvbiBzdGFuZGFyZHMuCisgICAgICAg IFJlZjogaHR0cDovL2Rldi53My5vcmcvZ2VvL2FwaS9zcGVjLXNvdXJjZS5odG1sI3Bvc2l0aW9u X2ludGVyZmFjZSAKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvRE9NLUxldmVsLTMtQ29y ZS9jb3JlLmh0bWwjQ29yZS1ET01UaW1lU3RhbXAgCisKKyAgICAgICAgSW1wbGVtZW50ZWQgYnkg QXNoZWVzaCBTcml2YXN0YXZhLgorCisgICAgICAgIFtRVF0gUXRXZWJraXQgZ2VvbG9jYXRpb24n cyBwb3NpdGlvbi50aW1lc3RhbXAgaXMgbm90IGluIG1pbGlzZWNvbmRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTEwMAorCisgICAgICAgIFBvcnRp bmcgY29kZSBub3QgY292ZXJlZCBpbiBsYXlvdXQgdGVzdGluZy4gTm8gbmV3IHRlc3RzIGFkZGVk LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvR2VvbG9jYXRpb25TZXJ2aWNlUXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25TZXJ2aWNlUXQ6OnBvc2l0aW9uVXBkYXRlZCk6CisK IDIwMTAtMTItMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vcXQvR2VvbG9jYXRpb25TZXJ2aWNlUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKaW5kZXggMzU2MmViOS4uZjQzNzliMiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9HZW9sb2NhdGlvblNlcnZpY2VRdC5jcHAKQEAgLTgzLDcg KzgzLDEzIEBAIHZvaWQgR2VvbG9jYXRpb25TZXJ2aWNlUXQ6OnBvc2l0aW9uVXBkYXRlZChjb25z dCBRR2VvUG9zaXRpb25JbmZvICZnZW9Qb3NpdGlvbikKICAgICBSZWZQdHI8Q29vcmRpbmF0ZXM+ IGNvb3JkaW5hdGVzID0gQ29vcmRpbmF0ZXM6OmNyZWF0ZShsYXRpdHVkZSwgbG9uZ2l0dWRlLCBw cm92aWRlc0FsdGl0dWRlLCBhbHRpdHVkZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhY2N1cmFjeSwgcHJvdmlkZXNBbHRpdHVkZUFj Y3VyYWN5LCBhbHRpdHVkZUFjY3VyYWN5LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByb3ZpZGVzSGVhZGluZywgaGVhZGluZywgcHJv dmlkZXNTcGVlZCwgc3BlZWQpOwotICAgIG1fbGFzdFBvc2l0aW9uID0gR2VvcG9zaXRpb246OmNy ZWF0ZShjb29yZGluYXRlcy5yZWxlYXNlKCksIGdlb1Bvc2l0aW9uLnRpbWVzdGFtcCgpLnRvVGlt ZV90KCkpOworCisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDQsIDcsIDApCisg ICAgbV9sYXN0UG9zaXRpb24gPSBHZW9wb3NpdGlvbjo6Y3JlYXRlKGNvb3JkaW5hdGVzLnJlbGVh c2UoKSwgZ2VvUG9zaXRpb24udGltZXN0YW1wKCkudG9NU2Vjc1NpbmNlRXBvY2goKSk7CisjZWxz ZQorICAgIFFEYXRlVGltZSB0aW1lc3RhbXAgPSBnZW9Qb3NpdGlvbi50aW1lc3RhbXAoKTsKKyAg ICBtX2xhc3RQb3NpdGlvbiA9IEdlb3Bvc2l0aW9uOjpjcmVhdGUoY29vcmRpbmF0ZXMucmVsZWFz ZSgpLCAodGltZXN0YW1wLnRvVGltZV90KCkgKiAxMDAwLjAwKSArIHRpbWVzdGFtcC50aW1lKCku bXNlYygpKTsKKyNlbmRpZgogICAgIHBvc2l0aW9uQ2hhbmdlZCgpOwogfQogCg==