51079 2010-12-14 17:50:05 -0800 Possible infinite loop in ContainerNode::willRemoveChildren 2013-03-28 19:27:50 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 eae webkit-unassigned abarth commit-queue eric esprehn webkit.review.bot oldest_to_newest 322397 0 eae 2010-12-14 17:50:05 -0800 Adding children to ContainerNode in a DOMNodeRemoved event handler triggers an infinite loop in ContainerNode::willRemoveChildren. 322401 1 76604 eae 2010-12-14 17:51:25 -0800 Created attachment 76604 Patch 322539 2 commit-queue 2010-12-15 01:45:32 -0800 The commit-queue encountered the following flaky tests while processing attachment 76604: http/tests/navigation/target-frame-from-window.html bug 51098 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch. 322540 3 76604 commit-queue 2010-12-15 01:47:30 -0800 Comment on attachment 76604 Patch Clearing flags on attachment: 76604 Committed r74101: <http://trac.webkit.org/changeset/74101> 322541 4 commit-queue 2010-12-15 01:47:35 -0800 All reviewed patches have been landed. Closing bug. 322582 5 webkit.review.bot 2010-12-15 05:58:40 -0800 http://trac.webkit.org/changeset/74101 might have broken GTK Linux 64-bit Debug 865965 6 esprehn 2013-03-28 19:27:50 -0700 What was the reason for this fix? Gecko and Opera both end up in an infinite loop here so it's not clear avoiding it makes sense, and avoiding it added some complication to the algorithm (and more iterations over the children). 76604 2010-12-14 17:51:25 -0800 2010-12-15 01:47:30 -0800 Patch 51079.patch text/plain 4245 eae SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDA4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTItMTQgIEVtaWwgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2UgQ29udGFpbmVyTm9kZTo6d2lsbFJlbW92ZUNoaWxkcmVuIHRvIG5vdCBmaXJlIG11dGF0aW9u IGV2ZW50cyBmb3IgY2hpbGRyZW4KKyAgICAgICAgYWRkZWQgYXMgYSByZXN1bHQgb2YgYSBtdXRh dGlvbiBldmVudCwgdGhlcmVieSBhdm9pZGluZyBhbiBpbmZpbml0ZSBsb29wLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEwNzkKKworICAgICAgICBU ZXN0OiBmYXN0L2RvbS9jb250YWluZXJOb2RlLmh0bWwKKworICAgICAgICAqIGRvbS9Db250YWlu ZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndpbGxSZW1vdmVDaGlsZHJlbik6IERvbid0 IGZpcmUgbXV0YXRpb24gZXZlbnRzIGZvciBjaGlsZHJlbiBhZGRlZCBkdXJpbmcgYSBtdXRhdGlv biBldmVudC4KKwogMjAxMC0xMi0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBNYXJyaW4uCkluZGV4OiBXZWJDb3Jl L2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Db250YWlu ZXJOb2RlLmNwcAkocmV2aXNpb24gNzM5MjQpCisrKyBXZWJDb3JlL2RvbS9Db250YWluZXJOb2Rl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc5LDEwICszNzksMTQgQEAgc3RhdGljIHZvaWQgd2ls bFJlbW92ZUNoaWxkcmVuKENvbnRhaW5lcgogICAgIGNvbnRhaW5lci0+ZG9jdW1lbnQoKS0+bm9k ZUNoaWxkcmVuV2lsbEJlUmVtb3ZlZChjb250YWluZXIpOwogICAgIGNvbnRhaW5lci0+ZG9jdW1l bnQoKS0+aW5jRE9NVHJlZVZlcnNpb24oKTsKIAotICAgIC8vIEZJWE1FOiBBZGRpbmcgbmV3IGNo aWxkcmVuIGZyb20gZXZlbnQgaGFuZGxlcnMgY2FuIGNhdXNlIGFuIGluZmluaXRlIGxvb3AgaGVy ZS4KLSAgICBmb3IgKFJlZlB0cjxOb2RlPiBjaGlsZCA9IGNvbnRhaW5lci0+Zmlyc3RDaGlsZCgp OyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgeworICAgIE5vZGVWZWN0b3Ig Y2hpbGRyZW47CisgICAgZm9yIChOb2RlKiBuID0gY29udGFpbmVyLT5maXJzdENoaWxkKCk7IG47 IG4gPSBuLT5uZXh0U2libGluZygpKQorICAgICAgICBjaGlsZHJlbi5hcHBlbmQobik7CisKKyAg ICBmb3IgKE5vZGVWZWN0b3I6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gY2hpbGRyZW4uYmVnaW4oKTsg aXQgIT0gY2hpbGRyZW4uZW5kKCk7IGl0KyspIHsKKyAgICAgICAgTm9kZSogY2hpbGQgPSBpdC0+ Z2V0KCk7CiAgICAgICAgIC8vIGZpcmUgcmVtb3ZlZCBmcm9tIGRvY3VtZW50IG11dGF0aW9uIGV2 ZW50cy4KLSAgICAgICAgZGlzcGF0Y2hDaGlsZFJlbW92YWxFdmVudHMoY2hpbGQuZ2V0KCkpOwor ICAgICAgICBkaXNwYXRjaENoaWxkUmVtb3ZhbEV2ZW50cyhjaGlsZCk7CiAgICAgICAgIGNoaWxk LT53aWxsUmVtb3ZlKCk7CiAgICAgfQogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzQwODMpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx MC0xMi0xNCAgRW1pbCBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgZm9yIGluZmluaXRl IGxvb3AgaW4gQ29udGFpbmVyTm9kZTo6d2lsbFJlbW92ZUNoaWxkcmVuLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEwNzkKKworICAgICAgICAqIGZh c3QvZG9tL2NvbnRhaW5lck5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2RvbS9jb250YWluZXJOb2RlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTEyLTE0ICBZYWVsIEFoYXJv biAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIC4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZG9tL2NvbnRhaW5lck5vZGUtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2NvbnRhaW5lck5vZGUtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vY29udGFpbmVyTm9kZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1BBU1M6IE5vIGluZmluaXRlIGxvb3Au CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jb250YWluZXJOb2RlLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vY29udGFpbmVyTm9kZS5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vY29udGFpbmVyTm9kZS5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDQ2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAg PHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICBmdW5jdGlvbiBsb2cobXNn KQorICAgICAgICB7CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKG1zZykpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24g YXBwZW5kSXRlbShsaXN0LCBjYXB0aW9uKQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgaXRl bSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2xpJyk7CisgICAgICAgICAgICBpdGVtLmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGNhcHRpb24pKTsKKyAgICAgICAgICAgIGxp c3QuYXBwZW5kQ2hpbGQoaXRlbSk7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBydW5U ZXN0cygpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworCisgICAgICAgICAgICB2YXIgZnJhZ21lbnQgPSBkb2N1bWVudC5jcmVhdGVEb2N1bWVudEZy YWdtZW50KCk7CisgICAgICAgICAgICB2YXIgbGlzdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J3VsJyk7CisgICAgICAgICAgICB2YXIgaTsKKyAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCA1 OyBpKyspCisgICAgICAgICAgICAgICAgYXBwZW5kSXRlbShsaXN0LCAnaXRlbSAnICsgaSk7Cisg ICAgICAgICAgICAgICAgCisgICAgICAgICAgICBmcmFnbWVudC5hcHBlbmRDaGlsZChsaXN0KTsK KyAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRPTU5vZGVSZW1vdmVkIiwg ZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgYXBwZW5kSXRlbShsaXN0LCAnaXRlbSAnICsg aSsrKTsKKyAgICAgICAgICAgIH0sIGZhbHNlKTsKKworICAgICAgICAgICAgZG9jdW1lbnQuYm9k eS5hcHBlbmRDaGlsZChmcmFnbWVudCk7CisgICAgICAgICAgICBsaXN0LnRleHRDb250ZW50ID0g Jyc7CisKKyAgICAgICAgICAgIGlmIChsaXN0LmNoaWxkTm9kZXMubGVuZ3RoID09IDApCisgICAg ICAgICAgICAgICAgbG9nKCdQQVNTOiBObyBpbmZpbml0ZSBsb29wLicpCisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgbG9nKCdGQUlMOiBIYXMgdG9vIG1hbnkgY2hpbGRyZW4uJykK KyAgICAgICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0 cygpOyI+CisKKzwvYm9keT4KKzwvaHRtbD4K