51046 2010-12-14 10:43:49 -0800 Expose AccessibilityObject::url() to Chromium 2010-12-16 15:37:53 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ctguil webkit-unassigned abarth commit-queue eric fishd webkit.review.bot oldest_to_newest 322047 0 ctguil 2010-12-14 10:43:49 -0800 During a chromium code review we determined that we needed access to the url of link accessibility objects. http://codereview.chromium.org/5751002/ 322092 1 76552 ctguil 2010-12-14 11:59:30 -0800 Created attachment 76552 Proposed Patch 322093 2 ctguil 2010-12-14 12:00:16 -0800 WebKit API change. 322486 3 76552 fishd 2010-12-14 20:49:36 -0800 Comment on attachment 76552 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76552&action=review > WebKit/chromium/public/WebAccessibilityObject.h:113 > + WEBKIT_API WebString url() const; nit: we ordinarily expose urls using WebURL. it looks like m_private->url() is a KURL object. (KURL can be implicitly converted to WebURL.) 322520 4 76633 ctguil 2010-12-14 23:18:07 -0800 Created attachment 76633 Patch Returning as WebURL. 322933 5 commit-queue 2010-12-15 16:45:08 -0800 The commit-queue encountered the following flaky tests while processing attachment 76633: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 323024 6 76633 commit-queue 2010-12-15 19:32:00 -0800 Comment on attachment 76633 Patch Clearing flags on attachment: 76633 Committed r74171: <http://trac.webkit.org/changeset/74171> 323025 7 commit-queue 2010-12-15 19:32:06 -0800 All reviewed patches have been landed. Closing bug. 323462 8 webkit.review.bot 2010-12-16 15:37:53 -0800 http://trac.webkit.org/changeset/74171 might have broken Leopard Intel Debug (Tests) 76552 2010-12-14 11:59:30 -0800 2010-12-14 23:18:07 -0800 Proposed Patch MyPatch.txt text/plain 1787 ctguil SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzQwNDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMTQgIENocmlz IEd1aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgQWNjZXNzaWJpbGl0eU9iamVj dDo6dXJsKCkgdG8gQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUxMDQ2CisKKyAgICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdC5oOgorICAgICAgICAqIHNyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dXJsKToKKwogMjAxMC0xMi0xMyAg TWlrZSBMYXd0aGVyICA8bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEphbWVzIFJvYmluc29uLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDczOTg0KQorKysgV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAg LTExMCw2ICsxMTAsNyBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0FQSSB2b2lkIHNldEZvY3VzZWQo Ym9vbCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgc3RyaW5nVmFsdWUoKSBjb25z dDsKICAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyB0aXRsZSgpIGNvbnN0OworICAgIFdFQktJVF9B UEkgV2ViU3RyaW5nIHVybCgpIGNvbnN0OwogCiAgICAgV0VCS0lUX0FQSSBXZWJOb2RlIG5vZGUo KSBjb25zdDsKICAgICBXRUJLSVRfQVBJIFdlYkRvY3VtZW50IGRvY3VtZW50KCkgY29uc3Q7Cklu ZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJ KHJldmlzaW9uIDczOTg0KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYxLDYgKzQ2MSwxNCBAQCBXZWJTdHJpbmcg V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dGl0bGUoCiAgICAgcmV0dXJuIG1fcHJpdmF0ZS0+dGl0 bGUoKTsKIH0KIAorV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnVybCgpIGNvbnN0 Cit7CisgICAgaWYgKCFtX3ByaXZhdGUpCisgICAgICAgIHJldHVybiBXZWJTdHJpbmcoKTsKKyAg ICAKKyAgICBtX3ByaXZhdGUtPnVwZGF0ZUJhY2tpbmdTdG9yZSgpOworICAgIHJldHVybiBtX3By aXZhdGUtPnVybCgpLnN0cmluZygpOworfQogCiBXZWJOb2RlIFdlYkFjY2Vzc2liaWxpdHlPYmpl Y3Q6Om5vZGUoKSBjb25zdAogewo= 76633 2010-12-14 23:18:07 -0800 2010-12-15 19:32:00 -0800 Patch MyPatch.txt text/plain 2068 ctguil SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzQwNTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMTQgIENocmlz IEd1aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgQWNjZXNzaWJpbGl0eU9iamVj dDo6dXJsKCkgdG8gQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUxMDQ2CisKKyAgICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdC5oOgorICAgICAgICAqIHNyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dXJsKToKKwogMjAxMC0xMi0xMyAg TWlrZSBMYXd0aGVyICA8bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEphbWVzIFJvYmluc29uLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDc0MDUzKQorKysgV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAg LTQ1LDYgKzQ1LDcgQEAgY2xhc3MgV2ViQWNjZXNzaWJpbGl0eU9iamVjdFByaXZhdGU7CiBjbGFz cyBXZWJOb2RlOwogY2xhc3MgV2ViRG9jdW1lbnQ7CiBjbGFzcyBXZWJTdHJpbmc7CitjbGFzcyBX ZWJVUkw7CiBzdHJ1Y3QgV2ViUG9pbnQ7CiBzdHJ1Y3QgV2ViUmVjdDsKIApAQCAtMTEwLDYgKzEx MSw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0Rm9jdXNlZChib29sKSBjb25z dDsKICAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyBzdHJpbmdWYWx1ZSgpIGNvbnN0OwogICAgIFdF QktJVF9BUEkgV2ViU3RyaW5nIHRpdGxlKCkgY29uc3Q7CisgICAgV0VCS0lUX0FQSSBXZWJVUkwg dXJsKCkgY29uc3Q7CiAKICAgICBXRUJLSVRfQVBJIFdlYk5vZGUgbm9kZSgpIGNvbnN0OwogICAg IFdFQktJVF9BUEkgV2ViRG9jdW1lbnQgZG9jdW1lbnQoKSBjb25zdDsKSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkocmV2aXNpb24gNzQw NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw3IEBACiAjaW5jbHVkZSAiV2ViUG9pbnQuaCIKICNp bmNsdWRlICJXZWJSZWN0LmgiCiAjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCisjaW5jbHVkZSAiV2Vi VVJMLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC00NjEsNiArNDYyLDE0IEBA IFdlYlN0cmluZyBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp0aXRsZSgKICAgICByZXR1cm4gbV9w cml2YXRlLT50aXRsZSgpOwogfQogCitXZWJVUkwgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dXJs KCkgY29uc3QKK3sKKyAgICBpZiAoIW1fcHJpdmF0ZSkKKyAgICAgICAgcmV0dXJuIFdlYlVSTCgp OworICAgIAorICAgIG1fcHJpdmF0ZS0+dXBkYXRlQmFja2luZ1N0b3JlKCk7CisgICAgcmV0dXJu IG1fcHJpdmF0ZS0+dXJsKCk7Cit9CiAKIFdlYk5vZGUgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6 bm9kZSgpIGNvbnN0CiB7Cg==