51032 2010-12-14 06:22:44 -0800 [GTK] Fix several issues in r73858 2010-12-14 08:11:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 321934 0 cgarcia 2010-12-14 06:22:44 -0800 - It uses both glib private data and it allocates its own private structure - It calls parent's dispose method from finalize - webkit_web_plugin_get_mimetypes() uses a wrong annotation for the returned value, it should be transfer none rather than transfer container. - Since the mime type list is internal and we return the list and not a copy, it should never be freed by the caller, so webkit_web_plugin_mime_type_list_free() should be removed from the public API. - Mime types list is used uninitialized - Mention in the docs that list returned by webkit_web_plugin_database_get_plugins() must be freed with webkit_web_plugin_database_plugins_list_free() 321936 1 76531 cgarcia 2010-12-14 06:26:09 -0800 Created attachment 76531 Patch to fix the issues 321938 2 76531 xan.lopez 2010-12-14 06:31:56 -0800 Comment on attachment 76531 Patch to fix the issues View in context: https://bugs.webkit.org/attachment.cgi?id=76531&action=review > WebKit/gtk/webkit/webkitwebplugin.cpp:55 > Are both of these NULL-safe? 321940 3 76531 xan.lopez 2010-12-14 06:34:53 -0800 Comment on attachment 76531 Patch to fix the issues Seems they are. 321965 4 76531 commit-queue 2010-12-14 07:55:40 -0800 Comment on attachment 76531 Patch to fix the issues Clearing flags on attachment: 76531 Committed r74026: <http://trac.webkit.org/changeset/74026> 321966 5 commit-queue 2010-12-14 07:55:45 -0800 All reviewed patches have been landed. Closing bug. 321974 6 commit-queue 2010-12-14 08:11:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 76531: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 76531 2010-12-14 06:26:09 -0800 2010-12-14 07:55:40 -0800 Patch to fix the issues issues-r73858.diff text/plain 5048 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNzY5NGMyOS4uZmY1OWFhMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxMC0xMi0xNCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRml4IHNldmVyYWwgaXNz dWVzIGluIHI3Mzg1OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTEwMzIKKworICAgICAgICAtIEl0IHVzZXMgYm90aCBnbGliIHByaXZhdGUgZGF0YSBh bmQgaXQgYWxsb2NhdGVzIGl0cyBvd24gcHJpdmF0ZQorICAgICAgICAgIHN0cnVjdHVyZS4KKyAg ICAgICAgLSBJdCBjYWxscyBwYXJlbnQncyBkaXNwb3NlIG1ldGhvZCBmcm9tIGZpbmFsaXplLgor ICAgICAgICAtIHdlYmtpdF93ZWJfcGx1Z2luX2dldF9taW1ldHlwZXMoKSB1c2VzIGEgd3Jvbmcg YW5ub3RhdGlvbiBmb3IgdGhlCisgICAgICAgICAgcmV0dXJuZWQgdmFsdWUsIGl0IHNob3VsZCBi ZSB0cmFuc2ZlciBub25lIHJhdGhlciB0aGFuIHRyYW5zZmVyCisgICAgICAgICAgY29udGFpbmVy LgorICAgICAgICAtIFNpbmNlIHRoZSBtaW1lIHR5cGUgbGlzdCBpcyBpbnRlcm5hbCBhbmQgd2Ug cmV0dXJuIHRoZSBsaXN0IGFuZCBub3QgYQorICAgICAgICAgIGNvcHksIGl0IHNob3VsZCBuZXZl ciBiZSBmcmVlZCBieSB0aGUgY2FsbGVyLCBzbworICAgICAgICAgIHdlYmtpdF93ZWJfcGx1Z2lu X21pbWVfdHlwZV9saXN0X2ZyZWUoKSBzaG91bGQgYmUgcmVtb3ZlZCBmcm9tIHRoZQorICAgICAg ICAgIHB1YmxpYyBBUEkuCisgICAgICAgIC0gTWltZSB0eXBlcyBsaXN0IGlzIHVzZWQgdW5pbml0 aWFsaXplZC4KKyAgICAgICAgLSBNZW50aW9uIGluIHRoZSBkb2NzIHRoYXQgbGlzdCByZXR1cm5l ZCBieQorICAgICAgICAgIHdlYmtpdF93ZWJfcGx1Z2luX2RhdGFiYXNlX2dldF9wbHVnaW5zKCkg bXVzdCBiZSBmcmVlZCB3aXRoCisgICAgICAgICAgd2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2Vf cGx1Z2luc19saXN0X2ZyZWUoKS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJwbHVnaW4u Y3BwOgorICAgICAgICAod2Via2l0X3dlYl9wbHVnaW5fZmluYWxpemUpOgorICAgICAgICAod2Vi a2l0X3dlYl9wbHVnaW5fY2xhc3NfaW5pdCk6CisgICAgICAgICh3ZWJraXRfd2ViX3BsdWdpbl9p bml0KToKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2VicGx1Z2luLmg6CisgICAgICAgICogd2Vi a2l0L3dlYmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNwcDoKKwogMjAxMC0xMi0xMyAgWGFuIExvcGV6 ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmlu c29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcCBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5jcHAKaW5kZXggNWQwOGI0ZC4uNjk5 Y2Q1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcAor KysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW4uY3BwCkBAIC00NSwyMyArNDUs MTcgQEAgc3RhdGljIHZvaWQgZnJlZU1JTUVUeXBlKFdlYktpdFdlYlBsdWdpbk1JTUVUeXBlKiBt aW1lVHlwZSkKICAgICBnX3NsaWNlX2ZyZWUoV2ViS2l0V2ViUGx1Z2luTUlNRVR5cGUsIG1pbWVU eXBlKTsKIH0KIAotdm9pZCB3ZWJraXRfd2ViX3BsdWdpbl9taW1lX3R5cGVfbGlzdF9mcmVlKEdT TGlzdCogbGlzdCkKLXsKLSAgICBmb3IgKEdTTGlzdCogcCA9IGxpc3Q7IHA7IHAgPSBwLT5uZXh0 KQotICAgICAgICBmcmVlTUlNRVR5cGUoKFdlYktpdFdlYlBsdWdpbk1JTUVUeXBlKilwLT5kYXRh KTsKLSAgICBnX3NsaXN0X2ZyZWUobGlzdCk7Ci19Ci0KIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJf cGx1Z2luX2ZpbmFsaXplKEdPYmplY3QqIG9iamVjdCkKIHsKLSAgICBXZWJLaXRXZWJQbHVnaW5Q cml2YXRlKiBwcml2ID0gV0VCS0lUX1dFQl9QTFVHSU4ob2JqZWN0KS0+cHJpdjsKKyAgICBXZWJL aXRXZWJQbHVnaW4qIHBsdWdpbiA9IFdFQktJVF9XRUJfUExVR0lOKG9iamVjdCk7CisgICAgV2Vi S2l0V2ViUGx1Z2luUHJpdmF0ZSogcHJpdiA9IHBsdWdpbi0+cHJpdjsKIAotICAgIGlmIChwcml2 LT5taW1lVHlwZXMpCi0gICAgICAgIHdlYmtpdF93ZWJfcGx1Z2luX21pbWVfdHlwZV9saXN0X2Zy ZWUocHJpdi0+bWltZVR5cGVzKTsKKyAgICBnX3NsaXN0X2ZvcmVhY2gocHJpdi0+bWltZVR5cGVz LCAoR0Z1bmMpZnJlZU1JTUVUeXBlLCAwKTsKKyAgICBnX3NsaXN0X2ZyZWUocHJpdi0+bWltZVR5 cGVzKTsKIAotICAgIGRlbGV0ZSBXRUJLSVRfV0VCX1BMVUdJTihvYmplY3QpLT5wcml2OworICAg IGRlbGV0ZSBwbHVnaW4tPnByaXY7CiAKLSAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3Bs dWdpbl9wYXJlbnRfY2xhc3MpLT5kaXNwb3NlKG9iamVjdCk7CisgICAgR19PQkpFQ1RfQ0xBU1Mo d2Via2l0X3dlYl9wbHVnaW5fcGFyZW50X2NsYXNzKS0+ZmluYWxpemUob2JqZWN0KTsKIH0KIAog c3RhdGljIHZvaWQgd2Via2l0X3dlYl9wbHVnaW5fZ2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVj dCwgZ3VpbnQgcHJvcF9pZCwgR1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyogcGFyYW1TcGVjKQpA QCAtMTA3LDE0ICsxMDEsMTIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9wbHVnaW5fY2xhc3Nf aW5pdChXZWJLaXRXZWJQbHVnaW5DbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJXaGV0aGVyIHRoZSBwbHVnaW4g aXMgZW5hYmxlZCIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgRkFMU0UsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfUEFSQU1fUkVBRFdSSVRFKSk7Ci0KLSAgICBn X3R5cGVfY2xhc3NfYWRkX3ByaXZhdGUoa2xhc3MsIHNpemVvZihXZWJLaXRXZWJQbHVnaW5Qcml2 YXRlKSk7CiB9CiAKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfcGx1Z2luX2luaXQoV2ViS2l0V2Vi UGx1Z2luICpwbHVnaW4pCiB7Ci0gICAgV2ViS2l0V2ViUGx1Z2luUHJpdmF0ZSogcHJpdiA9IEdf VFlQRV9JTlNUQU5DRV9HRVRfUFJJVkFURShwbHVnaW4sIFdFQktJVF9UWVBFX1dFQl9QTFVHSU4s IFdlYktpdFdlYlBsdWdpblByaXZhdGUpOwotICAgIHBsdWdpbi0+cHJpdiA9IHByaXYgPSBuZXcg V2ViS2l0V2ViUGx1Z2luUHJpdmF0ZSgpOworICAgIHBsdWdpbi0+cHJpdiA9IG5ldyBXZWJLaXRX ZWJQbHVnaW5Qcml2YXRlKCk7CisgICAgcGx1Z2luLT5wcml2LT5taW1lVHlwZXMgPSAwOwogfQog CiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTE3NSw3ICsxNjcsNyBAQCBjb25zdCBjaGFyKiB3ZWJr aXRfd2ViX3BsdWdpbl9nZXRfZGVzY3JpcHRpb24oV2ViS2l0V2ViUGx1Z2luKiBwbHVnaW4pCiAg KiBSZXR1cm5zIGFsbCB0aGUgI1dlYktpdFdlYlBsdWdpbk1JTUVUeXBlIHRoYXQgQHBsdWdpbiBp cyBoYW5kbGluZwogICogYXQgdGhlIG1vbWVudC4KICAqCi0gKiBSZXR1cm5zOiAodHJhbnNmZXIg Y29udGFpbmVyKSAoZWxlbWVudC10eXBlIFdlYktpdFdlYlBsdWdpbk1JTUVUeXBlKTogYSAjR1NM aXN0IG9mICNXZWJLaXRXZWJQbHVnaW5NSU1FVHlwZQorICogUmV0dXJuczogKHRyYW5zZmVyIG5v bmUpIChlbGVtZW50LXR5cGUgV2ViS2l0V2ViUGx1Z2luTUlNRVR5cGUpOiBhICNHU0xpc3Qgb2Yg I1dlYktpdFdlYlBsdWdpbk1JTUVUeXBlCiAgKgogICogU2luY2U6IDEuMy44CiAgKi8KZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5oIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2VicGx1Z2luLmgKaW5kZXggMjhiOTZlMS4uMzUxNGQxZSAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmgKKysrIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2VicGx1Z2luLmgKQEAgLTU0LDkgKzU0LDYgQEAgdHlwZWRlZiBzdHJ1Y3Qg X1dlYktpdFdlYlBsdWdpbk1JTUVUeXBlIHsKICAgICBjaGFyKiogZXh0ZW5zaW9uczsKIH0gV2Vi S2l0V2ViUGx1Z2luTUlNRVR5cGU7CiAKLVdFQktJVF9BUEkgdm9pZAotd2Via2l0X3dlYl9wbHVn aW5fbWltZV90eXBlX2xpc3RfZnJlZSAoR1NMaXN0Kik7Ci0KIHN0cnVjdCBfV2ViS2l0V2ViUGx1 Z2luQ2xhc3MgewogICAgIEdPYmplY3RDbGFzcyBwYXJlbnRDbGFzczsKIH07CmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5kYXRhYmFzZS5jcHAgYi9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5kYXRhYmFzZS5jcHAKaW5kZXggYTQ0ZmVkYy4uYWZj M2NlYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luZGF0YWJh c2UuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNw cApAQCAtNzYsNiArNzYsNyBAQCB2b2lkIHdlYmtpdF93ZWJfcGx1Z2luX2RhdGFiYXNlX3BsdWdp bnNfbGlzdF9mcmVlKEdTTGlzdCogbGlzdCkKICAqIEBkYXRhYmFzZTogYSAjV2ViS2l0V2ViUGx1 Z2luRGF0YWJhc2UKICAqCiAgKiBSZXR1cm5zIGFsbCAjV2ViS2l0V2ViUGx1Z2luIGF2YWlsYWJs ZSBpbiBAZGF0YWJhc2UuCisgKiBUaGUgcmV0dXJuZWQgbGlzdCBtdXN0IGJlIGZyZWVkIHdpdGgg d2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2VfcGx1Z2luc19saXN0X2ZyZWUoKQogICoKICAqIFJl dHVybnM6ICh0cmFuc2ZlciBmdWxsKSAoZWxlbWVudC10eXBlIFdlYktpdFdlYlBsdWdpbik6IGEg I0dTTGlzdCBvZiAjV2ViS2l0V2ViUGx1Z2luCiAgKgo=