50995 2010-12-13 16:51:15 -0800 Flaky Test: fast/workers/storage/use-same-database-in-page-and-workers.html 2012-03-07 15:24:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED DUPLICATE 75111 P2 Normal --- 75111 50856 1 commit-queue commit-queue adamk dslomov dumi eric levin michaeln webkit.review.bot zhenghao oldest_to_newest 321548 0 commit-queue 2010-12-13 16:51:15 -0800 This is an automatically generated bug from the commit-queue. fast/workers/storage/use-same-database-in-page-and-workers.html has been flaky on the commit-queue. fast/workers/storage/use-same-database-in-page-and-workers.html was authored by dumi@chromium.org. http://trac.webkit.org/browser/trunk/LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers.html The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76453 on bug 50988. Bot: eseidel-cq-sl Port: Mac Platform: Mac OS X 10.6.5 The bots will update this with information from each new failure. If you would like to track this test fix with another bug, please close this bug as a duplicate. 321720 1 eric 2010-12-13 23:46:06 -0800 *** Bug 51003 has been marked as a duplicate of this bug. *** 321908 2 commit-queue 2010-12-14 05:14:41 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76523 on bug 51023. Bot: eseidel-cq-sl Port: Mac Platform: Mac OS X 10.6.5 321920 3 commit-queue 2010-12-14 05:38:01 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76523 on bug 51023. Bot: eseidel-cq-sl Port: Mac Platform: Mac OS X 10.6.5 321997 4 commit-queue 2010-12-14 09:11:29 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76535 on bug 51037. Bot: eseidel-cq-sl Port: Mac Platform: Mac OS X 10.6.5 323489 5 commit-queue 2010-12-16 16:06:10 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76787 on bug 51160. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.4 323514 6 eric 2010-12-16 16:41:23 -0800 This may be a timeout or crash since the cq hasn't uploaded any results for it yet. Sadly our reporting code isn't good enough at conveying that on the bug yet. 323684 7 commit-queue 2010-12-17 02:56:32 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76854 on bug 51236. Bot: abarth-cq-sl Port: Mac Platform: Mac OS X 10.6.5 326656 8 commit-queue 2010-12-24 10:19:00 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 77418 on bug 28291. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.4 326671 9 commit-queue 2010-12-24 10:54:25 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 77286 on bug 27753. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 326676 10 commit-queue 2010-12-24 10:58:21 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 77330 on bug 51535. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4 327263 11 commit-queue 2010-12-28 10:54:25 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 76776 on bug 50971. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 327669 12 commit-queue 2010-12-29 12:38:44 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake while processing attachment 77591 on bug 51067. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 331331 13 commit-queue 2011-01-08 17:29:11 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 78266 on bug 52081. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 331349 14 commit-queue 2011-01-08 18:53:51 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 78288 on bug 51982. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.4 331603 15 commit-queue 2011-01-10 06:38:26 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 77717 on bug 51776. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 332099 16 commit-queue 2011-01-10 18:24:16 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 78408 on bug 51253. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 332267 17 commit-queue 2011-01-11 04:43:48 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 76977 on bug 51237. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.4 332719 18 commit-queue 2011-01-11 15:17:06 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 78578 on bug 52239. Bot: eseidel-sf-cq Port: Mac Platform: Mac OS X 10.6.4 332720 19 78608 commit-queue 2011-01-11 15:17:08 -0800 Created attachment 78608 Archive of layout-test-results from eseidel-sf-cq 332745 20 commit-queue 2011-01-11 15:47:05 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 78487 on bug 50182. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.4 332836 21 78608 eric 2011-01-11 18:03:04 -0800 Comment on attachment 78608 Archive of layout-test-results from eseidel-sf-cq Clearly there is a bug in the zip uploading code. Investigating. 332935 22 eric 2011-01-11 23:38:10 -0800 I believe the upload behavior to be fixed in http://trac.webkit.org/changeset/75583. Sorry for the noise. The next flake should give us results. 346541 23 commit-queue 2011-02-07 04:34:19 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 81231 on bug 53775. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4 346542 24 81466 commit-queue 2011-02-07 04:34:22 -0800 Created attachment 81466 Failure diff from eseidel-cq-sf 350789 25 commit-queue 2011-02-14 11:43:18 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 82330 on bug 54333. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4 350790 26 82344 commit-queue 2011-02-14 11:43:21 -0800 Created attachment 82344 Failure diff from eseidel-cq-sf 368840 27 commit-queue 2011-03-16 22:55:05 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 85986 on bug 56414. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 368841 28 86029 commit-queue 2011-03-16 22:55:08 -0700 Created attachment 86029 Failure diff from cr-jail-3 373666 29 commit-queue 2011-03-25 12:29:36 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 86858 on bug 57062. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 373667 30 86972 commit-queue 2011-03-25 12:29:39 -0700 Created attachment 86972 Failure diff from cr-jail-3 375010 31 commit-queue 2011-03-28 22:38:35 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 86935 on bug 57022. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6 375011 32 87261 commit-queue 2011-03-28 22:38:38 -0700 Created attachment 87261 Failure diff from cr-jail-7 375050 33 commit-queue 2011-03-28 23:30:42 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 87119 on bug 57142. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 375051 34 87267 commit-queue 2011-03-28 23:30:45 -0700 Created attachment 87267 Failure diff from cr-jail-3 375485 35 commit-queue 2011-03-29 10:32:59 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 87333 on bug 56602. Bot: cr-jail-8 Port: Mac Platform: Mac OS X 10.6.6 375486 36 87360 commit-queue 2011-03-29 10:33:02 -0700 Created attachment 87360 Failure diff from cr-jail-8 375622 37 commit-queue 2011-03-29 11:57:47 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 87316 on bug 57338. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 375623 38 87383 commit-queue 2011-03-29 11:57:50 -0700 Created attachment 87383 Failure diff from cr-jail-3 377378 39 commit-queue 2011-03-31 12:27:10 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 87712 on bug 57017. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6 377379 40 87776 commit-queue 2011-03-31 12:27:12 -0700 Created attachment 87776 Failure diff from cr-jail-7 379397 41 commit-queue 2011-04-05 02:26:10 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 88139 on bug 57664. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6 379398 42 88193 commit-queue 2011-04-05 02:26:13 -0700 Created attachment 88193 Failure diff from cr-jail-7 383451 43 commit-queue 2011-04-11 13:43:07 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 88876 on bug 58143. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 383452 44 89072 commit-queue 2011-04-11 13:43:10 -0700 Created attachment 89072 Failure diff from cr-jail-3 394947 45 commit-queue 2011-04-28 17:08:10 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 90704 on bug 53031. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.6 394948 46 91596 commit-queue 2011-04-28 17:08:13 -0700 Created attachment 91596 Failure diff from cr-jail-3 394981 47 eric 2011-04-28 17:35:44 -0700 This seems to be failing quite often. Any theories? 394987 48 levin 2011-04-28 17:42:47 -0700 Adding others who may be maintaining database related items. 395718 49 commit-queue 2011-04-29 18:58:40 -0700 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 91762 on bug 58378. Bot: cr-jail-8 Port: Mac Platform: Mac OS X 10.6.6 395719 50 91791 commit-queue 2011-04-29 18:58:44 -0700 Created attachment 91791 Failure diff from cr-jail-8 568342 51 webkit.review.bot 2012-02-29 22:12:21 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129530 on bug 79145. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 568421 52 webkit.review.bot 2012-03-01 00:12:23 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129549 on bug 79855. Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 568529 53 webkit.review.bot 2012-03-01 03:41:18 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129631 on bug 80004. Bot: ec2-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 568553 54 webkit.review.bot 2012-03-01 04:35:41 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129640 on bug 80008. Bot: ec2-cq-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 568605 55 webkit.review.bot 2012-03-01 05:59:02 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129663 on bug 77522. Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 568708 56 levin 2012-03-01 09:23:17 -0800 I think this test should just be disabled (and someone should look into it because something seems really wrong here). It is failing so much that it is getting perfectly good patches rejected from the commit queue. 568710 57 levin 2012-03-01 09:25:06 -0800 Looks like https://bugs.webkit.org/show_bug.cgi?id=75111 is related. 568728 58 webkit.review.bot 2012-03-01 09:49:22 -0800 The commit-queue just saw fast/workers/storage/use-same-database-in-page-and-workers.html flake (Text diff mismatch) while processing attachment 129688 on bug 79929. Bot: ec2-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick 569043 59 michaeln 2012-03-01 16:28:47 -0800 David, in recent history, is this giving us grief for v8 ports only or should we disable this test for all ports across the board? 'ChromiumXVFBPort' makes me think the former. What happened on 2012-02-29? Prior to that date, there hadn't been a report of this since 2011-04-29. 569048 60 eric 2012-03-01 16:31:40 -0800 The commit-queue forgot how to report flaky tests for several months. :) It miraculously remembered recently. 569058 61 michaeln 2012-03-01 16:46:37 -0800 (In reply to comment #60) > The commit-queue forgot how to report flaky tests for several months. :) It miraculously remembered recently. How many is several, did the amnesia start before or after 2011-04-29? And how recent is recently, revision number? This looks like something that happened on 2012-02-29 that could be related. http://trac.webkit.org/changeset/109319 569064 62 eric 2012-03-01 16:49:36 -0800 (In reply to comment #61) > (In reply to comment #60) > > The commit-queue forgot how to report flaky tests for several months. :) It miraculously remembered recently. > > How many is several, did the amnesia start before or after 2011-04-29? And how recent is recently, revision number? > > This looks like something that happened on 2012-02-29 that could be related. > http://trac.webkit.org/changeset/109319 From https://bugs.webkit.org/show_activity.cgi?id=50856 it looks like the CQ forgot how to report flaky tests around last July, and started again on Valentines day. 569065 63 eric 2012-03-01 16:49:53 -0800 We may disable this feature entirely. I'm not sure it's providing value. 569079 64 michaeln 2012-03-01 17:03:01 -0800 Thnx for the dates... there's a buffer of a couple of months before amnesia set in, and a few weeks after recovery where this wasn't flaking/crashing on us. Seems like the db related patch on 2/29 may be related in some unanticipated way? I'll take a look at that patch and see if anything looks interesting. I can also take a loot at modifying the canInvokeCallback() method for this particular class &| making a custom binding for this that doesn't call CRASH (as mentioned in https://bugs.webkit.org/show_bug.cgi?id=75111) It'd probably be good to skip this test in the interim. 569124 65 levin 2012-03-01 18:03:58 -0800 (In reply to comment #64) > Thnx for the dates... there's a buffer of a couple of months before amnesia set in, and a few weeks after recovery where this wasn't flaking/crashing on us. Seems like the db related patch on 2/29 may be related in some unanticipated way? > > I'll take a look at that patch and see if anything looks interesting. > > I can also take a loot at modifying the canInvokeCallback() method for this particular class &| making a custom binding for this that doesn't call CRASH (as mentioned in https://bugs.webkit.org/show_bug.cgi?id=75111) > > It'd probably be good to skip this test in the interim. Here's a better indicator for when this test fell over: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=use-same-database-in-page-and-workers.html Looks like it is only Linux and started happening http://trac.webkit.org/log/?verbose=on&rev=109304&stop_rev=109297 When a result was added for it? (Maybe not so helpful.) 569143 66 dslomov 2012-03-01 18:25:03 -0800 (In reply to comment #65) > (In reply to comment #64) > > Thnx for the dates... there's a buffer of a couple of months before amnesia set in, and a few weeks after recovery where this wasn't flaking/crashing on us. Seems like the db related patch on 2/29 may be related in some unanticipated way? > > > > I'll take a look at that patch and see if anything looks interesting. > > > > I can also take a loot at modifying the canInvokeCallback() method for this particular class &| making a custom binding for this that doesn't call CRASH (as mentioned in https://bugs.webkit.org/show_bug.cgi?id=75111) > > > > It'd probably be good to skip this test in the interim. > > Here's a better indicator for when this test fell over: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=use-same-database-in-page-and-workers.html > > Looks like it is only Linux and started happening http://trac.webkit.org/log/?verbose=on&rev=109304&stop_rev=109297 > > When a result was added for it? (Maybe not so helpful.) Rats, it looks like the wrong result was added (without a PASS in the end). The test still times out. 569150 67 michaeln 2012-03-01 18:39:09 -0800 Oh... that's what happened on 2/29... the results of a timed out test were added as the expected results on linux... pretty funny :) That patch should be reverted. 569152 68 zhenghao 2012-03-01 18:40:48 -0800 (In reply to comment #64) > Thnx for the dates... there's a buffer of a couple of months before amnesia set in, and a few weeks after recovery where this wasn't flaking/crashing on us. Seems like the db related patch on 2/29 may be related in some unanticipated way? > > I'll take a look at that patch and see if anything looks interesting. > > I can also take a loot at modifying the canInvokeCallback() method for this particular class &| making a custom binding for this that doesn't call CRASH (as mentioned in https://bugs.webkit.org/show_bug.cgi?id=75111) > > It'd probably be good to skip this test in the interim. I'm afraid skipping this single test is not enough. I saw that several other tests related to WebWorker flakily crash when timing out on our downstream Android bot, and all are caused by the same issue: fast/workers/worker-navigator.html = CRASH http/tests/websocket/tests/hybi/workers/close-in-worker.html = CRASH fast/workers/storage/open-database-set-empty-version-sync.html = CRASH http/tests/filesystem/workers/resolve-url.html = CRASH http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html = CRASH We don't see other crash on public bots just because they don't timeout as frequently as on Android. 569153 69 levin 2012-03-01 18:42:13 -0800 (In reply to comment #68) > > I'm afraid skipping this single test is not enough. I saw that several other tests related to WebWorker flakily crash when timing out on our downstream Android bot, and all are caused by the same issue: > fast/workers/worker-navigator.html = CRASH > http/tests/websocket/tests/hybi/workers/close-in-worker.html = CRASH > fast/workers/storage/open-database-set-empty-version-sync.html = CRASH > http/tests/filesystem/workers/resolve-url.html = CRASH > http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html = CRASH > > We don't see other crash on public bots just because they don't timeout as frequently as on Android. At the moment, I've mostly been concerned with how this is affecting our commit queue (which is why I wanted it skipped). 569158 70 michaeln 2012-03-01 18:48:12 -0800 Do you know if those if the proximate cause of those crashes is also a v8 binding induced CRASH() like the one in the database case? In the db case, the CRASH() call seems like an overly aggressive response to what happening in the case. > fast/workers/worker-navigator.html = CRASH > http/tests/websocket/tests/hybi/workers/close-in-worker.html = CRASH > fast/workers/storage/open-database-set-empty-version-sync.html = CRASH > http/tests/filesystem/workers/resolve-url.html = CRASH > http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html = CRASH > > We don't see other crash on public bots just because they don't timeout as frequently as on Android. @david, seems like reverting http://trac.webkit.org/changeset/109303/ would make the cq a lot better. 569159 71 zhenghao 2012-03-01 18:49:57 -0800 (In reply to comment #69) > (In reply to comment #68) > > > > I'm afraid skipping this single test is not enough. I saw that several other tests related to WebWorker flakily crash when timing out on our downstream Android bot, and all are caused by the same issue: > > fast/workers/worker-navigator.html = CRASH > > http/tests/websocket/tests/hybi/workers/close-in-worker.html = CRASH > > fast/workers/storage/open-database-set-empty-version-sync.html = CRASH > > http/tests/filesystem/workers/resolve-url.html = CRASH > > http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html = CRASH > > > > We don't see other crash on public bots just because they don't timeout as frequently as on Android. > > At the moment, I've mostly been concerned with how this is affecting our commit queue (which is why I wanted it skipped). Sure. Sounds good to me. 569161 72 zhenghao 2012-03-01 18:50:38 -0800 (In reply to comment #70) > Do you know if those if the proximate cause of those crashes is also a v8 binding induced CRASH() like the one in the database case? In the db case, the CRASH() call seems like an overly aggressive response to what happening in the case. Yes, I confirm. 569165 73 michaeln 2012-03-01 19:02:59 -0800 > Yes, I confirm. The suicidal CRASH() seems too harsh for this condition. As I understand it, The c++ object has outlived it's v8 split personality (not really unexpected since the c++ obj is refcounted independently), the c++ guy tries to poke its v8 peer and CRASH() is intentionally invoked in the bindings layer as the outgoing poke is being performed. Why does that condition warrant a CRASH? 569799 74 dslomov 2012-03-02 11:40:48 -0800 (In reply to comment #73) > > Yes, I confirm. > > The suicidal CRASH() seems too harsh for this condition. As I understand it, The c++ object has outlived it's v8 split personality (not really unexpected since the c++ obj is refcounted independently), This is definitely not expected. v8 objects maintain a "ref ptr" to c++ object. > the c++ guy tries to poke its v8 peer and CRASH() is intentionally invoked in the bindings layer as the outgoing poke is being performed. Why does that condition warrant a CRASH? 569888 75 michaeln 2012-03-02 13:31:38 -0800 (In reply to comment #74) > (In reply to comment #73) > > > Yes, I confirm. > > > > The suicidal CRASH() seems too harsh for this condition. As I understand it, The c++ object has outlived it's v8 split personality (not really unexpected since the c++ obj is refcounted independently), > > This is definitely not expected. v8 objects maintain a "ref ptr" to c++ object. really... v8 obj goes away releasing "a" ref on the c++ guy, but not the final ref)... c++ obj still hanging around... what's not to be expected about that? See comments just added to https://bugs.webkit.org/show_bug.cgi?id=75111 about a proposed fix for this class of bugs 569891 76 dslomov 2012-03-02 13:36:12 -0800 (In reply to comment #75) > (In reply to comment #74) > > (In reply to comment #73) > > > > Yes, I confirm. > > > > > > The suicidal CRASH() seems too harsh for this condition. As I understand it, The c++ object has outlived it's v8 split personality (not really unexpected since the c++ obj is refcounted independently), > > > > This is definitely not expected. v8 objects maintain a "ref ptr" to c++ object. > > really... v8 obj goes away releasing "a" ref on the c++ guy, but not the final ref)... c++ obj still hanging around... what's not to be expected about that? v8 objects don't go away until their C++ objects go away. We are in termination conditions here where this does not hold though. > > See comments just added to https://bugs.webkit.org/show_bug.cgi?id=75111 about a proposed fix for this class of bugs 573298 77 michaeln 2012-03-07 15:24:44 -0800 *** This bug has been marked as a duplicate of bug 75111 *** 78608 2011-01-11 15:17:08 -0800 2011-01-11 18:03:04 -0800 Archive of layout-test-results from eseidel-sf-cq layout-test-results.zip application/zip 22 commit-queue UEsFBgAAAAABAAEAXgAAAFIAAAAAAA== 81466 2011-02-07 04:34:22 -0800 2011-02-07 04:34:22 -0800 Failure diff from eseidel-cq-sf failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAyLTA3IDA0 OjIxOjAzLjAwMDAwMDAwMCAtMDgwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAyLTA3IDA0OjIxOjAzLjAwMDAwMDAwMCAtMDgwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 82344 2011-02-14 11:43:21 -0800 2011-02-14 11:43:21 -0800 Failure diff from eseidel-cq-sf failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAyLTE0IDEx OjMwOjI1LjAwMDAwMDAwMCAtMDgwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAyLTE0IDExOjMwOjI1LjAwMDAwMDAwMCAtMDgwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 86029 2011-03-16 22:55:08 -0700 2011-03-16 22:55:08 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTE2IDIy OjQxOjU4LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTE2IDIyOjQxOjU4LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 86972 2011-03-25 12:29:39 -0700 2011-03-25 12:29:39 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTI1IDEy OjE2OjIwLjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTI1IDEyOjE2OjIwLjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 87261 2011-03-28 22:38:38 -0700 2011-03-28 22:38:38 -0700 Failure diff from cr-jail-7 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTI4IDIy OjI0OjM2LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTI4IDIyOjI0OjM2LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 87267 2011-03-28 23:30:45 -0700 2011-03-28 23:30:45 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTI4IDIz OjE3OjQ0LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTI4IDIzOjE3OjQ0LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 87360 2011-03-29 10:33:02 -0700 2011-03-29 10:33:02 -0700 Failure diff from cr-jail-8 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTI5IDEw OjIyOjA4LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTI5IDEwOjIyOjA4LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 87383 2011-03-29 11:57:50 -0700 2011-03-29 11:57:50 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTI5IDEx OjQ0OjE4LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTI5IDExOjQ0OjE4LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 87776 2011-03-31 12:27:12 -0700 2011-03-31 12:27:12 -0700 Failure diff from cr-jail-7 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTAzLTMxIDEy OjEzOjQ1LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTAzLTMxIDEyOjEzOjQ1LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 88193 2011-04-05 02:26:13 -0700 2011-04-05 02:26:13 -0700 Failure diff from cr-jail-7 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTA0LTA1IDAy OjEyOjQ1LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTA0LTA1IDAyOjEyOjQ1LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 89072 2011-04-11 13:43:10 -0700 2011-04-11 13:43:10 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTA0LTExIDEz OjI4OjU1LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTA0LTExIDEzOjI4OjU1LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 91596 2011-04-28 17:08:13 -0700 2011-04-28 17:08:13 -0700 Failure diff from cr-jail-3 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTA0LTI4IDE2 OjQ3OjA1LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTA0LTI4IDE2OjQ3OjA1LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK 91791 2011-04-29 18:58:44 -0700 2011-04-29 18:58:44 -0700 Failure diff from cr-jail-8 failure.diff text/plain 456 commit-queue LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dvcmtlcnMvc3RvcmFnZS91c2Utc2Ft ZS1kYXRhYmFzZS1pbi1wYWdlLWFuZC13b3JrZXJzLWV4cGVjdGVkLnR4dAkyMDExLTA0LTI5IDE4 OjQwOjA0LjAwMDAwMDAwMCAtMDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qv d29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMtYWN0 dWFsLnR4dAkyMDExLTA0LTI5IDE4OjQwOjA0LjAwMDAwMDAwMCAtMDcwMApAQCAtMSwzICsxLDMg QEAKK0ZBSUw6IFRpbWVkIG91dCB3YWl0aW5nIGZvciBub3RpZnlEb25lIHRvIGJlIGNhbGxlZAog VGVzdCB0aGF0IHdlIGNhbiBzdWNjZXNzZnVsbHkgdXNlIHRoZSBzYW1lIGRhdGFiYXNlIGluIHRo ZSBwYWdlIGFuZCBpbiBtdWx0aXBsZSB3b3JrZXJzIGF0IHRoZSBzYW1lIHRpbWUuCi1QQVNTCiAK