50982 2010-12-13 15:02:34 -0800 ViewportArguments.h uses an enum to intialize a bool 2010-12-23 20:32:10 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 51551 1 evan webkit-unassigned commit-queue kenneth oldest_to_newest 321459 0 evan 2010-12-13 15:02:34 -0800 r69316 changed userScalable from a float to a bool. However, userScalable is initialized from an enum in the constructor, and the enum value is ValueAuto (-1). This produces a compiler warning and probably isn't doing what we want. third_party/WebKit/WebCore/dom/ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool' 326212 1 77358 evan 2010-12-23 12:25:33 -0800 Created attachment 77358 Patch 326214 2 evan 2010-12-23 12:26:58 -0800 I don't really know what I'm doing so please review carefully. But I figure -1 is also true so this should be the same thing(?). 326221 3 kenneth 2010-12-23 12:37:22 -0800 Well ValueAuto means that it is unset and thus will use the default (which might depend on some of the other values). I guess the most right thing is to make userScalable a float and convert it to true or false in the compute* method. For instance if I set min-scale = 1.0 and max-scale = 1.0, it is basically not scalable, but I guess the iPhone might still consider it scalable, as it affects more than just the scale change. From docs: Setting user-scalable to no also prevents a webpage from scrolling when entering text in an input field. 326252 4 evan 2010-12-23 13:16:58 -0800 Kenneth, what do you think of the patch I uploaded? It at least doesn't change the current behavior of the code. I'm reluctant to try to change the semantics of userScalable since I don't really understand what it means or how it's used. 326305 5 kenneth 2010-12-23 15:09:34 -0800 (In reply to comment #4) > Kenneth, what do you think of the patch I uploaded? It at least doesn't change the current behavior of the code. I'm reluctant to try to change the semantics of userScalable since I don't really understand what it means or how it's used. It is fine, as you said it should give the correct behavior. Thanks for doing this. 326452 6 77358 commit-queue 2010-12-23 20:32:04 -0800 Comment on attachment 77358 Patch Clearing flags on attachment: 77358 Committed r74610: <http://trac.webkit.org/changeset/74610> 326453 7 commit-queue 2010-12-23 20:32:10 -0800 All reviewed patches have been landed. Closing bug. 77358 2010-12-23 12:25:33 -0800 2010-12-23 20:32:04 -0800 Patch bug-50982-20101223122530.patch text/plain 1180 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTBiZGE4NGYyYjUwMDc5ODNlNjZmNGY1ODUxYzYzNGJlZTc1ZTlmZS4uMGNlNjQ3ODU4OWI2ZTBi ODZmMGYxOTI2MWYyNjQ1MjNmN2NjYWY3YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0yMyAgRXZh biBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBWaWV3cG9ydEFyZ3VtZW50cy5oIHVzZXMgYW4gZW51bSB0 byBpbnRpYWxpemUgYSBib29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MDk4MgorCisgICAgICAgIEluaXRpYWxpemUgdXNlclNjYWxhYmxlIHRvIHRy dWUsIHJhdGhlciB0aGFuIC0xLgorICAgICAgICBObyB0ZXN0czsgZml4ZXMgYSBjb21waWxlciB3 YXJuaW5nLgorCisgICAgICAgICogZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmg6CisgICAgICAgIChX ZWJDb3JlOjpWaWV3cG9ydEFyZ3VtZW50czo6Vmlld3BvcnRBcmd1bWVudHMpOgorCiAyMDEwLTEy LTIyICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vVmlld3BvcnRB cmd1bWVudHMuaCBiL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKaW5kZXggYTMxZTAw OWRjNGVmNmQ3MjViMWEwZTlmMTIwYWI5NjNiZmYzNTdlNC4uNGY2NzhmMzNjOTExOTA1MDUwM2Yw NGZhZTA5NDBkMWNlYTZlYWRlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vVmlld3BvcnRBcmd1 bWVudHMuaAorKysgYi9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oCkBAIC03NCw3ICs3 NCw3IEBAIHN0cnVjdCBWaWV3cG9ydEFyZ3VtZW50cyB7CiAgICAgICAgICwgd2lkdGgoVmFsdWVB dXRvKQogICAgICAgICAsIGhlaWdodChWYWx1ZUF1dG8pCiAgICAgICAgICwgdGFyZ2V0RGVuc2l0 eURwaShWYWx1ZUF1dG8pCi0gICAgICAgICwgdXNlclNjYWxhYmxlKFZhbHVlQXV0bykKKyAgICAg ICAgLCB1c2VyU2NhbGFibGUodHJ1ZSkKICAgICB7CiAgICAgfQogCg==