50814 2010-12-10 06:45:58 -0800 [GTK] AX: implement isEnabled in DRT 2010-12-10 08:54:02 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mario webkit-unassigned oldest_to_newest 320123 0 mario 2010-12-10 06:45:58 -0800 DRT needs to be updated to correctly implement the isEnabled action so that accessibility/aria-disabled.html can be uncommented in the skip list and run 320146 1 76195 mario 2010-12-10 07:27:41 -0800 Created attachment 76195 Patch proposal 320153 2 76195 mrobinson 2010-12-10 07:38:03 -0800 Comment on attachment 76195 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=76195&action=review Nice patch! Please incorporate the small cleanup suggested below before landing. > WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:382 > + bool result = static_cast<bool>(atk_state_set_contains_state(stateSet.get(), stateType)); > + > + return result; This can just be: return atk_state_set_contains_state(stateSet.get(), stateType) 320188 3 mario 2010-12-10 08:54:02 -0800 Committed r73732: <http://trac.webkit.org/changeset/73732> 76195 2010-12-10 07:27:41 -0800 2010-12-10 07:38:03 -0800 Patch proposal bug-50814-20101210162743.patch text/plain 3691 mario ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmYmY0ZTIwMGUzYzg1YmRlNmNkOThlMDRhMDhhNTc4MmM4MGYzYjNiLi5hZmRiOGQ0 ZWUyZTlmODQzOTcxNTlkMjczODU0MzhjN2YxY2IyODkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTMgQEAK IDIwMTAtMTItMTAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgog CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBw YXNzaW5nIGFjY2Vzc2liaWxpdHkvYXJpYS1kaXNhYmxlZC5odG1sIHRlc3QuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDogVW5za2lwIHRlc3QuCisKKzIwMTAtMTItMTAgIE1hcmlv IFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3 ZWQsIHVuc2tpcCBwYXNzaW5nIGFjY2Vzc2liaWxpdHkgdGVzdHMgb24gR1RLLgogCiAgICAgICAg ICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCBwYXNzaW5nIHRlc3RzLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZAppbmRleCA3ZmY1YmExYWFhNjJhMjhkNTdhMDEwN2FlN2EwYmNmYjUyYmI4 N2FhLi5iZjkzNTljNDA1ZDA4ODFiMzFkOTdiNThlNzVjZmIxMTY3YWRkY2I1IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTYsNyArNTYsNiBAQCBodHRwL3Rlc3RzL2luY3JlbWVudGFs L3NwbGl0LWhleC1lbnRpdGllcy5wbAogIyBBbiBpbXBsZW1lbnRhdGlvbiBvZiBhY2Nlc3NpYmls aXR5Q29udHJvbGxlciBpcyByZXF1aXJlZC4KICMgICBUZXN0cyBmYWlsaW5nCiBhY2Nlc3NpYmls aXR5L2FyaWEtY29tYm9ib3guaHRtbAotYWNjZXNzaWJpbGl0eS9hcmlhLWRpc2FibGVkLmh0bWwK IGFjY2Vzc2liaWxpdHkvZWxsaXBzaXMtdGV4dC5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtaGVs cC5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtaGlkZGVuLmh0bWwKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBlNGZhMTQzNmFj MzJlYzU4OWJjMmVjMWViODc2OGRmZDZmNDMyMjExLi4yMWU5ZmJiNzY4NzJmNTJiOWRlZTkwM2Y4 OTgzZTc5YjBiYjU5NzgyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTItMTAgIE1hcmlv IFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50Ojppc0VuYWJsZWQoKSBmb3IgR1RLLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv Z3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgorICAgICAgICAoY2hlY2tFbGVtZW50 U3RhdGUpOiBOZXcgZnVuY3Rpb24gdG8gcmVmYWN0b3IgY29tbW9uIGNvZGUuCisgICAgICAgIChB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojppc0VuYWJsZWQpOiBJbXBsZW1lbnQgdGhpcyBieSBjaGVj a2luZworICAgICAgICB0aGUgY3VycmVudCBzdGF0ZSBvZiB0aGUgQXRrT2JqZWN0LgorICAgICAg ICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3RlZCk6IFVzZSB0aGUgbmV3CisgICAg ICAgIGNoZWNrRWxlbWVudFN0YXRlIGZ1bmN0aW9uLgorCiAyMDEwLTEyLTEwICBKb2NlbHluIFR1 cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKaW5k ZXggYzRmMzliZWU3MzlkYTA0ZWE4MWNlNjc4YmQyMDIwYTZhODhkMGVmMS4uOWNmY2ViYjJkMTUx NGFhZjU2YTE3YjMwMDM3NzJhN2E4YTBiN2YxYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisrKyBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcApA QCAtMzcxLDEyICszNzEsMjEgQEAgSlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6 dmFsdWVEZXNjcmlwdGlvbigpCiAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3Rl cnMoMCwgMCk7CiB9CiAKLWJvb2wgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNFbmFibGVkKCkK K3N0YXRpYyBib29sIGNoZWNrRWxlbWVudFN0YXRlKFBsYXRmb3JtVUlFbGVtZW50IGVsZW1lbnQs IEF0a1N0YXRlVHlwZSBzdGF0ZVR5cGUpCiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAotICAg IHJldHVybiBmYWxzZTsKKyAgICBpZiAoIUFUS19JU19PQkpFQ1QoZWxlbWVudCkpCisgICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICBQbGF0Zm9ybVJlZlB0cjxBdGtTdGF0ZVNldD4gc3RhdGVT ZXQgPSBhZG9wdFBsYXRmb3JtUmVmKGF0a19vYmplY3RfcmVmX3N0YXRlX3NldChBVEtfT0JKRUNU KGVsZW1lbnQpKSk7CisgICAgYm9vbCByZXN1bHQgPSBzdGF0aWNfY2FzdDxib29sPihhdGtfc3Rh dGVfc2V0X2NvbnRhaW5zX3N0YXRlKHN0YXRlU2V0LmdldCgpLCBzdGF0ZVR5cGUpKTsKKworICAg IHJldHVybiByZXN1bHQ7CiB9CiAKK2Jvb2wgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNFbmFi bGVkKCkKK3sKKyAgICByZXR1cm4gY2hlY2tFbGVtZW50U3RhdGUobV9lbGVtZW50LCBBVEtfU1RB VEVfRU5BQkxFRCk7Cit9CiAKIGludCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjppbnNlcnRpb25Q b2ludExpbmVOdW1iZXIoKQogewpAQCAtMzk4LDEzICs0MDcsNyBAQCBib29sIEFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OmlzUmVxdWlyZWQoKSBjb25zdAogCiBib29sIEFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQ6OmlzU2VsZWN0ZWQoKSBjb25zdAogewotICAgIGlmICghQVRLX0lTX09CSkVDVChtX2Vs ZW1lbnQpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBQbGF0Zm9ybVJlZlB0cjxBdGtT dGF0ZVNldD4gc3RhdGVTZXQgPSBhZG9wdFBsYXRmb3JtUmVmKGF0a19vYmplY3RfcmVmX3N0YXRl X3NldChBVEtfT0JKRUNUKG1fZWxlbWVudCkpKTsKLSAgICBnYm9vbGVhbiBpc1NlbGVjdGVkID0g YXRrX3N0YXRlX3NldF9jb250YWluc19zdGF0ZShzdGF0ZVNldC5nZXQoKSwgQVRLX1NUQVRFX1NF TEVDVEVEKTsKLQotICAgIHJldHVybiBpc1NlbGVjdGVkOworICAgIHJldHVybiBjaGVja0VsZW1l bnRTdGF0ZShtX2VsZW1lbnQsIEFUS19TVEFURV9TRUxFQ1RFRCk7CiB9CiAKIGludCBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjpoaWVyYXJjaGljYWxMZXZlbCgpIGNvbnN0Cg==