50707 2010-12-08 12:46:17 -0800 [Qt] Build fix for Symbian after recent allocator refactoring 2010-12-10 23:14:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 1 s.mathur s.mathur commit-queue kling laszlo.gombos webkit.review.bot oldest_to_newest 318951 0 s.mathur 2010-12-08 12:46:17 -0800 wtf.pri should unix!symbian to avoid POSIX memory management code from being compile for Symbian. 318952 1 75948 s.mathur 2010-12-08 12:51:04 -0800 Created attachment 75948 exclude Symbian from trying to compile POSIX memory management code 318970 2 75954 s.mathur 2010-12-08 13:17:58 -0800 Created attachment 75954 no POSIXy love for Symbian 319479 3 75954 laszlo.gombos 2010-12-09 08:37:52 -0800 Comment on attachment 75954 no POSIXy love for Symbian View in context: https://bugs.webkit.org/attachment.cgi?id=75954&action=review > JavaScriptCore/ChangeLog:5 > + Build fix for Symbian: don't compile POSIX memory management implementation We usually have a [Qt] prefix in the title for Qt-only changes. > JavaScriptCore/wtf/wtf.pri:46 > +unix!symbian: SOURCES += wtf/OSAllocatorPosix.cpp Don't we need a ":" to make it "unix:!symbian" ? 319483 4 s.mathur 2010-12-09 08:45:40 -0800 The existing syntax in the patch works OK, for example the following snippet prints "Hello Symbian" only without any warnings. I will fix the Changelog entry in a new patch. ## test.pro ## unix!symbian:message("Hello Unix") symbian:message("Hello Symbian") 320145 5 76194 s.mathur 2010-12-10 07:26:47 -0800 Created attachment 76194 updated patch with Changelog corrected. 320147 6 76196 s.mathur 2010-12-10 07:32:23 -0800 Created attachment 76196 Correct syntax and correct changelog (I need more sleep and/or coffee) 320567 7 76196 eric 2010-12-10 20:58:51 -0800 Comment on attachment 76196 Correct syntax and correct changelog Looks sane to me. 320613 8 76196 webkit.review.bot 2010-12-10 23:14:47 -0800 Comment on attachment 76196 Correct syntax and correct changelog Clearing flags on attachment: 76196 Committed r73842: <http://trac.webkit.org/changeset/73842> 320614 9 webkit.review.bot 2010-12-10 23:14:53 -0800 All reviewed patches have been landed. Closing bug. 75948 2010-12-08 12:51:04 -0800 2010-12-08 13:17:58 -0800 exclude Symbian from trying to compile POSIX memory management code buildfix_symbian.patch text/plain 453 s.mathur ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJpIGIvSmF2YVNjcmlwdENvcmUv d3RmL3d0Zi5wcmkKaW5kZXggNmE3YWM0MS4uOWNkNmZmNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUvd3RmL3d0Zi5wcmkKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkKQEAgLTQz LDYgKzQzLDYgQEAgY29udGFpbnMoREVGSU5FUywgVVNFX0dTVFJFQU1FUj0xKSB7CiAgICAgU09V UkNFUyArPSB3dGYvVENTeXN0ZW1BbGxvYy5jcHAKIH0KIAotdW5peDogU09VUkNFUyArPSB3dGYv T1NBbGxvY2F0b3JQb3NpeC5jcHAKK3VuaXghc3ltYmlhbjogU09VUkNFUyArPSB3dGYvT1NBbGxv Y2F0b3JQb3NpeC5jcHAKIHN5bWJpYW46IFNPVVJDRVMgKz0gd3RmL09TQWxsb2NhdG9yU3ltYmlh bi5jcHAKIHdpbip8d2luY2UqOiBTT1VSQ0VTICs9IHd0Zi9PU0FsbG9jYXRvcldpbi5jcHAK 75954 2010-12-08 13:17:58 -0800 2010-12-10 07:26:47 -0800 no POSIXy love for Symbian buildfix_symbianv2.patch text/plain 990 s.mathur ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA4M2NjYTRmLi43MDQ1ZDQ4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTAtMTItMDggIFNpZGRoYXJ0aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWlsZCBmaXggZm9yIFN5bWJpYW46IGRvbid0IGNvbXBpbGUgUE9TSVggbWVtb3J5IG1hbmFnZW1l bnQgaW1wbGVtZW50YXRpb24gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MDcwNworCisgICAgICAgICogd3RmL3d0Zi5wcmk6CisKIDIwMTAtMTItMDcg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBm aXggZm9sbG93IHVwIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi93 dGYucHJpIGIvSmF2YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkKaW5kZXggNmE3YWM0MS4uOWNkNmZm NSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkKKysrIGIvSmF2YVNjcmlw dENvcmUvd3RmL3d0Zi5wcmkKQEAgLTQzLDYgKzQzLDYgQEAgY29udGFpbnMoREVGSU5FUywgVVNF X0dTVFJFQU1FUj0xKSB7CiAgICAgU09VUkNFUyArPSB3dGYvVENTeXN0ZW1BbGxvYy5jcHAKIH0K IAotdW5peDogU09VUkNFUyArPSB3dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAKK3VuaXghc3ltYmlh bjogU09VUkNFUyArPSB3dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAKIHN5bWJpYW46IFNPVVJDRVMg Kz0gd3RmL09TQWxsb2NhdG9yU3ltYmlhbi5jcHAKIHdpbip8d2luY2UqOiBTT1VSQ0VTICs9IHd0 Zi9PU0FsbG9jYXRvcldpbi5jcHAK 76194 2010-12-10 07:26:47 -0800 2010-12-10 07:28:12 -0800 updated patch with Changelog corrected. 50707_v2.patch text/plain 1022 s.mathur ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZw0KaW5kZXggODNjY2E0Zi4uNzA0NWQ0OCAxMDA2NDQNCi0tLSBhL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZw0KKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nDQpAQCAtMSwzICsx LDEyIEBADQorMjAxMC0xMi0wOCAgU2lkZGhhcnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQor ICAgICAgICBbUXRdIEJ1aWxkIGZpeCBmb3IgU3ltYmlhbjogZG9uJ3QgY29tcGlsZSBQT1NJWCBt ZW1vcnkgbWFuYWdlbWVudCBpbXBsZW1lbnRhdGlvbiANCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDcwNw0KKw0KKyAgICAgICAgKiB3dGYvd3RmLnBy aToNCisNCiAyMDEwLTEyLTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ DQogDQogICAgICAgICBCdWlsZCBmaXggZm9sbG93IHVwIGJ1aWxkIGZpeC4NCmRpZmYgLS1naXQg YS9KYXZhU2NyaXB0Q29yZS93dGYvd3RmLnByaSBiL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJp DQppbmRleCA2YTdhYzQxLi45Y2Q2ZmY1IDEwMDY0NA0KLS0tIGEvSmF2YVNjcmlwdENvcmUvd3Rm L3d0Zi5wcmkNCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJpDQpAQCAtNDMsNiArNDMs NiBAQCBjb250YWlucyhERUZJTkVTLCBVU0VfR1NUUkVBTUVSPTEpIHsNCiAgICAgU09VUkNFUyAr PSB3dGYvVENTeXN0ZW1BbGxvYy5jcHANCiB9DQogDQotdW5peDogU09VUkNFUyArPSB3dGYvT1NB bGxvY2F0b3JQb3NpeC5jcHANCit1bml4IXN5bWJpYW46IFNPVVJDRVMgKz0gd3RmL09TQWxsb2Nh dG9yUG9zaXguY3BwDQogc3ltYmlhbjogU09VUkNFUyArPSB3dGYvT1NBbGxvY2F0b3JTeW1iaWFu LmNwcA0KIHdpbip8d2luY2UqOiBTT1VSQ0VTICs9IHd0Zi9PU0FsbG9jYXRvcldpbi5jcHA= 76196 2010-12-10 07:32:23 -0800 2010-12-10 23:14:47 -0800 Correct syntax and correct changelog 50707_v3.patch text/plain 1023 s.mathur ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZw0KaW5kZXggODNjY2E0Zi4uNzA0NWQ0OCAxMDA2NDQNCi0tLSBhL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZw0KKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nDQpAQCAtMSwzICsx LDEyIEBADQorMjAxMC0xMi0wOCAgU2lkZGhhcnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQor ICAgICAgICBbUXRdIEJ1aWxkIGZpeCBmb3IgU3ltYmlhbjogZG9uJ3QgY29tcGlsZSBQT1NJWCBt ZW1vcnkgbWFuYWdlbWVudCBpbXBsZW1lbnRhdGlvbiANCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDcwNw0KKw0KKyAgICAgICAgKiB3dGYvd3RmLnBy aToNCisNCiAyMDEwLTEyLTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ DQogDQogICAgICAgICBCdWlsZCBmaXggZm9sbG93IHVwIGJ1aWxkIGZpeC4NCmRpZmYgLS1naXQg YS9KYXZhU2NyaXB0Q29yZS93dGYvd3RmLnByaSBiL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJp DQppbmRleCA2YTdhYzQxLi45Y2Q2ZmY1IDEwMDY0NA0KLS0tIGEvSmF2YVNjcmlwdENvcmUvd3Rm L3d0Zi5wcmkNCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJpDQpAQCAtNDMsNiArNDMs NiBAQCBjb250YWlucyhERUZJTkVTLCBVU0VfR1NUUkVBTUVSPTEpIHsNCiAgICAgU09VUkNFUyAr PSB3dGYvVENTeXN0ZW1BbGxvYy5jcHANCiB9DQogDQotdW5peDogU09VUkNFUyArPSB3dGYvT1NB bGxvY2F0b3JQb3NpeC5jcHANCit1bml4OiFzeW1iaWFuOiBTT1VSQ0VTICs9IHd0Zi9PU0FsbG9j YXRvclBvc2l4LmNwcA0KIHN5bWJpYW46IFNPVVJDRVMgKz0gd3RmL09TQWxsb2NhdG9yU3ltYmlh bi5jcHANCiB3aW4qfHdpbmNlKjogU09VUkNFUyArPSB3dGYvT1NBbGxvY2F0b3JXaW4uY3Bw