50681 2010-12-08 04:53:14 -0800 [GTK] Add new-run-webkit-tests support to gtk 2010-12-12 03:47:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 50635 1 alex webkit-unassigned commit-queue eric mrobinson pnormand webkit.review.bot xan.lopez oldest_to_newest 318733 0 alex 2010-12-08 04:53:14 -0800 Currently it does not run, we have to add some of the functions pointing to the resources to run the script. 318734 1 75892 alex 2010-12-08 04:57:58 -0800 Created attachment 75892 Proposed patch I can run the tests with this patch, if someone could check fedora would be helpful. 320773 2 75892 eric 2010-12-12 02:19:04 -0800 Comment on attachment 75892 Proposed patch LGTM. 320815 3 webkit.review.bot 2010-12-12 03:44:28 -0800 The commit-queue encountered the following flaky tests while processing attachment 75892: inspector/styles-new-API.html bug 50889 (authors: apavlov@chromium.org and pfeldman@chromium.org) The commit-queue is continuing to process your patch. 320816 4 75892 webkit.review.bot 2010-12-12 03:46:16 -0800 Comment on attachment 75892 Proposed patch Clearing flags on attachment: 75892 Committed r73873: <http://trac.webkit.org/changeset/73873> 320817 5 webkit.review.bot 2010-12-12 03:46:22 -0800 All reviewed patches have been landed. Closing bug. 320818 6 xan.lopez 2010-12-12 03:47:52 -0800 (In reply to comment #1) > Created an attachment (id=75892) [details] > Proposed patch > > I can run the tests with this patch, if someone could check fedora would be helpful. For the record, this was tested on Fedora before landing :) 75892 2010-12-08 04:57:58 -0800 2010-12-12 03:46:16 -0800 Proposed patch new_tests.patch text/plain 2149 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5Y2FiYzA4Li45Y2ZkMzhkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTIt MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRkIG5ldy1ydW4td2Vi a2l0LXRlc3RzIHN1cHBvcnQgdG8gZ3RrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MDY4MQorCisgICAgICAgIEFkZGluZyB0aGUgYmFzaWMgc3VwcG9y dCB0byBydW4gdGhlIG5ldy1ydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHk6CisKIDIwMTAtMTItMDcgIFRvbnkgQ2hh bmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFp LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9ndGsucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2d0ay5weQppbmRleCBjNjA5MDllLi5hMThmZGZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQorKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQpAQCAtMzAsNiAr MzAsNyBAQAogCiBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9zCitpbXBvcnQgc2lnbmFsCiAKIGZy b20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQud2Via2l0IGltcG9ydCBXZWJLaXRQb3J0CiAK QEAgLTgxLDMgKzgyLDM1IEBAIGNsYXNzIEd0a1BvcnQoV2ViS2l0UG9ydCk6CiAgICAgICAgICAg ICAgICAgIyBmaWxlKSwgc28gaWYga2lsbCBmYWlscyBvbiB0aGUgZ2l2ZW4gUElELCBqdXN0IHRy eSB0bwogICAgICAgICAgICAgICAgICMgJ2tpbGxhbGwnIHdlYiBzZXJ2ZXJzLgogICAgICAgICAg ICAgICAgIHNlbGYuX3NodXRfZG93bl9odHRwX3NlcnZlcihOb25lKQorCisgICAgZGVmIF9wYXRo X3RvX2RyaXZlcihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYuX2J1aWxkX3BhdGgoJ1Byb2dy YW1zJywgJ0R1bXBSZW5kZXJUcmVlJykKKworICAgIGRlZiBjaGVja19idWlsZChzZWxmLCBuZWVk c19odHRwKToKKyAgICAgICAgaWYgbm90IHNlbGYuX2NoZWNrX2RyaXZlcigpOgorICAgICAgICAg ICAgcmV0dXJuIEZhbHNlCisgICAgICAgIHJldHVybiBUcnVlCisKKyAgICBkZWYgX3BhdGhfdG9f YXBhY2hlKHNlbGYpOgorICAgICAgICBpZiBzZWxmLl9pc19yZWRoYXRfYmFzZWQoKToKKyAgICAg ICAgICAgIHJldHVybiAnL3Vzci9zYmluL2h0dHBkJworICAgICAgICBlbHNlOgorICAgICAgICAg ICAgcmV0dXJuICcvdXNyL3NiaW4vYXBhY2hlMicKKworICAgIGRlZiBfcGF0aF90b19hcGFjaGVf Y29uZmlnX2ZpbGUoc2VsZik6CisgICAgICAgIGlmIHNlbGYuX2lzX3JlZGhhdF9iYXNlZCgpOgor ICAgICAgICAgICAgY29uZmlnX25hbWUgPSAnZmVkb3JhLWh0dHBkLmNvbmYnCisgICAgICAgIGVs c2U6CisgICAgICAgICAgICBjb25maWdfbmFtZSA9ICdhcGFjaGUyLWRlYmlhbi1odHRwZC5jb25m JworCisgICAgICAgIHJldHVybiBvcy5wYXRoLmpvaW4oc2VsZi5sYXlvdXRfdGVzdHNfZGlyKCks ICdodHRwJywgJ2NvbmYnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmZpZ19uYW1l KQorCisgICAgZGVmIF9wYXRoX3RvX3dkaWZmKHNlbGYpOgorICAgICAgICBpZiBzZWxmLl9pc19y ZWRoYXRfYmFzZWQoKToKKyAgICAgICAgICAgIHJldHVybiAnL3Vzci9iaW4vZHdkaWZmJworICAg ICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuICcvdXNyL2Jpbi93ZGlmZicKKworICAgIGRl ZiBfaXNfcmVkaGF0X2Jhc2VkKHNlbGYpOgorICAgICAgICByZXR1cm4gb3MucGF0aC5leGlzdHMo b3MucGF0aC5qb2luKCcvZXRjJywgJ3JlZGhhdC1yZWxlYXNlJykpCg==