50668 2010-12-07 22:50:50 -0800 Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp 2010-12-12 07:59:53 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 50365 50619 0 koansin.tan webkit-unassigned abarth ap eric mitz webkit.review.bot oldest_to_newest 318660 0 koansin.tan 2010-12-07 22:50:50 -0800 Bopomofo, which mainly used in Taiwan for educational purposes, is used to note the pronunciation of Han glyphs. It should be considered part of CJK Ideographs 318665 1 75875 koansin.tan 2010-12-07 23:04:27 -0800 Created attachment 75875 let Bopomofo, Bopomofo Extended, and tone marks be part of CJK 319013 2 ap 2010-12-08 14:03:37 -0800 Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made. 319153 3 koansin.tan 2010-12-08 17:18:41 -0800 (In reply to comment #2) > Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made. Yes, pretty observable when you got certain "broken" fonts. I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1]. I cannot find redistributable fonts which have the same problem yet. [1] http://www.microsoft.com/typography/fonts/font.aspx?FMID=838 319160 4 75992 koansin.tan 2010-12-08 17:36:51 -0800 Created attachment 75992 a test page to show this bug To see this page properly, you need 'resources/kaiu.ttf', which is not redistributable. However, it came with every Windows system :-) 319163 5 75994 koansin.tan 2010-12-08 17:44:30 -0800 Created attachment 75994 a snapshot picture to show what's wrong those Bopomofo glyphs in red circles should be rotated 90 degrees counterclockwise. 319205 6 ap 2010-12-08 19:13:23 -0800 > I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1]. I cannot find redistributable fonts which have the same problem yet. That's a a good explanation - it should go into ChangeLog, as the patch won't successfully land with OOPS. + // 0x2C7 Caron, Mandrin Chinese 3rd Tone Typo: should be Mandarin. Note that I do not intend to do final review on this patch - perhaps Dan (already CC'ed) would like to take a look. 319230 7 76007 koansin.tan 2010-12-08 20:04:38 -0800 Created attachment 76007 Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK fix typo and add description of test case as suggested by Alexey 319994 8 76007 eric 2010-12-10 00:11:29 -0800 Comment on attachment 76007 Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK OK. 320052 9 76007 webkit.review.bot 2010-12-10 02:37:04 -0800 Comment on attachment 76007 Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK Clearing flags on attachment: 76007 Committed r73706: <http://trac.webkit.org/changeset/73706> 320053 10 webkit.review.bot 2010-12-10 02:37:09 -0800 All reviewed patches have been landed. Closing bug. 320282 11 webkit.review.bot 2010-12-10 11:45:54 -0800 http://trac.webkit.org/changeset/73706 might have broken GTK Linux 32-bit Debug 75875 2010-12-07 23:04:27 -0800 2010-12-08 20:04:38 -0800 let Bopomofo, Bopomofo Extended, and tone marks be part of CJK bopomofo.diff2 text/plain 1799 koansin.tan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzQ5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMDcgIEtvYW4tU2luIFRhbiAgPGtvYW5zaW4udGFuQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCb3BvbW9mbyBzaG91bGQgYmUgcGFydCBvZiBDSksgSWRlb2dyYXBocyBpbiBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MDY2OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGb250Ojppc0NKS0lkZW9ncmFwaCk6CisKIDIwMTAtMTItMDcgIEFudG9uIE11aGluICA8YW50 b25tQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOYXRlIENoYXBpbi4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAkocmV2aXNpb24gNzM0OTEpCisrKyBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzgsNiAr MzM4LDEzIEBAIEZvbnQ6OkNvZGVQYXRoIEZvbnQ6OmNvZGVQYXRoKGNvbnN0IFRleHQKIAogYm9v bCBGb250Ojppc0NKS0lkZW9ncmFwaChVQ2hhcjMyIGMpCiB7CisgICAgLy8gMHgyQzcgQ2Fyb24s IE1hbmRyaW4gQ2hpbmVzZSAzcmQgVG9uZQorICAgIC8vIDB4MkNBIE1vZGlmaWVyIExldHRlciBB Y3V0ZSBBY2NlbnQsIE1hbmRhcmluIENoaW5lc2UgMm5kIFRvbmUKKyAgICAvLyAweDJDQiBNb2Rp ZmllciBMZXR0ZXIgR3JhdmUgQWNjZXNzLCBNYW5kYXJpbiBDaGluZXNlIDR0aCBUb25lIAorICAg IC8vIDB4MkQ5IERvdCBBYm92ZSwgTWFuZGFyaW4gQ2hpbmVzZSA1dGggVG9uZSAKKyAgICBpZiAo KGMgPT0gMHgyQzcpIHx8IChjID09IDB4MkNBKSB8fCAoYyA9PSAweDJDQikgfHwgKGMgPT0gMHgy RDkpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIC8vIFRoZSBiYXNpYyBDSksgVW5pZmll ZCBJZGVvZ3JhcGhzIGJsb2NrLgogICAgIGlmIChjID49IDB4NEUwMCAmJiBjIDw9IDB4OUZGRikK ICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0zNjEsNyArMzY4LDE1IEBAIGJvb2wgRm9udDo6aXND SktJZGVvZ3JhcGgoVUNoYXIzMiBjKQogICAgIC8vIENKSyBTeW1ib2xzIGFuZCBQdW5jdHVhdGlv bi4KICAgICBpZiAoYyA+PSAweDMwMDAgJiYgYyA8PSAweDMwM0YpCiAgICAgICAgIHJldHVybiB0 cnVlOworICAgCisgICAgLy8gQm9wb21vZm8KKyAgICBpZiAoYyA+PSAweDMxMDAgJiYgYyA8PSAw eDMxMkYpCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIAorICAgIC8vIEJvcG9tb2ZvIEV4dGVu ZGVkCisgICAgaWYgKGMgPj0gMHgzMUEwICYmIGMgPD0gMHgzMUJGKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKyAKICAgICAvLyBDSksgU3Ryb2tlcy4KICAgICBpZiAoYyA+PSAweDMxQzAgJiYgYyA8 PSAweDMxRUYpCiAgICAgICAgIHJldHVybiB0cnVlOwo= 75992 2010-12-08 17:36:51 -0800 2010-12-08 17:36:51 -0800 a test page to show this bug url.txt text/plain 69 koansin.tan aHR0cDovL2ZyZWVic2QuY3NpZS5uY3R1LmVkdS50dy9+ZnJlZWRvbS9icm9rZW4taWRlb2dyYXBo aWMtZm9udC5odG1s 75994 2010-12-08 17:44:30 -0800 2010-12-08 17:44:30 -0800 a snapshot picture to show what's wrong url.txt text/plain 60 koansin.tan aHR0cDovL2ZyZWVic2QuY3NpZS5uY3R1LmVkdS50dy9+ZnJlZWRvbS9icm9rZW4tYm9wb21vZm8u cG5n 76007 2010-12-08 20:04:38 -0800 2010-12-10 02:37:04 -0800 Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK bopomofo.diff2 text/plain 2027 koansin.tan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzU4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMDggIEtvYW4tU2luIFRhbiAgPGtvYW5zaW4udGFuQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgorCisgICAgICAg IEJvcG9tb2ZvIHNob3VsZCBiZSBwYXJ0IG9mIENKSyBJZGVvZ3JhcGhzIGluIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUwNjY4CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBOb3RlIHRoYXQs IGFzIHNhaWQgaW4gdGhlIGJ1ZyByZXBvcnQgZGlzY3Vzc2lvbiwKKyAgICAgICAgSSBkaWQgaGF2 ZSBhIHRlc3QgY2FzZSBmb3IgdGhlIGJ1Zy4gSG93ZXZlciwgdG8gc2hvdyB0aGUgdGVzdCAKKyAg ICAgICAgY2FzZSB5b3UgbmVlZCBzb21lICJicm9rZW4iIE1pY3Jvc29mdCBjb3B5cmlnaHRlZCBm b250cywgc3VjaAorICAgICAgICBhcyBERkthaS1TQi4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0ZvbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6aXNDSktJZGVvZ3JhcGgp OgorCiAyMDEwLTEyLTA4ICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xs YWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCShyZXZpc2lvbiA3MzU4OCkKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzOCw2ICsz MzgsMTMgQEAgRm9udDo6Q29kZVBhdGggRm9udDo6Y29kZVBhdGgoY29uc3QgVGV4dAogCiBib29s IEZvbnQ6OmlzQ0pLSWRlb2dyYXBoKFVDaGFyMzIgYykKIHsKKyAgICAvLyAweDJDNyBDYXJvbiwg TWFuZGFyaW4gQ2hpbmVzZSAzcmQgVG9uZQorICAgIC8vIDB4MkNBIE1vZGlmaWVyIExldHRlciBB Y3V0ZSBBY2NlbnQsIE1hbmRhcmluIENoaW5lc2UgMm5kIFRvbmUKKyAgICAvLyAweDJDQiBNb2Rp ZmllciBMZXR0ZXIgR3JhdmUgQWNjZXNzLCBNYW5kYXJpbiBDaGluZXNlIDR0aCBUb25lIAorICAg IC8vIDB4MkQ5IERvdCBBYm92ZSwgTWFuZGFyaW4gQ2hpbmVzZSA1dGggVG9uZSAKKyAgICBpZiAo KGMgPT0gMHgyQzcpIHx8IChjID09IDB4MkNBKSB8fCAoYyA9PSAweDJDQikgfHwgKGMgPT0gMHgy RDkpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIC8vIFRoZSBiYXNpYyBDSksgVW5pZmll ZCBJZGVvZ3JhcGhzIGJsb2NrLgogICAgIGlmIChjID49IDB4NEUwMCAmJiBjIDw9IDB4OUZGRikK ICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0zNjEsNyArMzY4LDE1IEBAIGJvb2wgRm9udDo6aXND SktJZGVvZ3JhcGgoVUNoYXIzMiBjKQogICAgIC8vIENKSyBTeW1ib2xzIGFuZCBQdW5jdHVhdGlv bi4KICAgICBpZiAoYyA+PSAweDMwMDAgJiYgYyA8PSAweDMwM0YpCiAgICAgICAgIHJldHVybiB0 cnVlOworICAgCisgICAgLy8gQm9wb21vZm8KKyAgICBpZiAoYyA+PSAweDMxMDAgJiYgYyA8PSAw eDMxMkYpCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIAorICAgIC8vIEJvcG9tb2ZvIEV4dGVu ZGVkCisgICAgaWYgKGMgPj0gMHgzMUEwICYmIGMgPD0gMHgzMUJGKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKyAKICAgICAvLyBDSksgU3Ryb2tlcy4KICAgICBpZiAoYyA+PSAweDMxQzAgJiYgYyA8 PSAweDMxRUYpCiAgICAgICAgIHJldHVybiB0cnVlOwo=