<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>50562</bug_id>
          
          <creation_ts>2010-12-06 04:49:22 -0800</creation_ts>
          <short_desc>Enable client-based geolocation in Chromium</short_desc>
          <delta_ts>2010-12-16 15:38:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>45752</dependson>
    
    <dependson>50920</dependson>
          <blocked>50921</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="John Knottenbelt">jknotten</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>jorlow</cc>
    
    <cc>steveblock</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>317561</commentid>
    <comment_count>0</comment_count>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2010-12-06 04:49:22 -0800</bug_when>
    <thetext>Set the CLIENT_BASED_GEOLOCATION flag in Chromium.
Enable test fast/dom/Geolocation/delayed-permission-timeout.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321150</commentid>
    <comment_count>1</comment_count>
      <attachid>76391</attachid>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2010-12-13 09:21:27 -0800</bug_when>
    <thetext>Created attachment 76391
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321164</commentid>
    <comment_count>2</comment_count>
    <who name="John Knottenbelt">jknotten</who>
    <bug_when>2010-12-13 09:40:45 -0800</bug_when>
    <thetext>Enable CLIENT_BASED_GEOLOCATION in the WebKit Chromium smoke tests in preparation for enabling client-based geolocation support in Chromium itself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323082</commentid>
    <comment_count>3</comment_count>
      <attachid>76391</attachid>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2010-12-16 02:09:47 -0800</bug_when>
    <thetext>Comment on attachment 76391
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323127</commentid>
    <comment_count>4</comment_count>
      <attachid>76391</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-16 05:38:38 -0800</bug_when>
    <thetext>Comment on attachment 76391
Patch

Rejecting attachment 76391 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;apply-attachment&apos;, &apos;--non-interactive&apos;, 76391]&quot; exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  &lt;yurys@chromium.org&gt;

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2

Full output: http://queues.webkit.org/results/7080055</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323157</commentid>
    <comment_count>5</comment_count>
      <attachid>76391</attachid>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2010-12-16 07:05:45 -0800</bug_when>
    <thetext>Comment on attachment 76391
Patch

Clearing flags on attachment: 76391

Committed r74189: &lt;http://trac.webkit.org/changeset/74189&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323158</commentid>
    <comment_count>6</comment_count>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2010-12-16 07:05:54 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323433</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-16 14:35:15 -0800</bug_when>
    <thetext>Sorry.  The git repo on one of the commit-bots got corrupted.  I&apos;m attempting to fix it now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323434</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-16 14:35:51 -0800</bug_when>
    <thetext>Sorry.  The git repo on one of the commit-queue bots got corrupted. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323470</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-16 15:38:50 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/74189 might have broken Leopard Intel Debug (Tests)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76391</attachid>
            <date>2010-12-13 09:21:27 -0800</date>
            <delta_ts>2010-12-16 07:05:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-50562-20101213172113.patch</filename>
            <type>text/plain</type>
            <size>1075</size>
            <attacher name="John Knottenbelt">jknotten</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nCmluZGV4IDllZWM2NGEwYWMyZTA0N2ZmOWE5ZjBlYzE1MzY1MmE0MTU2OTJjYmMu
LjkwNmRiOThkNDJjY2NjNDJjZmVmM2I4YjBkMzc0MDg0YWQzMjBjODYgMTAwNjQ0Ci0tLSBhL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEyIEBACisyMDEwLTEyLTEzICBKb2huIEtub3R0ZW5iZWx0ICA8amtub3R0ZW5A
Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEVuYWJsZSBjbGllbnQtYmFzZWQgZ2VvbG9jYXRpb24gaW4gQ2hyb21pdW0KKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNTYyCisKKyAgICAg
ICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDEwLTEyLTEzICBJbHlhIFRpa2hvbm92c2t5ICA8bG9p
c2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5
LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9XZWJLaXQvY2hy
b21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCAwM2U2Y2U0MDA3MTYwOTZkODY5ZmY3ZjAyNzgyNjEw
ZTNiMmI0MDNiLi4zNzJjYzVjNTA0MDA5ZjEyMzEzYjE3ZTk4YmMyODQ3YWEyNTc5M2NkIDEwMDY0
NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9XZWJLaXQvY2hyb21p
dW0vZmVhdHVyZXMuZ3lwaQpAQCAtNDUsNiArNDUsNyBAQAogICAgICAgICAnRU5BQkxFX0JMT0I9
MScsCiAgICAgICAgICdFTkFCTEVfQkxPQl9TTElDRT0xJywKICAgICAgICAgJ0VOQUJMRV9DSEFO
TkVMX01FU1NBR0lORz0xJywKKyAgICAgICAgJ0VOQUJMRV9DTElFTlRfQkFTRURfR0VPTE9DQVRJ
T049MScsCiAgICAgICAgICdFTkFCTEVfREFTSEJPQVJEX1NVUFBPUlQ9MCcsCiAgICAgICAgICdF
TkFCTEVfREFUQUJBU0U9MScsCiAgICAgICAgICdFTkFCTEVfREFUQUdSSUQ9MCcsCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>