50502 2010-12-03 16:18:13 -0800 REGRESSION (r72988): change to CSSImportRule breaks loading in iframes 2010-12-07 01:50:33 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P1 Blocker --- 1 alice.barraclough webkit-unassigned ap c.petersen87 hyatt mathewlavery mitz pfeldman simon.fraser oldest_to_newest 317165 0 75576 alice.barraclough 2010-12-03 16:18:13 -0800 Created attachment 75576 test case http://trac.webkit.org/changeset/72988 seems to have broken loading of iframes with pages that use @import somewhere in their style. Attached a test case steps to repro: open attached test case Expected behavior: the page with url http://www.nytimes.com/2010/11/07/education/07china-t.html?pagewanted=2&ref=education should load in the iframe and then shortly afterward the document is overtaken by http://www.nytimes.com/2010/11/07/education/07china-t.html. Not sure why, but anyway this is what happens in shipping safari. 5.0.3 TOT behavior: nothing loads in iframe. side note: in the test case is a commented-out line that uses http://www.rollingstone.com/politics/news/17390/119236?RS_show_page=1. This page doesn't use @import and behaves the same way in shipping as TOT. it also just loads in the iframe and doens't overtake the whole document in both cases. <rdar://problem/8728742> 317445 1 mitz 2010-12-05 21:33:00 -0800 See also bug 50532. 317862 2 alice.barraclough 2010-12-06 15:04:24 -0800 Pavel, had you had any chance to take a look? Is it reasonable to consider reverting r72988? The consequences of the bug fix seem more serious than the fixed symptoms. 317913 3 jamesr 2010-12-06 16:23:53 -0800 *** Bug 50532 has been marked as a duplicate of this bug. *** 317925 4 jamesr 2010-12-06 16:41:38 -0800 *** Bug 50526 has been marked as a duplicate of this bug. *** 318046 5 jamesr 2010-12-06 20:52:56 -0800 *** Bug 50613 has been marked as a duplicate of this bug. *** 318066 6 pfeldman 2010-12-06 22:55:29 -0800 (In reply to comment #2) > Pavel, had you had any chance to take a look? Is it reasonable to consider reverting r72988? The consequences of the bug fix seem more serious than the fixed symptoms. Sorry, was flying across the ocean. Reverting this asap. 318068 7 pfeldman 2010-12-06 23:02:03 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/CSSImportRule.cpp Committed r73427 318090 8 ap 2010-12-07 01:37:12 -0800 Eventually we should land a regression test for this problem. Pavel, would you be willing to make one? 318096 9 pfeldman 2010-12-07 01:50:33 -0800 (In reply to comment #8) > Eventually we should land a regression test for this problem. Pavel, would you be willing to make one? Absolutely. We will need to fix the http://trac.webkit.org/changeset/72988 and it'll require a test. 75576 2010-12-03 16:18:13 -0800 2010-12-03 16:18:13 -0800 test case nextPageLoadTest.html text/html 637 alice.barraclough PGh0bWw+CjxzY3JpcHQ+CmZ1bmN0aW9uIG5leHRQYWdlTG9hZENvbXBsZXRlKCkKewogICAgY29u c29sZS5sb2coIm5leHQgcGFnZSBsb2FkIGNvbXBsZXRlIik7Cn0KCmZ1bmN0aW9uIHN0YXJ0VGVz dCgpCnsKICAgIHZhciBuZXh0UGFnZUNvbnRhaW5lciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJuZXh0LXBhZ2UtY29udGFpbmVyIik7CiAgICBuZXh0UGFnZUNvbnRhaW5lci5hZGRFdmVudExp c3RlbmVyKCdsb2FkJywgbmV4dFBhZ2VMb2FkQ29tcGxldGUsIGZhbHNlKTsKICAgIG5leHRQYWdl Q29udGFpbmVyLnNyYyA9ICJodHRwOi8vd3d3Lm55dGltZXMuY29tLzIwMTAvMTEvMDcvZWR1Y2F0 aW9uLzA3Y2hpbmEtdC5odG1sP3BhZ2V3YW50ZWQ9MiZyZWY9ZWR1Y2F0aW9uIjsgLy8gdXNlcyBA aW1wb3J0Ci8vICAgIG5leHRQYWdlQ29udGFpbmVyLnNyYyA9ICJodHRwOi8vd3d3LnJvbGxpbmdz dG9uZS5jb20vcG9saXRpY3MvbmV3cy8xNzM5MC8xMTkyMzY/UlNfc2hvd19wYWdlPTEiOyAvLyBk b2Vzbid0IHVzZSBAaW1wb3J0Cn0KCjwvc2NyaXB0Pgo8Ym9keSBvbmxvYWQ9InN0YXJ0VGVzdCgp Ij4KSGVsbG8KPGlmcmFtZSBpZD0ibmV4dC1wYWdlLWNvbnRhaW5lciI+PC9pZnJhbWU+CjwvYm9k eT4KPC9odG1sPg==