50396 2010-12-02 09:40:55 -0800 REGRESSION(r72783): DOMActivate fires multiple times from input type=file 2010-12-03 09:56:18 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 49986 1 dglazkov webkit-unassigned darin oldest_to_newest 316216 0 dglazkov 2010-12-02 09:40:55 -0800 This results in a confused ChromeClient being called twice, and file upload dialog popping up multiple times in multiprocess port (Chromium and I bet WebKit2 as well). 316434 1 75417 dglazkov 2010-12-02 15:01:55 -0800 Created attachment 75417 Patch 316440 2 75417 darin 2010-12-02 15:12:47 -0800 Comment on attachment 75417 Patch Is there any way to make a regression test for this? Does this only affect <input type=file>? 316448 3 dglazkov 2010-12-02 15:19:44 -0800 (In reply to comment #2) > (From update of attachment 75417 [details]) > Is there any way to make a regression test for this? Does this only affect <input type=file>? I am writing a test, sorry :) Didn't mean to mark for review. 316840 4 75502 dglazkov 2010-12-03 09:23:33 -0800 Created attachment 75502 Patch 316841 5 dglazkov 2010-12-03 09:23:57 -0800 Now with a layout test :) 316848 6 75502 darin 2010-12-03 09:36:04 -0800 Comment on attachment 75502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75502&action=review > WebCore/dom/Node.cpp:1205 > + if (!node) > + return false; > + if (this == node) > + return true; > + for (ContainerNode* n = node->parentOrHostNode(); n; n = n->parentOrHostNode()) { > + if (n == this) > + return true; > + } > + return false; I like the way you wrote this, but I would have written it this way: for (Node* n = node; n; n = n->parentOrHostNode()) { if (n == this) return true; } return false; No need for the special handling of the node itself. 316849 7 dglazkov 2010-12-03 09:41:45 -0800 (In reply to comment #6) > (From update of attachment 75502 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75502&action=review > > > WebCore/dom/Node.cpp:1205 > > + if (!node) > > + return false; > > + if (this == node) > > + return true; > > + for (ContainerNode* n = node->parentOrHostNode(); n; n = n->parentOrHostNode()) { > > + if (n == this) > > + return true; > > + } > > + return false; > > I like the way you wrote this, but I would have written it this way: > > for (Node* n = node; n; n = n->parentOrHostNode()) { > if (n == this) > return true; > } > return false; > > No need for the special handling of the node itself. I like it. I'll change before landing. 316860 8 dglazkov 2010-12-03 09:56:18 -0800 Committed r73270: <http://trac.webkit.org/changeset/73270> 75417 2010-12-02 15:01:55 -0800 2010-12-03 09:23:28 -0800 Patch bug-50396-20101202150154.patch text/plain 4491 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2E4ZjlkZDkyZjY3ZGRiMTFkMDZjYWNmNTRjNTViNDdmYjJmZDQ0YS4uNmQ3OTAxOWYzNmIyN2Mw MDVhZWYyODkxYjE1MWQxYzdlNmUyYzRkMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMi0wMiAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjcyNzgzKTogRE9NQWN0 aXZhdGUgZmlyZXMgbXVsdGlwbGUgdGltZXMgZnJvbSBpbnB1dCB0eXBlPWZpbGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMzk2CisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBkb20vRXZlbnRDb250ZXh0LmNwcDog UmV2ZXJ0ZWQgY2hhbmdlcyBtYWRlIGluIHI3Mjc4My4KKyAgICAgICAgKiBkb20vRXZlbnRDb250 ZXh0Lmg6IERpdHRvLgorICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok5vZGU6OmNvbnRhaW5zSW5jbHVkaW5nU2hhZG93RE9NKTogQWRkZWQuCisgICAgICAgIChXZWJD b3JlOjpOb2RlOjpkaXNwYXRjaEdlbmVyaWNFdmVudCk6IFJldmVydGVkIGNoYW5nZXMgbWFkZSBp biByNzI3ODMuCisgICAgICAgICogZG9tL05vZGUuaDogQWRkZWQgZGVjbC4KKyAgICAgICAgKiBo dG1sL0hUTUxMYWJlbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTExhYmVsRWxl bWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6IFJldmVydGVkIGNoYW5nZXMgbWFkZSBpbiByNzI3 ODMuCisKIDIwMTAtMTItMDIgIFZpbmNlbnQgU2NoZWliICA8c2NoZWliQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2RvbS9FdmVudENvbnRleHQuY3BwIGIvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmNwcAppbmRl eCBlNWZlMGVlOGY2M2RmYzRlMWEwNzYxMDMwOTBjMzczMGRkNmQ4OTNiLi4yYTVjNTIxMGFhZWY2 Yjk0MWJiZGU1ZGUyOTVjYmEzMzlkMTQyZGY1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9FdmVu dENvbnRleHQuY3BwCisrKyBiL1dlYkNvcmUvZG9tL0V2ZW50Q29udGV4dC5jcHAKQEAgLTQxLDEz ICs0MSw2IEBAIEV2ZW50Q29udGV4dDo6RXZlbnRDb250ZXh0KFBhc3NSZWZQdHI8Tm9kZT4gbm9k ZSwgUGFzc1JlZlB0cjxFdmVudFRhcmdldD4gY3VycmVuCiB7CiB9CiAKLXZvaWQgRXZlbnRDb250 ZXh0OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkgY29uc3QKLXsKLSAgICBldmVu dC0+c2V0VGFyZ2V0KG1fdGFyZ2V0LmdldCgpKTsKLSAgICBldmVudC0+c2V0Q3VycmVudFRhcmdl dChtX2N1cnJlbnRUYXJnZXQuZ2V0KCkpOwotICAgIG1fbm9kZS0+ZGVmYXVsdEV2ZW50SGFuZGxl cihldmVudCk7Ci19Ci0KIHZvaWQgRXZlbnRDb250ZXh0OjpoYW5kbGVMb2NhbEV2ZW50cyhFdmVu dCogZXZlbnQpIGNvbnN0CiB7CiAgICAgZXZlbnQtPnNldFRhcmdldChtX3RhcmdldC5nZXQoKSk7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaCBiL1dlYkNvcmUvZG9tL0V2 ZW50Q29udGV4dC5oCmluZGV4IDgzMzFiNGRlMTg1NzQ4NDBiZDM3MzRlMTYyYTMzNzViYjFjOTE5 MzYuLjliYWI5ZDQxNjJjMzViNjJjZmQ3MDYyMzZlZTFmNTQ3YmRkMjk3NGIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvZG9tL0V2ZW50Q29udGV4dC5oCisrKyBiL1dlYkNvcmUvZG9tL0V2ZW50Q29udGV4 dC5oCkBAIC00Miw3ICs0Miw2IEBAIHB1YmxpYzoKIAogICAgIE5vZGUqIG5vZGUoKSBjb25zdDsK ICAgICBFdmVudFRhcmdldCogdGFyZ2V0KCkgY29uc3Q7Ci0gICAgdm9pZCBkZWZhdWx0RXZlbnRI YW5kbGVyKEV2ZW50KikgY29uc3Q7CiAgICAgdm9pZCBoYW5kbGVMb2NhbEV2ZW50cyhFdmVudCop IGNvbnN0OwogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9X ZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCAxNWE1YWIxNGQxMjM4ZTBmNzcxM2FmMWYwMTc3MzNk ODhlYmYxOTJhLi40NTk0MzAzN2FhZmUxNDc2NTM4Y2MzYmVmNmQ5MjVmZmIxOTQ5MDUxIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApA QCAtMTE5Miw2ICsxMTkyLDE5IEBAIGJvb2wgTm9kZTo6Y29udGFpbnMoY29uc3QgTm9kZSogbm9k ZSkgY29uc3QKICAgICByZXR1cm4gdGhpcyA9PSBub2RlIHx8IG5vZGUtPmlzRGVzY2VuZGFudE9m KHRoaXMpOwogfQogCitib29sIE5vZGU6OmNvbnRhaW5zSW5jbHVkaW5nU2hhZG93RE9NKE5vZGUq IG5vZGUpCit7CisgICAgaWYgKCFub2RlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYg KHRoaXMgPT0gbm9kZSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgZm9yIChDb250YWluZXJO b2RlKiBuID0gbm9kZS0+cGFyZW50T3JIb3N0Tm9kZSgpOyBuOyBuID0gbi0+cGFyZW50T3JIb3N0 Tm9kZSgpKSB7CisgICAgICAgIGlmIChuID09IHRoaXMpCisgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIE5vZGU6OmF0dGFjaCgpCiB7 CiAgICAgQVNTRVJUKCFhdHRhY2hlZCgpKTsKQEAgLTI2MzQsNyArMjY0Nyw3IEBAIGRvbmVEaXNw YXRjaGluZzoKICAgICAgICAgaWYgKGV2ZW50LT5idWJibGVzKCkpIHsKICAgICAgICAgICAgIHNp emVfdCBzaXplID0gYW5jZXN0b3JzLnNpemUoKTsKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkg PSAwOyBpIDwgc2l6ZTsgKytpKSB7Ci0gICAgICAgICAgICAgICAgYW5jZXN0b3JzW2ldLmRlZmF1 bHRFdmVudEhhbmRsZXIoZXZlbnQuZ2V0KCkpOworICAgICAgICAgICAgICAgIGFuY2VzdG9yc1tp XS5ub2RlKCktPmRlZmF1bHRFdmVudEhhbmRsZXIoZXZlbnQuZ2V0KCkpOwogICAgICAgICAgICAg ICAgIEFTU0VSVCghZXZlbnQtPmRlZmF1bHRQcmV2ZW50ZWQoKSk7CiAgICAgICAgICAgICAgICAg aWYgKGV2ZW50LT5kZWZhdWx0SGFuZGxlZCgpKQogICAgICAgICAgICAgICAgICAgICBnb3RvIGRv bmVXaXRoRGVmYXVsdDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL05vZGUuaCBiL1dlYkNvcmUv ZG9tL05vZGUuaAppbmRleCA5ZmNlYTFlMjkzZWVkOTIwNzZmZGFmOTM0NjA0YjcwOGJlYWM4NDUx Li45OTIxNzk1ZDdiYTZhMmU3M2ZlYWE4MTc0ODVlNDgwYzMwZDUyMDUxIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIvV2ViQ29yZS9kb20vTm9kZS5oCkBAIC0zODUsNiArMzg1 LDcgQEAgcHVibGljOgogICAgIHZvaWQgY2hlY2tTZXRQcmVmaXgoY29uc3QgQXRvbWljU3RyaW5n JiBwcmVmaXgsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICBib29sIGlzRGVzY2VuZGFudE9mKGNvbnN0 IE5vZGUqKSBjb25zdDsKICAgICBib29sIGNvbnRhaW5zKGNvbnN0IE5vZGUqKSBjb25zdDsKKyAg ICBib29sIGNvbnRhaW5zSW5jbHVkaW5nU2hhZG93RE9NKE5vZGUqKTsKIAogICAgIC8vIFRoaXMg bWV0aG9kIGlzIHVzZWQgdG8gZG8gc3RyaWN0IGVycm9yLWNoZWNraW5nIHdoZW4gYWRkaW5nIGNo aWxkcmVuIHZpYQogICAgIC8vIHRoZSBwdWJsaWMgRE9NIEFQSSAoZS5nLiwgYXBwZW5kQ2hpbGQo KSkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTExhYmVsRWxlbWVudC5jcHAgYi9XZWJD b3JlL2h0bWwvSFRNTExhYmVsRWxlbWVudC5jcHAKaW5kZXggMWU0NGUyYWQ3OTIwYTY2NmVmY2Yx ZTNhM2MxNjliYjA4YzQ0NjZlNy4uOTdhMGM2NTk4YTU0NWNkZWRhOWNhMWEwYmVjZjU0NGQ5NjAy MWExNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxMYWJlbEVsZW1lbnQuY3BwCisrKyBi L1dlYkNvcmUvaHRtbC9IVE1MTGFiZWxFbGVtZW50LmNwcApAQCAtMTE5LDcgKzExOSw3IEBAIHZv aWQgSFRNTExhYmVsRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZ0KQogCiAg ICAgICAgIC8vIElmIHdlIGNhbid0IGZpbmQgYSBjb250cm9sIG9yIGlmIHRoZSBjb250cm9sIHJl Y2VpdmVkIHRoZSBjbGljawogICAgICAgICAvLyBldmVudCwgdGhlbiB0aGVyZSdzIG5vIG5lZWQg Zm9yIHVzIHRvIGRvIGFueXRoaW5nLgotICAgICAgICBpZiAoIWVsZW1lbnQgfHwgKGV2dC0+dGFy Z2V0KCkgJiYgZWxlbWVudC0+Y29udGFpbnMoZXZ0LT50YXJnZXQoKS0+dG9Ob2RlKCkpKSkKKyAg ICAgICAgaWYgKCFlbGVtZW50IHx8IChldnQtPnRhcmdldCgpICYmIGVsZW1lbnQtPmNvbnRhaW5z SW5jbHVkaW5nU2hhZG93RE9NKGV2dC0+dGFyZ2V0KCktPnRvTm9kZSgpKSkpCiAgICAgICAgICAg ICByZXR1cm47CiAKICAgICAgICAgcHJvY2Vzc2luZ0NsaWNrID0gdHJ1ZTsK 75502 2010-12-03 09:23:33 -0800 2010-12-03 09:36:04 -0800 Patch bug-50396-20101203092331.patch text/plain 8278 dglazkov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4Y2RhZWMxZDE1ZGRhMmZkNjk3NzJjNjk5MGIwNDhiNTJlZTg3YzQ3Li44YzE5NmM2 MGExNDgyZjhlMGEzZDY5YjA5ZDQyMDZlMWU1OGZlN2JhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTItMDMgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9O KHI3Mjc4Myk6IERPTUFjdGl2YXRlIGZpcmVzIG11bHRpcGxlIHRpbWVzIGZyb20gaW5wdXQgdHlw ZT1maWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MDM5NgorCisgICAgICAgICogZmFzdC9ldmVudHMvc2hhZG93LWJvdW5kYXJ5LWNyb3NzaW5nLTIt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZXZlbnRzL3NoYWRvdy1ib3VuZGFyeS1jcm9z c2luZy0yLmh0bWw6CisKIDIwMTAtMTItMDIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHNraXAgZmFpbGluZyB0ZXN0LgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2hhZG93LWJvdW5kYXJ5LWNyb3NzaW5n LTItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2hhZG93LWJvdW5kYXJ5 LWNyb3NzaW5nLTItZXhwZWN0ZWQudHh0CmluZGV4IDNjNjkzNmNlZWY2MTk5MjE2ZjJhZTUyMjhi NGMzNmM2MjBjNzY3OTkuLmEyZjFlY2U5NDM0ZmMwZGE0ODg0ZGE1MTNjNTRmZjM2NTU1MzBlZGYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NoYWRvdy1ib3VuZGFyeS1jcm9z c2luZy0yLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zaGFkb3ct Ym91bmRhcnktY3Jvc3NpbmctMi1leHBlY3RlZC50eHQKQEAgLTMsNyArMyw4IEBAIFRlc3RzIHRv IGVuc3VyZSB0aGF0IHNoYWRvdyBET00gYm91bmRhcnkgaXMgbm90IGNyb3NzZWQgZHVyaW5nIGV2 ZW50IHByb3BhZ2F0aW9uCiBTZWUgYnVnIDQ2MDE1IGZvciBkZXRhaWxzLgogCiBNdXRhdGlvbiBl dmVudHMgc2hvdWxkIG5vdCBwcm9wYWdhdGUgb3V0IG9mIHRoZSBzaGFkb3cgRE9NOiBQQVNTCi1F dmVudHMgZm9yIGRlZmF1bHQgZXZlbnQgaGFuZGxlciBzaG91bGQgYWxzbyBiZSByZXRhcmdldGVk OiBQQVNTCitMYWJlbCBzaG91bGQgbG9vayBiZXlvbmQgc2hhZG93IGJvdW5kYXJ5IHRvIGRldGVj dCBpZiBpdCBlbmNsb3NlcyBpdHMgYXNzb2NpYXRlZCBlbGVtZW50OiBQQVNTCitFdmVudHMgZm9y IGRlZmF1bHQgZXZlbnQgaGFuZGxlciBzaG91bGQgbm90IGJlIHJldGFyZ2V0ZWQ6IFBBU1MKIE90 aGVyIGV2ZW50cyBzaG91bGQgYmUgcmV0YXJnZXRlZDogUEFTUwogQWZ0ZXIgZXZlbnQgZGlzcGF0 Y2gsIHRoZSBldmVudCBvYmplY3Qgc2hvdWxkIG5vdCByZXZlYWwgc2hhZG93IERPTTogUEFTUwog Rm9jdXNpbmcgc2FtZSBzaGFkb3cgRE9NIGVsZW1lbnQgcmVwZWF0ZWRseSBzaG91bGQgbm90IHRy aWdnZXIgbXVsdGlwbGUgZm9jdXMvYmx1ciBldmVudHM6IFBBU1MKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL3NoYWRvdy1ib3VuZGFyeS1jcm9zc2luZy0yLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9zaGFkb3ctYm91bmRhcnktY3Jvc3NpbmctMi5odG1sCmluZGV4 IDA3NTQ0OTNhNjllYWFhNTFkMDJmNGZmM2JlMzc0MzIyYmUzZmY2MTIuLjkxYjM2MmY1N2I4MWUx NTJmM2EwZTk2YzQxMjZiYjhkMGVkMjRiOGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NoYWRvdy1ib3VuZGFyeS1jcm9zc2luZy0yLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvc2hhZG93LWJvdW5kYXJ5LWNyb3NzaW5nLTIuaHRtbApAQCAtMjEsNiArMjEs MTcgQEAgZnVuY3Rpb24gY2xpY2tPbihlbGVtZW50KQogICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAo KTsKIH0KIAorZnVuY3Rpb24gY2xpY2tPbkxlZnRRdWFydGVyT2YoZWxlbWVudCkKK3sKKyAgICBp ZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICAgICAgcmV0dXJuOworCisgICAgdmFyIHggPSBl bGVtZW50Lm9mZnNldExlZnQgKyBlbGVtZW50Lm9mZnNldFdpZHRoIC8gNDsKKyAgICB2YXIgeSA9 IGVsZW1lbnQub2Zmc2V0VG9wICsgZWxlbWVudC5vZmZzZXRIZWlnaHQgLyAyOworICAgIGV2ZW50 U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwor ICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KIAogZnVuY3Rpb24gbGVhcEZvcndhcmQoKQog ewpAQCAtNDUsNyArNTYsNyBAQCB2YXIgdGVzdHMgPSB7CiAgICAgICAgIGxvZygnTXV0YXRpb24g ZXZlbnRzIHNob3VsZCBub3QgcHJvcGFnYXRlIG91dCBvZiB0aGUgc2hhZG93IERPTScsICFtdXRh dGlvbkV2ZW50RmlyZWQpOwogICAgICAgICB0ZXh0YXJlYS5wYXJlbnROb2RlLnJlbW92ZUNoaWxk KHRleHRhcmVhKTsKICAgICB9LAotICAgIGRlZmF1bHRFdmVudFJldGFyZ2V0aW5nOiBmdW5jdGlv bigpCisgICAgbGFiZWxTeW50aGV0aWNDbGljazogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAg dmFyIGNvdW50ID0gMDsKICAgICAgICAgdmFyIGxhYmVsID0gZG9jdW1lbnQuYm9keS5hcHBlbmRD aGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdsYWJlbCcpKTsKQEAgLTU4LDkgKzY5LDI0IEBA IHZhciB0ZXN0cyA9IHsKICAgICAgICAgICAgIGNvdW50Kys7CiAgICAgICAgIH0sIGZhbHNlKTsK ICAgICAgICAgY2xpY2tPbihzZWFyY2hJbnB1dCk7Ci0gICAgICAgIGxvZygiRXZlbnRzIGZvciBk ZWZhdWx0IGV2ZW50IGhhbmRsZXIgc2hvdWxkIGFsc28gYmUgcmV0YXJnZXRlZCIsIGNvdW50ID09 IDEpOworICAgICAgICBsb2coIkxhYmVsIHNob3VsZCBsb29rIGJleW9uZCBzaGFkb3cgYm91bmRh cnkgdG8gZGV0ZWN0IGlmIGl0IGVuY2xvc2VzIGl0cyBhc3NvY2lhdGVkIGVsZW1lbnQiLCBjb3Vu dCA9PSAxKTsKICAgICAgICAgbGFiZWwucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChsYWJlbCk7CiAg ICAgfSwKKyAgICBkZWZhdWx0RXZlbnRSZXRhcmdldGluZzogZnVuY3Rpb24oKQorICAgIHsKKyAg ICAgICAgdmFyIGNvdW50ID0gMDsKKyAgICAgICAgdmFyIGZpbGVJbnB1dCA9IGRvY3VtZW50LmJv ZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnaW5wdXQnKSk7CisgICAgICAg IGZpbGVJbnB1dC5zZXRBdHRyaWJ1dGUoJ3R5cGUnLCAnZmlsZScpOworICAgICAgICB2YXIgY291 bnRlciA9IGZ1bmN0aW9uKCkKKyAgICAgICAgeworICAgICAgICAgICAgY291bnQrKzsKKyAgICAg ICAgfQorICAgICAgICBkb2N1bWVudC5ib2R5LmFkZEV2ZW50TGlzdGVuZXIoJ0RPTUFjdGl2YXRl JywgY291bnRlciwgZmFsc2UpOworICAgICAgICBjbGlja09uTGVmdFF1YXJ0ZXJPZihmaWxlSW5w dXQpOworICAgICAgICBsb2coIkV2ZW50cyBmb3IgZGVmYXVsdCBldmVudCBoYW5kbGVyIHNob3Vs ZCBub3QgYmUgcmV0YXJnZXRlZCIsIGNvdW50ID09IDEpOworICAgICAgICBkb2N1bWVudC5ib2R5 LnJlbW92ZUV2ZW50TGlzdGVuZXIoJ0RPTUFjdGl2YXRlJywgY291bnRlciwgZmFsc2UpOworICAg ICAgICBmaWxlSW5wdXQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChmaWxlSW5wdXQpOworICAgIH0s CiAgICAgZXZlbnRJblByb2dyZXNzOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIgdGV4 dElucHV0ID0gZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCdpbnB1dCcpKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggM2E4ZjlkZDkyZjY3ZGRiMTFkMDZjYWNmNTRjNTViNDdmYjJmZDQ0YS4uODMx Zjc5OWRmNjg3OGMzNTdiYTNkODc0NDQyOTM3OTk3ODkwMzRmNyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAx MC0xMi0wMyAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjcy NzgzKTogRE9NQWN0aXZhdGUgZmlyZXMgbXVsdGlwbGUgdGltZXMgZnJvbSBpbnB1dCB0eXBlPWZp bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMzk2 CisKKyAgICAgICAgKiBkb20vRXZlbnRDb250ZXh0LmNwcDoKKyAgICAgICAgKiBkb20vRXZlbnRD b250ZXh0Lmg6CisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9k ZTo6Y29udGFpbnNJbmNsdWRpbmdTaGFkb3dET00pOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6 ZGlzcGF0Y2hHZW5lcmljRXZlbnQpOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisgICAgICAgICog aHRtbC9IVE1MTGFiZWxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMYWJlbEVs ZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDEwLTEyLTAyICBWaW5jZW50IFNjaGVp YiAgPHNjaGVpYkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlz aGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmNwcCBiL1dlYkNvcmUv ZG9tL0V2ZW50Q29udGV4dC5jcHAKaW5kZXggZTVmZTBlZThmNjNkZmM0ZTFhMDc2MTAzMDkwYzM3 MzBkZDZkODkzYi4uMmE1YzUyMTBhYWVmNmI5NDFiYmRlNWRlMjk1Y2JhMzM5ZDE0MmRmNSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmNwcAorKysgYi9XZWJDb3JlL2RvbS9F dmVudENvbnRleHQuY3BwCkBAIC00MSwxMyArNDEsNiBAQCBFdmVudENvbnRleHQ6OkV2ZW50Q29u dGV4dChQYXNzUmVmUHRyPE5vZGU+IG5vZGUsIFBhc3NSZWZQdHI8RXZlbnRUYXJnZXQ+IGN1cnJl bgogewogfQogCi12b2lkIEV2ZW50Q29udGV4dDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCog ZXZlbnQpIGNvbnN0Ci17Ci0gICAgZXZlbnQtPnNldFRhcmdldChtX3RhcmdldC5nZXQoKSk7Ci0g ICAgZXZlbnQtPnNldEN1cnJlbnRUYXJnZXQobV9jdXJyZW50VGFyZ2V0LmdldCgpKTsKLSAgICBt X25vZGUtPmRlZmF1bHRFdmVudEhhbmRsZXIoZXZlbnQpOwotfQotCiB2b2lkIEV2ZW50Q29udGV4 dDo6aGFuZGxlTG9jYWxFdmVudHMoRXZlbnQqIGV2ZW50KSBjb25zdAogewogICAgIGV2ZW50LT5z ZXRUYXJnZXQobV90YXJnZXQuZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRXZlbnRD b250ZXh0LmggYi9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaAppbmRleCA4MzMxYjRkZTE4NTc0 ODQwYmQzNzM0ZTE2MmEzMzc1YmIxYzkxOTM2Li45YmFiOWQ0MTYyYzM1YjYyY2ZkNzA2MjM2ZWUx ZjU0N2JkZDI5NzRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaAorKysg Yi9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaApAQCAtNDIsNyArNDIsNiBAQCBwdWJsaWM6CiAK ICAgICBOb2RlKiBub2RlKCkgY29uc3Q7CiAgICAgRXZlbnRUYXJnZXQqIHRhcmdldCgpIGNvbnN0 OwotICAgIHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCopIGNvbnN0OwogICAgIHZvaWQg aGFuZGxlTG9jYWxFdmVudHMoRXZlbnQqKSBjb25zdDsKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBh L1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggMTVhNWFi MTRkMTIzOGUwZjc3MTNhZjFmMDE3NzMzZDg4ZWJmMTkyYS4uNDU5NDMwMzdhYWZlMTQ3NjUzOGNj M2JlZjZkOTI1ZmZiMTk0OTA1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysr IGIvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTExOTIsNiArMTE5MiwxOSBAQCBib29sIE5vZGU6 OmNvbnRhaW5zKGNvbnN0IE5vZGUqIG5vZGUpIGNvbnN0CiAgICAgcmV0dXJuIHRoaXMgPT0gbm9k ZSB8fCBub2RlLT5pc0Rlc2NlbmRhbnRPZih0aGlzKTsKIH0KIAorYm9vbCBOb2RlOjpjb250YWlu c0luY2x1ZGluZ1NoYWRvd0RPTShOb2RlKiBub2RlKQoreworICAgIGlmICghbm9kZSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIGlmICh0aGlzID09IG5vZGUpCisgICAgICAgIHJldHVybiB0 cnVlOworICAgIGZvciAoQ29udGFpbmVyTm9kZSogbiA9IG5vZGUtPnBhcmVudE9ySG9zdE5vZGUo KTsgbjsgbiA9IG4tPnBhcmVudE9ySG9zdE5vZGUoKSkgeworICAgICAgICBpZiAobiA9PSB0aGlz KQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKK30K Kwogdm9pZCBOb2RlOjphdHRhY2goKQogewogICAgIEFTU0VSVCghYXR0YWNoZWQoKSk7CkBAIC0y NjM0LDcgKzI2NDcsNyBAQCBkb25lRGlzcGF0Y2hpbmc6CiAgICAgICAgIGlmIChldmVudC0+YnVi YmxlcygpKSB7CiAgICAgICAgICAgICBzaXplX3Qgc2l6ZSA9IGFuY2VzdG9ycy5zaXplKCk7CiAg ICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNpemU7ICsraSkgewotICAgICAgICAg ICAgICAgIGFuY2VzdG9yc1tpXS5kZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50LmdldCgpKTsKKyAg ICAgICAgICAgICAgICBhbmNlc3RvcnNbaV0ubm9kZSgpLT5kZWZhdWx0RXZlbnRIYW5kbGVyKGV2 ZW50LmdldCgpKTsKICAgICAgICAgICAgICAgICBBU1NFUlQoIWV2ZW50LT5kZWZhdWx0UHJldmVu dGVkKCkpOwogICAgICAgICAgICAgICAgIGlmIChldmVudC0+ZGVmYXVsdEhhbmRsZWQoKSkKICAg ICAgICAgICAgICAgICAgICAgZ290byBkb25lV2l0aERlZmF1bHQ7CmRpZmYgLS1naXQgYS9XZWJD b3JlL2RvbS9Ob2RlLmggYi9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggOWZjZWExZTI5M2VlZDky MDc2ZmRhZjkzNDYwNGI3MDhiZWFjODQ1MS4uOTkyMTc5NWQ3YmE2YTJlNzNmZWFhODE3NDg1ZTQ4 MGMzMGQ1MjA1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5oCisrKyBiL1dlYkNvcmUv ZG9tL05vZGUuaApAQCAtMzg1LDYgKzM4NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNoZWNrU2V0 UHJlZml4KGNvbnN0IEF0b21pY1N0cmluZyYgcHJlZml4LCBFeGNlcHRpb25Db2RlJik7CiAgICAg Ym9vbCBpc0Rlc2NlbmRhbnRPZihjb25zdCBOb2RlKikgY29uc3Q7CiAgICAgYm9vbCBjb250YWlu cyhjb25zdCBOb2RlKikgY29uc3Q7CisgICAgYm9vbCBjb250YWluc0luY2x1ZGluZ1NoYWRvd0RP TShOb2RlKik7CiAKICAgICAvLyBUaGlzIG1ldGhvZCBpcyB1c2VkIHRvIGRvIHN0cmljdCBlcnJv ci1jaGVja2luZyB3aGVuIGFkZGluZyBjaGlsZHJlbiB2aWEKICAgICAvLyB0aGUgcHVibGljIERP TSBBUEkgKGUuZy4sIGFwcGVuZENoaWxkKCkpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hU TUxMYWJlbEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxMYWJlbEVsZW1lbnQuY3BwCmlu ZGV4IDFlNDRlMmFkNzkyMGE2NjZlZmNmMWUzYTNjMTY5YmIwOGM0NDY2ZTcuLjk3YTBjNjU5OGE1 NDVjZGVkYTljYTFhMGJlY2Y1NDRkOTYwMjFhMTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9I VE1MTGFiZWxFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTExhYmVsRWxlbWVudC5j cHAKQEAgLTExOSw3ICsxMTksNyBAQCB2b2lkIEhUTUxMYWJlbEVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQqIGV2dCkKIAogICAgICAgICAvLyBJZiB3ZSBjYW4ndCBmaW5kIGEgY29u dHJvbCBvciBpZiB0aGUgY29udHJvbCByZWNlaXZlZCB0aGUgY2xpY2sKICAgICAgICAgLy8gZXZl bnQsIHRoZW4gdGhlcmUncyBubyBuZWVkIGZvciB1cyB0byBkbyBhbnl0aGluZy4KLSAgICAgICAg aWYgKCFlbGVtZW50IHx8IChldnQtPnRhcmdldCgpICYmIGVsZW1lbnQtPmNvbnRhaW5zKGV2dC0+ dGFyZ2V0KCktPnRvTm9kZSgpKSkpCisgICAgICAgIGlmICghZWxlbWVudCB8fCAoZXZ0LT50YXJn ZXQoKSAmJiBlbGVtZW50LT5jb250YWluc0luY2x1ZGluZ1NoYWRvd0RPTShldnQtPnRhcmdldCgp LT50b05vZGUoKSkpKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHByb2Nlc3NpbmdD bGljayA9IHRydWU7Cg==