50077 2010-11-25 06:56:13 -0800 Fix rendering of speech button when setting the attribute dynamically. 2010-11-30 07:33:39 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned jorlow tkent oldest_to_newest 313744 0 satish 2010-11-25 06:56:13 -0800 Setting the 'x-webkit-speech' attribute on an input field dynamically (via setAttribute or other means) was causing the speech/mic button to show up at the wrong position. This patch fixes that by explicitly reinitializing the rendering components when the attribute is changed at runtime. I have added this case to one of the existing pixel tests. This will cause the tests to fail in chromium and I'll submit new baseline images once the change propagates to the chromium canary bots. 313745 1 74873 satish 2010-11-25 06:58:42 -0800 Created attachment 74873 Patch 314335 2 satish 2010-11-29 03:30:14 -0800 Adding tkent@ as a reviewer as he took a look at this speech input UI layout code in the past. 314741 3 74873 tkent 2010-11-29 17:04:44 -0800 Comment on attachment 74873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74873&action=review > WebCore/rendering/RenderTextControlSingleLine.cpp:676 > + setChildrenInline(true); Is this needed? 314890 4 74873 satish 2010-11-30 00:24:43 -0800 Comment on attachment 74873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74873&action=review >> WebCore/rendering/RenderTextControlSingleLine.cpp:676 >> + setChildrenInline(true); > > Is this needed? Yes it was needed because the m_childrenInline flag of this render element gets set to false in layouts without speech. In this method we are recreating the child elements and setting this flag to its default value (set to true in constructor of RenderBlock.cpp) gets us the accurate layout. 314894 5 74873 tkent 2010-11-30 00:35:35 -0800 Comment on attachment 74873 Patch ok. Does this code work well when x-webkit-speech attribute is removed? 314915 6 satish 2010-11-30 02:37:27 -0800 (In reply to comment #5) > (From update of attachment 74873 [details]) > ok. Does this code work well when x-webkit-speech attribute is removed? Yes it works as expected, layout matches what was shown without this patch. 315004 7 tkent 2010-11-30 06:52:36 -0800 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 74873 [details] [details]) > > ok. Does this code work well when x-webkit-speech attribute is removed? > > Yes it works as expected, layout matches what was shown without this patch. We should have a test for a case of removeAttribute('x-webkit-speech'). 315010 8 74873 tkent 2010-11-30 06:53:54 -0800 Comment on attachment 74873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74873&action=review > LayoutTests/fast/speech/input-appearance-speechbutton.html:37 > +var inputWithAttribute = document.createElement('input'); > +inputWithAttribute.setAttribute('x-webkit-speech', 'x-webkit-speech'); > +document.body.appendChild(inputWithAttribute); This doesn't test the new code. We should call setAttribute() after document.body.appendChild(). 315028 9 75145 satish 2010-11-30 07:19:52 -0800 Created attachment 75145 Patch 315030 10 satish 2010-11-30 07:21:12 -0800 Uploaded new patch, with a fix to the setAttribute test case as suggested and an addition to test removeAttribute calls. As mentioned above this patch will cause the tests to fail in chromium and I'll submit new baseline images once the change propagates to the chromium canary bots. 315034 11 75145 tkent 2010-11-30 07:26:52 -0800 Comment on attachment 75145 Patch ok 315036 12 satish 2010-11-30 07:33:39 -0800 Committed r72915: <http://trac.webkit.org/changeset/72915> 74873 2010-11-25 06:58:42 -0800 2010-11-30 07:19:46 -0800 Patch bug-50077-20101125145840.patch text/plain 4710 satish ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZWMyZDA4MTc1MzA3MjM1M2U2M2Q0NGY5ZTBhZjIyZjIxZDhhOTYzLi40NjdmNGM5 ZWRiMmJlMzJlYzIzMTc2NDgzYjkzZDhmMjRiOWI4YTM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMjUgIFNhdGlzaCBTYW1wYXRoICA8c2F0aXNoQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcmVuZGVyaW5n IG9mIHNwZWVjaCBidXR0b24gd2hlbiBzZXR0aW5nIHRoZSBhdHRyaWJ1dGUgZHluYW1pY2FsbHku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDA3Nwor CisgICAgICAgICogZmFzdC9zcGVlY2gvaW5wdXQtYXBwZWFyYW5jZS1zcGVlY2hidXR0b24uaHRt bDoKKwogMjAxMC0xMS0yNSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRW5hYmxlIHRlc3RzIGluIGNocm9taXVtLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zcGVlY2gvaW5wdXQtYXBwZWFyYW5jZS1zcGVlY2hidXR0 b24uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc3BlZWNoL2lucHV0LWFwcGVhcmFuY2Utc3BlZWNo YnV0dG9uLmh0bWwKaW5kZXggN2FmMDVlNDNkZmY2MzZlZjY0MTQ1MjUzY2UyODU5ZTAyY2EyNTRl NC4uMDdjMWJlZGY4ZGYwOWIzZDE2NzM0MzQ0ODUwYmFjMWUxZTI3NjA0YSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9zcGVlY2gvaW5wdXQtYXBwZWFyYW5jZS1zcGVlY2hidXR0b24uaHRt bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NwZWVjaC9pbnB1dC1hcHBlYXJhbmNlLXNwZWVjaGJ1 dHRvbi5odG1sCkBAIC0zMCw2ICszMCwxMSBAQCBmb3IgKHZhciBpID0gMDsgaSA8IGNlbGxzLmxl bmd0aDsgKytpKSB7CiAgIGRpdi5pbm5lckhUTUwgPSBjZWxsc1tpXTsKICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3AnICsgKGkgKyAxKSkuYXBwZW5kQ2hpbGQoZGl2KTsKIH0KKworLy8gQWxz byBjaGVjayB0aGF0IHNldHRpbmcgdGhlIGF0dHJpYnV0ZSBmcm9tIHNjcmlwdCByZW5kZXJzIHNp bWlsYXJseS4KK3ZhciBpbnB1dFdpdGhBdHRyaWJ1dGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCdpbnB1dCcpOworaW5wdXRXaXRoQXR0cmlidXRlLnNldEF0dHJpYnV0ZSgneC13ZWJraXQtc3Bl ZWNoJywgJ3gtd2Via2l0LXNwZWVjaCcpOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChpbnB1 dFdpdGhBdHRyaWJ1dGUpOwogPC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgwMDcyMmQ2MzIw N2RjYzUzM2M3NTQyZjA3MDdlYTY4Y2I0N2Q5ZDMuLjVmNWE5YjAyYmJjMjc0YmViNmU5MjIyYWJl ZDdkYTU5ZTI3MmVjYzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMjUgIFNhdGlzaCBTYW1wYXRo ICA8c2F0aXNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggcmVuZGVyaW5nIG9mIHNwZWVjaCBidXR0b24gd2hlbiBzZXR0 aW5nIHRoZSBhdHRyaWJ1dGUgZHluYW1pY2FsbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDA3NworCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlTWFw cGVkQXR0cmlidXRlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5n bGVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZTo6c3BlZWNoQXR0cmlidXRlQ2hhbmdlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRl eHRDb250cm9sU2luZ2xlTGluZS5oOgorCiAyMDEwLTExLTI1ICBIYW5zIFdlbm5ib3JnICA8aGFu c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGZjYjJiZThkNjg2ODlmNWYxMTBjMzRlYjAyY2Fl MTQ2MGMyOTM5MmMuLjRjZGNlNzcyNDQ4ZTg0ZTBiNjgzZGM0ODM0ZGY1NjM2MTEyN2QxN2EgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTc3Nyw3ICs3NzcsNyBAQCB2b2lkIEhUTUxJ bnB1dEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKICNpZiBF TkFCTEUoSU5QVVRfU1BFRUNIKQogICAgIGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSB3ZWJraXRz cGVlY2hBdHRyKSB7CiAgICAgICBpZiAocmVuZGVyZXIoKSkKLSAgICAgICAgICByZW5kZXJlcigp LT51cGRhdGVGcm9tRWxlbWVudCgpOworICAgICAgICAgIHRvUmVuZGVyVGV4dENvbnRyb2xTaW5n bGVMaW5lKHJlbmRlcmVyKCkpLT5zcGVlY2hBdHRyaWJ1dGVDaGFuZ2VkKCk7CiAgICAgICBzZXRO ZWVkc1N0eWxlUmVjYWxjKCk7CiAgICAgfSBlbHNlIGlmIChhdHRyLT5uYW1lKCkgPT0gb253ZWJr aXRzcGVlY2hjaGFuZ2VBdHRyKQogICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2 ZW50TmFtZXMoKS53ZWJraXRzcGVlY2hjaGFuZ2VFdmVudCwgY3JlYXRlQXR0cmlidXRlRXZlbnRM aXN0ZW5lcih0aGlzLCBhdHRyKSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lLmNwcAppbmRleCBmNjM4OTA3OTI3ODA3YTA4MDU1NjgwZTdmNmY2 NGJkNjNlZDVhZWRiLi4yZGY5NmEyZDNhODc2OGU3NDg4ZjQ5YTdjOWQ5MWNlOWI2ZjY2YjdlIDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUu Y3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5j cHAKQEAgLTY2NSw2ICs2NjUsMjEgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6 OmNyZWF0ZVN1YnRyZWVJZk5lZWRlZCgpCiAgICAgfQogfQogCisjaWYgRU5BQkxFKElOUFVUX1NQ RUVDSCkKK3ZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpzcGVlY2hBdHRyaWJ1dGVD aGFuZ2VkKCkKK3sKKyAgICAvLyBUaGUgaW5uZXIgdGV4dCBlbGVtZW50IG9mIHRoaXMgcmVuZGVy ZXIgaGFzIGRpZmZlcmVudCBzdHlsZXMgZGVwZW5kaW5nIG9uIHdoZXRoZXIgdGhlCisgICAgLy8g c3BlZWNoIGJ1dHRvbiBpcyB2aXNpYmxlIG9yIG5vdC4gU28gd2hlbiB0aGUgc3BlZWNoIGF0dHJp YnV0ZSBjaGFuZ2VzLCB3ZSByZXNldCB0aGUKKyAgICAvLyB3aG9sZSB0aGluZyBhbmQgcmVjcmVh dGUgdG8gZ2V0IHRoZSByaWdodCBzdHlsZXMgYW5kIGxheW91dC4KKyAgICBpZiAobV9zcGVlY2hC dXR0b24pCisgICAgICAgIG1fc3BlZWNoQnV0dG9uLT5kZXRhY2goKTsKKyAgICBzZXRDaGlsZHJl bklubGluZSh0cnVlKTsKKyAgICBSZW5kZXJTdHlsZSogcGFyZW50U3R5bGUgPSBtX2lubmVyQmxv Y2sgPyBtX2lubmVyQmxvY2stPnJlbmRlcmVyKCktPnN0eWxlKCkgOiBzdHlsZSgpOworICAgIHNl dFN0eWxlKGNyZWF0ZUlubmVyVGV4dFN0eWxlKHBhcmVudFN0eWxlKSk7CisgICAgdXBkYXRlRnJv bUVsZW1lbnQoKTsKK30KKyNlbmRpZgorCiB2b2lkIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZTo6dXBkYXRlRnJvbUVsZW1lbnQoKQogewogICAgIGNyZWF0ZVN1YnRyZWVJZk5lZWRlZCgpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5l LmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaAppbmRl eCAyNjk4N2ZkN2UyNmRmM2I5YzFmNDRjNmEzZDAwOGY1MTgwMDlkNzU0Li5kNTFkN2YzZDljZmYy MWQyZWVlODk2OGEzNzBlZDIzOTA5YTYzNjEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaApAQCAtNTksNiArNTksMTAgQEAgcHVibGljOgog ICAgIC8vIERlY29yYXRpb24gd2lkdGggb3V0c2lkZSBvZiB0aGUgdGV4dCBmaWVsZC4KICAgICBp bnQgZGVjb3JhdGlvbldpZHRoUmlnaHQoKSBjb25zdDsKIAorI2lmIEVOQUJMRShJTlBVVF9TUEVF Q0gpCisgICAgdm9pZCBzcGVlY2hBdHRyaWJ1dGVDaGFuZ2VkKCk7CisjZW5kaWYKKwogcHJpdmF0 ZToKICAgICBpbnQgcHJlZmVycmVkRGVjb3JhdGlvbldpZHRoUmlnaHQoKSBjb25zdDsKICAgICB2 aXJ0dWFsIGJvb2wgaGFzQ29udHJvbENsaXAoKSBjb25zdDsK 75145 2010-11-30 07:19:52 -0800 2010-11-30 07:26:52 -0800 Patch bug-50077-20101130151950.patch text/plain 5052 satish ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjFhZWZjZGZlZDFhNGZhZjg1ZTJiNDAxOTU2NGQxN2U2N2ZmMzBjLi5mYjk5M2Rh MDU5ZDBkZTE0OWJjYTAwMTgxYzhlYzc0ZDZkYmEzZWVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMjUgIFNhdGlzaCBTYW1wYXRoICA8c2F0aXNoQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcmVuZGVyaW5n IG9mIHNwZWVjaCBidXR0b24gd2hlbiBzZXR0aW5nIHRoZSBhdHRyaWJ1dGUgZHluYW1pY2FsbHku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDA3Nwor CisgICAgICAgICogZmFzdC9zcGVlY2gvaW5wdXQtYXBwZWFyYW5jZS1zcGVlY2hidXR0b24uaHRt bDoKKwogMjAxMC0xMS0zMCAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3Qvc3BlZWNoL2lucHV0LWFwcGVhcmFuY2Utc3BlZWNoYnV0dG9uLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L3NwZWVjaC9pbnB1dC1hcHBlYXJhbmNlLXNwZWVjaGJ1dHRvbi5odG1s CmluZGV4IDdhZjA1ZTQzZGZmNjM2ZWY2NDE0NTI1M2NlMjg1OWUwMmNhMjU0ZTQuLjFmNDA4YmZj ODNjYmNhZTkyZDMyMjM4Y2Y1M2VkZDFjN2ExZWRjODkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3Qvc3BlZWNoL2lucHV0LWFwcGVhcmFuY2Utc3BlZWNoYnV0dG9uLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9zcGVlY2gvaW5wdXQtYXBwZWFyYW5jZS1zcGVlY2hidXR0b24uaHRtbApA QCAtMzAsNiArMzAsMTggQEAgZm9yICh2YXIgaSA9IDA7IGkgPCBjZWxscy5sZW5ndGg7ICsraSkg ewogICBkaXYuaW5uZXJIVE1MID0gY2VsbHNbaV07CiAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdwJyArIChpICsgMSkpLmFwcGVuZENoaWxkKGRpdik7CiB9CisKKy8vIEFsc28gY2hlY2sgdGhh dCBzZXR0aW5nIHRoZSBhdHRyaWJ1dGUgZnJvbSBzY3JpcHQgcmVuZGVycyBzaW1pbGFybHkuCit2 YXIgaW5wdXRXaXRoQXR0cmlidXRlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnaW5wdXQnKTsK K2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaW5wdXRXaXRoQXR0cmlidXRlKTsKK2lucHV0V2l0 aEF0dHJpYnV0ZS5zZXRBdHRyaWJ1dGUoJ3gtd2Via2l0LXNwZWVjaCcsICd4LXdlYmtpdC1zcGVl Y2gnKTsKKworLy8gU2ltaWxhciB0byBhYm92ZSwgY2hlY2sgaWYgcmVtb3ZpbmcgdGhlIGF0dHJp YnV0ZSB3aXRoIHNjcmlwdCByZW5kZXJzIGFuIGVtcHR5IGlucHV0IGZpZWxkLgordmFyIGlucHV0 V2l0aG91dEF0dHJpYnV0ZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lucHV0Jyk7CitpbnB1 dFdpdGhvdXRBdHRyaWJ1dGUuc2V0QXR0cmlidXRlKCd4LXdlYmtpdC1zcGVlY2gnLCAneC13ZWJr aXQtc3BlZWNoJyk7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlucHV0V2l0aG91dEF0dHJp YnV0ZSk7CitpbnB1dFdpdGhvdXRBdHRyaWJ1dGUucmVtb3ZlQXR0cmlidXRlKCd4LXdlYmtpdC1z cGVlY2gnKTsKKwogPC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDEzMTc3NjcyMDllOGViODk2 NjRlOTQ0MjhiM2VhNmUxMTc5NmUxZjEuLmNhZDFiOWI5YWUwMmNjNmFhZGY3ODIwZGVlZTFlMDQ2 MjdmYzU2ZjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMjUgIFNhdGlzaCBTYW1wYXRoICA8c2F0 aXNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggcmVuZGVyaW5nIG9mIHNwZWVjaCBidXR0b24gd2hlbiBzZXR0aW5nIHRo ZSBhdHRyaWJ1dGUgZHluYW1pY2FsbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MDA3NworCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0 cmlidXRlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5l LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6c3Bl ZWNoQXR0cmlidXRlQ2hhbmdlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRleHRDb250 cm9sU2luZ2xlTGluZS5oOgorCiAyMDEwLTExLTMwICBKb2huIEtub3R0ZW5iZWx0ICA8amtub3R0 ZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDNkMTcxOTQwNjEzNGM3ZTM2YjhiN2IzZjc4NTcy YjQ2YzU3Y2VhYmIuLmU0NzQ3NzNiNDgyZmUxM2NmNzQzM2JiN2UzZTQxYzcyMjBiYWIyNDkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTc3Nyw3ICs3NzcsNyBAQCB2b2lkIEhUTUxJ bnB1dEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKICNpZiBF TkFCTEUoSU5QVVRfU1BFRUNIKQogICAgIGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSB3ZWJraXRz cGVlY2hBdHRyKSB7CiAgICAgICBpZiAocmVuZGVyZXIoKSkKLSAgICAgICAgICByZW5kZXJlcigp LT51cGRhdGVGcm9tRWxlbWVudCgpOworICAgICAgICAgIHRvUmVuZGVyVGV4dENvbnRyb2xTaW5n bGVMaW5lKHJlbmRlcmVyKCkpLT5zcGVlY2hBdHRyaWJ1dGVDaGFuZ2VkKCk7CiAgICAgICBzZXRO ZWVkc1N0eWxlUmVjYWxjKCk7CiAgICAgfSBlbHNlIGlmIChhdHRyLT5uYW1lKCkgPT0gb253ZWJr aXRzcGVlY2hjaGFuZ2VBdHRyKQogICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2 ZW50TmFtZXMoKS53ZWJraXRzcGVlY2hjaGFuZ2VFdmVudCwgY3JlYXRlQXR0cmlidXRlRXZlbnRM aXN0ZW5lcih0aGlzLCBhdHRyKSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lLmNwcAppbmRleCBmNjM4OTA3OTI3ODA3YTA4MDU1NjgwZTdmNmY2 NGJkNjNlZDVhZWRiLi4yZGY5NmEyZDNhODc2OGU3NDg4ZjQ5YTdjOWQ5MWNlOWI2ZjY2YjdlIDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUu Y3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5j cHAKQEAgLTY2NSw2ICs2NjUsMjEgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6 OmNyZWF0ZVN1YnRyZWVJZk5lZWRlZCgpCiAgICAgfQogfQogCisjaWYgRU5BQkxFKElOUFVUX1NQ RUVDSCkKK3ZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpzcGVlY2hBdHRyaWJ1dGVD aGFuZ2VkKCkKK3sKKyAgICAvLyBUaGUgaW5uZXIgdGV4dCBlbGVtZW50IG9mIHRoaXMgcmVuZGVy ZXIgaGFzIGRpZmZlcmVudCBzdHlsZXMgZGVwZW5kaW5nIG9uIHdoZXRoZXIgdGhlCisgICAgLy8g c3BlZWNoIGJ1dHRvbiBpcyB2aXNpYmxlIG9yIG5vdC4gU28gd2hlbiB0aGUgc3BlZWNoIGF0dHJp YnV0ZSBjaGFuZ2VzLCB3ZSByZXNldCB0aGUKKyAgICAvLyB3aG9sZSB0aGluZyBhbmQgcmVjcmVh dGUgdG8gZ2V0IHRoZSByaWdodCBzdHlsZXMgYW5kIGxheW91dC4KKyAgICBpZiAobV9zcGVlY2hC dXR0b24pCisgICAgICAgIG1fc3BlZWNoQnV0dG9uLT5kZXRhY2goKTsKKyAgICBzZXRDaGlsZHJl bklubGluZSh0cnVlKTsKKyAgICBSZW5kZXJTdHlsZSogcGFyZW50U3R5bGUgPSBtX2lubmVyQmxv Y2sgPyBtX2lubmVyQmxvY2stPnJlbmRlcmVyKCktPnN0eWxlKCkgOiBzdHlsZSgpOworICAgIHNl dFN0eWxlKGNyZWF0ZUlubmVyVGV4dFN0eWxlKHBhcmVudFN0eWxlKSk7CisgICAgdXBkYXRlRnJv bUVsZW1lbnQoKTsKK30KKyNlbmRpZgorCiB2b2lkIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZTo6dXBkYXRlRnJvbUVsZW1lbnQoKQogewogICAgIGNyZWF0ZVN1YnRyZWVJZk5lZWRlZCgpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5l LmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaAppbmRl eCAyNjk4N2ZkN2UyNmRmM2I5YzFmNDRjNmEzZDAwOGY1MTgwMDlkNzU0Li5kNTFkN2YzZDljZmYy MWQyZWVlODk2OGEzNzBlZDIzOTA5YTYzNjEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuaApAQCAtNTksNiArNTksMTAgQEAgcHVibGljOgog ICAgIC8vIERlY29yYXRpb24gd2lkdGggb3V0c2lkZSBvZiB0aGUgdGV4dCBmaWVsZC4KICAgICBp bnQgZGVjb3JhdGlvbldpZHRoUmlnaHQoKSBjb25zdDsKIAorI2lmIEVOQUJMRShJTlBVVF9TUEVF Q0gpCisgICAgdm9pZCBzcGVlY2hBdHRyaWJ1dGVDaGFuZ2VkKCk7CisjZW5kaWYKKwogcHJpdmF0 ZToKICAgICBpbnQgcHJlZmVycmVkRGVjb3JhdGlvbldpZHRoUmlnaHQoKSBjb25zdDsKICAgICB2 aXJ0dWFsIGJvb2wgaGFzQ29udHJvbENsaXAoKSBjb25zdDsK