49963 2010-11-23 03:04:41 -0800 V8 binding for DOMTimeStamp should be Number, not Date 2010-11-30 07:14:56 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jknotten webkit-unassigned commit-queue dglazkov levin oldest_to_newest 312734 0 jknotten 2010-11-23 03:04:41 -0800 The W3C DOM Level 3 Core TR currently differs from standard practice in that the TR states that DOMTimeStamp should be bound to a Date object in ECMAScript ( http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp ). Initially, I had thought that JSC in WebKit needed to change ( https://bugs.webkit.org/show_bug.cgi?id=49589 ), but in practice, most existing implementations bind DOMTimeStamp to a Number. This was observed on what-wg before ( http://www.mail-archive.com/whatwg@lists.whatwg.org/msg13626.html ) and an intention was made to change the DOM Core 3 so that DOMTimeStamp be bound to a number for ECMAScript ( http://www.w3.org/TR/DOM-Level-3-Events/#changes-DOMLevel2to3Changes ): "Event.timeStamp is now a Number in the ECMAScript binding; a proposed correction to make the same change in [DOM3 Core] is forthcoming." The action is here: http://www.w3.org/2008/webapps/track/actions/417 So, the V8 WebKit binding for DOMTimeStamp should be changed from Date to Number. 312813 1 jknotten 2010-11-23 06:48:40 -0800 DOMTimeStamp has now moved out to Web IDL - the current development version of DOM Core can be found at http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html And the development version of Web IDL can be found here: http://dev.w3.org/2006/webapi/WebIDL/#common-DOMTimeStamp 314000 2 74931 jknotten 2010-11-26 06:31:32 -0800 Created attachment 74931 Patch 314987 3 commit-queue 2010-11-30 06:21:02 -0800 The commit-queue encountered the following flaky tests while processing attachment 74931: compositing/iframes/overlapped-nested-iframes.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 315024 4 commit-queue 2010-11-30 07:11:40 -0800 The commit-queue encountered the following flaky tests while processing attachment 74931: inspector/elements-panel-xhtml-structure.xhtml Please file bugs against the tests. These tests were authored by apavlov@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch. 315026 5 74931 commit-queue 2010-11-30 07:14:51 -0800 Comment on attachment 74931 Patch Clearing flags on attachment: 74931 Committed r72912: <http://trac.webkit.org/changeset/72912> 315027 6 commit-queue 2010-11-30 07:14:56 -0800 All reviewed patches have been landed. Closing bug. 74931 2010-11-26 06:31:32 -0800 2010-11-30 07:14:51 -0800 Patch bug-49963-20101126143130.patch text/plain 4839 jknotten ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNTE4ZGU3ZmM2ZjhhOGYyM2UzYzMyNWVkMmQyYzhjMDllNjU1MjE1Li4yY2MyMWM0 OGZhZThjZjUxOGE0YTUzMzA1YWUyNDVlYmI3MjA3ZDVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTEtMjYgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVjggYmluZGlu ZyBmb3IgRE9NVGltZVN0YW1wIHNob3VsZCBiZSBOdW1iZXIsIG5vdCBEYXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTk2MworCisgICAgICAgICog ZmFzdC9kb20vZG9tdGltZXN0YW1wLWlzLW51bWJlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvZG9tL2RvbXRpbWVzdGFtcC1pcy1udW1iZXIuaHRtbDogQWRkZWQuCisgICAg ICAgICogZmFzdC9kb20vc2NyaXB0LXRlc3RzL2RvbXRpbWVzdGFtcC1pcy1udW1iZXIuanM6IEFk ZGVkLgorICAgICAgICAoZG9fY2hlY2spOgorCiAyMDEwLTExLTI1ICBZdXpvIEZ1amlzaGltYSAg PHl1em9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIHRlc3QgZXhw ZWN0YWlvbiBjaGFuZ2UuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9kb210aW1l c3RhbXAtaXMtbnVtYmVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2RvbXRp bWVzdGFtcC1pcy1udW1iZXItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI0MTVhMGRmOTI2MDYw ZTY4NGQzNGZjYWM0OGQ4YWY4YjA4NjM0Y2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9kb210aW1lc3RhbXAtaXMtbnVtYmVyLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDExIEBACitUaGlzIHRlc3RzIHRoYXQgRE9NVGltZVN0YW1wIGlzIGEgTnVtYmVyIChhbmQgbm90 IGEgRGF0ZSBvYmplY3QpLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB0 aW1lc3RhbXAgaW5zdGFuY2VvZiBEYXRlIGlzIGZhbHNlCitQQVNTIHRpbWVzdGFtcCA9PSBOdW1i ZXIodGltZXN0YW1wKSBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9tdGlt ZXN0YW1wLWlzLW51bWJlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9tdGltZXN0YW1w LWlzLW51bWJlci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU1YzY3YWViZWI5ZGVlNGI1NzM3YTNkNWY3OTQ5 ZDhjN2YyN2IyMmEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9kb210 aW1lc3RhbXAtaXMtbnVtYmVyLmh0bWwKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwg UFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJl bD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4K KzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHkgb25sb2FkPSJkb19jaGVjayhldmVudCkiPgorPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQt dGVzdHMvZG9tdGltZXN0YW1wLWlzLW51bWJlci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvZG9tdGlt ZXN0YW1wLWlzLW51bWJlci5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy9k b210aW1lc3RhbXAtaXMtbnVtYmVyLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg4NjY5Y2M2N2UxMmY5NGMxZTUw MmQzOGEwM2IzY2ExM2E2ZWFiYTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zY3JpcHQtdGVzdHMvZG9tdGltZXN0YW1wLWlzLW51bWJlci5qcwpAQCAtMCwwICsxLDE0 IEBACitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IERPTVRpbWVTdGFtcCBpcyBhIE51bWJl ciAoYW5kIG5vdCBhIERhdGUgb2JqZWN0KS4iKTsKKy8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk5NjMKKwordmFyIHRpbWVzdGFtcCA9IG51bGw7CisKK2Z1 bmN0aW9uIGRvX2NoZWNrKGUpIHsKKyAgdGltZXN0YW1wID0gZS50aW1lU3RhbXA7CisgIHNob3Vs ZEJlRmFsc2UoInRpbWVzdGFtcCBpbnN0YW5jZW9mIERhdGUiKTsKKyAgc2hvdWxkQmVUcnVlKCJ0 aW1lc3RhbXAgPT0gTnVtYmVyKHRpbWVzdGFtcCkiKTsKKyAgZmluaXNoSlNUZXN0KCk7Cit9CisK K3dpbmRvdy5zdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOword2luZG93LmpzVGVzdElzQXN5bmMg PSB0cnVlOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdjNWU3MmU4NDZjZWQ1Y2YzZDI5 OGZhMTRlMWQwOTdmMGI4YWQ1Zi4uNjhiMDczYTE3N2Q3YzIwMzhmZGJjOTczMjViNzI0Y2NjMzBl M2IyZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yNiAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90 dGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBWOCBiaW5kaW5nIGZvciBET01UaW1lU3RhbXAgc2hvdWxkIGJlIE51bWJlciwg bm90IERhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ5OTYzCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vZG9tdGltZXN0YW1wLWlzLW51bWJlci5o dG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKwog MjAxMC0xMS0yNSAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KaW5kZXggOTIyZGExNWZlOGMxNjYxMDIxMWQyZDAxMmE0NzFhNDM4 YzNhNGU2Zi4uY2JlMjY0N2E5OGI2MmNhNDQ0NDNmMTA2ZTA5YmQ4NGMzYzk5OTU5YiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0zMDg4LDcgKzMw ODgsNiBAQCBzdWIgUmV0dXJuTmF0aXZlVG9KU1ZhbHVlCiAgICAgbXkgJGluZGVudCA9IHNoaWZ0 OwogICAgIG15ICR0eXBlID0gR2V0VHlwZUZyb21TaWduYXR1cmUoJHNpZ25hdHVyZSk7CiAKLSAg ICByZXR1cm4gInJldHVybiB2ODo6RGF0ZTo6TmV3KHN0YXRpY19jYXN0PGRvdWJsZT4oJHZhbHVl KSkiIGlmICR0eXBlIGVxICJET01UaW1lU3RhbXAiOwogICAgIHJldHVybiAicmV0dXJuIHY4Qm9v bGVhbigkdmFsdWUpIiBpZiAkdHlwZSBlcSAiYm9vbGVhbiI7CiAgICAgcmV0dXJuICJyZXR1cm4g djg6OkhhbmRsZTx2ODo6VmFsdWU+KCkiIGlmICR0eXBlIGVxICJ2b2lkIjsgICAgICMgZXF1aXZh bGVudCB0byB2ODo6VW5kZWZpbmVkKCkKIApAQCAtMzEwMCw3ICszMDk5LDcgQEAgc3ViIFJldHVy bk5hdGl2ZVRvSlNWYWx1ZQogCiAgICAgcmV0dXJuICJyZXR1cm4gdjhEYXRlT3JOdWxsKCR2YWx1 ZSkiIGlmICR0eXBlIGVxICJEYXRlIjsKICAgICAjIGxvbmcgbG9uZyBhbmQgdW5zaWduZWQgbG9u ZyBsb25nIGFyZSBub3QgcmVwcmVzZW50YWJsZSBpbiBFQ01BU2NyaXB0LgotICAgIHJldHVybiAi cmV0dXJuIHY4OjpOdW1iZXI6Ok5ldyhzdGF0aWNfY2FzdDxkb3VibGU+KCR2YWx1ZSkpIiBpZiAk dHlwZSBlcSAibG9uZyBsb25nIiBvciAkdHlwZSBlcSAidW5zaWduZWQgbG9uZyBsb25nIjsKKyAg ICByZXR1cm4gInJldHVybiB2ODo6TnVtYmVyOjpOZXcoc3RhdGljX2Nhc3Q8ZG91YmxlPigkdmFs dWUpKSIgaWYgJHR5cGUgZXEgImxvbmcgbG9uZyIgb3IgJHR5cGUgZXEgInVuc2lnbmVkIGxvbmcg bG9uZyIgb3IgJHR5cGUgZXEgIkRPTVRpbWVTdGFtcCI7CiAgICAgcmV0dXJuICJyZXR1cm4gdjg6 Ok51bWJlcjo6TmV3KCR2YWx1ZSkiIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1ByaW1pdGl2ZVR5cGUo JHR5cGUpIG9yICR0eXBlIGVxICJTVkdQYWludFR5cGUiOwogICAgIHJldHVybiAicmV0dXJuICR2 YWx1ZS52OFZhbHVlKCkiIGlmICRuYXRpdmVUeXBlIGVxICJTY3JpcHRWYWx1ZSI7CiAK