49954 2010-11-22 19:27:44 -0800 [Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p() 2010-12-17 04:05:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged commit-queue oldest_to_newest 312665 0 kling 2010-11-22 19:27:44 -0800 Some methods in GraphicsContextQt.cpp call m_data->p() multiple times. We should stash it in a QPainter* and reuse that. 322640 1 76656 kling 2010-12-15 09:47:28 -0800 Created attachment 76656 Proposed patch 323126 2 commit-queue 2010-12-16 05:33:50 -0800 The commit-queue encountered the following flaky tests while processing attachment 76656: inspector/timeline-paint.html bug 51182 (authors: pfeldman@chromium.org and yurys@chromium.org) java/argument-to-object-type.html bug 51102 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 323169 3 76656 commit-queue 2010-12-16 07:37:40 -0800 Comment on attachment 76656 Proposed patch Rejecting attachment 76656 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76656]" exit_code: 2 Last 500 characters of output: ailed to merge in the changes. Patch failed at 0001 2010-12-16 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7115058 323698 4 76656 kling 2010-12-17 04:05:29 -0800 Comment on attachment 76656 Proposed patch Clearing flags on attachment: 76656 Committed r74248: <http://trac.webkit.org/changeset/74248> 323699 5 kling 2010-12-17 04:05:38 -0800 All reviewed patches have been landed. Closing bug. 76656 2010-12-15 09:47:28 -0800 2010-12-17 04:05:29 -0800 Proposed patch bug-49954.diff text/plain 1815 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzBkYjcxNS4uYjc1MzAxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0xNSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQXZvaWQgdW5uZWNlc3NhcnkgY2FsbHMgdG8gR3Jh cGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlOjpwKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTU0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6OnB1c2hUcmFuc3BhcmVuY3lMYXllckludGVybmFsKToKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDo6YmVnaW5UcmFuc3BhcmVuY3lMYXllcik6CisKIDIwMTAtMTIt MTQgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKaW5kZXggMjU0MjM1ZS4uOTEwZmZjNyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAK QEAgLTk4Myw3ICs5ODMsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6Y2xlYXJQbGF0Zm9ybVNo YWRvdygpCiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpwdXNoVHJhbnNwYXJlbmN5TGF5ZXJJbnRl cm5hbChjb25zdCBRUmVjdCAmcmVjdCwgcXJlYWwgb3BhY2l0eSwgUVBpeG1hcCYgYWxwaGFNYXNr KQogewotICAgbV9kYXRhLT5sYXllcnMucHVzaChuZXcgVHJhbnNwYXJlbmN5TGF5ZXIobV9kYXRh LT5wKCksIG1fZGF0YS0+cCgpLT50cmFuc2Zvcm0oKS5tYXBSZWN0KHJlY3QpLCAxLjAsIGFscGhh TWFzaykpOworICAgIFFQYWludGVyKiBwID0gbV9kYXRhLT5wKCk7CisgICAgbV9kYXRhLT5sYXll cnMucHVzaChuZXcgVHJhbnNwYXJlbmN5TGF5ZXIocCwgcC0+dHJhbnNmb3JtKCkubWFwUmVjdChy ZWN0KSwgMS4wLCBhbHBoYU1hc2spKTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmJlZ2lu VHJhbnNwYXJlbmN5TGF5ZXIoZmxvYXQgb3BhY2l0eSkKQEAgLTEwMDYsNyArMTAwNyw3IEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpiZWdpblRyYW5zcGFyZW5jeUxheWVyKGZsb2F0IG9wYWNpdHkp CiAgICAgaCA9IGludChxQm91bmQocXJlYWwoMCksIGRldmljZUNsaXAuaGVpZ2h0KCksIChxcmVh bCloKSArIDIpOwogCiAgICAgUVBpeG1hcCBlbXB0eUFscGhhTWFzazsKLSAgICBtX2RhdGEtPmxh eWVycy5wdXNoKG5ldyBUcmFuc3BhcmVuY3lMYXllcihtX2RhdGEtPnAoKSwgUVJlY3QoeCwgeSwg dywgaCksIG9wYWNpdHksIGVtcHR5QWxwaGFNYXNrKSk7CisgICAgbV9kYXRhLT5sYXllcnMucHVz aChuZXcgVHJhbnNwYXJlbmN5TGF5ZXIocCwgUVJlY3QoeCwgeSwgdywgaCksIG9wYWNpdHksIGVt cHR5QWxwaGFNYXNrKSk7CiAgICAgKyttX2RhdGEtPmxheWVyQ291bnQ7CiB9CiAK