49918 2010-11-22 09:30:09 -0800 [Qt] StillImage::draw() shouldn't call setCompositionMode() unless the QPaintEngine has Porter-Duff composition 2010-12-15 17:16:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged commit-queue oldest_to_newest 312379 0 kling 2010-11-22 09:30:09 -0800 To avoid QPainter moaning on the console. Basically, we need to check if (painter->paintEngine()->hasFeature(QPaintEngine::PorterDuff)). Note that this isn't relevant when painting on a QImage. 322644 1 76657 kling 2010-12-15 09:49:07 -0800 Created attachment 76657 Proposed patch 322865 2 76657 ariya.hidayat 2010-12-15 15:26:02 -0800 Comment on attachment 76657 Proposed patch LGTM. 322958 3 commit-queue 2010-12-15 17:08:26 -0800 The commit-queue encountered the following flaky tests while processing attachment 76657: fast/canvas/webgl/tex-sub-image-2d.html bug 51153 (authors: abarth@webkit.org, kbr@google.com, and zmo@google.com) accessibility/media-element.html bug 51154 (author: eric.carlson@apple.com) The commit-queue is continuing to process your patch. 322962 4 76657 commit-queue 2010-12-15 17:15:59 -0800 Comment on attachment 76657 Proposed patch Clearing flags on attachment: 76657 Committed r74165: <http://trac.webkit.org/changeset/74165> 322963 5 commit-queue 2010-12-15 17:16:05 -0800 All reviewed patches have been landed. Closing bug. 76657 2010-12-15 09:49:07 -0800 2010-12-15 17:15:59 -0800 Proposed patch bug-49918.diff text/plain 1879 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzBkYjcxNS4uNDIxOWIzMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xNSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU3RpbGxJbWFnZTo6ZHJhdygpIHNob3VsZG4ndCBj YWxsIHNldENvbXBvc2l0aW9uTW9kZSgpIHVubGVzcyB0aGUgUVBhaW50RW5naW5lIGhhcyBQb3J0 ZXItRHVmZiBjb21wb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDk5MTgKKworICAgICAgICBHbyB0aHJvdWdoIEdyYXBoaWNzQ29udGV4dDo6 c2V0Q29tcG9zaXRlT3BlcmF0aW9uKCkgd2hpY2ggZG9lcyB0aGUgY2hlY2sgZm9yIHVzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFnZVF0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlN0aWxsSW1hZ2U6OmRyYXcpOgorCiAyMDEwLTEyLTE0ICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4g TG9wZXouCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1h Z2VRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5jcHAK aW5kZXggZjFlNWRjZC4uNTFjOTQ5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9xdC9TdGlsbEltYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvU3RpbGxJbWFnZVF0LmNwcApAQCAtNzEsMTEgKzcxLDExIEBAIHZvaWQgU3RpbGxJbWFnZTo6 ZHJhdyhHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgZHN0LAogICAgIEZs b2F0UmVjdCBub3JtYWxpemVkU3JjID0gc3JjLm5vcm1hbGl6ZWQoKTsKICAgICBGbG9hdFJlY3Qg bm9ybWFsaXplZERzdCA9IGRzdC5ub3JtYWxpemVkKCk7CiAKLSAgICBRUGFpbnRlciogcGFpbnRl ciA9IGN0eHQtPnBsYXRmb3JtQ29udGV4dCgpOwotICAgIFFQYWludGVyOjpDb21wb3NpdGlvbk1v ZGUgb2xkQ29tcG9zaXRpb25Nb2RlID0gcGFpbnRlci0+Y29tcG9zaXRpb25Nb2RlKCk7Ci0KKyAg ICBDb21wb3NpdGVPcGVyYXRvciBwcmV2aW91c09wZXJhdG9yID0gY3R4dC0+Y29tcG9zaXRlT3Bl cmF0aW9uKCk7CiAgICAgY3R4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKG9wKTsKIAorICAgIFFQ YWludGVyKiBwYWludGVyID0gY3R4dC0+cGxhdGZvcm1Db250ZXh0KCk7CisKICAgICBDb250ZXh0 U2hhZG93KiBzaGFkb3cgPSBjdHh0LT5jb250ZXh0U2hhZG93KCk7CiAgICAgaWYgKHNoYWRvdy0+ bV90eXBlICE9IENvbnRleHRTaGFkb3c6Ok5vU2hhZG93KSB7CiAgICAgICAgIFFQYWludGVyKiBz aGFkb3dQYWludGVyID0gc2hhZG93LT5iZWdpblNoYWRvd0xheWVyKHBhaW50ZXIsIG5vcm1hbGl6 ZWREc3QpOwpAQCAtODcsNyArODcsNyBAQCB2b2lkIFN0aWxsSW1hZ2U6OmRyYXcoR3JhcGhpY3ND b250ZXh0KiBjdHh0LCBjb25zdCBGbG9hdFJlY3QmIGRzdCwKICAgICB9CiAKICAgICBwYWludGVy LT5kcmF3UGl4bWFwKG5vcm1hbGl6ZWREc3QsICptX3BpeG1hcCwgbm9ybWFsaXplZFNyYyk7Ci0g ICAgcGFpbnRlci0+c2V0Q29tcG9zaXRpb25Nb2RlKG9sZENvbXBvc2l0aW9uTW9kZSk7CisgICAg Y3R4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKHByZXZpb3VzT3BlcmF0b3IpOwogfQogCiB9Cg==