49589 2010-11-16 03:11:38 -0800 DOMTimeStamp needs to be bound to Date object in ECMAScript 2011-02-15 04:41:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 0 jknotten webkit-unassigned ggaren jorlow oliver sam oldest_to_newest 309656 0 jknotten 2010-11-16 03:11:38 -0800 In mac WebKit, DOMTimeStamp is currently bound to an integer. It should be bound to a Date object as per the w3c spec: http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp 309723 1 73994 jknotten 2010-11-16 07:54:43 -0800 Created attachment 73994 Patch 309778 2 sam 2010-11-16 09:42:02 -0800 Do any other browsers do this? If not, it seems like this could be a compat issue. 310259 3 jknotten 2010-11-17 06:58:30 -0800 Out of Opera, Firefox, Safari, and Chromium, it seems that right now only Chromium binds it to a Date object. I tried to check on IE, but my test script failed as the onload event did not have a timeStamp field. The ECMAScript 262 specification for Date says that the valueOf() method of Date should return "the Number, which is the time value". This means that code that works with the DOMTimeStamp as if it were a number should continue to work (even if it is a Date instance). I use this fact in my test https://bugs.webkit.org/show_bug.cgi?id=48518 where I check that Geoposition timestamps are well-formed. Since this change affects only Mac WebKit, it would be great if you could suggest next steps on this issue. 312182 4 sam 2010-11-21 17:04:51 -0800 (In reply to comment #3) > Out of Opera, Firefox, Safari, and Chromium, it seems that right now only Chromium binds it to a Date object. > > I tried to check on IE, but my test script failed as the onload event did not have a timeStamp field. > > The ECMAScript 262 specification for Date says that the valueOf() method of Date should return "the Number, which is the time value". This means that code that works with the DOMTimeStamp as if it were a number should continue to work (even if it is a Date instance). I use this fact in my test https://bugs.webkit.org/show_bug.cgi?id=48518 where I check that Geoposition timestamps are well-formed. > > Since this change affects only Mac WebKit, it would be great if you could suggest next steps on this issue. I don't understand why this only affects Mac WebKit, it seems like it should effect all ports of WebKit that use the WebKit JS engine, JavaScriptCore. If only chromium has this behavior, I suggest moving chromium to match other browsers. 312314 5 jknotten 2010-11-22 06:18:32 -0800 Sam, you are correct, I should have said JSC instead of WebKit mac. 312501 6 sam 2010-11-22 13:54:35 -0800 Ok, I am going to mark this bug as INVALID then. 312735 7 jknotten 2010-11-23 03:06:43 -0800 (In reply to comment #6) > Ok, I am going to mark this bug as INVALID then. Agreed. I've filed a new bug to change the V8 bindings for DOMTimeStamp from Date object to Number, with rationale in the bug description. https://bugs.webkit.org/show_bug.cgi?id=49963 73994 2010-11-16 07:54:43 -0800 2011-02-15 04:41:23 -0800 Patch bug-49589-20101116155441.patch text/plain 4679 jknotten ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNDM2ZDJlYTZiZDVkMzE4NTc4Y2FhYjI1ODk0OTZiZTRkZWNmZmJkLi5lNTdmZWVk NjM4MjMwOTRmMmRjNmM3NTkyNjk1MDYzNDVhNjIxYmVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMTEtMTYgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgorCisgICAgICAgIERPTVRpbWVTdGFt cCBuZWVkcyB0byBiZSBib3VuZCB0byBEYXRlIG9iamVjdCBpbiBFQ01BU2NyaXB0LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk1ODkKKworICAgICAg ICBNYWMgV2ViS2l0IGN1cnJlbnRseSBiaW5kcyBET01UaW1lU3RhbXAgdG8gYW4gaW50ZWdlciBp biBFQ01BU2NyaXB0LAorICAgICAgICBidXQgYWNjb3JkaW5nIHRvCisgICAgICAgIGh0dHA6Ly93 d3cudzMub3JnL1RSL0RPTS1MZXZlbC0zLUNvcmUvY29yZS5odG1sI0RPTVRpbWVTdGFtcCBpdCBz aG91bGQKKyAgICAgICAgYmUgYSBEYXRlIG9iamVjdC4KKworICAgICAgICAqIGZhc3QvZG9tL2Rv bXRpbWVzdGFtcC1pcy1kYXRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9k b20vZG9tdGltZXN0YW1wLWlzLWRhdGUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20v c2NyaXB0LXRlc3RzL2RvbXRpbWVzdGFtcC1pcy1kYXRlLmpzOiBBZGRlZC4KKyAgICAgICAgKGRv X2NoZWNrKToKKwogMjAxMC0xMS0xNSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9kb210aW1lc3RhbXAtaXMtZGF0ZS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9kb210aW1lc3RhbXAtaXMtZGF0ZS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uYzE5OGMwNGMzMTYwYmE5MGZmZTU3MjM1MzFmMzhiMjY4MzUwZDE2MwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2RvbXRpbWVzdGFtcC1pcy1kYXRl LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3RzIHRoYXQgRE9NVGltZVN0 YW1wIGlzIGJvdW5kIHRvIGEgRGF0ZSBvYmplY3QuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCitQQVNTIHRpbWVzdGFtcCBpbnN0YW5jZW9mIERhdGUgaXMgdHJ1ZQorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL2RvbXRpbWVzdGFtcC1pcy1kYXRlLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9kb210aW1lc3RhbXAtaXMtZGF0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQxZjA5Yzhj ZWE3ZDhiNjFjODk4YTEzNDBhZjVkYTY0OTIwMWRmMGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9kb210aW1lc3RhbXAtaXMtZGF0ZS5odG1sCkBAIC0wLDAgKzEsMTMg QEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1s PgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0iZG9fY2hlY2soZXZlbnQp Ij4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8 c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2RvbXRpbWVzdGFtcC1pcy1kYXRlLmpzIj48L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Nj cmlwdC10ZXN0cy9kb210aW1lc3RhbXAtaXMtZGF0ZS5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L3NjcmlwdC10ZXN0cy9kb210aW1lc3RhbXAtaXMtZGF0ZS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNTg1ZjY2 MWM4ZWNjMmJkN2FlNDJhNWZlNTZlNjE0YTE1NjFhNGRkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRlc3RzL2RvbXRpbWVzdGFtcC1pcy1kYXRlLmpzCkBA IC0wLDAgKzEsMTMgQEAKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgRE9NVGltZVN0YW1w IGlzIGJvdW5kIHRvIGEgRGF0ZSBvYmplY3QuIik7CisvLyBTZWUgaHR0cDovL3d3dy53My5vcmcv VFIvRE9NLUxldmVsLTMtQ29yZS9jb3JlLmh0bWwjRE9NVGltZVN0YW1wCisKK3ZhciB0aW1lc3Rh bXAgPSBudWxsOworCitmdW5jdGlvbiBkb19jaGVjayhlKSB7CisgIHRpbWVzdGFtcCA9IGUudGlt ZVN0YW1wOworICBzaG91bGRCZVRydWUoInRpbWVzdGFtcCBpbnN0YW5jZW9mIERhdGUiKTsKKyAg ZmluaXNoSlNUZXN0KCk7Cit9CisKK3dpbmRvdy5zdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwor d2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTYwOTU2MDQyMDhiY2JmNjY3N2RjNTMxNjUxMTk3NTViZWM0YTIyMC4uNWIwMTExNmJmYWJmYWI1 NzBlYWUyM2Y1NzIyMzJkNzU4YjM1OTdhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0xNiAgSm9o biBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBKZXJlbXkgT3Jsb3cuCisKKyAgICAgICAgRE9NVGltZVN0YW1wIG5lZWRzIHRvIGJlIGJv dW5kIHRvIERhdGUgb2JqZWN0IGluIEVDTUFTY3JpcHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU4OQorCisgICAgICAgIE1hYyBXZWJLaXQgY3Vy cmVudGx5IGJpbmRzIERPTVRpbWVTdGFtcCB0byBhbiBpbnRlZ2VyIGluIEVDTUFTY3JpcHQsCisg ICAgICAgIGJ1dCBhY2NvcmRpbmcgdG8KKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvRE9N LUxldmVsLTMtQ29yZS9jb3JlLmh0bWwjRE9NVGltZVN0YW1wIGl0IHNob3VsZAorICAgICAgICBi ZSBhIERhdGUgb2JqZWN0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2RvbXRpbWVzdGFtcC1p cy1kYXRlLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtOgorCiAyMDEwLTExLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDA3NTc1ZjdlYTk2OTY3NjJlNWVm OGQ0YmFiNWZjOWQ5NDg2ZTBlM2YuLjI4YzU1MWM0NWZkY2Y0NTNlMTJhZGIyNjFmNDA3YmY5Njlk NzBlYmQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y SlMucG0KKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpA QCAtMjUxMiwxMCArMjUxMiwxMCBAQCBzdWIgTmF0aXZlVG9KU1ZhbHVlCiAgICAgcmV0dXJuICJq c0Jvb2xlYW4oJHZhbHVlKSIgaWYgJHR5cGUgZXEgImJvb2xlYW4iOwogCiAgICAgIyBOZWVkIHRv IGNoZWNrIERhdGUgdHlwZSBiZWZvcmUgSXNQcmltaXRpdmVUeXBlKCkuCi0gICAgaWYgKCR0eXBl IGVxICJEYXRlIikgeworICAgIGlmICgkdHlwZSBlcSAiRGF0ZSIgb3IgJHR5cGUgZXEgIkRPTVRp bWVTdGFtcCIpIHsKICAgICAgICAgcmV0dXJuICJqc0RhdGVPck51bGwoZXhlYywgJHZhbHVlKSI7 CiAgICAgfQotICAgIGlmICgkY29kZUdlbmVyYXRvci0+SXNQcmltaXRpdmVUeXBlKCR0eXBlKSBv ciAkdHlwZSBlcSAiU1ZHUGFpbnRUeXBlIiBvciAkdHlwZSBlcSAiRE9NVGltZVN0YW1wIikgewor ICAgIGlmICgkY29kZUdlbmVyYXRvci0+SXNQcmltaXRpdmVUeXBlKCR0eXBlKSBvciAkdHlwZSBl cSAiU1ZHUGFpbnRUeXBlIikgewogICAgICAgICAkaW1wbEluY2x1ZGVzeyI8cnVudGltZS9KU051 bWJlckNlbGwuaD4ifSA9IDE7CiAgICAgICAgIHJldHVybiAianNOdW1iZXIoJHZhbHVlKSI7CiAg ICAgfQo=