49569 2010-11-15 15:55:31 -0800 REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash. 2010-11-16 08:37:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 46015 1 dglazkov dglazkov commit-queue darin oldest_to_newest 309487 0 dglazkov 2010-11-15 15:55:31 -0800 REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash. 309492 1 73941 dglazkov 2010-11-15 15:58:00 -0800 Created attachment 73941 Patch 309494 2 dglazkov 2010-11-15 15:59:50 -0800 Darin, this is a mirror change to that in ShadowElement.h (http://trac.webkit.org/changeset/71934/trunk/WebCore/rendering/ShadowElement.h). I should've been more careful in reviewing all instances of where this pattern is used. Missed one. 309543 3 73941 dglazkov 2010-11-15 18:39:40 -0800 Comment on attachment 73941 Patch Let's see if the monkeybot can land it. 309577 4 73941 commit-queue 2010-11-15 21:35:57 -0800 Comment on attachment 73941 Patch Clearing flags on attachment: 73941 Committed r72062: <http://trac.webkit.org/changeset/72062> 309578 5 commit-queue 2010-11-15 21:36:04 -0800 All reviewed patches have been landed. Closing bug. 73941 2010-11-15 15:58:00 -0800 2010-11-15 21:35:57 -0800 Patch bug-49569-20101115155759.patch text/plain 4203 dglazkov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYWJjZmVmYzc4Y2RjOGJhMGNkZmNhMGFmYTdmYmQxY2U0MDk5ZjI0Li43ZTBjN2Y2 ZmFjMTBiMzJhOWY5MWY4N2FjMTJlMTQ4ZGVhMTFkMzkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMTUgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9O KHI3MTkzNCk6IFJlbW92aW5nIGFuIGVsZW1lbnQgd2l0aCBhIHNoYWRvdyBET00gZnJvbSB1bmRl ciBhIGN1cnNvciBjYXVzZXMgYSBjcmFzaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5NTY5CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9yZW1vdmUt c2hhZG93LWhvc3QtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2 ZW50cy9yZW1vdmUtc2hhZG93LWhvc3QtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTAtMTEtMTUg IFJlbmF0YSBIb2RvdmFuICA8cmVuaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZW1v dmUtc2hhZG93LWhvc3QtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvcmVtb3ZlLXNoYWRvdy1ob3N0LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNjQ5 NjlmMjBhZDkzZGZhMGIwYWIzMzBlZDJjOWU5NDZiM2EzMmIwCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLXNoYWRvdy1ob3N0LWNyYXNoLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDUgQEAKK0Vuc3VyZXMgdGhhdCBhICJtb3VzZW91dCIgZXZlbnQsIGZp cmVkIG9uIHNoYWRvdyBET00gZWxlbWVudCBvZiBhIGRlc3Ryb3llZCBob3N0IGVsZW1lbnQgZG9l c24ndCBjcmFzaCB0aGUgYnJvd3Nlci4KKworUGFzc2VzIGlmIGRvZXNuJ3QgY3Jhc2guCisKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLXNoYWRvdy1ob3N0LWNy YXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZW1vdmUtc2hhZG93LWhvc3QtY3Jh c2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi40YzkxMTA0MjNmMmViODU1M2IxNDcwMmE2OTgzNTY3OGU2ZjJl MTBjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLXNo YWRvdy1ob3N0LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwzNSBAQAorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQ+CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBtb3VzZU92ZXIoZWxlbWVudCkK K3sKKyAgICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICAgICAgcmV0dXJuOworCisgICAg dmFyIHggPSBlbGVtZW50Lm9mZnNldExlZnQgKyBlbGVtZW50Lm9mZnNldFdpZHRoIC8gMjsKKyAg ICB2YXIgeSA9IGVsZW1lbnQub2Zmc2V0VG9wICsgZWxlbWVudC5vZmZzZXRIZWlnaHQgLyAyOwor ICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworfQorCitmdW5jdGlvbiBydW5UZXN0 KCkKK3sKKyAgICB2YXIgYXJlYSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhcmVhJyk7Cisg ICAgbW91c2VPdmVyKGFyZWEpOworICAgIGFyZWEuaW5uZXJIVE1MID0gJyc7CisgICAgbW91c2VP dmVyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkZXNjcmlwdGlvbicpKTsKK30KKworPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+CisgICAgPHAgaWQ9ImRlc2Ny aXB0aW9uIj5FbnN1cmVzIHRoYXQgYSAibW91c2VvdXQiIGV2ZW50LCBmaXJlZCBvbiBzaGFkb3cg RE9NIGVsZW1lbnQgb2YgYSBkZXN0cm95ZWQgaG9zdCBlbGVtZW50IGRvZXNuJ3QgY3Jhc2ggdGhl IGJyb3dzZXIuCisgICAgPHA+UGFzc2VzIGlmIGRvZXNuJ3QgY3Jhc2guCisgICAgPGRpdiBpZD0i YXJlYSIgc3R5bGU9IndpZHRoOjEwMHB4O2hlaWdodDoxMDBweCI+CisgICAgICAgIDx0ZXh0YXJl YSBzdHlsZT0id2lkdGg6MTAwcHg7aGVpZ2h0OjEwMHB4Ij5Gb288L3RleHRhcmVhPgorICAgIDwv ZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwN2Q0NjRkOTUyNjc0ZTU2OWY3ZmZkNTIyNDU0NTcwNjk2 YTkzM2QyLi5kZjQ0NjM1OTQ2Nzg3MDRiMjBjNjBhMzE5NWE1ZmFjYmJjY2Q0Y2Y5IDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTExLTE1ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVH UkVTU0lPTihyNzE5MzQpOiBSZW1vdmluZyBhbiBlbGVtZW50IHdpdGggYSBzaGFkb3cgRE9NIGZy b20gdW5kZXIgYSBjdXJzb3IgY2F1c2VzIGEgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU2OQorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZl bnRzL3JlbW92ZS1zaGFkb3ctaG9zdC1jcmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcv VGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmg6CisgICAgICAgIChXZWJDb3JlOjpUZXh0Q29udHJv bElubmVyRWxlbWVudDo6aXNTaGFkb3dOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRDb250 cm9sSW5uZXJFbGVtZW50OjpzaGFkb3dQYXJlbnROb2RlKToKKwogMjAxMC0xMS0xNSAgUGF0cmlj ayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJv bElubmVyRWxlbWVudHMuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVt ZW50cy5oCmluZGV4IDYxYzlkYmFjY2NlYWFmNWVjNzk0NzNkNDg1MDE1NDk1MTc5ZTdmYTMuLjUx YzlhZmZlMjA0YTgxMjE4YjJkOGFmNzdmM2I5MmM2NmEyMGQ1YWEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCisrKyBiL1dlYkNvcmUvcmVu ZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCkBAIC00NywxMiArNDcsMTIgQEAgcHJv dGVjdGVkOgogCiBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBpc01vdXNlRm9jdXNhYmxlKCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0gCi0gICAgdmlydHVhbCBib29sIGlzU2hhZG93Tm9kZSgp IGNvbnN0IHsgcmV0dXJuIG1fc2hhZG93UGFyZW50OyB9Ci0gICAgdmlydHVhbCBDb250YWluZXJO b2RlKiBzaGFkb3dQYXJlbnROb2RlKCkgeyByZXR1cm4gbV9zaGFkb3dQYXJlbnQ7IH0KKyAgICB2 aXJ0dWFsIGJvb2wgaXNTaGFkb3dOb2RlKCkgY29uc3QgeyByZXR1cm4gbV9zaGFkb3dQYXJlbnQu Z2V0KCk7IH0KKyAgICB2aXJ0dWFsIENvbnRhaW5lck5vZGUqIHNoYWRvd1BhcmVudE5vZGUoKSB7 IHJldHVybiBtX3NoYWRvd1BhcmVudC5nZXQoKTsgfQogICAgIHZpcnR1YWwgYm9vbCBpc1NwZWxs Q2hlY2tpbmdFbmFibGVkKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRTaGFkb3dQYXJlbnROb2RlKEhU TUxFbGVtZW50KiBzaGFkb3dQYXJlbnQpIHsgbV9zaGFkb3dQYXJlbnQgPSBzaGFkb3dQYXJlbnQ7 IH0KIAotICAgIEhUTUxFbGVtZW50KiBtX3NoYWRvd1BhcmVudDsKKyAgICBSZWZQdHI8SFRNTEVs ZW1lbnQ+IG1fc2hhZG93UGFyZW50OwogfTsKIAogY2xhc3MgVGV4dENvbnRyb2xJbm5lclRleHRF bGVtZW50IDogcHVibGljIFRleHRDb250cm9sSW5uZXJFbGVtZW50IHsK