49477 2010-11-12 13:56:25 -0800 [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows 2011-03-05 06:46:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip reed commit-queue helder jamesr kling reed senorblanco steven.brudenell oldest_to_newest 308771 0 mihaip 2010-11-12 13:56:25 -0800 See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=canvas-arc-360-winding.html&showExpectations=true Diff: @@ -4,13 +4,13 @@ PASS data[0] is 0 -PASS data[1] is 0 +FAIL data[1] should be 0. Was 255. PASS data[2] is 0 PASS data[0] is 0 PASS data[1] is 255 PASS data[2] is 0 PASS data[0] is 0 -PASS data[1] is 0 +FAIL data[1] should be 0. Was 255. PASS data[2] is 0 PASS successfullyParsed is true 308773 1 mihaip 2010-11-12 13:57:31 -0800 Forgot a link to the revision that added the test: http://trac.webkit.org/changeset/71936 308775 2 jamesr 2010-11-12 13:59:23 -0800 We just render a big green rectangle on this in Skia instead of concentric circles. 362112 3 steven.brudenell 2011-03-03 17:20:34 -0800 any action here? as a developer i describe this bug as "chrome can't draw a torus shape with ctx.arc(), while firefox/ie9 can". this "testcase fails" description would indicate something's off by a pixel or philosophically wrong in an obscure case, but this is a bad bug! a common-case-is-visibly-cattywampus bug! i claim the root cause is in WebCore/platform/graphics/skia/PathSkia.cpp -- Path::addArc just adds an oval if sweepDegrees covers a whole circle. it disregards anticlockwise and the sign of sweepDegrees in this case. 362116 4 jamesr 2011-03-03 17:23:52 -0800 http://trac.webkit.org/export/80302/trunk/LayoutTests/fast/canvas/canvas-arc-360-winding.html 362452 5 84737 reed 2011-03-04 06:21:02 -0800 Created attachment 84737 respect anticlockwise in Path::addArc() 362458 6 steven.brudenell 2011-03-04 06:32:39 -0800 holy crap, that was the fastest response from any dev team i've ever seen. thanks :) 362463 7 84737 kling 2011-03-04 06:40:28 -0800 Comment on attachment 84737 respect anticlockwise in Path::addArc() Looks sane, r=me 362520 8 84737 mihaip 2011-03-04 08:29:49 -0800 Comment on attachment 84737 respect anticlockwise in Path::addArc() View in context: https://bugs.webkit.org/attachment.cgi?id=84737&action=review > WebCore/ChangeLog:9 > + LayoutTests/fast/canvas/canvas-arc-360-winding.html Shouldn't the TEXT entry for this in LayoutTests/platform/chromium/test_expectations.txt be removed, now that we expect it to pass? 362539 9 kling 2011-03-04 08:49:39 -0800 (In reply to comment #8) > (From update of attachment 84737 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84737&action=review > > > WebCore/ChangeLog:9 > > + LayoutTests/fast/canvas/canvas-arc-360-winding.html > > Shouldn't the TEXT entry for this in LayoutTests/platform/chromium/test_expectations.txt be removed, now that we expect it to pass? D'oh. Yes of course. @Mike: Please update the patch accordingly. 362597 10 84773 reed 2011-03-04 10:08:13 -0800 Created attachment 84773 Patch 362599 11 reed 2011-03-04 10:09:01 -0800 This time with the updated test_expectations.txt 362861 12 84773 commit-queue 2011-03-04 20:58:54 -0800 Comment on attachment 84773 Patch Rejecting attachment 84773 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2 Last 500 characters of output: ....................................................................................................................................................................................................................... inspector ........... inspector/audits . inspector/audits/audits-panel-functional.html -> failed Exiting early after 1 failures. 12758 tests run. 299.28s total testing time 12757 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 8 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8087853 362869 13 84773 jamesr 2011-03-04 21:46:29 -0800 Comment on attachment 84773 Patch Flake 362879 14 commit-queue 2011-03-04 22:29:45 -0800 The commit-queue encountered the following flaky tests while processing attachment 84773: inspector/audits/audits-panel-functional.html bug 55776 (authors: apavlov@chromium.org, pfeldman@chromium.org, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 362880 15 84773 commit-queue 2011-03-04 22:32:25 -0800 Comment on attachment 84773 Patch Clearing flags on attachment: 84773 Committed r80409: <http://trac.webkit.org/changeset/80409> 362881 16 commit-queue 2011-03-04 22:32:31 -0800 All reviewed patches have been landed. Closing bug. 362942 17 senorblanco 2011-03-05 06:46:37 -0800 Cool! 84737 2011-03-04 06:21:02 -0800 2011-03-04 10:08:02 -0800 respect anticlockwise in Path::addArc() clockwise.diff text/plain 1375 reed SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA4MDM0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDQgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNwZWN0 IGFudGljbG9ja3dpc2UgaW4gUGF0aDo6YXJjVG8oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk0NzcKKworICAgICAgICBObyBuZXcgdGVzdHMuCisg ICAgICAgIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1hcmMtMzYwLXdpbmRpbmcuaHRt bAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQYXRoOjphZGRBcmMpOgorCiAyMDExLTAzLTA0ICBJbHlhIFRpa2hvbm92 c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNl bWlraGF0c2t5LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lh LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0aFNr aWEuY3BwCShyZXZpc2lvbiA4MDM0MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9QYXRoU2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw3ICsxNDQsOCBAQCB2b2lkIFBh dGg6OmFkZEFyYyhjb25zdCBGbG9hdFBvaW50JiBwLCBmCiAgICAgICAgIC8vIE1vdmUgdG8gdGhl IHN0YXJ0IHBvc2l0aW9uICgwIHN3ZWVwIG1lYW5zIHdlIGFkZCBhIHNpbmdsZSBwb2ludCkuCiAg ICAgICAgIG1fcGF0aC0+YXJjVG8ob3ZhbCwgc3RhcnREZWdyZWVzLCAwLCBmYWxzZSk7CiAgICAg ICAgIC8vIERyYXcgdGhlIGNpcmNsZS4KLSAgICAgICAgbV9wYXRoLT5hZGRPdmFsKG92YWwpOwor ICAgICAgICBtX3BhdGgtPmFkZE92YWwob3ZhbCwgYW50aWNsb2Nrd2lzZSA/CisgICAgICAgICAg ICBTa1BhdGg6OmtDQ1dfRGlyZWN0aW9uIDogU2tQYXRoOjprQ1dfRGlyZWN0aW9uKTsKICAgICAg ICAgLy8gRm9yY2UgYSBtb3ZlVG8gdGhlIGVuZCBwb3NpdGlvbi4KICAgICAgICAgbV9wYXRoLT5h cmNUbyhvdmFsLCBzdGFydERlZ3JlZXMgKyBzd2VlcERlZ3JlZXMsIDAsIHRydWUpOwogICAgIH0g ZWxzZSB7Cg== 84773 2011-03-04 10:08:13 -0800 2011-03-04 22:32:25 -0800 Patch bug-49477-20110304130805.patch text/plain 2725 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDQgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbQ2hyb21pdW1dIGZhc3QvY2FudmFzL2NhbnZhcy1hcmMtMzYwLXdpbmRp bmcuaHRtbCBmYWlscyBvbiBMaW51eCBhbmQgV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk0NzcKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3NraWEvUGF0aFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6YWRkQXJj KToKKwogMjAxMS0wMy0wNCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcAkocmV2 aXNpb24gODAzNjIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1Bh dGhTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ0LDcgKzE0NCw4IEBAIHZvaWQgUGF0aDo6 YWRkQXJjKGNvbnN0IEZsb2F0UG9pbnQmIHAsIGYKICAgICAgICAgLy8gTW92ZSB0byB0aGUgc3Rh cnQgcG9zaXRpb24gKDAgc3dlZXAgbWVhbnMgd2UgYWRkIGEgc2luZ2xlIHBvaW50KS4KICAgICAg ICAgbV9wYXRoLT5hcmNUbyhvdmFsLCBzdGFydERlZ3JlZXMsIDAsIGZhbHNlKTsKICAgICAgICAg Ly8gRHJhdyB0aGUgY2lyY2xlLgotICAgICAgICBtX3BhdGgtPmFkZE92YWwob3ZhbCk7CisgICAg ICAgIG1fcGF0aC0+YWRkT3ZhbChvdmFsLCBhbnRpY2xvY2t3aXNlID8KKyAgICAgICAgICAgIFNr UGF0aDo6a0NDV19EaXJlY3Rpb24gOiBTa1BhdGg6OmtDV19EaXJlY3Rpb24pOwogICAgICAgICAv LyBGb3JjZSBhIG1vdmVUbyB0aGUgZW5kIHBvc2l0aW9uLgogICAgICAgICBtX3BhdGgtPmFyY1Rv KG92YWwsIHN0YXJ0RGVncmVlcyArIHN3ZWVwRGVncmVlcywgMCwgdHJ1ZSk7CiAgICAgfSBlbHNl IHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMDQgIE1pa2UgUmVlZCAgPHJl ZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbQ2hyb21pdW1dIGZhc3QvY2FudmFzL2NhbnZhcy1hcmMtMzYwLXdpbmRpbmcuaHRt bCBmYWlscyBvbiBMaW51eCBhbmQgV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk0NzcKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wMy0wNCAgSmVzc2llIEJlcmxpbiAgPGpi ZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzIDcgV2ViS2l0MiBSZWxlYXNlIFRl c3RzXSBmYXN0L2ZyYW1lcy9pZnJhbWUtcGx1Z2luLWxvYWQtcmVtb3ZlLWRvY3VtZW50LWNyYXNo Lmh0bWwKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDgwMzYyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yNjM0 LDggKzI2MzQsNiBAQCBCVUdDUjYwMzkzIE1BQyA6IGZhc3Qvc2VsZWN0b3JzLzAwMS5odG1sCiAK IEJVR0NSNjE3MzkgV0lOIExJTlVYIERFQlVHIDogYW5pbWF0aW9ucy9zdXNwZW5kLXJlc3VtZS1h bmltYXRpb24tZXZlbnRzLmh0bWwgPSBDUkFTSCBURVhUIFBBU1MKIAotQlVHV0s0OTQ3NyBXSU4g TElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtYXJjLTM2MC13aW5kaW5nLmh0bWwgPSBURVhUCi0K IC8vIE5ldyB0ZXN0cyBhZGRlZCB3aXRoIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0 LzcyNDcyIGFuZCBmdXJ0aGVyLgogLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MTk4MiBmb3IgbW9yZSBpbmZvLgogQlVHQ1I2MzkyMSBMSU5VWCBXSU4gOiBm YXN0L2NhbnZhcy9jYW52YXMtZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBURVhUCg==