<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>49395</bug_id>
          
          <creation_ts>2010-11-11 11:41:04 -0800</creation_ts>
          <short_desc>EWS bots can&apos;t understand when they can&apos;t update</short_desc>
          <delta_ts>2010-11-11 11:42:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>46636</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>aroben</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>308026</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-11-11 11:41:04 -0800</bug_when>
    <thetext>EWS bots can&apos;t understand when they can&apos;t update

It turns out that if you get your svn checkout wedged (as often happens on windows), then EWS bots can get into a state where they can&apos;t update and can&apos;t build, but don&apos;t report this.

The way we do an update is part of the _build call:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py#L60

But!  we can&apos;t distinguish between a failed first build and a failed update.  The update will fail, causing the build to fail, and then if the checkout happens to be bad enough that a no-update build fails on it too, then we just assume the tree is hosed and do nothing.

The way I&apos;ve fixed this for the win-ews for now is to add a:
svn status | grep ? | awk &apos;{print $2}&apos; | xargs rm
step to the wrapper script.  (To emulate git clean -f)

The right fix is to separate out the update step so we can detect when it goes wrong.  I think the commit-queue needs a separate update step too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308028</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-11-11 11:42:29 -0800</bug_when>
    <thetext>This is very similar to bug 46636.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>