49371 2010-11-11 01:23:59 -0800 Make it possible to override the visibleContentRect 2010-11-11 04:41:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 43852 1 kenneth webkit-unassigned kling zalan oldest_to_newest 307784 0 kenneth 2010-11-11 01:23:59 -0800 Make it possible to override the visibleContentRect in the case the client is handling the scrolling. This is similar to what the iPhone does. 307785 1 73590 kenneth 2010-11-11 01:32:48 -0800 Created attachment 73590 Patch 307818 2 73590 kling 2010-11-11 03:55:58 -0800 Comment on attachment 73590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73590&action=review r=me > WebCore/platform/ScrollView.h:129 > + // included. In the situation the client is responsible for the scrolling (ie. with a tiled backing store) it is possible to inform s/inform/override/ perhaps? 307838 3 kling 2010-11-11 04:41:28 -0800 Landed in <http://trac.webkit.org/changeset/71804> 73590 2010-11-11 01:32:48 -0800 2010-11-11 03:55:58 -0800 Patch 0001-Make-it-possible-to-override-the-visibleContentRect-.patch text/plain 3664 kenneth RnJvbSBmYTY1MTM3MGVkYTNmYmI5MDA3OWUyZTE3OWIyMDQ4N2E4M2I0MzIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUaHUsIDExIE5vdiAyMDEwIDEyOjI1OjIwICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gTWFrZSBpdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0aGUgdmlzaWJsZUNvbnRlbnRS ZWN0IGluIHRoZSBjYXNlIHRoZQogY2xpZW50IGlzIGhhbmRsaW5nIHRoZSBzY3JvbGxpbmcuIFRo aXMgaXMgc2ltaWxhciB0byB3aGF0IHRoZSBpUGhvbmUKIGRvZXMuCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CihXZWJDb3JlOjpTY3JvbGxW aWV3Ojp2aXNpYmxlQ29udGVudFJlY3QpOgoqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKFdlYkNv cmU6OlNjcm9sbFZpZXc6OnNldEFjdHVhbFZpc2libGVDb250ZW50UmVjdCk6Ci0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViQ29yZS9w bGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCB8ICAgIDQgKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxWaWV3LmggICB8ICAgIDUgKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IGQ2OGFmN2QuLjAxZjgxYzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAt MTEtMTAgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgaXQg cG9zc2libGUgdG8gb3ZlcnJpZGUgdGhlIHZpc2libGVDb250ZW50UmVjdCBpbiB0aGUgY2FzZSB0 aGUKKyAgICAgICAgY2xpZW50IGlzIGhhbmRsaW5nIHRoZSBzY3JvbGxpbmcuIFRoaXMgaXMgc2lt aWxhciB0byB3aGF0IHRoZSBpUGhvbmUKKyAgICAgICAgZG9lcy4KKworICAgICAgICAqIHBsYXRm b3JtL1Njcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6dmlzaWJs ZUNvbnRlbnRSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3Lmg6CisgICAgICAg IChXZWJDb3JlOjpTY3JvbGxWaWV3OjpzZXRBY3R1YWxWaXNpYmxlQ29udGVudFJlY3QpOgorCiAy MDEwLTExLTEwICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApp bmRleCBiMWM5NjE1Li5iZDc1YjgzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTIwNiw2 ICsyMDYsMTAgQEAgSW50UmVjdCBTY3JvbGxWaWV3Ojp2aXNpYmxlQ29udGVudFJlY3QoYm9vbCBp bmNsdWRlU2Nyb2xsYmFycykgY29uc3QKIHsKICAgICBpZiAocGxhdGZvcm1XaWRnZXQoKSkKICAg ICAgICAgcmV0dXJuIHBsYXRmb3JtVmlzaWJsZUNvbnRlbnRSZWN0KGluY2x1ZGVTY3JvbGxiYXJz KTsKKworICAgIGlmICghbV9hY3R1YWxWaXNpYmxlQ29udGVudFJlY3QuaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4gbV9hY3R1YWxWaXNpYmxlQ29udGVudFJlY3Q7CisKICAgICByZXR1cm4gSW50 UmVjdChJbnRQb2ludChtX3Njcm9sbE9mZnNldC53aWR0aCgpLCBtX3Njcm9sbE9mZnNldC5oZWln aHQoKSksCiAgICAgICAgICAgICAgICAgICAgSW50U2l6ZShtYXgoMCwgd2lkdGgoKSAtICh2ZXJ0 aWNhbFNjcm9sbGJhcigpICYmICFpbmNsdWRlU2Nyb2xsYmFycyA/IHZlcnRpY2FsU2Nyb2xsYmFy KCktPndpZHRoKCkgOiAwKSksIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4KDAsIGhl aWdodCgpIC0gKGhvcml6b250YWxTY3JvbGxiYXIoKSAmJiAhaW5jbHVkZVNjcm9sbGJhcnMgPyBo b3Jpem9udGFsU2Nyb2xsYmFyKCktPmhlaWdodCgpIDogMCkpKSk7CmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaCBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5o CmluZGV4IDIyZTQ4N2QuLjVhMWNmMWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsVmlldy5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCkBAIC0xMjYsOCAr MTI2LDEwIEBAIHB1YmxpYzoKIAogICAgIC8vIFRoZSB2aXNpYmxlIGNvbnRlbnQgcmVjdCBoYXMg YSBsb2NhdGlvbiB0aGF0IGlzIHRoZSBzY3JvbGxlZCBvZmZzZXQgb2YgdGhlIGRvY3VtZW50LiBU aGUgd2lkdGggYW5kIGhlaWdodCBhcmUgdGhlIHZpZXdwb3J0IHdpZHRoCiAgICAgLy8gYW5kIGhl aWdodC4gQnkgZGVmYXVsdCB0aGUgc2Nyb2xsYmFycyB0aGVtc2VsdmVzIGFyZSBleGNsdWRlZCBm cm9tIHRoaXMgcmVjdGFuZ2xlLCBidXQgYW4gb3B0aW9uYWwgYm9vbGVhbiBhcmd1bWVudCBhbGxv d3MgdGhlbSB0byBiZQotICAgIC8vIGluY2x1ZGVkLgorICAgIC8vIGluY2x1ZGVkLiBJbiB0aGUg c2l0dWF0aW9uIHRoZSBjbGllbnQgaXMgcmVzcG9uc2libGUgZm9yIHRoZSBzY3JvbGxpbmcgKGll LiB3aXRoIGEgdGlsZWQgYmFja2luZyBzdG9yZSkgaXQgaXMgcG9zc2libGUgdG8gaW5mb3JtCisg ICAgLy8gdGhlIGN1cnJlbnQgdmlzaWJsZUNvbnRlbnRSZWN0IGJ5IHVzaW5nIHNldEFjdHVhbFZp c2libGVDb250ZW50UmVjdCwgZm9yIGluc3RhbmNlIHdoZW4gYSBwYW4gZW5kcy4KICAgICBJbnRS ZWN0IHZpc2libGVDb250ZW50UmVjdChib29sIGluY2x1ZGVTY3JvbGxiYXJzID0gZmFsc2UpIGNv bnN0OworICAgIHZvaWQgc2V0QWN0dWFsVmlzaWJsZUNvbnRlbnRSZWN0KEludFJlY3QgYWN0dWFs VmlzaWJsZUNvbnRlbnRSZWN0KSB7IG1fYWN0dWFsVmlzaWJsZUNvbnRlbnRSZWN0ID0gYWN0dWFs VmlzaWJsZUNvbnRlbnRSZWN0OyB9CiAgICAgaW50IHZpc2libGVXaWR0aCgpIGNvbnN0IHsgcmV0 dXJuIHZpc2libGVDb250ZW50UmVjdCgpLndpZHRoKCk7IH0KICAgICBpbnQgdmlzaWJsZUhlaWdo dCgpIGNvbnN0IHsgcmV0dXJuIHZpc2libGVDb250ZW50UmVjdCgpLmhlaWdodCgpOyB9CiAKQEAg LTI4Nyw2ICsyODksNyBAQCBwcml2YXRlOgogICAgIC8vIHdoZXRoZXIgaXQgaXMgc2FmZSB0byBi bGl0IG9uIHNjcm9sbC4KICAgICBib29sIG1fY2FuQmxpdE9uU2Nyb2xsOwogCisgICAgSW50UmVj dCBtX2FjdHVhbFZpc2libGVDb250ZW50UmVjdDsKICAgICBJbnRTaXplIG1fc2Nyb2xsT2Zmc2V0 OyAvLyBGSVhNRTogV291bGQgcmF0aGVyIHN0b3JlIHRoaXMgYXMgYSBwb3NpdGlvbiwgYnV0IHdl IHdpbGwgd2FpdCB0byBtYWtlIHRoaXMgY2hhbmdlIHVudGlsIG1vcmUgY29kZSBpcyBzaGFyZWQu CiAgICAgSW50U2l6ZSBtX2ZpeGVkTGF5b3V0U2l6ZTsKICAgICBJbnRTaXplIG1fY29udGVudHNT aXplOwotLSAKMS43LjEKCg==