49369 2010-11-11 01:16:17 -0800 Philip Canvas test 2d.drawImage.wrongtype fails 2010-11-11 12:53:57 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.wrongtype.html P2 Normal --- 46506 0 helder webkit-unassigned excors mdelaney7 oldest_to_newest 307778 0 helder 2010-11-11 01:16:17 -0800 According to the spec (http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.drawImage.type), if the image is of the wrong type, the implementation must raise a TYPE_MISMATCH_ERR exception. For this reason, I think this test is inconsistent with the spec, since it checks if the exception raised is an instance of TypeError instead. It is also inconsistent with the 2d.drawImage.null.html test (see Bug 49368 which fixes it). 307783 1 73589 helder 2010-11-11 01:23:55 -0800 Created attachment 73589 Patch 307801 2 73589 kling 2010-11-11 03:07:32 -0800 Comment on attachment 73589 Patch This is incorrect, if the first argument to drawImage() isn't either null, a HTMLImageElement, a HTMLVideoElement or a HTMLCanvasElement, it doesn't match any of the overloads and Web IDL specifies that a TypeError exception should be raised. 307807 3 excors 2010-11-11 03:11:37 -0800 That's an old copy of the spec - http://whatwg.org/html5#dom-context-2d-drawimage is the latest version. (Also that's from an old copy of the tests - http://test.w3.org/html/tests/submission/PhilipTaylor/canvas/ is the latest now). It no longer has a comment about "wrong type", because it's impossible for it to be wrong type at that point: WebIDL will throw a TypeError before reaching this stage. 308073 4 helder 2010-11-11 12:53:57 -0800 Thanks, guys. Closing this. 73589 2010-11-11 01:23:55 -0800 2010-11-11 03:07:32 -0800 Patch bug-49369-20101111012353.patch text/plain 3441 helder ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZmM0MGFhZTU5Mjc1YjhlN2I2ZWQ2MWVhM2E2NmYyOGI5OGUyYzVhLi45ZTUyNTJm NDkyNjQ0ODE2YjYyNzNkMmFmM2M0M2E4MDdhODNhOGYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTEtMTEgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGhpbGlwIENhbnZhcyB0 ZXN0IDJkLmRyYXdJbWFnZS53cm9uZ3R5cGUgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MzY5CisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHRo ZSBzcGVjLCBpZiB0aGUgaW1hZ2UgaXMgb2YgdGhlIHdyb25nIHR5cGUsIHRoZSBpbXBsZW1lbnRh dGlvbiBtdXN0IHJhaXNlIGEKKyAgICAgICAgVFlQRV9NSVNNQVRDSF9FUlIgZXhjZXB0aW9uLgor CisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2Uud3Jvbmd0eXBlLmh0 bWw6CisKIDIwMTAtMTEtMTAgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRpbmcgQ2hyb21pdW0gZXhwZWN0YXRpb25zLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2Uud3Jv bmd0eXBlLmh0bWwgYi9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFn ZS53cm9uZ3R5cGUuaHRtbAppbmRleCBmYTc0YzBlNGJlNGNmMTQzM2ZjOThlNDgyYWMzMDg2ZmE2 ODczMDZkLi43YzYyMmZmOGIzYTcyOGE3ODIyY2E0MjMyOGIxNjExYjlhZTkxYjQ4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS53cm9uZ3R5 cGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFn ZS53cm9uZ3R5cGUuaHRtbApAQCAtMTQsMTYgKzE0LDE2IEBAIF9hZGRUZXN0KGZ1bmN0aW9uKGNh bnZhcywgY3R4KSB7CiAKIHRyeSB7IHZhciBfdGhyb3duID0gZmFsc2U7CiAgIGN0eC5kcmF3SW1h Z2UodW5kZWZpbmVkLCAwLCAwKTsKLX0gY2F0Y2ggKGUpIHsgaWYgKCEoZSBpbnN0YW5jZW9mIFR5 cGVFcnJvcikpIF9mYWlsKCJGYWlsZWQgYXNzZXJ0aW9uOiBleHBlY3RlZCBleGNlcHRpb24gb2Yg dHlwZSBUeXBlRXJyb3IsIGdvdDogIitlKTsgX3Rocm93biA9IHRydWU7IH0gZmluYWxseSB7IF9h c3NlcnQoX3Rocm93biwgInNob3VsZCB0aHJvdyBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3I6 IGN0eC5kcmF3SW1hZ2UodW5kZWZpbmVkLCAwLCAwKSIpOyB9Cit9IGNhdGNoIChlKSB7IGlmIChl LmNvZGUgIT0gRE9NRXhjZXB0aW9uLlRZUEVfTUlTTUFUQ0hfRVJSKSBfZmFpbCgiRmFpbGVkIGFz c2VydGlvbjogZXhwZWN0ZWQgZXhjZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9yLCBnb3Q6ICIrZSk7 IF90aHJvd24gPSB0cnVlOyB9IGZpbmFsbHkgeyBfYXNzZXJ0KF90aHJvd24sICJzaG91bGQgdGhy b3cgZXhjZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9yOiBjdHguZHJhd0ltYWdlKHVuZGVmaW5lZCwg MCwgMCkiKTsgfQogdHJ5IHsgdmFyIF90aHJvd24gPSBmYWxzZTsKICAgY3R4LmRyYXdJbWFnZSgw LCAwLCAwKTsKLX0gY2F0Y2ggKGUpIHsgaWYgKCEoZSBpbnN0YW5jZW9mIFR5cGVFcnJvcikpIF9m YWlsKCJGYWlsZWQgYXNzZXJ0aW9uOiBleHBlY3RlZCBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJy b3IsIGdvdDogIitlKTsgX3Rocm93biA9IHRydWU7IH0gZmluYWxseSB7IF9hc3NlcnQoX3Rocm93 biwgInNob3VsZCB0aHJvdyBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3I6IGN0eC5kcmF3SW1h Z2UoMCwgMCwgMCkiKTsgfQorfSBjYXRjaCAoZSkgeyBpZiAoZS5jb2RlICE9IERPTUV4Y2VwdGlv bi5UWVBFX01JU01BVENIX0VSUikgX2ZhaWwoIkZhaWxlZCBhc3NlcnRpb246IGV4cGVjdGVkIGV4 Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJvciwgZ290OiAiK2UpOyBfdGhyb3duID0gdHJ1ZTsgfSBm aW5hbGx5IHsgX2Fzc2VydChfdGhyb3duLCAic2hvdWxkIHRocm93IGV4Y2VwdGlvbiBvZiB0eXBl IFR5cGVFcnJvcjogY3R4LmRyYXdJbWFnZSgwLCAwLCAwKSIpOyB9CiB0cnkgeyB2YXIgX3Rocm93 biA9IGZhbHNlOwogICBjdHguZHJhd0ltYWdlKCIiLCAwLCAwKTsKLX0gY2F0Y2ggKGUpIHsgaWYg KCEoZSBpbnN0YW5jZW9mIFR5cGVFcnJvcikpIF9mYWlsKCJGYWlsZWQgYXNzZXJ0aW9uOiBleHBl Y3RlZCBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3IsIGdvdDogIitlKTsgX3Rocm93biA9IHRy dWU7IH0gZmluYWxseSB7IF9hc3NlcnQoX3Rocm93biwgInNob3VsZCB0aHJvdyBleGNlcHRpb24g b2YgdHlwZSBUeXBlRXJyb3I6IGN0eC5kcmF3SW1hZ2UoXCJcIiwgMCwgMCkiKTsgfQorfSBjYXRj aCAoZSkgeyBpZiAoZS5jb2RlICE9IERPTUV4Y2VwdGlvbi5UWVBFX01JU01BVENIX0VSUikgX2Zh aWwoIkZhaWxlZCBhc3NlcnRpb246IGV4cGVjdGVkIGV4Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJv ciwgZ290OiAiK2UpOyBfdGhyb3duID0gdHJ1ZTsgfSBmaW5hbGx5IHsgX2Fzc2VydChfdGhyb3du LCAic2hvdWxkIHRocm93IGV4Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJvcjogY3R4LmRyYXdJbWFn ZShcIlwiLCAwLCAwKSIpOyB9CiB0cnkgeyB2YXIgX3Rocm93biA9IGZhbHNlOwogICBjdHguZHJh d0ltYWdlKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3AnKSwgMCwgMCk7Ci19IGNhdGNoIChlKSB7 IGlmICghKGUgaW5zdGFuY2VvZiBUeXBlRXJyb3IpKSBfZmFpbCgiRmFpbGVkIGFzc2VydGlvbjog ZXhwZWN0ZWQgZXhjZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9yLCBnb3Q6ICIrZSk7IF90aHJvd24g PSB0cnVlOyB9IGZpbmFsbHkgeyBfYXNzZXJ0KF90aHJvd24sICJzaG91bGQgdGhyb3cgZXhjZXB0 aW9uIG9mIHR5cGUgVHlwZUVycm9yOiBjdHguZHJhd0ltYWdlKGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ3AnKSwgMCwgMCkiKTsgfQorfSBjYXRjaCAoZSkgeyBpZiAoZS5jb2RlICE9IERPTUV4Y2Vw dGlvbi5UWVBFX01JU01BVENIX0VSUikgX2ZhaWwoIkZhaWxlZCBhc3NlcnRpb246IGV4cGVjdGVk IGV4Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJvciwgZ290OiAiK2UpOyBfdGhyb3duID0gdHJ1ZTsg fSBmaW5hbGx5IHsgX2Fzc2VydChfdGhyb3duLCAic2hvdWxkIHRocm93IGV4Y2VwdGlvbiBvZiB0 eXBlIFR5cGVFcnJvcjogY3R4LmRyYXdJbWFnZShkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdwJyks IDAsIDApIik7IH0KIAogCiB9KTsK