49368 2010-11-11 00:42:18 -0800 Philip canvas test 2d.drawImage.null fails 2010-11-11 12:41:40 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 48307 http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.null.html P2 Normal --- 46506 0 helder webkit-unassigned commit-queue mdelaney7 oldest_to_newest 307769 0 helder 2010-11-11 00:42:18 -0800 A TYPE_MISMATCH_ERR DOM exception must be thrown if the image is of the wrong type or null. 307772 1 73587 helder 2010-11-11 00:47:11 -0800 Created attachment 73587 Patch 307800 2 73587 kling 2010-11-11 03:02:01 -0800 Comment on attachment 73587 Patch r=me 307878 3 73587 commit-queue 2010-11-11 06:34:16 -0800 Comment on attachment 73587 Patch Rejecting patch 73587 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73587]" exit_code: 2 Last 500 characters of output: g file LayoutTests/platform/qt/Skipped patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp Hunk #1 succeeded at 281 with fuzz 2 (offset 86 lines). Hunk #2 FAILED at 355. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp.rej Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/5546095 307884 4 mdelaney7 2010-11-11 06:47:18 -0800 This fix should break other current test expectations that assume that the TypeError will be thrown because of the (non-null) invalid parameters as per the WebIDL spec (as noted by Philip in your other patch from last night) such as the test 2d.drawImage,wrongTypes (or something like that name). Did nothing fail when you ran the layout tests? Also, a few hours earlier: https://bugs.webkit.org/show_bug.cgi?id=48307 308065 5 helder 2010-11-11 12:41:23 -0800 (In reply to comment #4) > Did nothing fail when you ran the layout tests? Hmm, looks like I only ran the fast canvas tests, my bad. > Also, a few hours earlier: https://bugs.webkit.org/show_bug.cgi?id=48307 Heh, better try to sync with you on IRC next time :) Thanks, Matthew, I'll mark this as a duplicate. 308066 6 helder 2010-11-11 12:41:40 -0800 *** This bug has been marked as a duplicate of bug 48307 *** 73587 2010-11-11 00:47:11 -0800 2010-11-11 06:34:16 -0800 Patch bug-49368-20101111004710.patch text/plain 4733 helder ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZmM0MGFhZTU5Mjc1YjhlN2I2ZWQ2MWVhM2E2NmYyOGI5OGUyYzVhLi5lMzgyMjk0 NjRlMDZjZTI4ODc3OTk2ZDk3M2FlOTA0OTRjYjg3N2FjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTEtMTEgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGhpbGlwIGNhbnZhcyB0 ZXN0IDJkLmRyYXdJbWFnZS5udWxsIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00OTM2OAorCisgICAgICAgIFJlbW92ZSB0ZXN0IGZyb20gc2tp cHBlZCBsaXN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisgICAgICAgICog cGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lw cGVkOgorCiAyMDEwLTExLTEwICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0aW5nIENocm9taXVtIGV4cGVjdGF0aW9ucy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggOTkzNzljZTYxZGRmY2Q4ODAwM2NiZDNmNzk1NmUz Y2NmMzNiZmY2YS4uZDU5YTEyOGM0YmJlMzM2Yzc2MjM2YmY1YWZkYjI1MGFiNWFhNGMwMyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTUzMTEsNyArNTMxMSw2IEBAIGNhbnZhcy9waGls aXAvdGVzdHMvMmQuY29tcG9zaXRlLnVuY292ZXJlZC5wYXR0ZXJuLmRlc3RpbmF0aW9uLWluLmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuY29tcG9zaXRlLnVuY292ZXJlZC5wYXR0ZXJuLnNv dXJjZS1pbi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmNvbXBvc2l0ZS51bmNvdmVyZWQu cGF0dGVybi5zb3VyY2Utb3V0Lmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdl LmJyb2tlbi5odG1sCi1jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5udWxsLmh0bWwK IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNlLnN5c3RlbS5odG1sCiBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmZyb250Lmh0bWwKIGNhbnZh cy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUudG9wLmh0bWwKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCmluZGV4IGQyOWU1MGI1MjZlZmZhMGU3ODZj ZDQxOWJhNjU3NzlmMmZkNjdmNTkuLjdiOWVlM2NlMWYyM2QwNzQ0NDY0MjRiZjI4ZGQ3NjJmYjM4 ZGI5NWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZApAQCAtMTEy LDcgKzExMiw2IEBAIHBsYXRmb3JtL21hYy9lZGl0aW5nL3NwZWxsaW5nL21vdmUtY3Vyc29yLXRv LWJlZ2lubmluZy1vZi1hdXRvY29ycmVjdGVkLXdvcmQuaHRtCiAKICMgU2tpcHBpbmcgZmFpbGlu ZyBwaGlsaXAgY2FudmFzIHRlc3RzIGZyb20gaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMv Y2FudmFzL3N1aXRlL3Rlc3RzLwogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2UuYnJv a2VuLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLm51bGwuaHRtbAogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2Uuc3lzdGVtLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJvbnQuaHRtbAogY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKaW5kZXggZDk5MGZjOGZhMjljNWYxM2VjNjRmMzcyNDlhMDkxYjBkMzlmNGZmZS4u YWFlMmJiMThlYTg1NTA2YjhhNTFkY2M0OTcxYmRjNGU2YmQwZmZiOSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9Ta2lwcGVkCkBAIC01MDM5LDcgKzUwMzksNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmNv bXBvc2l0ZS51bmNvdmVyZWQucGF0dGVybi5kZXN0aW5hdGlvbi1pbi5odG1sCiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLmNvbXBvc2l0ZS51bmNvdmVyZWQucGF0dGVybi5zb3VyY2UtaW4uaHRtbAog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5jb21wb3NpdGUudW5jb3ZlcmVkLnBhdHRlcm4uc291cmNl LW91dC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5icm9rZW4uaHRtbAot Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2UubnVsbC5odG1sCiBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJzZS5zeXN0ZW0uaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5iZWhpbmQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5iZXNpZGUuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNWZhNWJmOWZhY2ZkM2ZkNGIy ZGExZWE1MjI3NjY4YWRjODAxMzViLi5kNWZkZThkYzk4YmVjNzAzYTkzMTcwMDcyNzg4OWY3NDg3 YTVlZDNmIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTExICBIZWxkZXIgQ29ycmVpYSAgPGhlbGRl ckBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFBoaWxpcCBjYW52YXMgdGVzdCAyZC5kcmF3SW1hZ2UubnVsbCBmYWlscworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzNjgKKworICAgICAg ICBBIFRZUEVfTUlTTUFUQ0hfRVJSIERPTSBleGNlcHRpb24gbXVzdCBiZSB0aHJvd24gaWYgdGhl IGltYWdlIGlzIG9mIHRoZSB3cm9uZyB0eXBlIG9yIG51bGwuCisKKyAgICAgICAgKiBiaW5kaW5n cy9qcy9KU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpKU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd0ltYWdlKToKKwogMjAxMC0xMS0x MCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0eWxlIGZpeCBJ IHNhaWQgSeKAmWQgbWFrZSB0aGVuIGZvcmdvdCB0byBtYWtlLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHAgYi9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQ3VzdG9tLmNwcAppbmRl eCBlM2Y1YTRlYmZmZmNiMmIxZDk1ZTMxMDg2OGJlYWZhNzJiNTFiYzgwLi5lYjA3OTA5MTk5NzRm ZWYzMTc3ZjMwMjQzYjIzM2RjZDA4OWM2M2QwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQ3VzdG9tLmNwcApAQCAtMTk1LDgg KzE5NSwxMCBAQCBKU1ZhbHVlIEpTQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkcmF3SW1hZ2Uo RXhlY1N0YXRlKiBleGVjKQogICAgIC8vIENvbXBvc2l0ZSBvcGVyYXRpb24gaXMgc3BlY2lmaWVk IHdpdGggZ2xvYmFsQ29tcG9zaXRlT3BlcmF0aW9uLgogICAgIC8vIFRoZSBpbWcgcGFyYW1ldGVy IGNhbiBiZSBhIDxpbWc+IG9yIDxjYW52YXM+IGVsZW1lbnQuCiAgICAgSlNWYWx1ZSB2YWx1ZSA9 IGV4ZWMtPmFyZ3VtZW50KDApOwotICAgIGlmICghdmFsdWUuaXNPYmplY3QoKSkKLSAgICAgICAg cmV0dXJuIHRocm93VHlwZUVycm9yKGV4ZWMpOworICAgIGlmICghdmFsdWUuaXNPYmplY3QoKSkg eworICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgVFlQRV9NSVNNQVRDSF9FUlIpOworICAg ICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKKyAgICB9CiAgICAgSlNPYmplY3QqIG8gPSBhc09i amVjdCh2YWx1ZSk7CiAgICAgCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CkBAIC0yNjcsNyAr MjY5LDcgQEAgSlNWYWx1ZSBKU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd0ltYWdlKEV4 ZWNTdGF0ZSogZXhlYykKICAgICAgICAgfQogI2VuZGlmCiAgICAgfSBlbHNlCi0gICAgICAgcmV0 dXJuIHRocm93VHlwZUVycm9yKGV4ZWMpOworICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBU WVBFX01JU01BVENIX0VSUik7CiAgICAgCiAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7ICAgIAog fQo=