49285 2010-11-09 15:37:19 -0800 [Chromium/DRT] Make EventSendingController send complete touch events. 2010-11-12 09:43:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 rjkroege webkit-unassigned commit-queue oldest_to_newest 307032 0 rjkroege 2010-11-09 15:37:19 -0800 The forthcoming patch makes EventSendingController send touch events more like how it currently handles mouse events: it gives them valid screenPosition fields and does layout before dispatching them. 307417 1 73505 rjkroege 2010-11-10 10:35:02 -0800 Created attachment 73505 p1 for 49285 307470 2 73505 jamesr 2010-11-10 11:59:21 -0800 Comment on attachment 73505 p1 for 49285 View in context: https://bugs.webkit.org/attachment.cgi?id=73505&action=review Patch looks good, but please fix/remove the comment before landing. > WebKitTools/DumpRenderTree/chromium/EventSender.cpp:878 > + // Force a layout here just to make sure every position has been > + // determined before we send events (as well as all the other methods > + // that send an event do). This comment doesn't seem very helpful, I'd just leave it out. It's also not entirely accurate from what I can tell (it won't change the position argument passed on this event). 307486 3 73527 rjkroege 2010-11-10 12:36:19 -0800 Created attachment 73527 Addressed review comments. 307537 4 73505 eric 2010-11-10 14:01:11 -0800 Comment on attachment 73505 p1 for 49285 Cleared James Robinson's review+ from obsolete attachment 73505 so that this bug does not appear in http://webkit.org/pending-commit. 308116 5 73527 jamesr 2010-11-11 13:48:55 -0800 Comment on attachment 73527 Addressed review comments. Cool! 308164 6 73527 commit-queue 2010-11-11 14:37:35 -0800 Comment on attachment 73527 Addressed review comments. Rejecting patch 73527 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/5744004 308606 7 73527 commit-queue 2010-11-12 09:43:27 -0800 Comment on attachment 73527 Addressed review comments. Clearing flags on attachment: 73527 Committed r71921: <http://trac.webkit.org/changeset/71921> 308607 8 commit-queue 2010-11-12 09:43:32 -0800 All reviewed patches have been landed. Closing bug. 73505 2010-11-10 10:35:02 -0800 2010-11-10 14:01:11 -0800 p1 for 49285 wk49285_1.patch text/plain 2299 rjkroege ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MWNlNWZhLi41NDBiMzE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEt MTAgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bS9EUlRdIE1ha2Ug RXZlbnRTZW5kaW5nQ29udHJvbGxlciBzZW5kIGNvbXBsZXRlIHRvdWNoIGV2ZW50cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5Mjg1CisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChF dmVudFNlbmRlcjo6YWRkVG91Y2hQb2ludCk6CisgICAgICAgIChFdmVudFNlbmRlcjo6dXBkYXRl VG91Y2hQb2ludCk6CisgICAgICAgIChFdmVudFNlbmRlcjo6c2VuZEN1cnJlbnRUb3VjaEV2ZW50 KToKKwogMjAxMC0xMS0wOSAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCmluZGV4IGVjMTZjZjcuLjYy YTMwOTEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0V2 ZW50U2VuZGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9F dmVudFNlbmRlci5jcHAKQEAgLTgwMSw2ICs4MDEsNyBAQCB2b2lkIEV2ZW50U2VuZGVyOjphZGRU b3VjaFBvaW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiBy ZQogICAgIFdlYlRvdWNoUG9pbnQgdG91Y2hQb2ludDsKICAgICB0b3VjaFBvaW50LnN0YXRlID0g V2ViVG91Y2hQb2ludDo6U3RhdGVQcmVzc2VkOwogICAgIHRvdWNoUG9pbnQucG9zaXRpb24gPSBX ZWJQb2ludChhcmd1bWVudHNbMF0udG9JbnQzMigpLCBhcmd1bWVudHNbMV0udG9JbnQzMigpKTsK KyAgICB0b3VjaFBvaW50LnNjcmVlblBvc2l0aW9uID0gdG91Y2hQb2ludC5wb3NpdGlvbjsKICAg ICB0b3VjaFBvaW50LmlkID0gdG91Y2hQb2ludHMuc2l6ZSgpOwogICAgIHRvdWNoUG9pbnRzLmFw cGVuZCh0b3VjaFBvaW50KTsKIH0KQEAgLTg1NCw2ICs4NTUsNyBAQCB2b2lkIEV2ZW50U2VuZGVy Ojp1cGRhdGVUb3VjaFBvaW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBW YXJpYW50KgogICAgIFdlYlRvdWNoUG9pbnQqIHRvdWNoUG9pbnQgPSAmdG91Y2hQb2ludHNbaW5k ZXhdOwogICAgIHRvdWNoUG9pbnQtPnN0YXRlID0gV2ViVG91Y2hQb2ludDo6U3RhdGVNb3ZlZDsK ICAgICB0b3VjaFBvaW50LT5wb3NpdGlvbiA9IHBvc2l0aW9uOworICAgIHRvdWNoUG9pbnQtPnNj cmVlblBvc2l0aW9uID0gcG9zaXRpb247CiB9CiAKIHZvaWQgRXZlbnRTZW5kZXI6OmNhbmNlbFRv dWNoUG9pbnQoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJl c3VsdCkKQEAgLTg3MCw2ICs4NzIsMTIgQEAgdm9pZCBFdmVudFNlbmRlcjo6Y2FuY2VsVG91Y2hQ b2ludChjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCoKIHZvaWQg RXZlbnRTZW5kZXI6OnNlbmRDdXJyZW50VG91Y2hFdmVudChjb25zdCBXZWJJbnB1dEV2ZW50OjpU eXBlIHR5cGUpCiB7CiAgICAgQVNTRVJUKHN0YXRpY19jYXN0PHVuc2lnbmVkPihXZWJUb3VjaEV2 ZW50Ojp0b3VjaFBvaW50c0xlbmd0aENhcCkgPiB0b3VjaFBvaW50cy5zaXplKCkpOworCisgICAg Ly8gRm9yY2UgYSBsYXlvdXQgaGVyZSBqdXN0IHRvIG1ha2Ugc3VyZSBldmVyeSBwb3NpdGlvbiBo YXMgYmVlbgorICAgIC8vIGRldGVybWluZWQgYmVmb3JlIHdlIHNlbmQgZXZlbnRzIChhcyB3ZWxs IGFzIGFsbCB0aGUgb3RoZXIgbWV0aG9kcworICAgIC8vIHRoYXQgc2VuZCBhbiBldmVudCBkbyku CisgICAgd2VidmlldygpLT5sYXlvdXQoKTsKKwogICAgIFdlYlRvdWNoRXZlbnQgdG91Y2hFdmVu dDsKICAgICB0b3VjaEV2ZW50LnR5cGUgPSB0eXBlOwogICAgIHRvdWNoRXZlbnQubW9kaWZpZXJz ID0gdG91Y2hNb2RpZmllcnM7Cg== 73527 2010-11-10 12:36:19 -0800 2010-11-12 09:43:27 -0800 Addressed review comments. wk49285_2.patch text/plain 2119 rjkroege ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZjY5ZTg1Li5lMmQ2MzNmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEt MTAgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bS9EUlRdIE1ha2Ug RXZlbnRTZW5kaW5nQ29udHJvbGxlciBzZW5kIGNvbXBsZXRlIHRvdWNoIGV2ZW50cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5Mjg1CisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChF dmVudFNlbmRlcjo6YWRkVG91Y2hQb2ludCk6CisgICAgICAgIChFdmVudFNlbmRlcjo6dXBkYXRl VG91Y2hQb2ludCk6CisgICAgICAgIChFdmVudFNlbmRlcjo6c2VuZEN1cnJlbnRUb3VjaEV2ZW50 KToKKwogMjAxMC0xMS0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCmluZGV4IGVjMTZjZjcuLmVh Y2JlMGIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0V2 ZW50U2VuZGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9F dmVudFNlbmRlci5jcHAKQEAgLTgwMSw2ICs4MDEsNyBAQCB2b2lkIEV2ZW50U2VuZGVyOjphZGRU b3VjaFBvaW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiBy ZQogICAgIFdlYlRvdWNoUG9pbnQgdG91Y2hQb2ludDsKICAgICB0b3VjaFBvaW50LnN0YXRlID0g V2ViVG91Y2hQb2ludDo6U3RhdGVQcmVzc2VkOwogICAgIHRvdWNoUG9pbnQucG9zaXRpb24gPSBX ZWJQb2ludChhcmd1bWVudHNbMF0udG9JbnQzMigpLCBhcmd1bWVudHNbMV0udG9JbnQzMigpKTsK KyAgICB0b3VjaFBvaW50LnNjcmVlblBvc2l0aW9uID0gdG91Y2hQb2ludC5wb3NpdGlvbjsKICAg ICB0b3VjaFBvaW50LmlkID0gdG91Y2hQb2ludHMuc2l6ZSgpOwogICAgIHRvdWNoUG9pbnRzLmFw cGVuZCh0b3VjaFBvaW50KTsKIH0KQEAgLTg1NCw2ICs4NTUsNyBAQCB2b2lkIEV2ZW50U2VuZGVy Ojp1cGRhdGVUb3VjaFBvaW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBW YXJpYW50KgogICAgIFdlYlRvdWNoUG9pbnQqIHRvdWNoUG9pbnQgPSAmdG91Y2hQb2ludHNbaW5k ZXhdOwogICAgIHRvdWNoUG9pbnQtPnN0YXRlID0gV2ViVG91Y2hQb2ludDo6U3RhdGVNb3ZlZDsK ICAgICB0b3VjaFBvaW50LT5wb3NpdGlvbiA9IHBvc2l0aW9uOworICAgIHRvdWNoUG9pbnQtPnNj cmVlblBvc2l0aW9uID0gcG9zaXRpb247CiB9CiAKIHZvaWQgRXZlbnRTZW5kZXI6OmNhbmNlbFRv dWNoUG9pbnQoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJl c3VsdCkKQEAgLTg3MCw2ICs4NzIsOCBAQCB2b2lkIEV2ZW50U2VuZGVyOjpjYW5jZWxUb3VjaFBv aW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50Kgogdm9pZCBF dmVudFNlbmRlcjo6c2VuZEN1cnJlbnRUb3VjaEV2ZW50KGNvbnN0IFdlYklucHV0RXZlbnQ6OlR5 cGUgdHlwZSkKIHsKICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KFdlYlRvdWNoRXZl bnQ6OnRvdWNoUG9pbnRzTGVuZ3RoQ2FwKSA+IHRvdWNoUG9pbnRzLnNpemUoKSk7CisgICAgd2Vi dmlldygpLT5sYXlvdXQoKTsKKwogICAgIFdlYlRvdWNoRXZlbnQgdG91Y2hFdmVudDsKICAgICB0 b3VjaEV2ZW50LnR5cGUgPSB0eXBlOwogICAgIHRvdWNoRXZlbnQubW9kaWZpZXJzID0gdG91Y2hN b2RpZmllcnM7Cg==