48806 2010-11-01 16:50:45 -0700 Set frame name before appending it to the frame tree in the Apple Windows, GTK, and EFL ports 2010-11-02 09:04:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 6751 1 dbates dbates abarth aroben leandro mrobinson oldest_to_newest 303072 0 dbates 2010-11-01 16:50:45 -0700 The name of the frame should be set before it's appended to the frame tree in the Apple Windows, GTK, and EFL ports so that the frame count is correct (*) and consistent with the ordering used in the Mac, Qt, and Haiku ports. (*) Notice, FrameTree::uniqueName() generates unique names using a zero-based frame count. Disregarding the frame name prefix, for a page that that contains two (i.e. FrameTree::m_childCount := 2) unnamed frames A and B, the unique names would be <!--frame0--> and <!--frame1-->, respectively. For this to work out, the name of the frame must be set before it's appended to the tree (see remark (**)). (**) Note: Currently, there is no observed difference in the expected results for the Apple Windows, GTK and EFL ports because HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>, which is called before FrameLoaderClient::createFrame(), generates a unique name with the correct frame count. And by the implementation of FrameTree::uniqueName() <http://trac.webkit.org/browser/trunk/WebCore/page/FrameTree.cpp?rev=70976#L104>, we don't generate a unique name (with the incorrect child count) if the requested name is non-empty. 303080 1 72599 dbates 2010-11-01 16:57:19 -0700 Created attachment 72599 Patch At this time we cannot test this change since the observable change is being masked by code in HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160> (see comment 1 for more details). 303108 2 72599 mrobinson 2010-11-01 17:25:11 -0700 Comment on attachment 72599 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72599&action=review After discussing this with Daniel yesterday, I can confirm that this patch makes a lot of sense. > WebKit/efl/ChangeLog:10 > + Mac, Qt, and Haiku ports. In particular, the set the name of the new I think "the set the name" should probably be "set the name." 303396 3 dbates 2010-11-02 09:04:56 -0700 Committed r71120: <http://trac.webkit.org/changeset/71120> 72599 2010-11-01 16:57:19 -0700 2010-11-01 17:25:10 -0700 Patch Bug48806.patch text/plain 5368 dbates SW5kZXg6IFdlYktpdC9lZmwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvQ2hh bmdlTG9nCShyZXZpc2lvbiA3MTA2OCkKKysrIFdlYktpdC9lZmwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMDEgIERhbmllbCBCYXRlcyAgPGRiYXRl c0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNldCBmcmFtZSBuYW1lIGJlZm9yZSBhcHBlbmRpbmcgaXQgdG8gdGhlIGZyYW1lIHRyZWUg aW4gdGhlIEFwcGxlIFdpbmRvd3MsCisgICAgICAgIEdUSywgYW5kIEVGTCBwb3J0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg4MDYKKworICAgICAg ICBNYWtlIHRoZSBmcmFtZSBjcmVhdGlvbiBwcm9jZXNzIGluIHRoZSBFRkwtcG9ydCBjb25zaXN0 ZW50IHdpdGggdGhlCisgICAgICAgIE1hYywgUXQsIGFuZCBIYWlrdSBwb3J0cy4gSW4gcGFydGlj dWxhciwgdGhlIHNldCB0aGUgbmFtZSBvZiB0aGUgbmV3CisgICAgICAgIGZyYW1lIGJlZm9yZSBp dCdzIGFwcGVuZGVkIHRvIHRoZSBmcmFtZSB0cmVlLgorCisgICAgICAgIEF0IHRoaXMgdGltZSB3 ZSBjYW5ub3QgdGVzdCB0aGlzIGNoYW5nZSBzaW5jZSBpdCBpcyBiZWluZyBtYXNrZWQgYnkKKyAg ICAgICAgSFRNTEZyYW1lRWxlbWVudEJhc2U6OnNldE5hbWUoKSA8aHR0cDovL3RyYWMud2Via2l0 Lm9yZy9icm93c2VyL3RydW5rL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHA/ cmV2PTcwOTc2I0wxNjA+LgorICAgICAgICBXZSdsbCBiZSBhYmxlIHRvIHRlc3QgdGhpcyBvbmNl IHdlIGZpeCBidWcgIzY3NTEuCisKKyAgICAgICAgKiBld2svZXdrX2ZyYW1lLmNwcDoKKyAgICAg ICAgKGV3a19mcmFtZV9jaGlsZF9hZGQpOgorCiAyMDEwLTExLTAxICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24u CkluZGV4OiBXZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9lZmwvZXdrL2V3a19mcmFtZS5jcHAJKHJldmlzaW9uIDcwOTg2KQorKysgV2ViS2l0L2VmbC9l d2svZXdrX2ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyMywxMSArMTYyMywxMSBAQCBF dmFzX09iamVjdCogZXdrX2ZyYW1lX2NoaWxkX2FkZChFdmFzX09iCiAgICAgfQogCiAgICAgY2Yg PSBjaGlsZC5nZXQoKTsKLSAgICBzZC0+ZnJhbWUtPnRyZWUoKS0+YXBwZW5kQ2hpbGQoY2hpbGQp OwogICAgIGlmIChjZi0+dHJlZSgpKQogICAgICAgICBjZi0+dHJlZSgpLT5zZXROYW1lKG5hbWUp OwogICAgIGVsc2UKICAgICAgICAgRVJSKCJubyB0cmVlIGZvciBjaGlsZCBvYmplY3QiKTsKKyAg ICBzZC0+ZnJhbWUtPnRyZWUoKS0+YXBwZW5kQ2hpbGQoY2hpbGQpOwogCiAgICAgaWYgKCFld2tf ZnJhbWVfaW5pdChmcmFtZSwgc2QtPnZpZXcsIGNmKSkgewogICAgICAgICBldmFzX29iamVjdF9k ZWwoZnJhbWUpOwpJbmRleDogV2ViS2l0L2d0ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxMDY4KQorKysgV2ViS2l0L2d0ay9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMS0wMSAgRGFuaWVsIEJh dGVzICA8ZGJhdGVzQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2V0IGZyYW1lIG5hbWUgYmVmb3JlIGFwcGVuZGluZyBpdCB0byB0aGUg ZnJhbWUgdHJlZSBpbiB0aGUgQXBwbGUgV2luZG93cywKKyAgICAgICAgR1RLLCBhbmQgRUZMIHBv cnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODgw NgorCisgICAgICAgIE1ha2UgdGhlIGZyYW1lIGNyZWF0aW9uIHByb2Nlc3MgaW4gdGhlIEdUSy1w b3J0IGNvbnNpc3RlbnQgd2l0aCB0aGUKKyAgICAgICAgTWFjLCBRdCwgYW5kIEhhaWt1IHBvcnRz LiBJbiBwYXJ0aWN1bGFyLCB0aGUgc2V0IHRoZSBuYW1lIG9mIHRoZSBuZXcKKyAgICAgICAgZnJh bWUgYmVmb3JlIGl0J3MgYXBwZW5kZWQgdG8gdGhlIGZyYW1lIHRyZWUuCisKKyAgICAgICAgQXQg dGhpcyB0aW1lIHdlIGNhbm5vdCB0ZXN0IHRoaXMgY2hhbmdlIHNpbmNlIGl0IGlzIGJlaW5nIG1h c2tlZCBieQorICAgICAgICBIVE1MRnJhbWVFbGVtZW50QmFzZTo6c2V0TmFtZSgpIDxodHRwOi8v dHJhYy53ZWJraXQub3JnL2Jyb3dzZXIvdHJ1bmsvV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1l bnRCYXNlLmNwcD9yZXY9NzA5NzYjTDE2MD4uCisgICAgICAgIFdlJ2xsIGJlIGFibGUgdG8gdGVz dCB0aGlzIG9uY2Ugd2UgZml4IGJ1ZyAjNjc1MS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJD bGllbnQ6OmNyZWF0ZUZyYW1lKToKKwogMjAxMC0xMS0wMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmlu c29uLgpJbmRleDogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0 ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEd0ay5jcHAJKHJldmlzaW9uIDcwOTg2KQorKysgV2ViS2l0L2d0ay9XZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4NCw4ICs1 ODQsOCBAQCBQYXNzUmVmUHRyPEZyYW1lPiBGcmFtZUxvYWRlckNsaWVudDo6Y3JlCiAgICAgUmVm UHRyPEZyYW1lPiBjaGlsZEZyYW1lID0gRnJhbWU6OmNyZWF0ZShwYWdlLCBvd25lckVsZW1lbnQs IG5ldyBGcmFtZUxvYWRlckNsaWVudChraXRGcmFtZSkpOwogICAgIGZyYW1lUHJpdmF0ZS0+Y29y ZUZyYW1lID0gY2hpbGRGcmFtZS5nZXQoKTsKIAotICAgIHBhcmVudEZyYW1lLT50cmVlKCktPmFw cGVuZENoaWxkKGNoaWxkRnJhbWUpOwogICAgIGNoaWxkRnJhbWUtPnRyZWUoKS0+c2V0TmFtZShu YW1lKTsKKyAgICBwYXJlbnRGcmFtZS0+dHJlZSgpLT5hcHBlbmRDaGlsZChjaGlsZEZyYW1lKTsK ICAgICBjaGlsZEZyYW1lLT5pbml0KCk7CiAKICAgICAvLyBUaGUgY3JlYXRpb24gb2YgdGhlIGZy YW1lIG1heSBoYXZlIHJ1biBhcmJpdHJhcnkgSmF2YVNjcmlwdCB0aGF0IHJlbW92ZWQgaXQgZnJv bSB0aGUgcGFnZSBhbHJlYWR5LgpJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxMDY4KQorKysgV2ViS2l0L3dp bi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMS0wMSAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IGZyYW1lIG5hbWUgYmVmb3JlIGFwcGVuZGluZyBp dCB0byB0aGUgZnJhbWUgdHJlZSBpbiB0aGUgQXBwbGUgV2luZG93cywKKyAgICAgICAgR1RLLCBh bmQgRUZMIHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00ODgwNgorCisgICAgICAgIE1ha2UgdGhlIGZyYW1lIGNyZWF0aW9uIHByb2Nlc3MgaW4g dGhlIEFwcGxlIFdpbmRvd3MtcG9ydCBjb25zaXN0ZW50CisgICAgICAgIHdpdGggdGhlIE1hYywg UXQsIGFuZCBIYWlrdSBwb3J0cy4gSW4gcGFydGljdWxhciwgdGhlIHNldCB0aGUgbmFtZSBvZgor ICAgICAgICB0aGUgbmV3IGZyYW1lIGJlZm9yZSBpdCdzIGFwcGVuZGVkIHRvIHRoZSBmcmFtZSB0 cmVlLgorCisgICAgICAgIEF0IHRoaXMgdGltZSB3ZSBjYW5ub3QgdGVzdCB0aGlzIGNoYW5nZSBz aW5jZSBpdCBpcyBiZWluZyBtYXNrZWQgYnkKKyAgICAgICAgSFRNTEZyYW1lRWxlbWVudEJhc2U6 OnNldE5hbWUoKSA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL1dlYkNvcmUv aHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHA/cmV2PTcwOTc2I0wxNjA+LgorICAgICAgICBX ZSdsbCBiZSBhYmxlIHRvIHRlc3QgdGhpcyBvbmNlIHdlIGZpeCBidWcgIzY3NTEuCisKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChX ZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlRnJhbWUpOgorCiAyMDEwLTExLTAxICBCcmFkeSBF aWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMg Q2FybHNzb24uCkluZGV4OiBXZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVy Q2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcAkocmV2aXNpb24gNzA5ODYpCisrKyBXZWJLaXQvd2luL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzU0 LDggKzc1NCw4IEBAIFBhc3NSZWZQdHI8RnJhbWU+IFdlYkZyYW1lTG9hZGVyQ2xpZW50OjoKIAog ICAgIFJlZlB0cjxGcmFtZT4gY2hpbGRGcmFtZSA9IHdlYkZyYW1lLT5pbml0KG1fd2ViRnJhbWUt PndlYlZpZXcoKSwgY29yZUZyYW1lLT5wYWdlKCksIG93bmVyRWxlbWVudCk7CiAKLSAgICBjb3Jl RnJhbWUtPnRyZWUoKS0+YXBwZW5kQ2hpbGQoY2hpbGRGcmFtZSk7CiAgICAgY2hpbGRGcmFtZS0+ dHJlZSgpLT5zZXROYW1lKG5hbWUpOworICAgIGNvcmVGcmFtZS0+dHJlZSgpLT5hcHBlbmRDaGls ZChjaGlsZEZyYW1lKTsKICAgICBjaGlsZEZyYW1lLT5pbml0KCk7CiAKICAgICBjb3JlRnJhbWUt PmxvYWRlcigpLT5sb2FkVVJMSW50b0NoaWxkRnJhbWUoVVJMLCByZWZlcnJlciwgY2hpbGRGcmFt ZS5nZXQoKSk7Cg==