48593 2010-10-28 16:48:34 -0700 HTML5 Conformance Test failure: approved/xhtml5/html_style_in_comment.xhtml 2011-01-08 17:31:33 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://test.w3.org/html/tests/approved/xhtml5/html_style_in_comment.xhtml P2 Normal --- 48575 1 ddkilzer tonyg abarth ap commit-queue eric mike tonyg oldest_to_newest 301457 0 ddkilzer 2010-10-28 16:48:34 -0700 The approved/xhtml5/html_style_in_comment.xhtml test fails with WebKit nightly build r70732 run in Safari 5.0.x. 330420 1 tonyg 2011-01-06 14:18:11 -0800 Yeah, we don't match IE9 and FF4. I'll take a look. 330547 2 tonyg 2011-01-06 16:40:49 -0800 Does it makes sense to import these tests directly (similar to what we did with html5lib)? I'm thinking about adding only this test into a new directory with this patch: LayoutTests/w3html/xhtml5/html_style_in_comment.xhtml The idea being that LayoutTests/w3html/ would house the same structure as http://test.w3.org/html/tests/approved/ 330549 3 abarth 2011-01-06 16:46:48 -0800 Yeah, we've historically imported these test suites when the license allowed for it. 330553 4 tonyg 2011-01-06 16:55:55 -0800 (In reply to comment #3) > Yeah, we've historically imported these test suites when the license allowed for it. OTOH, this particular test kind of sucks because rather than displaying PASS or FAIL, it simply changes the color of some text. That forces it to be a pixel test instead of using dumpAsText(). I'm wondering if it wouldn't be better to just rewrite so they don't have to be pixel tests. :-( 330573 5 abarth 2011-01-06 17:40:03 -0800 Can we have a harness that looks inside and reads the computed style? 331013 6 78271 tonyg 2011-01-07 14:31:41 -0800 Created attachment 78271 Patch 331018 7 tonyg 2011-01-07 14:35:00 -0800 (In reply to comment #5) > Can we have a harness that looks inside and reads the computed style? After looking over the other tests in the suite, I decided to just go for an ad hoc test in this patch. Most of the tests don't seem to lend themselves well to our style of automated testing and it will be a slightly more involved task to come up with a scheme for running them. 331028 8 78271 eric 2011-01-07 14:51:48 -0800 Comment on attachment 78271 Patch Wow. Crazy. 331335 9 78271 commit-queue 2011-01-08 17:31:25 -0800 Comment on attachment 78271 Patch Clearing flags on attachment: 78271 Committed r75338: <http://trac.webkit.org/changeset/75338> 331336 10 commit-queue 2011-01-08 17:31:33 -0800 All reviewed patches have been landed. Closing bug. 78271 2011-01-07 14:31:41 -0800 2011-01-08 17:31:25 -0800 Patch bug-48593-20110107143140.patch text/plain 6165 tonyg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NDQ2ODQ1M2ZlZjEyNGQwMmI3YWI3ZDZiOTNlMWQ4NjcwOGM0ZmJlLi43NDkzMmUw ZGNkZGNmMzk0NDYwMDM4ZjM1ZGI2YWFmNjlmZGY5ZWU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDEtMDcgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIVE1MNSBDb25mb3Jt YW5jZSBUZXN0IGZhaWx1cmU6IGFwcHJvdmVkL3hodG1sNS9odG1sX3N0eWxlX2luX2NvbW1lbnQu eGh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4 NTkzCisKKyAgICAgICAgKiBmYXN0L3BhcnNlci9odG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1i bG9jay1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2VyL2h0bWwtaHRt bC1jb21tZW50LWluLXN0eWxlLWJsb2NrLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFy c2VyL3hodG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9jay1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvcGFyc2VyL3hodG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9j ay54aHRtbDogQWRkZWQuCisKIDIwMTEtMDEtMDcgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5j b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZDsgbmV3IHRlc3QgcmVzdWx0cyBh bmQgZXhwZWN0YXRpb25zIHVwZGF0ZXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3Bh cnNlci9odG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9jay1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L3BhcnNlci9odG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9jay1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNjljNzVkMDI2MTkwZTcxMTczYTM5Yjg0YmY0ZTJlM2M4OTVh MDhlNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2h0bWwtaHRt bC1jb21tZW50LWluLXN0eWxlLWJsb2NrLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1Ro aXMgcGFnZSB0ZXN0cyB0aGF0IHN0eWxlIHdyaXR0ZW4gaW5zaWRlIGFuIEhUTUwgY29tbWVudCBp cyBhcHBsaWVkLgorCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9o dG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9jay5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9w YXJzZXIvaHRtbC1odG1sLWNvbW1lbnQtaW4tc3R5bGUtYmxvY2suaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42 NzgyODUwMDg5YTA3YjA5YTUxN2NiOGJkNjc3ZTJmZGIzNmJjMzkyCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvaHRtbC1odG1sLWNvbW1lbnQtaW4tc3R5bGUtYmxv Y2suaHRtbApAQCAtMCwwICsxLDIyIEBACis8aHRtbD4NCis8aGVhZD4NCis8c2NyaXB0Pg0KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpDQorICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsNCis8L3NjcmlwdD4NCis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPg0KKy5w YXNzIHtkaXNwbGF5OiBub25lfQ0KKy5mYWlsIHtkaXNwbGF5OiBibG9ja30NCis8IS0tDQorLnBh c3Mge2Rpc3BsYXk6IGJsb2NrfQ0KKy5mYWlsIHtkaXNwbGF5OiBub25lfQ0KKy0tPg0KKzwvc3R5 bGU+DQorPC9oZWFkPg0KKzxib2R5Pg0KKzxwPlRoaXMgcGFnZSB0ZXN0cyB0aGF0IHN0eWxlIHdy aXR0ZW4gaW5zaWRlIGFuIEhUTUwgY29tbWVudCBpcyBhcHBsaWVkLg0KKzwvcD4NCis8c3BhbiBj bGFzcz0icGFzcyI+UEFTUzwvc3Bhbj4NCis8c3BhbiBjbGFzcz0iZmFpbCI+RkFJTDwvc3Bhbj4N Cis8L2JvZHk+DQorPC9odG1sPg0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcGFyc2Vy L3hodG1sLWh0bWwtY29tbWVudC1pbi1zdHlsZS1ibG9jay1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9mYXN0L3BhcnNlci94aHRtbC1odG1sLWNvbW1lbnQtaW4tc3R5bGUtYmxvY2stZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjliNjQzYzNhNDUzMDE0OTAyOGMyZTJjMzY5Mjc5MTI3MWM5YzQz N2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci94aHRtbC1odG1s LWNvbW1lbnQtaW4tc3R5bGUtYmxvY2stZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGhp cyBwYWdlIHRlc3RzIHRoYXQgc3R5bGUgd3JpdHRlbiBpbnNpZGUgYW4gSFRNTCBjb21tZW50IGlz IG5vdCBhcHBsaWVkLiBTZWU6IGh0dHA6Ly90ZXN0LnczLm9yZy9odG1sL3Rlc3RzL2FwcHJvdmVk L3hodG1sNS9odG1sX3N0eWxlX2luX2NvbW1lbnQueGh0bWwKKworUEFTUwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveGh0bWwtaHRtbC1jb21tZW50LWluLXN0eWxlLWJsb2Nr LnhodG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveGh0bWwtaHRtbC1jb21tZW50LWluLXN0 eWxlLWJsb2NrLnhodG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM5Njk3ZThjN2ZmZmFhMDFiYzY2MWI5YWU1Yjgz MDQ2OThiMzMxZjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci94 aHRtbC1odG1sLWNvbW1lbnQtaW4tc3R5bGUtYmxvY2sueGh0bWwKQEAgLTAsMCArMSwyMyBAQAor PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KKzxoZWFkPg0KKzxz Y3JpcHQ+DQoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikNCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOw0KKzwvc2NyaXB0Pg0KKzxzdHlsZSB0eXBlPSJ0ZXh0 L2NzcyI+DQorLnBhc3Mge2Rpc3BsYXk6IGJsb2NrfQ0KKy5mYWlsIHtkaXNwbGF5OiBub25lfQ0K KzwhLS0NCisucGFzcyB7ZGlzcGxheTogbm9uZX0NCisuZmFpbCB7ZGlzcGxheTogYmxvY2t9DQor LS0+DQorPC9zdHlsZT4NCis8L2hlYWQ+DQorPGJvZHk+DQorPHA+VGhpcyBwYWdlIHRlc3RzIHRo YXQgc3R5bGUgd3JpdHRlbiBpbnNpZGUgYW4gSFRNTCBjb21tZW50IGlzIG5vdCBhcHBsaWVkLiBT ZWU6DQoraHR0cDovL3Rlc3QudzMub3JnL2h0bWwvdGVzdHMvYXBwcm92ZWQveGh0bWw1L2h0bWxf c3R5bGVfaW5fY29tbWVudC54aHRtbA0KKzwvcD4NCis8c3BhbiBjbGFzcz0icGFzcyI+UEFTUzwv c3Bhbj4NCis8c3BhbiBjbGFzcz0iZmFpbCI+RkFJTDwvc3Bhbj4NCis8L2JvZHk+DQorPC9odG1s Pg0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggYmMyZTI0ODE0MWI2NDc4Yzk0ODExOThhYTEzMGViMDJlMDQyOWJjOS4uMDZkZThjMDNkZmE3 NmQ2MzU4ZjY5MTAzMzZjZmUwNTk5ZDViZjJiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wMS0wNyAg VG9ueSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUw1IENvbmZvcm1hbmNlIFRlc3QgZmFp bHVyZTogYXBwcm92ZWQveGh0bWw1L2h0bWxfc3R5bGVfaW5fY29tbWVudC54aHRtbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1OTMKKworICAgICAg ICBYSFRNTCA8c3R5bGU+IGJsb2NrcywgdW5saWtlIEhUTUwgPHN0eWxlPiBibG9ja3MsIHNob3Vs ZCByZXNwZWN0IEhUTUwKKyAgICAgICAgY29tbWVudHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9w YXJzZXIveGh0bWwtaHRtbC1jb21tZW50LWluLXN0eWxlLWJsb2NrLnhodG1sCisKKyAgICAgICAg KiBkb20vU3R5bGVFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzVmFsaWRTdHlsZUNo aWxkKTogUmVtb3ZlIHRoZSBDT01NRU5UX05PREUgY2hlY2sgYXMgdGhlIEhUTUwgcGFyc2VyIGRv ZXNuJ3QgYWRkIENPTU1FTlRfTk9ERXMgYXMgY2hpbGRyZW4gb2Ygc3R5bGUgYmxvY2tzLgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGVFbGVtZW50Ojpwcm9jZXNzKTogRmFjdG9yZWQgb3V0IGEgY29u ZGl0aW9uIHRoYXQgbXVzdCByZW1haW4gaW4gc3luYy4KKwogMjAxMS0wMS0wNyAgVGFrYXNoaSBU b3lvc2hpbWEgIDx0b3lvc2hpbUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtl bm5ldGggUnVzc2VsbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1N0eWxlRWxlbWVudC5jcHAg Yi9XZWJDb3JlL2RvbS9TdHlsZUVsZW1lbnQuY3BwCmluZGV4IDE1N2U4ZjlmNmI0MzY0MDZiYzhl MTQwYzFlYWI5OTY3ODI0N2MxNjQuLjMxYzA5NDdkZTE3NDJmZGVlNjUxMDk4ZDk2NTFjOTlmZmY3 ZTYyNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1N0eWxlRWxlbWVudC5jcHAKKysrIGIvV2Vi Q29yZS9kb20vU3R5bGVFbGVtZW50LmNwcApAQCAtMzAsNiArMzAsMTMgQEAKIAogbmFtZXNwYWNl IFdlYkNvcmUgewogCitzdGF0aWMgYm9vbCBpc1ZhbGlkU3R5bGVDaGlsZChOb2RlKiBub2RlKQor eworICAgIEFTU0VSVChub2RlKTsKKyAgICBOb2RlOjpOb2RlVHlwZSBub2RlVHlwZSA9IG5vZGUt Pm5vZGVUeXBlKCk7CisgICAgcmV0dXJuIG5vZGVUeXBlID09IE5vZGU6OlRFWFRfTk9ERSB8fCBu b2RlVHlwZSA9PSBOb2RlOjpDREFUQV9TRUNUSU9OX05PREU7Cit9CisgICAgCiBTdHlsZUVsZW1l bnQ6OlN0eWxlRWxlbWVudChEb2N1bWVudCogZG9jdW1lbnQsIGJvb2wgY3JlYXRlZEJ5UGFyc2Vy KQogICAgIDogbV9jcmVhdGVkQnlQYXJzZXIoY3JlYXRlZEJ5UGFyc2VyKQogICAgICwgbV9sb2Fk aW5nKGZhbHNlKQpAQCAtOTQsOCArMTAxLDcgQEAgdm9pZCBTdHlsZUVsZW1lbnQ6OnByb2Nlc3Mo RWxlbWVudCogZSkKIAogICAgIHVuc2lnbmVkIHJlc3VsdExlbmd0aCA9IDA7CiAgICAgZm9yIChO b2RlKiBjID0gZS0+Zmlyc3RDaGlsZCgpOyBjOyBjID0gYy0+bmV4dFNpYmxpbmcoKSkgewotICAg ICAgICBOb2RlOjpOb2RlVHlwZSBub2RlVHlwZSA9IGMtPm5vZGVUeXBlKCk7Ci0gICAgICAgIGlm IChub2RlVHlwZSA9PSBOb2RlOjpURVhUX05PREUgfHwgbm9kZVR5cGUgPT0gTm9kZTo6Q0RBVEFf U0VDVElPTl9OT0RFIHx8IG5vZGVUeXBlID09IE5vZGU6OkNPTU1FTlRfTk9ERSkKKyAgICAgICAg aWYgKGlzVmFsaWRTdHlsZUNoaWxkKGMpKQogICAgICAgICAgICAgcmVzdWx0TGVuZ3RoICs9IGMt Pm5vZGVWYWx1ZSgpLmxlbmd0aCgpOwogICAgIH0KICAgICBVQ2hhciogdGV4dDsKQEAgLTEwMyw4 ICsxMDksNyBAQCB2b2lkIFN0eWxlRWxlbWVudDo6cHJvY2VzcyhFbGVtZW50KiBlKQogCiAgICAg VUNoYXIqIHAgPSB0ZXh0OwogICAgIGZvciAoTm9kZSogYyA9IGUtPmZpcnN0Q2hpbGQoKTsgYzsg YyA9IGMtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgTm9kZTo6Tm9kZVR5cGUgbm9kZVR5cGUg PSBjLT5ub2RlVHlwZSgpOwotICAgICAgICBpZiAobm9kZVR5cGUgPT0gTm9kZTo6VEVYVF9OT0RF IHx8IG5vZGVUeXBlID09IE5vZGU6OkNEQVRBX1NFQ1RJT05fTk9ERSB8fCBub2RlVHlwZSA9PSBO b2RlOjpDT01NRU5UX05PREUpIHsKKyAgICAgICAgaWYgKGlzVmFsaWRTdHlsZUNoaWxkKGMpKSB7 CiAgICAgICAgICAgICBTdHJpbmcgbm9kZVZhbHVlID0gYy0+bm9kZVZhbHVlKCk7CiAgICAgICAg ICAgICB1bnNpZ25lZCBub2RlTGVuZ3RoID0gbm9kZVZhbHVlLmxlbmd0aCgpOwogICAgICAgICAg ICAgbWVtY3B5KHAsIG5vZGVWYWx1ZS5jaGFyYWN0ZXJzKCksIG5vZGVMZW5ndGggKiBzaXplb2Yo VUNoYXIpKTsK