48306 2010-10-25 22:53:13 -0700 Fix LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.html 2010-11-03 18:20:15 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 46506 0 mikelawther mdelaney7 excors mdelaney7 simon.fraser oldest_to_newest 299297 0 mikelawther 2010-10-25 22:53:13 -0700 This layout test fails. See master bug: https://bugs.webkit.org/show_bug.cgi?id=46506 304364 1 mdelaney7 2010-11-03 16:58:41 -0700 I believe this test is incorrect in the way that it creates an image that is supposed to have its complete attribute set to false. Per the spec, an <img> without a src attribute specified should have complete return true: "" The IDL attribute complete must return true if any of the following conditions is true: The src attribute is omitted. The src attribute's value is the empty string. The final task that is queued by the networking task source once the resource has been fetched has been queued, but has not yet been run, and the img element is not in the broken state. The img element is completely available. "" from http://dev.w3.org/html5/spec/Overview.html#dom-img-complete I'm going to modify the test to create the image and then set its src attribute to be a non-existent file. This will cause the image to have complete=false. 304384 2 72890 mdelaney7 2010-11-03 17:51:28 -0700 Created attachment 72890 Patch 304385 3 72890 darin 2010-11-03 17:55:01 -0700 Comment on attachment 72890 Patch How are we getting these test changes back to the original tests? 304388 4 mdelaney7 2010-11-03 18:02:51 -0700 By cc-ing philip! :-) I've been chatting with him off and on via IRC about these issues. He said he's quite busy but always wants to be CC-ed or informed about them so that we can incorporate them later. There's also an effort to get his most up-to-date versions of his tests since some of the ones we have are out of date. Though, as I run through individual tests, I'm making sure to sync up the tests that I post fixes for - hopefully that'll make syncing up with his new test versions easier. 304393 5 mdelaney7 2010-11-03 18:20:15 -0700 Committed r71292: <http://trac.webkit.org/changeset/71292> 72890 2010-11-03 17:51:28 -0700 2010-11-03 17:55:01 -0700 Patch bug-48306-20101103175127.patch text/plain 4069 mdelaney7 SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMjg5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDMgIE1hdHRoZXcgRGVsYW5leSAg PG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3 SW1hZ2UuaW5jb21wbGV0ZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00ODMwNgorCisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5k cmF3SW1hZ2UuaW5jb21wbGV0ZS5odG1sOiBNb2RpZmllZCB0ZXN0IHRvIGNvcnJlY3RseSBjcmVh dGUgYW4gaW1hZ2Ugb2JqZWN0IHdpdGggaXRzIGNvbXBsZXRlIGF0dHIgc2V0IHRvIGZhbHNlLgor ICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXBwaW5nIG5vdyBwYXNzaW5nIHRl c3RzLiBTYW1lIGZvciBiZWxvdy4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lw cGVkOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0v bWFjLXNub3dsZW9wYXJkL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLmluY29tcGxl dGUtZXhwZWN0ZWQudHh0OiBSZW1vdmVkIG9sZCBmYWlsaW5nIGV4cGVjdGF0aW9ucy4KKwogMjAx MC0xMS0wMyAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IExheW91dFRlc3RzL2NhbnZhcy9waGls aXAvdGVzdHMvMmQuZHJhd0ltYWdlLmluY29tcGxldGUuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5pbmNvbXBsZXRlLmh0bWwJ KHJldmlzaW9uIDcxMjY3KQorKysgTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5k cmF3SW1hZ2UuaW5jb21wbGV0ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBA IF9hZGRUZXN0KGZ1bmN0aW9uKGNhbnZhcywgY3R4KSB7CiBjdHguZmlsbFN0eWxlID0gJyMwZjAn OwogY3R4LmZpbGxSZWN0KDAsIDAsIDEwMCwgNTApOwogdmFyIGltZyA9IG5ldyBJbWFnZSgpOwor aW1nLnNyYyA9ICJOb3RBUmVhbEZpbGVOYW1lLnBuZyI7CiBfYXNzZXJ0U2FtZShpbWcuY29tcGxl dGUsIGZhbHNlLCAiaW1nLmNvbXBsZXRlIiwgImZhbHNlIik7CiBjdHguZHJhd0ltYWdlKGltZywg MCwgMCk7CiAKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiA3MTI2OCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01 MzU2LDcgKzUzNTYsNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmNvbXBvc2l0ZS51bmNvdmVy CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmNvbXBvc2l0ZS51bmNvdmVyZWQucGF0dGVybi5zb3Vy Y2UtaW4uaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5jb21wb3NpdGUudW5jb3ZlcmVkLnBh dHRlcm4uc291cmNlLW91dC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5i cm9rZW4uaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2UuaW5jb21wbGV0ZS5o dG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5udWxsLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNlLnN5c3RlbS5odG1sCiBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmZyb250Lmh0bWwKSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZAkocmV2aXNpb24gNzEyNjgpCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0x MTIsNyArMTEyLDYgQEAgcGxhdGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxpbmcvbW92ZS1jdXJzbwog CiAjIFNraXBwaW5nIGZhaWxpbmcgcGhpbGlwIGNhbnZhcyB0ZXN0cyBmcm9tIGh0dHA6Ly9waGls aXAuaHRtbDUub3JnL3Rlc3RzL2NhbnZhcy9zdWl0ZS90ZXN0cy8KIGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuZHJhd0ltYWdlLmJyb2tlbi5odG1sCi1jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJ bWFnZS5pbmNvbXBsZXRlLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLm51 bGwuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2Uuc3lzdGVtLmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJvbnQuaHRt bApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL2NhbnZhcy9waGls aXAvdGVzdHMvMmQuZHJhd0ltYWdlLmluY29tcGxldGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy1zbm93bGVvcGFyZC9jYW52YXMvcGhpbGlwL3Rl c3RzLzJkLmRyYXdJbWFnZS5pbmNvbXBsZXRlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNzEyNjcp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5kcmF3SW1hZ2UuaW5jb21wbGV0ZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTEsNyArMCwwIEBACi08IFtpbmRleF0gPgotMmQuZHJhd0ltYWdlLmluY29tcGxldGUKLVJl ZmVyZW5jZXM6IDJkLmRyYXdJbWFnZS5pbmNvbXBsZXRlLmltYWdlCi1BY3R1YWwgb3V0cHV0Ogot RXhwZWN0ZWQgb3V0cHV0OgotCi1GYWlsZWQgYXNzZXJ0aW9uIGltZy5jb21wbGV0ZSA9PT0gZmFs c2UgKGdvdCB0cnVlW2Jvb2xlYW5dLCBleHBlY3RlZCBmYWxzZVtib29sZWFuXSkKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNzEyNjgpCisrKyBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01MTc3LDcgKzUxNzcsNiBAQCBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLmNvbXBvc2l0ZS51bmNvdmVyCiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLmNvbXBvc2l0ZS51bmNvdmVyZWQucGF0dGVybi5zb3VyY2UtaW4uaHRtbAogY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5jb21wb3NpdGUudW5jb3ZlcmVkLnBhdHRlcm4uc291cmNlLW91dC5odG1s CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5icm9rZW4uaHRtbAotY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2UuaW5jb21wbGV0ZS5odG1sCiBjYW52YXMvcGhpbGlwL3Rl c3RzLzJkLmRyYXdJbWFnZS5udWxsLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZmlsbFN0 eWxlLnBhcnNlLnN5c3RlbS5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJh ZGlhbC5jb25lLmJlaGluZC5odG1sCg==