48277 2010-10-25 16:27:05 -0700 Fix canvas/philip/tests/2d.imageData.get.source.negative 2010-10-29 18:10:52 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 46506 0 mikelawther webkit-unassigned commit-queue jamesr mdelaney7 oliver oldest_to_newest 299178 0 mikelawther 2010-10-25 16:27:05 -0700 Update behaviour as per http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation: "The getImageData(sx, sy, sw, sh) method must return an ImageData object representing the underlying pixel data for the area of the canvas denoted by the rectangle whose corners are the four points (sx, sy), (sx+sw, sy), (sx+sw, sy+sh), (sx, sy+sh), in canvas coordinate space units." 299179 1 mikelawther 2010-10-25 16:28:40 -0700 Added block on master bug 299200 2 71821 mikelawther 2010-10-25 17:08:52 -0700 Created attachment 71821 Patch 299208 3 mikelawther 2010-10-25 17:25:32 -0700 Added jamesr to cc list. 299219 4 mdelaney7 2010-10-25 17:48:54 -0700 FWIW, this patch looks good to me. Though, does it end up making 2d.imageData.get.source.negative pass entirely on Mac? I note on my machine that the test fails 3 pixels of the imgdata1 and one of the imgdata2's pixels. Off the top of my head, I would guess that that imgdata2's pixel still fails. 299223 5 mikelawther 2010-10-25 18:06:08 -0700 I tested it on my Mac in Safari, and on Chromium Windows, and it passed entirely on both. run-webkit-tests also reported it passing correctly. Running the test in a current Chrome, I get: Failed assertion imgdata1.data["0"] === 255 (got 0[number], expected 255[number]) Failed assertion imgdata1.data["1"] === 255 (got 0[number], expected 255[number]) Failed assertion imgdata1.data["2"] === 255 (got 0[number], expected 255[number]) Failed assertion imgdata2.data["3"] === 0 (got 255[number], expected 0[number]) But running it in a patched Safari, I get it saying 'Passed', as per the expectations. 299242 6 mdelaney7 2010-10-25 19:33:42 -0700 Ok great. Make sure then to remove the test from the LayoutTests/platform/mac/Skipped list and that it still passes from run-webkit-tests. I had a patch out to unskip all the tests and reset the expectations, but it had some troubles with the bots and I need to resubmit. That should hopefully clear up future confusions about whether these tests are passing/failing and fixed or not. 299246 7 mikelawther 2010-10-25 19:42:09 -0700 Yep - the patch does remove the test from LayoutTests/platform/mac/Skipped (and also from chromium's test_expectations.txt, since I tested that platform too). 299986 8 mikelawther 2010-10-26 22:01:58 -0700 Adding Oliver to cc: Oliver: could you take a look at this patch? Thanks! 300383 9 71821 jamesr 2010-10-27 11:24:57 -0700 Comment on attachment 71821 Patch R=me. Thanks! 300400 10 71821 commit-queue 2010-10-27 11:40:29 -0700 Comment on attachment 71821 Patch Rejecting patch 71821 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 71821]" exit_code: 1 Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=71821&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=48277&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 71821 from bug 48277. ERROR: /Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4746045 302121 11 72402 mikelawther 2010-10-29 15:18:17 -0700 Created attachment 72402 Patch 302139 12 mdelaney7 2010-10-29 15:32:45 -0700 Since I landed the patch to (finally) stop skipping all those (including this) canvas tests on mac, if this patch fixes the mac failing expectations then you'll need to update that file as well. It's located at LayoutTests/platform/mac-snowleopard/canvas/philip… The mac-leopard skipped list currently contains this test so there's no need to update those expectations. Though, if this certainly fixes the problem on both snowleopard and leopard (likely the case) you can just get the expectation (of passing) file into LayoutTests/platform/mac/canvas/philip… in which case it'll apple to both leopard and snowleopard. 302146 13 mikelawther 2010-10-29 15:36:16 -0700 The patch does remove the snowleopard expectations file, since I can confirm that the test passes on snowleopard. I can't see why it wouldn't work on leopard, but since I didn't test it, I haven't touched those. 302159 14 mdelaney7 2010-10-29 15:57:19 -0700 Are you on IRC? I can't find you. I can explain the Skipped lists in more detail. Basically, if you have a fix (presumably) for all the ports, you'll just want to reset the project-wide expectations file (to now be passing) and then get rid of each port's expectation file if they have one. That way none of the test bots for those ports will show red on that test if the patch did indeed fix the bug. 302197 15 72402 commit-queue 2010-10-29 17:13:25 -0700 Comment on attachment 72402 Patch Clearing flags on attachment: 72402 Committed r70957: <http://trac.webkit.org/changeset/70957> 302198 16 commit-queue 2010-10-29 17:13:31 -0700 All reviewed patches have been landed. Closing bug. 302218 17 mikelawther 2010-10-29 18:10:52 -0700 Followup patch to remove entries in other ports Skipped files: https://bugs.webkit.org/show_bug.cgi?id=48702 71821 2010-10-25 17:08:52 -0700 2010-10-29 15:18:09 -0700 Patch bug-48277-20101026110849.patch text/plain 4705 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMjMxYjkwMzdlZDk0MTEwY2I2MjQzYTJiZDQyNGU2ZWU4YzIyOTI5Li4xZjBkZTFj OGM4OTQ3M2JiNmRiODQxMDllMmNlOWEwODUxNzdkZDg4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTAtMjUgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5u ZWdhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDgyNzcKKworICAgICAgICBSZW1vdmUgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEu Z2V0LnNvdXJjZS5uZWdhdGl2ZSBmcm9tIHNraXBwZWQuCisgICAgICAgIEFsc28gcmVtb3ZlIHNw dXJpb3VzIHRyYWlsaW5nIG5ld2xpbmVzIGZyb20gMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVn YXRpdmUtZXhwZWN0ZWQudHh0CisKKyAgICAgICAgKiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmlt YWdlRGF0YS5nZXQuc291cmNlLm5lZ2F0aXZlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisgICAgICAgICogcGxhdGZvcm0v bWFjL1NraXBwZWQ6CisKIDIwMTAtMTAtMjUgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHRlc3QgZXhwZWN0YXRpb25zIHVwZGF0ZS4gVGVt cG9yYXJpbHkgV2ViR0wgbGF5b3V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhp bGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5nZXQuc291cmNlLm5lZ2F0aXZlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2Uu bmVnYXRpdmUtZXhwZWN0ZWQudHh0CmluZGV4IGNiOGM0M2ZkNTBiMjI2NDk2NzlmY2Y1OWVmMTU1 NjkzOTI5MTFjNDIuLjNiODNiOTQ3ZTg4NWMxOGEzOGQyZWI0Mzc3MDZjMmVhNDllZjZkNmIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdl dC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2NhbnZhcy9w aGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0ZWQudHh0 CkBAIC00LDYgKzQsMyBAQCBnZXRJbWFnZURhdGEoKSB3b3JrcyB3aXRoIG5lZ2F0aXZlIHdpZHRo IGFuZCBoZWlnaHQsIGFuZCByZXR1cm5zIHRvcC10by1ib3R0b20gbAogUmVmZXJlbmNlczogMmQu aW1hZ2VEYXRhLmdldC5iYXNpYyAyZC5waXhlbGFycmF5Lm9yZGVyCiBBY3R1YWwgb3V0cHV0Ogog UGFzc2VkCi0KLQotCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggY2QwODVmNjRkYjI4NTg4NjY3ZTc2YmJiNzBjNWMxMWJk NmU1YzY3Yy4uZTU3YjE3MDBhMzdjZWFlYTljNzQwODRiZGVlNDYyMTNmNmY0N2ZlOCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dApAQCAtMjU1Myw3ICsyNTUzLDYgQEAgQlVHNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LmZpbGxTdHlsZS5wYXJzZS5jdXJyZW50LmJhc2ljLmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkx IDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuY3VycmVudC5jaGFuZ2Vk Lmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxs U3R5bGUucGFyc2UuY3VycmVudC5yZW1vdmVkLmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkxIDog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2Uuc3lzdGVtLmh0bWwgPSBURVhU IFBBU1MKLUJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNv dXJjZS5uZWdhdGl2ZS5odG1sID0gVEVYVCBQQVNTCiBCVUc0NTk5MSA6IGNhbnZhcy9waGlsaXAv dGVzdHMvMmQucGF0aC5yZWN0LndpbmRpbmcuaHRtbCA9IFRFWFQgUEFTUwogQlVHNDU5OTEgOiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UudW5kZWZpbmVkLmh0bWwgPSBURVhU IFBBU1MKIEJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuZ3JhZGllbnQu YWxwaGEuaHRtbCA9IFRFWFQgUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAppbmRleCBkZWM2 NDRmMzY5OTU2ODA2ZmQwOTViODc0NmI0ZDIyNGYxYzhlMjM0Li42NDYxMjJkNGI1ZTNiODIwNDU2 ODJhOTllOGM0Mjc5OWMxZjFhZjRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApAQCAtMTc3 LDcgKzE3Nyw2IEBAIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmluc2lk ZTMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwub3V0c2lkZTEu aHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuY3JlYXRlMS50eXBlLmh0bWwK IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmNyZWF0ZTIudHlwZS5odG1sCi1jYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5nZXQuc291cmNlLm5lZ2F0aXZlLmh0bWwKIGNh bnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2Uub3V0c2lkZS5odG1sCiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5nZXQudHlwZS5odG1sCiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLmxpbmUuY2FwLmNsb3NlZC5odG1sCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGZhNTg5MjVkOWIyYjIzNmRiOTU3N2U0 ZDE5YTU5ZmZiZjM0Nzg2MTUuLjlmZWI3MWQ3NDE3OWE1Yjg2ZmI3OTI3MzYzYTcwYjgyMDI4NjM3 M2YgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjUgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVy QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5u ZWdhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDgyNzcKKworICAgICAgICBIYW5kbGUgbmVnYXRpdmUgd2lkdGgvaGVpZ2h0LgorICAgICAgICBT ZWUgaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0 aXBhZ2UvdGhlLWNhbnZhcy1lbGVtZW50Lmh0bWwjcGl4ZWwtbWFuaXB1bGF0aW9uCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpnZXRJbWFnZURhdGEpOgorCiAyMDEw LTEwLTI1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgUXQgYnVpbGQgZml4IGZvciByNzA0OTYuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv Y2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFz L0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggYjFkN2IyMzNkMmI1YThlNmY3MDcz OWM2MDNlMTNlMjhkYTFlZTMzNy4uYTJkOWU5OGNhMzM4MjkyMjhlMDZmMjIwZmY3M2Q1NzI5ZDQw NzE0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmNwcApAQCAtMTU4Miw2ICsxNTgyLDE1IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRhPiBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmdldEltYWdlRGF0YShmbG9hdCBzeCwgZmxvYXQgc3ksCiAg ICAgICAgIHJldHVybiAwOwogICAgIH0KIAorICAgIGlmIChzdyA8IDApIHsKKyAgICAgICAgc3gg Kz0gc3c7CisgICAgICAgIHN3ID0gLXN3OworICAgIH0gICAgCisgICAgaWYgKHNoIDwgMCkgewor ICAgICAgICBzeSArPSBzaDsKKyAgICAgICAgc2ggPSAtc2g7CisgICAgfQorICAgIAogICAgIEZs b2F0UmVjdCB1bnNjYWxlZFJlY3Qoc3gsIHN5LCBzdywgc2gpOwogICAgIEludFJlY3Qgc2NhbGVk UmVjdCA9IGNhbnZhcygpLT5jb252ZXJ0TG9naWNhbFRvRGV2aWNlKHVuc2NhbGVkUmVjdCk7CiAg ICAgaWYgKHNjYWxlZFJlY3Qud2lkdGgoKSA8IDEpCg== 72402 2010-10-29 15:18:17 -0700 2010-10-29 17:13:25 -0700 Patch bug-48277-20101030091814.patch text/plain 5004 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwOWIxNjM4ODc1NzNjNDFkMzIwYjI2ZThjMjhlYzlkZGQ2OGJjMTRmLi5mNWM0ZmFm NjBmODJlMDY1YjkwYmJkYThlZjA4ZjE3ZDBjNjdjNzZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTAtMjUgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5uZWdhdGl2ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgyNzcKKworICAgICAgICBS ZW1vdmUgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5uZWdhdGl2 ZSBmcm9tIGNocm9taXVtIHNraXBwZWQuCisgICAgICAgIEFsc28gcmVtb3ZlIHNwdXJpb3VzIHRy YWlsaW5nIG5ld2xpbmVzIGZyb20gMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhw ZWN0ZWQudHh0CisKKyAgICAgICAgKiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5n ZXQuc291cmNlLm5lZ2F0aXZlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMTAtMjggIE1paGFpIFBhcnBhcml0 YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdl RGF0YS5nZXQuc291cmNlLm5lZ2F0aXZlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NhbnZh cy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0ZWQu dHh0CmluZGV4IGNiOGM0M2ZkNTBiMjI2NDk2NzlmY2Y1OWVmMTU1NjkzOTI5MTFjNDIuLjNiODNi OTQ3ZTg4NWMxOGEzOGQyZWI0Mzc3MDZjMmVhNDllZjZkNmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUt ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1h Z2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0ZWQudHh0CkBAIC00LDYgKzQsMyBAQCBn ZXRJbWFnZURhdGEoKSB3b3JrcyB3aXRoIG5lZ2F0aXZlIHdpZHRoIGFuZCBoZWlnaHQsIGFuZCBy ZXR1cm5zIHRvcC10by1ib3R0b20gbAogUmVmZXJlbmNlczogMmQuaW1hZ2VEYXRhLmdldC5iYXNp YyAyZC5waXhlbGFycmF5Lm9yZGVyCiBBY3R1YWwgb3V0cHV0OgogUGFzc2VkCi0KLQotCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggZjg3NjU0MDBhZGQ3NzczZGI3M2E3MTMxOGVmOGQzNjMzN2UwMGZkYS4uMTM5MTRhNDMy YzQ4NGNmMWFkM2JlMTQ2MTI3ODllOGJmODJmOWRmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMjU3MCw3ICsyNTcw LDYgQEAgQlVHNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJzZS5j dXJyZW50LmJhc2ljLmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuY3VycmVudC5jaGFuZ2VkLmh0bWwgPSBURVhUIFBBU1MK IEJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuY3VycmVu dC5yZW1vdmVkLmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5maWxsU3R5bGUucGFyc2Uuc3lzdGVtLmh0bWwgPSBURVhUIFBBU1MKLUJVRzQ1OTkxIDog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5uZWdhdGl2ZS5odG1s ID0gVEVYVCBQQVNTCiBCVUc0NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5yZWN0 LndpbmRpbmcuaHRtbCA9IFRFWFQgUEFTUwogQlVHNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLnBhdHRlcm4uaW1hZ2UudW5kZWZpbmVkLmh0bWwgPSBURVhUIFBBU1MKIEJVRzQ1OTkxIDog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuZ3JhZGllbnQuYWxwaGEuaHRtbCA9IFRFWFQg UEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL2Nh bnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL2NhbnZhcy9waGls aXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUtZXhwZWN0ZWQudHh0CmRl bGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAzZGZkM2JlMTQ0OWJlNTU4NGIzMmQwOTBiZTY3 ZGMwZTQxNjA4MjBhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1zbm93bGVvcGFyZC9jYW52YXMvcGhpbGlwL3Rl c3RzLzJkLmltYWdlRGF0YS5nZXQuc291cmNlLm5lZ2F0aXZlLWV4cGVjdGVkLnR4dAorKysgL2Rl di9udWxsCkBAIC0xLDkgKzAsMCBAQAotPCBbaW5kZXhdID4KLTJkLmltYWdlRGF0YS5nZXQuc291 cmNlLm5lZ2F0aXZlCi1nZXRJbWFnZURhdGEoKSB3b3JrcyB3aXRoIG5lZ2F0aXZlIHdpZHRoIGFu ZCBoZWlnaHQsIGFuZCByZXR1cm5zIHRvcC10by1ib3R0b20gbGVmdC10by1yaWdodAotUmVmZXJl bmNlczogMmQuaW1hZ2VEYXRhLmdldC5iYXNpYyAyZC5waXhlbGFycmF5Lm9yZGVyCi1BY3R1YWwg b3V0cHV0OgotRmFpbGVkIGFzc2VydGlvbiBpbWdkYXRhMS5kYXRhWyIwIl0gPT09IDI1NSAoZ290 IDBbbnVtYmVyXSwgZXhwZWN0ZWQgMjU1W251bWJlcl0pCi1GYWlsZWQgYXNzZXJ0aW9uIGltZ2Rh dGExLmRhdGFbIjEiXSA9PT0gMjU1IChnb3QgMFtudW1iZXJdLCBleHBlY3RlZCAyNTVbbnVtYmVy XSkKLUZhaWxlZCBhc3NlcnRpb24gaW1nZGF0YTEuZGF0YVsiMiJdID09PSAyNTUgKGdvdCAwW251 bWJlcl0sIGV4cGVjdGVkIDI1NVtudW1iZXJdKQotRmFpbGVkIGFzc2VydGlvbiBpbWdkYXRhMi5k YXRhWyIzIl0gPT09IDAgKGdvdCAyNTVbbnVtYmVyXSwgZXhwZWN0ZWQgMFtudW1iZXJdKQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjMTgy YTczMWVjY2M2NGFkYmYxZDU5Yzg3ZjlhMDc3NjA2OWY1MjA1Li5kZDI3ZmZiNDE5YzhmMTQxMjAz YmJkZDNhZWM5NzZhY2NmYmQ1OWY0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTEwLTI1ICBNaWtlIExh d3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1h Z2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ4Mjc3CisKKyAgICAgICAgSGFuZGxlIG5lZ2F0aXZlIHdpZHRo L2hlaWdodC4KKyAgICAgICAgU2VlIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBw cy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3RoZS1jYW52YXMtZWxlbWVudC5odG1sI3BpeGVsLW1h bmlwdWxhdGlvbgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Z2V0 SW1hZ2VEYXRhKToKKwogMjAxMC0xMC0yOCAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCBiMWQ3YjIz M2QyYjVhOGU2ZjcwNzM5YzYwM2UxM2UyOGRhMWVlMzM3Li5hMmQ5ZTk4Y2EzMzgyOTIyOGUwNmYy MjBmZjczZDU3MjlkNDA3MTQ1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC0xNTgyLDYgKzE1ODIsMTUgQEAgUGFzc1JlZlB0cjxJ bWFnZURhdGE+IENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Z2V0SW1hZ2VEYXRhKGZsb2F0IHN4 LCBmbG9hdCBzeSwKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCisgICAgaWYgKHN3IDwgMCkg eworICAgICAgICBzeCArPSBzdzsKKyAgICAgICAgc3cgPSAtc3c7CisgICAgfSAgICAKKyAgICBp ZiAoc2ggPCAwKSB7CisgICAgICAgIHN5ICs9IHNoOworICAgICAgICBzaCA9IC1zaDsKKyAgICB9 CisgICAgCiAgICAgRmxvYXRSZWN0IHVuc2NhbGVkUmVjdChzeCwgc3ksIHN3LCBzaCk7CiAgICAg SW50UmVjdCBzY2FsZWRSZWN0ID0gY2FudmFzKCktPmNvbnZlcnRMb2dpY2FsVG9EZXZpY2UodW5z Y2FsZWRSZWN0KTsKICAgICBpZiAoc2NhbGVkUmVjdC53aWR0aCgpIDwgMSkK