48224 2010-10-25 00:31:18 -0700 build-webkit: add support for --meter-tag switch 2010-10-27 10:04:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy yael aroben bfulgham ddkilzer oldest_to_newest 298746 0 ossy 2010-10-25 00:31:18 -0700 This feature is missing. ( revealed by https://bugs.webkit.org/show_bug.cgi?id=48185 ) Yael, could you fix it? Please make sure not to break any port with this new default value. 298801 1 ddkilzer 2010-10-25 05:16:55 -0700 (In reply to comment #0) > This feature is missing. ( revealed by https://bugs.webkit.org/show_bug.cgi?id=48185 ) > > Yael, could you fix it? Please make sure not to > break any port with this new default value. Do all ports have this enabled by default, or only some? 298805 2 ddkilzer 2010-10-25 05:25:03 -0700 (In reply to comment #1) > Do all ports have this enabled by default, or only some? It looks like GTK disables it in WebCore/GNUmakefile.am, but Qt, Chrome and Apple (Mac) have it enabled. 298811 3 71740 ddkilzer 2010-10-25 05:31:57 -0700 Created attachment 71740 Patch v1 Let the EWS bots check this. 299482 4 71740 ossy 2010-10-26 08:36:02 -0700 Comment on attachment 71740 Patch v1 All EWS' are green, except Win-EWS. (It is stucked.) I checked build systems, but it seems that meter tag is disabled on Windows too, because it is missing from FeatureDefines.vsprops. Otherwise LGTM, r=me if you set correct default value for Windows. 299483 5 ossy 2010-10-26 08:36:40 -0700 I'm going to file a new bug to fix FeatureDefines.vsprops . 299518 6 ddkilzer 2010-10-26 09:30:09 -0700 (In reply to comment #4) > (From update of attachment 71740 [details]) > All EWS' are green, except Win-EWS. (It is stucked.) > > I checked build systems, but it seems that meter tag > is disabled on Windows too, because it is missing from > FeatureDefines.vsprops. Otherwise LGTM, r=me if you set > correct default value for Windows. Okay. Which ports use the vcproj files? Or should I use: !isGtk() && !(isWindows() || isCygwin()) 299525 7 aroben 2010-10-26 09:43:14 -0700 (In reply to comment #6) > Which ports use the vcproj files? Apple's Windows port, the Cairo/CFLite/libcurl Windows port, and the WinCE port (I think). 299540 8 ossy 2010-10-26 10:03:08 -0700 > !isGtk() && !(isWindows() || isCygwin()) maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , because METER_TAG is enabled on Qt, but Qt port has Windows build. But ... it is soooo ugly ... 299544 9 aroben 2010-10-26 10:04:36 -0700 (In reply to comment #8) > > !isGtk() && !(isWindows() || isCygwin()) > maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , > because METER_TAG is enabled on Qt, but Qt port has Windows build. > > But ... it is soooo ugly ... !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. 299552 10 ossy 2010-10-26 10:19:08 -0700 (In reply to comment #9) > !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. OK, I hope we won't break any other ports. :) 299832 11 ddkilzer 2010-10-26 15:10:36 -0700 (In reply to comment #10) > (In reply to comment #9) > > !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. > > OK, I hope we won't break any other ports. :) The Qt Windows ports build with ENABLE_METER_TAG=1, so Adam's suggestion should work. The only port I'm not sure about is WinCairo because I can't find a recent-ish buildbot log for it. 299961 12 ddkilzer 2010-10-26 21:07:10 -0700 Committed r70606: <http://trac.webkit.org/changeset/70606> 299962 13 71740 ddkilzer 2010-10-26 21:07:53 -0700 Comment on attachment 71740 Patch v1 Clearing flags. 300308 14 bfulgham 2010-10-27 10:04:05 -0700 For historical completeness, I just wanted to comment that this change should be fine for the WinCairo port. 71740 2010-10-25 05:31:57 -0700 2010-10-26 21:07:52 -0700 Patch v1 bug-48224-20101025053155.patch text/plain 1586 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3M2JjOTdlNzE0YjliNzAyNmM0MTY1ZTk5MTUyNTA5ODQxNGNmMTE2Li5lOTQwMWEz Y2U5YjAzNmQ2Y2MzNmE5Y2VkZGNiMDcwYjQwMmVmY2MwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTAtMjUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAg ICA8aHR0cDovL3dlYmtpdC5vcmcvYi80ODIyND4gYnVpbGQtd2Via2l0OiBhZGQgc3VwcG9ydCBm b3IgLS1tZXRlci10YWcgc3dpdGNoCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogQWRkZWQgc3VwcG9ydCBmb3Ig LS1tZXRlci10YWcgc3dpdGNoLgorICAgICAgICBJdCBzaG91bGQgaGF2ZSBiZWVuIGFkZGVkIHdp dGggcjYwODIwLgorCiAyMDEwLTEwLTI1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0CmluZGV4IGNlOWVkNzViOTk1YTYxYzhlNmFkODgwZDYxMmE5MTdjMjhiOTA2 NWYuLjE1MDg1NWU0YWZiNDdlYTU1MzM5YWM1NTJiYTI1YWNjNjEwYzNmMWMgMTAwNzU1Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0CkBAIC04Miw2ICs4Miw3IEBAIG15ICgKICAgICAkamF2YVNjcmlwdERl YnVnZ2VyU3VwcG9ydCwKICAgICAkbGlua1ByZWZldGNoU3VwcG9ydCwKICAgICAkbWF0aG1sU3Vw cG9ydCwKKyAgICAkbWV0ZXJUYWdTdXBwb3J0LAogICAgICRub3RpZmljYXRpb25zU3VwcG9ydCwK ICAgICAkb2ZmbGluZVdlYkFwcGxpY2F0aW9uU3VwcG9ydCwKICAgICAkcHJvZ3Jlc3NUYWdTdXBw b3J0LApAQCAtMTgxLDYgKzE4Miw5IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9 PiAibWF0aG1sIiwgZGVzYyA9PiAiVG9nZ2xlIE1hdGhNTCBzdXBwb3J0IiwKICAgICAgIGRlZmlu ZSA9PiAiRU5BQkxFX01BVEhNTCIsIGRlZmF1bHQgPT4gMSwgdmFsdWUgPT4gXCRtYXRobWxTdXBw b3J0IH0sCiAKKyAgICB7IG9wdGlvbiA9PiAibWV0ZXItdGFnIiwgZGVzYyA9PiAiTWV0ZXIgVGFn IHN1cHBvcnQiLAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVfTUVURVJfVEFHIiwgZGVmYXVsdCA9 PiAhaXNHdGsoKSwgdmFsdWUgPT4gXCRtZXRlclRhZ1N1cHBvcnQgfSwKKwogICAgIHsgb3B0aW9u ID0+ICJub3RpZmljYXRpb25zIiwgZGVzYyA9PiAiVG9nZ2xlIERlc2t0b3AgTm90aWZpY2F0aW9u cyBTdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX05PVElGSUNBVElPTlMiLCBkZWZh dWx0ID0+IDAsIHZhbHVlID0+IFwkbm90aWZpY2F0aW9uc1N1cHBvcnQgfSwKIAo=