48185 2010-10-23 06:39:50 -0700 build-webkit: add support for --progress-tag switch 2010-10-25 00:31:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 36961 48184 48210 1 ddkilzer ddkilzer abarth aroben eric ossy webkit.review.bot yael oldest_to_newest 298381 0 ddkilzer 2010-10-23 06:39:50 -0700 build-webkit: add support for --progress-tag switch 298382 1 71639 ddkilzer 2010-10-23 06:43:34 -0700 Created attachment 71639 Patch v1 298567 2 ddkilzer 2010-10-24 07:00:10 -0700 Committed r70413: <http://trac.webkit.org/changeset/70413> 298616 3 webkit.review.bot 2010-10-24 10:06:07 -0700 http://trac.webkit.org/changeset/70413 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/spelling/context-menu-suggestions.html editing/spelling/spellcheck-attribute.html editing/spelling/spelling-backspace-between-lines.html editing/spelling/spelling-contenteditable.html editing/spelling/spelling-textarea.html platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html platform/mac/accessibility/misspelled-attributed-string.html 298643 4 ossy 2010-10-24 12:55:35 -0700 (In reply to comment #2) > Committed r70413: <http://trac.webkit.org/changeset/70413> It broke Qt minimal build with this error message: (Unfortunately buildbot was dead.) In file included from ../../../WebCore/html/HTMLMeterElement.cpp:32: ../../../WebCore/rendering/RenderMeter.h:35: error: expected class-name before ‘{’ token ../../../WebCore/rendering/RenderMeter.h: In function ‘WebCore::RenderMeter* WebCore::toRenderMeter(WebCore::RenderObject*)’: ../../../WebCore/rendering/RenderMeter.h:64: error: invalid static_cast from type ‘WebCore::RenderObject*’ to type ‘WebCore::RenderMeter*’ ../../../WebCore/html/HTMLMeterElement.cpp: In member function ‘virtual WebCore::RenderObject* WebCore::HTMLMeterElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*)’: ../../../WebCore/html/HTMLMeterElement.cpp:54: error: cannot convert ‘WebCore::RenderMeter*’ to ‘WebCore::RenderObject*’ in return g It was rolled out by http://trac.webkit.org/changeset/70423 . I'll check it later. 298644 5 71639 ossy 2010-10-24 12:56:10 -0700 Comment on attachment 71639 Patch v1 remove r+ from landed and rolled-out patch 298648 6 71696 ossy 2010-10-24 13:36:46 -0700 Created attachment 71696 proposed buildfix Before this patch: ENABLE_METER_TAG=1 ENABLE_PROGRESS_TAG=1 After this patch: ENABLE_METER_TAG=1 ENABLE_PROGRESS_TAG=0 There were build fail, because METER_TAG depends on PROGRESS_TAG: RenderMeter class inherited from RenderIndicator in rendering/RenderMeter.h But after this patch RenderIndicator.h wasn't included in RenderMeter.h It is only included undirectly by RenderProgress.h if PROGRESS_TAG is enabled. I don't think if METER_TAG needs PROGRESS_TAG, but RenderIndicator class. 298649 7 ossy 2010-10-24 13:37:24 -0700 (In reply to comment #6) > Before this patch: > After this patch: I mean before/after the original patch. 298651 8 ossy 2010-10-24 13:40:19 -0700 I think the original bug dependency set by sheriffbot was correct: This bug depends on Bug 48210 - REGRESSION(r70413): It broke Qt minimal build (Requested by Ossy on #webkit). and b48210 blocks this bug. 298653 9 ossy 2010-10-24 13:44:03 -0700 Yael, you added HTMLMeterElement in http://trac.webkit.org/changeset/59541. What do you think about my proposed fix ? All, what do you think if we should add default value for ENABLE_METER_TAG, same as for ENABLE_PROGRESS_TAG in http://trac.webkit.org/changeset/70413 ? 298654 10 71696 ddkilzer 2010-10-24 13:49:56 -0700 Comment on attachment 71696 proposed buildfix r=me. This is obviously correct because RenderMeter derives from RenderIndicator. 298655 11 ddkilzer 2010-10-24 13:50:55 -0700 (In reply to comment #9) > All, what do you think if we should add default value for ENABLE_METER_TAG, > same as for ENABLE_PROGRESS_TAG in http://trac.webkit.org/changeset/70413 ? That's fine. I didn't even realize meter-tag was missing a switch on build-webkit, too. 298675 12 yael 2010-10-24 17:31:21 -0700 (In reply to comment #9) > Yael, you added HTMLMeterElement in http://trac.webkit.org/changeset/59541. > What do you think about my proposed fix ? > Thanks for taking a quick action, Ossy :-) You could also remove #include "RemderProgress.h". RenderMeter does not really depend on RenderProgress. > All, what do you think if we should add default value for ENABLE_METER_TAG, > same as for ENABLE_PROGRESS_TAG in http://trac.webkit.org/changeset/70413 ? Is anyone doing this already? If not, I will do that tomorrow. 298744 13 ossy 2010-10-25 00:26:51 -0700 (In reply to comment #10) > (From update of attachment 71696 [details]) > r=me. This is obviously correct because RenderMeter derives from RenderIndicator. Landed in http://trac.webkit.org/changeset/70440. Additionally I removed needless #include "RemderProgress.h". Original patch relanded in http://trac.webkit.org/changeset/70441 298747 14 ossy 2010-10-25 00:31:50 -0700 (In reply to comment #12) > > All, what do you think if we should add default value for ENABLE_METER_TAG, > > same as for ENABLE_PROGRESS_TAG in http://trac.webkit.org/changeset/70413 ? > Is anyone doing this already? If not, I will do that tomorrow. new bug filed on it: https://bugs.webkit.org/show_bug.cgi?id=48224 71639 2010-10-23 06:43:34 -0700 2010-10-24 12:56:10 -0700 Patch v1 bug-48185-20101023064333.patch text/plain 1717 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyNzc1MjgzMDY3YzViOWNmMmI3OTQ3ZmYwZGZiYmE3Y2Y3NDc1MDdmLi4zYzAyNzA4 MTUyMTIyMmUxNTE1MjFmMWU1ZTg4N2Q3YjM0ZjM5ZWQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMTAtMjMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAgICAg ICA8aHR0cDovL3dlYmtpdC5vcmcvYi80ODE4NT4gYnVpbGQtd2Via2l0OiBhZGQgc3VwcG9ydCBm b3IgLS1wcm9ncmVzcy10YWcgc3dpdGNoCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogQWRkZWQgc3VwcG9ydCBm b3IgLS1wcm9ncmVzcy10YWcgc3dpdGNoLgorICAgICAgICBJdCBzaG91bGQgaGF2ZSBiZWVuIGFk ZGVkIHdpdGggcjU3MDUxLgorCisyMDEwLTEwLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNDgxODQ+IGJ1aWxkLXdl YmtpdDogcmVmb3JtYXQgc3VwcG9ydCB2YXJpYWJsZXMgZm9yIGJldHRlciBtYWludGFpbmFiaWxp dHkKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQKaW5kZXggNDk1ZTIzNjY2MmNiNjUxZWQyOGVhNWMyZjRkMmQ4ZTQ1NjE0OWFiYi4u NTZjMmQyNTZkNDNlZDQ3MTA2NjBlZTg2NjI4NzhkN2VhM2ExMGRjZCAxMDA3NTUKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9i dWlsZC13ZWJraXQKQEAgLTg0LDYgKzg0LDcgQEAgbXkgKAogICAgICRtYXRobWxTdXBwb3J0LAog ICAgICRub3RpZmljYXRpb25zU3VwcG9ydCwKICAgICAkb2ZmbGluZVdlYkFwcGxpY2F0aW9uU3Vw cG9ydCwKKyAgICAkcHJvZ3Jlc3NUYWdTdXBwb3J0LAogICAgICRydWJ5U3VwcG9ydCwKICAgICAk c2FuZGJveFN1cHBvcnQsCiAgICAgJHNoYXJlZFdvcmtlcnNTdXBwb3J0LApAQCAtMTg2LDYgKzE4 Nyw5IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9PiAib2ZmbGluZS13ZWItYXBw bGljYXRpb25zIiwgZGVzYyA9PiAiVG9nZ2xlIE9mZmxpbmUgV2ViIEFwcGxpY2F0aW9uIFN1cHBv cnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TIiwg ZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJG9mZmxpbmVXZWJBcHBsaWNhdGlvblN1cHBvcnQgfSwK IAorICAgIHsgb3B0aW9uID0+ICJwcm9ncmVzcy10YWciLCBkZXNjID0+ICJQcm9ncmVzcyBUYWcg c3VwcG9ydCIsCisgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9QUk9HUkVTU19UQUciLCBkZWZhdWx0 ID0+IDEsIHZhbHVlID0+IFwkcHJvZ3Jlc3NUYWdTdXBwb3J0IH0sCisKICAgICB7IG9wdGlvbiA9 PiAicnVieSIsIGRlc2MgPT4gIlRvZ2dsZSBIVE1MNSBSdWJ5IHN1cHBvcnQiLAogICAgICAgZGVm aW5lID0+ICJFTkFCTEVfUlVCWSIsIGRlZmF1bHQgPT4gMSwgdmFsdWUgPT4gXCRydWJ5U3VwcG9y dCB9LAogCg== 71696 2010-10-24 13:36:46 -0700 2010-10-24 13:49:56 -0700 proposed buildfix 1.patch text/plain 909 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDQyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggUXQgbWluaW1hbCBidWlsZCBicmVhayByZXZlYWxlZCBieSByNzA0MTMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE4NQorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlck1ldGVyLmg6IE1pc3NpbmcgaW5jbHVkZSBhZGRlZC4KKwogMjAx MC0xMC0yNCAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck1ldGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWV0ZXIuaAko cmV2aXNpb24gNzA0MTgpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZXRlci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMyw2ICsyMyw3IEBACiAKICNpZiBFTkFCTEUoTUVURVJfVEFHKQogI2lu Y2x1ZGUgIlJlbmRlckJsb2NrLmgiCisjaW5jbHVkZSAiUmVuZGVySW5kaWNhdG9yLmgiCiAjaW5j bHVkZSAiUmVuZGVyUHJvZ3Jlc3MuaCIgCiAjaW5jbHVkZSAiUmVuZGVyV2lkZ2V0LmgiCiAK