48172 2010-10-22 23:24:35 -0700 check-webkit-style script should be changed for WebKit2 2010-10-23 07:15:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 37369 1 amruthraj webkit-unassigned ravi.kasibhatla oldest_to_newest 298317 0 amruthraj 2010-10-22 23:24:35 -0700 Following changes are required for the check-webkit-style script for WebKit2: 1. config.h need not be the first header inclusion in WebKit2 files as we are following framework style inclusion 2. WebKit2/UIProcess/gtk/WebViewInternal.h and WebKit2/UIProcess/gtk/WebViewInternal.cpp should be allowed to follow GTK naming conventions. This depends on https://bugs.webkit.org/show_bug.cgi?id=37369 Added a patch for the same. 298318 1 71623 amruthraj 2010-10-22 23:27:22 -0700 Created attachment 71623 Filtering files which have followed GTK naming convention Filtering files which have followed GTK naming convention from checker.py 298385 2 71623 ddkilzer 2010-10-23 07:14:59 -0700 Comment on attachment 71623 Filtering files which have followed GTK naming convention View in context: https://bugs.webkit.org/attachment.cgi?id=71623&action=review r- to fix the ChangeLog. Otherwise this looks fine. > WebKitTools/ChangeLog:1 > +2010-10-22 Amruth Raj/Ravi Kasibhatla <amruthraj@motorola.com/ravi.kasibhatla@motorola.com> Please reformat authors and email addresses: 2010-10-22 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com> > WebKitTools/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + > + Adding the WebKit2/UIProcess/gtk as a exception for style checking. > + The folder has two files WebViewInternal.h and WebViewInternal.cpp > + which follow GTK naming convention. Please add the bug title and a link to the bug in the ChangeLog. 71623 2010-10-22 23:27:22 -0700 2010-10-23 07:14:58 -0700 Filtering files which have followed GTK naming convention StyleCheckChange.patch text/plain 2184 amruthraj SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMDk4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjIgIEFtcnV0aCBSYWovUmF2aSBL YXNpYmhhdGxhICA8YW1ydXRocmFqQG1vdG9yb2xhLmNvbS9yYXZpLmthc2liaGF0bGFAbW90b3Jv bGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGluZyB0aGUgV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrIGFzIGEgZXhjZXB0aW9uIGZvciBzdHls ZSBjaGVja2luZy4KKyAgICAgICAgVGhlIGZvbGRlciBoYXMgdHdvIGZpbGVzIFdlYlZpZXdJbnRl cm5hbC5oIGFuZCBXZWJWaWV3SW50ZXJuYWwuY3BwCisgICAgICAgIHdoaWNoIGZvbGxvdyBHVEsg bmFtaW5nIGNvbnZlbnRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXIucHk6IEFkZGVkIHRoZSBleGNlcHRpb24gb2YgZm9sZGVyIFdlYktpdDIvVUlQcm9jZXNz L2d0ayBmb3IgR1RLIG5hbWluZyBjb252ZW50aW9uLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weTogQWRkZWQgYSB1bml0IHRlc3QgY2FzZSBhc3Nl cnROb0NoZWNrIGZvciBXZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViVmlld0ludGVybmFsLmgKKwog MjAxMC0xMC0xOSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXIucHkJKHJldmlzaW9uIDcwMDk4KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsNiArMTM2LDcgQEAgX1BB VEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICAgIyBBbHNvLCBHVEsrIGFsbG93cyB0aGUgdXNl IG9mIE5VTEwuCiAgICAgICAiV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdCIs CiAgICAgICAiV2ViS2l0L2d0ay93ZWJraXQvIiwKKyAgICAgICJXZWJLaXQyL1VJUHJvY2Vzcy9n dGsvIiwKICAgICAgICJXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvIl0sCiAgICAgIFsi LXJlYWRhYmlsaXR5L25hbWluZyIsCiAgICAgICAiLXJlYWRhYmlsaXR5L251bGwiXSksCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA3MDA5OCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjIyLDYg KzIyMiw4IEBAIGNsYXNzIEdsb2JhbFZhcmlhYmxlc1Rlc3QodW5pdHRlc3QuVGVzdEMKICAgICAg ICAgICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWluZyIpCiAgICAgICAgIGFzc2VydE5vQ2hl Y2soIldlYktpdC9ndGsvd2Via2l0L3dlYmtpdC5oIiwKICAgICAgICAgICAgICAgICAgICAgICAi cmVhZGFiaWxpdHkvbmFtaW5nIikKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiV2ViS2l0Mi9VSVBy b2Nlc3MvZ3RrL1dlYlZpZXdJbnRlcm5hbC5oIiwKKyAgICAgICAgICAgICAgICAgICAgICAicmVh ZGFiaWxpdHkvbmFtaW5nIikKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCIsCiAgICAgICAgICAgICAgICAgICAg ICAgInJlYWRhYmlsaXR5L251bGwiKQogICAgICAgICBhc3NlcnROb0NoZWNrKCJXZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5oIiwK