48150 2010-10-22 13:21:17 -0700 [Mac] LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs 2010-11-17 08:48:44 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46905 1 cshu cshu commit-queue tonikitoo oldest_to_newest 298142 0 cshu 2010-10-22 13:21:17 -0700 The above test hangs on Mac. For some reason, a visible graphic popup shows up during the DRT testing and it waits for input. 306812 1 73381 cshu 2010-11-09 08:38:23 -0800 Created attachment 73381 fix patch Here is basically what I did in this patch: When ARROW_KEYS_POP_MENU is defined, which is the case on Mac, do up/down key pop menu only when spatial navigation is not enabled. And when spatial navigation is enabled, do the work flow as if ARROW_KEYS_POP_MENU is not defined so that selecting items is allowed. 310313 2 73381 commit-queue 2010-11-17 08:48:38 -0800 Comment on attachment 73381 fix patch Clearing flags on attachment: 73381 Committed r72210: <http://trac.webkit.org/changeset/72210> 310314 3 commit-queue 2010-11-17 08:48:44 -0800 All reviewed patches have been landed. Closing bug. 73381 2010-11-09 08:38:23 -0800 2010-11-17 08:48:38 -0800 fix patch 48150_1.patch text/plain 4883 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTYzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDkgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW01h Y10gU3VwcHJlc3Mgc2luZ2xlIHNlbGVjdCBwb3B1cCBtZW51IHdoZW4gc3BhdGlhbCBuYXZpZ2F0 aW9uIGlzIGVuYWJsZWQgb24gTWFjLgorICAgICAgICBUaGlzIG1ha2VzIHNwYXRpYWwgbmF2aWdh dGlvbiB3b3JrIHByb3Blcmx5IGZvciBzaW5nbGUgc2VsZWN0IGJveC4KKworICAgICAgICBUZXN0 OiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1zaW5nbGUtc2VsZWN0Lmh0bWwK KworICAgICAgICAqIGRvbS9TZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5l eHRWYWxpZEluZGV4KToKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdEVsZW1lbnQ6Om1lbnVMaXN0 RGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMTAtMTEtMDkgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpJbmRleDogV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5jcHAJKHJldmlzaW9uIDcxNjM1KQorKysgV2Vi Q29yZS9kb20vU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxMiw3ICs1MTIs NiBAQCB2b2lkIFNlbGVjdEVsZW1lbnQ6OnJlc2V0KFNlbGVjdEVsZW1lbnRECiAgICAgZWxlbWVu dC0+c2V0TmVlZHNTdHlsZVJlY2FsYygpOwogfQogICAgIAotI2lmICFBUlJPV19LRVlTX1BPUF9N RU5VCiBlbnVtIFNraXBEaXJlY3Rpb24gewogICAgIFNraXBCYWNrd2FyZHMgPSAtMSwKICAgICBT a2lwRm9yd2FyZHMgPSAxCkBAIC01MzMsNyArNTMyLDYgQEAgc3RhdGljIGludCBuZXh0VmFsaWRJ bmRleChjb25zdCBWZWN0b3I8RQogICAgIH0KICAgICByZXR1cm4gbGFzdEdvb2RJbmRleDsKIH0K LSNlbmRpZgogCiB2b2lkIFNlbGVjdEVsZW1lbnQ6Om1lbnVMaXN0RGVmYXVsdEV2ZW50SGFuZGxl cihTZWxlY3RFbGVtZW50RGF0YSYgZGF0YSwgRWxlbWVudCogZWxlbWVudCwgRXZlbnQqIGV2ZW50 LCBIVE1MRm9ybUVsZW1lbnQqIGh0bWxGb3JtKQogewpAQCAtNTQ1LDIwICs1NDMsMjQgQEAgdm9p ZCBTZWxlY3RFbGVtZW50OjptZW51TGlzdERlZmF1bHRFdmVudAogICAgICAgICBib29sIGhhbmRs ZWQgPSBmYWxzZTsKIAogI2lmIEFSUk9XX0tFWVNfUE9QX01FTlUKLSAgICAgICAgaWYgKGtleUlk ZW50aWZpZXIgPT0gIkRvd24iIHx8IGtleUlkZW50aWZpZXIgPT0gIlVwIikgewotICAgICAgICAg ICAgZWxlbWVudC0+Zm9jdXMoKTsKLQotICAgICAgICAgICAgaWYgKCFlbGVtZW50LT5yZW5kZXJl cigpKSAvLyBDYWxsaW5nIGZvY3VzKCkgbWF5IGNhdXNlIHVzIHRvIGxvc2Ugb3VyIHJlbmRlcmVy LCBpbiB3aGljaCBjYXNlIGRvIG5vdCB3YW50IHRvIGhhbmRsZSB0aGUgZXZlbnQuCi0gICAgICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAoIWlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVk KGVsZW1lbnQtPmRvY3VtZW50KCktPmZyYW1lKCkpKSB7CisgICAgICAgICAgICBpZiAoa2V5SWRl bnRpZmllciA9PSAiRG93biIgfHwga2V5SWRlbnRpZmllciA9PSAiVXAiKSB7CisgICAgICAgICAg ICAgICAgZWxlbWVudC0+Zm9jdXMoKTsKKworICAgICAgICAgICAgICAgIGlmICghZWxlbWVudC0+ cmVuZGVyZXIoKSkgLy8gQ2FsbGluZyBmb2N1cygpIG1heSBjYXVzZSB1cyB0byBsb3NlIG91ciBy ZW5kZXJlciwgaW4gd2hpY2ggY2FzZSBkbyBub3Qgd2FudCB0byBoYW5kbGUgdGhlIGV2ZW50Lgor ICAgICAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgICAgICAvLyBTYXZlIHRo ZSBzZWxlY3Rpb24gc28gaXQgY2FuIGJlIGNvbXBhcmVkIHRvIHRoZSBuZXcgc2VsZWN0aW9uIHdo ZW4gZGlzcGF0Y2hpbmcgY2hhbmdlIGV2ZW50cyBkdXJpbmcgc2V0U2VsZWN0ZWRJbmRleCwKKyAg ICAgICAgICAgICAgICAvLyB3aGljaCBnZXRzIGNhbGxlZCBmcm9tIFJlbmRlck1lbnVMaXN0Ojp2 YWx1ZUNoYW5nZWQsIHdoaWNoIGdldHMgY2FsbGVkIGFmdGVyIHRoZSB1c2VyIG1ha2VzIGEgc2Vs ZWN0aW9uIGZyb20gdGhlIG1lbnUuCisgICAgICAgICAgICAgICAgc2F2ZUxhc3RTZWxlY3Rpb24o ZGF0YSwgZWxlbWVudCk7CisgICAgICAgICAgICAgICAgaWYgKFJlbmRlck1lbnVMaXN0KiBtZW51 TGlzdCA9IHRvUmVuZGVyTWVudUxpc3QoZWxlbWVudC0+cmVuZGVyZXIoKSkpCisgICAgICAgICAg ICAgICAgICAgIG1lbnVMaXN0LT5zaG93UG9wdXAoKTsKIAotICAgICAgICAgICAgLy8gU2F2ZSB0 aGUgc2VsZWN0aW9uIHNvIGl0IGNhbiBiZSBjb21wYXJlZCB0byB0aGUgbmV3IHNlbGVjdGlvbiB3 aGVuIGRpc3BhdGNoaW5nIGNoYW5nZSBldmVudHMgZHVyaW5nIHNldFNlbGVjdGVkSW5kZXgsCi0g ICAgICAgICAgICAvLyB3aGljaCBnZXRzIGNhbGxlZCBmcm9tIFJlbmRlck1lbnVMaXN0Ojp2YWx1 ZUNoYW5nZWQsIHdoaWNoIGdldHMgY2FsbGVkIGFmdGVyIHRoZSB1c2VyIG1ha2VzIGEgc2VsZWN0 aW9uIGZyb20gdGhlIG1lbnUuCi0gICAgICAgICAgICBzYXZlTGFzdFNlbGVjdGlvbihkYXRhLCBl bGVtZW50KTsKLSAgICAgICAgICAgIGlmIChSZW5kZXJNZW51TGlzdCogbWVudUxpc3QgPSB0b1Jl bmRlck1lbnVMaXN0KGVsZW1lbnQtPnJlbmRlcmVyKCkpKQotICAgICAgICAgICAgICAgIG1lbnVM aXN0LT5zaG93UG9wdXAoKTsKLSAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOworICAgICAgICAg ICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0jZWxzZQorI2VuZGlmCiAgICAgICAgIC8vIFdoZW4g dXNpbmcgc3BhdGlhbCBuYXZpZ2F0aW9uLCB3ZSB3YW50IHRvIGJlIGFibGUgdG8gbmF2aWdhdGUg YXdheSBmcm9tIHRoZSBzZWxlY3QgZWxlbWVudAogICAgICAgICAvLyB3aGVuIHRoZSB1c2VyIGhp dHMgYW55IG9mIHRoZSBhcnJvdyBrZXlzLCBpbnN0ZWFkIG9mIGNoYW5naW5nIHRoZSBzZWxlY3Rp b24uCiAgICAgICAgIGlmIChpc1NwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChlbGVtZW50LT5kb2N1 bWVudCgpLT5mcmFtZSgpKSkKQEAgLTU5MSw3ICs1OTMsNyBAQCB2b2lkIFNlbGVjdEVsZW1lbnQ6 Om1lbnVMaXN0RGVmYXVsdEV2ZW50CiAgICAgICAgIAogICAgICAgICBpZiAoaGFuZGxlZCAmJiBs aXN0SW5kZXggPj0gMCAmJiAodW5zaWduZWQpbGlzdEluZGV4IDwgbGlzdEl0ZW1zLnNpemUoKSkK ICAgICAgICAgICAgIHNldFNlbGVjdGVkSW5kZXgoZGF0YSwgZWxlbWVudCwgbGlzdFRvT3B0aW9u SW5kZXgoZGF0YSwgZWxlbWVudCwgbGlzdEluZGV4KSk7Ci0jZW5kaWYKKwogICAgICAgICBpZiAo aGFuZGxlZCkKICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAgIH0K SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxNjM1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDkgIENoYW5nIFNodSAgPGNoYW5n LnNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW01hY10gVW5za2lwIHRoZSB0ZXN0IHRoYXQgaXMgcGFzc2luZyBub3cuCisKKyAg ICAgICAgVGVzdDogZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2luZ2xlLXNl bGVjdC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKwogMjAxMC0xMS0w OSAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkIENocm9taXVtIHJlYmFzZWxpbmVzLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBw ZWQJKHJldmlzaW9uIDcxNTE4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQJ KHdvcmtpbmcgY29weSkKQEAgLTI2NSw5ICsyNjUsNiBAQCBmYXN0L2V2ZW50cy9zcGF0aWFsLW5h dmlnYXRpb24vc25hdi1pZnJhCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NzQ0OQogZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtdW5pdC1vdmVy Zmxvdy1hbmQtc2Nyb2xsLWluLWRpcmVjdGlvbi5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTUwCi1mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRp b24vc25hdi1zaW5nbGUtc2VsZWN0Lmh0bWwKLQogIyBSZXF1aXJlcyBXZWJQIHN1cHBvcnQuCiBm YXN0L2ltYWdlcy93ZWJwLWltYWdlLWRlY29kaW5nLmh0bWwKIAo=