48145 2010-10-22 11:58:24 -0700 LayoutTests/fast/events/spatial-navigation/snav-multiple-select.html fails 2010-11-01 18:57:03 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 48134 46905 1 cshu cshu commit-queue tonikitoo webkit.review.bot yael oldest_to_newest 298099 0 cshu 2010-10-22 11:58:24 -0700 The above test case fails when running the test case from a browser. It was working in DRT by mistake. After bug 48134 is fixed, the failure is unveiled. 298623 1 yael 2010-10-24 10:53:42 -0700 I think this test should be removed. The support I added for multi select is only for the case when ENABLE_NO_LISTBOX_RENDERING is defined, and we cannot test that in a layout test. Due to the bug in the test infrastructure, I did not catch this. (sorry about that :-). We already have manual tests that can test multi-select with ENABLE_NO_LISTBOX_RENDERING turned on, and we already have a bug report for adding support when the flag is not turned on https://bugs.webkit.org/show_bug.cgi?id=47094 . 302641 2 72502 cshu 2010-11-01 06:40:26 -0700 Created attachment 72502 fix patch 302643 3 cshu 2010-11-01 06:41:59 -0700 (In reply to comment #1) > I think this test should be removed. The support I added for multi select is only for the case when ENABLE_NO_LISTBOX_RENDERING is defined, and we cannot test that in a layout test. > Due to the bug in the test infrastructure, I did not catch this. (sorry about that :-). > > We already have manual tests that can test multi-select with ENABLE_NO_LISTBOX_RENDERING turned on, and we already have a bug report for adding support when the flag is not turned on https://bugs.webkit.org/show_bug.cgi?id=47094 . This test can still be valid for 47094. 302644 4 webkit.review.bot 2010-11-01 06:43:49 -0700 Attachment 72502 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/dom/SelectElement.cpp:768: Missing spaces around | [whitespace/operators] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 302654 5 yael 2010-11-01 07:26:14 -0700 (In reply to comment #3) > (In reply to comment #1) > > I think this test should be removed. The support I added for multi select is only for the case when ENABLE_NO_LISTBOX_RENDERING is defined, and we cannot test that in a layout test. > > Due to the bug in the test infrastructure, I did not catch this. (sorry about that :-). > > > > We already have manual tests that can test multi-select with ENABLE_NO_LISTBOX_RENDERING turned on, and we already have a bug report for adding support when the flag is not turned on https://bugs.webkit.org/show_bug.cgi?id=47094 . > > This test can still be valid for 47094. After this patch, can the user navigate out of the select list _without_ changing the selected item? 302659 6 72502 tonikitoo 2010-11-01 07:30:28 -0700 Comment on attachment 72502 fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=72502&action=review Thanks for fixing this! > WebCore/dom/SelectElement.cpp:768 > + if (keyIdentifier == "Left" || keyIdentifier == "Right"|| ((keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex == data.activeSelectionEndIndex())) Maybe we could have a helper method for this part (keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex == data.activeSelectionEndIndex() just to make it clear what is going on? 302660 7 cshu 2010-11-01 07:31:58 -0700 (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #1) > > > I think this test should be removed. The support I added for multi select is only for the case when ENABLE_NO_LISTBOX_RENDERING is defined, and we cannot test that in a layout test. > > > Due to the bug in the test infrastructure, I did not catch this. (sorry about that :-). > > > > > > We already have manual tests that can test multi-select with ENABLE_NO_LISTBOX_RENDERING turned on, and we already have a bug report for adding support when the flag is not turned on https://bugs.webkit.org/show_bug.cgi?id=47094 . > > > > This test can still be valid for 47094. > > After this patch, can the user navigate out of the select list _without_ changing the selected item? No. A complete support will follow up and probably attach to 47094. 302661 8 cshu 2010-11-01 07:33:05 -0700 (In reply to comment #6) > (From update of attachment 72502 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72502&action=review > > Thanks for fixing this! > > > WebCore/dom/SelectElement.cpp:768 > > + if (keyIdentifier == "Left" || keyIdentifier == "Right"|| ((keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex == data.activeSelectionEndIndex())) > > Maybe we could have a helper method for this part > > (keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex == data.activeSelectionEndIndex() > > just to make it clear what is going on? Thanks for the review. I will change accordingly. 302753 9 72517 cshu 2010-11-01 09:54:31 -0700 Created attachment 72517 fix patch 2 Fixed coding style and added comments. 302762 10 72517 tonikitoo 2010-11-01 10:18:55 -0700 Comment on attachment 72517 fix patch 2 r=me 303018 11 commit-queue 2010-11-01 16:03:16 -0700 The commit-queue encountered the following flaky tests while processing attachment 72517: fast/events/platform-wheelevent-in-scrolling-div.html fast/text/international/vertical-text-glyph-test.html Please file bugs against the tests. These tests were authored by aestes@apple.com and jamesr@chromium.org. The commit-queue is continuing to process your patch. 303157 12 72517 commit-queue 2010-11-01 18:56:57 -0700 Comment on attachment 72517 fix patch 2 Clearing flags on attachment: 72517 Committed r71094: <http://trac.webkit.org/changeset/71094> 303158 13 commit-queue 2010-11-01 18:57:03 -0700 All reviewed patches have been landed. Closing bug. 72502 2010-11-01 06:40:26 -0700 2010-11-01 09:54:31 -0700 fix patch 48145_1.patch text/plain 4492 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDgwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVh dmUgU2VsZWN0RWxlbWVudCBrZXkgaGFuZGxpbmcgd2l0aG91dCBzZXR0aW5nIGV2ZW50IGRlZmF1 bHQKKyAgICAgICAgaGFuZGxlZCB3aGVuIHRoZSBzZWxlY3Rpb24gcmVhY2hlcyB0aGUgYm91bmRh cnkgc28gZm9jdXMgY2FuIAorICAgICAgICBtb3ZlIHRvIG5laWdoYm9yIG5vZGVzIGluIHNwYXRp YWwgbmF2aWdhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4MTQ1CisKKyAgICAgICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpsaXN0Qm94RGVmYXVsdEV2ZW50SGFuZGxlcik6CisK IDIwMTAtMTAtMjggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9kb20vU2Vs ZWN0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5j cHAJKHJldmlzaW9uIDcwNzk4KQorKysgV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc2Miw3ICs3NjIsMTQgQEAgdm9pZCBTZWxlY3RFbGVtZW50OjpsaXN0 Qm94RGVmYXVsdEV2ZW50SAogICAgICAgICAgICAgZWxzZSBpZiAoa2V5SWRlbnRpZmllciA9PSAi VXAiKQogICAgICAgICAgICAgICAgIGVuZEluZGV4ID0gcHJldmlvdXNTZWxlY3RhYmxlTGlzdElu ZGV4KGRhdGEsIGVsZW1lbnQsIGRhdGEuYWN0aXZlU2VsZWN0aW9uRW5kSW5kZXgoKSk7ICAgIAog ICAgICAgICB9Ci0gICAgICAgIAorCisgICAgICAgIGlmIChGcmFtZSogZnJhbWUgPSBlbGVtZW50 LT5kb2N1bWVudCgpLT5mcmFtZSgpKSB7CisgICAgICAgICAgICBpZiAoZnJhbWUtPnNldHRpbmdz KCkgJiYgZnJhbWUtPnNldHRpbmdzKCktPmlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKCkpIHsK KyAgICAgICAgICAgICAgICBpZiAoa2V5SWRlbnRpZmllciA9PSAiTGVmdCIgfHwga2V5SWRlbnRp ZmllciA9PSAiUmlnaHQifHwgKChrZXlJZGVudGlmaWVyID09ICJEb3duIiB8fCBrZXlJZGVudGlm aWVyID09ICJVcCIpICYmIGVuZEluZGV4ID09IGRhdGEuYWN0aXZlU2VsZWN0aW9uRW5kSW5kZXgo KSkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorCiAgICAgICAgIGlmIChrZXlJZGVudGlmaWVyID09ICJEb3duIiB8fCBrZXlJZGVudGlmaWVy ID09ICJVcCIpIHsKICAgICAgICAgICAgIC8vIFNhdmUgdGhlIHNlbGVjdGlvbiBzbyBpdCBjYW4g YmUgY29tcGFyZWQgdG8gdGhlIG5ldyBzZWxlY3Rpb24gd2hlbiBkaXNwYXRjaGluZyBjaGFuZ2Ug ZXZlbnRzIGltbWVkaWF0ZWx5IGFmdGVyIG1ha2luZyB0aGUgbmV3IHNlbGVjdGlvbi4KICAgICAg ICAgICAgIHNhdmVMYXN0U2VsZWN0aW9uKGRhdGEsIGVsZW1lbnQpOwpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gNzA4MDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNSBAQAorMjAxMC0xMC0yOCAgQ2hhbmcgU2h1ICA8Y2hhbmcuc2h1QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZWF2ZSBT ZWxlY3RFbGVtZW50IGtleSBoYW5kbGluZyB3aXRob3V0IHNldHRpbmcgZXZlbnQgZGVmYXVsdAor ICAgICAgICBoYW5kbGVkIHdoZW4gdGhlIHNlbGVjdGlvbiByZWFjaGVzIHRoZSBib3VuZGFyeSBz byBmb2N1cyBjYW4gCisgICAgICAgIG1vdmUgdG8gbmVpZ2hib3Igbm9kZXMgaW4gc3BhdGlhbCBu YXZpZ2F0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDgxNDUKKworICAgICAgICAqIGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2 LW11bHRpcGxlLXNlbGVjdC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ldmVudHMvc3Bh dGlhbC1uYXZpZ2F0aW9uL3NuYXYtbXVsdGlwbGUtc2VsZWN0Lmh0bWw6CisKIDIwMTAtMTAtMjgg IFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhdmlkIEh5YXR0LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZp Z2F0aW9uL3NuYXYtbXVsdGlwbGUtc2VsZWN0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0aXBsZS1z ZWxlY3QtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA3MDUxOSkKKysrIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LW11bHRpcGxlLXNlbGVjdC1leHBlY3RlZC50 eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsOSArMSwxNCBAQAogMgkKIDQJCTYKIDgJCi1GQUlMIGdG b2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgc2hvdWxkIGJl IDguIFdhcyBzdGFydC4KIFBBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0 dHJpYnV0ZSgiaWQiKSBpcyAic3RhcnQiCi1GQUlMIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxl bWVudC5nZXRBdHRyaWJ1dGUoImlkIikgc2hvdWxkIGJlIDIuIFdhcyBzdGFydC4KK1BBU1MgZ0Zv Y3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAic3RhcnQi CitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikg aXMgInN0YXJ0IgorUEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmli dXRlKCJpZCIpIGlzICI4IgorUEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0 QXR0cmlidXRlKCJpZCIpIGlzICJzdGFydCIKK1BBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVF bGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAic3RhcnQiCitQQVNTIGdGb2N1c2VkRG9jdW1l bnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgInN0YXJ0IgorUEFTUyBnRm9j dXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICIyIgogUEFT UyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJz dGFydCIKIFBBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJpYnV0ZSgi aWQiKSBpcyAiNiIKIFBBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJp YnV0ZSgiaWQiKSBpcyAic3RhcnQiCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0 aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0aXBsZS1zZWxlY3QuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0aXBsZS1z ZWxlY3QuaHRtbAkocmV2aXNpb24gNzA1MTkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9z cGF0aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0aXBsZS1zZWxlY3QuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMTUsOCArMTUsMTMgQEAKICAgICA8c2NyaXB0IHR5cGU9ImFwcGxpY2F0aW9uL2phdmFz Y3JpcHQiPgogCiAgICAgdmFyIHJlc3VsdE1hcCA9IFsKKyAgICAgIFsiRG93biIsICJzdGFydCJd LAorICAgICAgWyJEb3duIiwgInN0YXJ0Il0sCisgICAgICBbIkRvd24iLCAic3RhcnQiXSwKICAg ICAgIFsiRG93biIsICI4Il0sCiAgICAgICBbIlVwIiwgInN0YXJ0Il0sCisgICAgICBbIlVwIiwg InN0YXJ0Il0sCisgICAgICBbIlVwIiwgInN0YXJ0Il0sCiAgICAgICBbIlVwIiwgIjIiXSwKICAg ICAgIFsiRG93biIsICJzdGFydCJdLAogICAgICAgWyJSaWdodCIsICI2Il0sCg== 72517 2010-11-01 09:54:31 -0700 2010-11-01 18:56:57 -0700 fix patch 2 48145_2.patch text/plain 4590 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTAyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMDEgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVh dmUgU2VsZWN0RWxlbWVudCBrZXkgaGFuZGxpbmcgd2l0aG91dCBzZXR0aW5nIGV2ZW50IGRlZmF1 bHQKKyAgICAgICAgaGFuZGxlZCB3aGVuIHRoZSBzZWxlY3Rpb24gcmVhY2hlcyB0aGUgYm91bmRh cnkgc28gZm9jdXMgY2FuIAorICAgICAgICBtb3ZlIHRvIG5laWdoYm9yIG5vZGVzIGluIHNwYXRp YWwgbmF2aWdhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4MTQ1CisKKyAgICAgICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpsaXN0Qm94RGVmYXVsdEV2ZW50SGFuZGxlcik6CisK IDIwMTAtMTEtMDEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IFdlYkNvcmUvZG9t L1NlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1NlbGVjdEVsZW1l bnQuY3BwCShyZXZpc2lvbiA3MTAyNikKKysrIFdlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03NjIsNyArNzYyLDE1IEBAIHZvaWQgU2VsZWN0RWxlbWVudDo6 bGlzdEJveERlZmF1bHRFdmVudEgKICAgICAgICAgICAgIGVsc2UgaWYgKGtleUlkZW50aWZpZXIg PT0gIlVwIikKICAgICAgICAgICAgICAgICBlbmRJbmRleCA9IHByZXZpb3VzU2VsZWN0YWJsZUxp c3RJbmRleChkYXRhLCBlbGVtZW50LCBkYXRhLmFjdGl2ZVNlbGVjdGlvbkVuZEluZGV4KCkpOyAg ICAKICAgICAgICAgfQotICAgICAgICAKKworICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gZWxl bWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkgeworICAgICAgICAgICAgaWYgKGZyYW1lLT5zZXR0 aW5ncygpICYmIGZyYW1lLT5zZXR0aW5ncygpLT5pc1NwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCgp KSB7CisgICAgICAgICAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIHNlbGVjdGlvbiBtb3ZlcyB0byB0 aGUgYm91bmRhcnkuCisgICAgICAgICAgICAgICAgaWYgKGtleUlkZW50aWZpZXIgPT0gIkxlZnQi IHx8IGtleUlkZW50aWZpZXIgPT0gIlJpZ2h0IiB8fCAoKGtleUlkZW50aWZpZXIgPT0gIkRvd24i IHx8IGtleUlkZW50aWZpZXIgPT0gIlVwIikgJiYgZW5kSW5kZXggPT0gZGF0YS5hY3RpdmVTZWxl Y3Rpb25FbmRJbmRleCgpKSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgfQorICAgICAgICB9CisKICAgICAgICAgaWYgKGtleUlkZW50aWZpZXIgPT0gIkRvd24iIHx8 IGtleUlkZW50aWZpZXIgPT0gIlVwIikgewogICAgICAgICAgICAgLy8gU2F2ZSB0aGUgc2VsZWN0 aW9uIHNvIGl0IGNhbiBiZSBjb21wYXJlZCB0byB0aGUgbmV3IHNlbGVjdGlvbiB3aGVuIGRpc3Bh dGNoaW5nIGNoYW5nZSBldmVudHMgaW1tZWRpYXRlbHkgYWZ0ZXIgbWFraW5nIHRoZSBuZXcgc2Vs ZWN0aW9uLgogICAgICAgICAgICAgc2F2ZUxhc3RTZWxlY3Rpb24oZGF0YSwgZWxlbWVudCk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiA3MTAyNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTAxICBDaGFuZyBTaHUgIDxjaGFuZy5z aHVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIExlYXZlIFNlbGVjdEVsZW1lbnQga2V5IGhhbmRsaW5nIHdpdGhvdXQgc2V0dGluZyBl dmVudCBkZWZhdWx0CisgICAgICAgIGhhbmRsZWQgd2hlbiB0aGUgc2VsZWN0aW9uIHJlYWNoZXMg dGhlIGJvdW5kYXJ5IHNvIGZvY3VzIGNhbiAKKyAgICAgICAgbW92ZSB0byBuZWlnaGJvciBub2Rl cyBpbiBzcGF0aWFsIG5hdmlnYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00ODE0NQorCisgICAgICAgICogZmFzdC9ldmVudHMvc3BhdGlhbC1u YXZpZ2F0aW9uL3NuYXYtbXVsdGlwbGUtc2VsZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0aXBsZS1zZWxlY3QuaHRtbDoK KwogMjAxMC0xMS0wMSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIHR3byBtb3JlIGZhaWxpbmcgdGVzdHMgdG8gdGhlIFdlYktpdDIgU2tpcHBlZCBmaWxlCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1tdWx0 aXBsZS1zZWxlY3QtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LW11bHRpcGxlLXNlbGVjdC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDcwNTE5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1u YXZpZ2F0aW9uL3NuYXYtbXVsdGlwbGUtc2VsZWN0LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtMSw5ICsxLDE0IEBACiAyCQogNAkJNgogOAkKLUZBSUwgZ0ZvY3VzZWREb2N1bWVudC5h Y3RpdmVFbGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBzaG91bGQgYmUgOC4gV2FzIHN0YXJ0Lgog UEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlz ICJzdGFydCIKLUZBSUwgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJpYnV0 ZSgiaWQiKSBzaG91bGQgYmUgMi4gV2FzIHN0YXJ0LgorUEFTUyBnRm9jdXNlZERvY3VtZW50LmFj dGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJzdGFydCIKK1BBU1MgZ0ZvY3VzZWRE b2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAic3RhcnQiCitQQVNT IGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjgi CitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikg aXMgInN0YXJ0IgorUEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmli dXRlKCJpZCIpIGlzICJzdGFydCIKK1BBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVtZW50 LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAic3RhcnQiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0 aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjIiCiBQQVNTIGdGb2N1c2VkRG9jdW1l bnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgInN0YXJ0IgogUEFTUyBnRm9j dXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICI2IgogUEFT UyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJz dGFydCIKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9z bmF2LW11bHRpcGxlLXNlbGVjdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LW11bHRpcGxlLXNlbGVjdC5odG1sCShyZXZp c2lvbiA3MDUxOSkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlv bi9zbmF2LW11bHRpcGxlLXNlbGVjdC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xNSw4ICsxNSwx MyBAQAogICAgIDxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vamF2YXNjcmlwdCI+CiAKICAgICB2 YXIgcmVzdWx0TWFwID0gWworICAgICAgWyJEb3duIiwgInN0YXJ0Il0sCisgICAgICBbIkRvd24i LCAic3RhcnQiXSwKKyAgICAgIFsiRG93biIsICJzdGFydCJdLAogICAgICAgWyJEb3duIiwgIjgi XSwKICAgICAgIFsiVXAiLCAic3RhcnQiXSwKKyAgICAgIFsiVXAiLCAic3RhcnQiXSwKKyAgICAg IFsiVXAiLCAic3RhcnQiXSwKICAgICAgIFsiVXAiLCAiMiJdLAogICAgICAgWyJEb3duIiwgInN0 YXJ0Il0sCiAgICAgICBbIlJpZ2h0IiwgIjYiXSwK