47812 2010-10-18 04:28:36 -0700 V8 binding for DOMSettableTokenList 2010-11-02 00:42:18 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 29363 0 bashi webkit-unassigned arv commit-queue tkent oldest_to_newest 295435 0 bashi 2010-10-18 04:28:36 -0700 Implement V8 binding for DOMSettableTokenList. This issue is a part of implementing the <output> element. See https://bugs.webkit.org/show_bug.cgi?id=29363 for more details. 302501 1 72479 bashi 2010-10-31 17:46:53 -0700 Created attachment 72479 Patch V0 302543 2 72479 commit-queue 2010-10-31 19:54:42 -0700 Comment on attachment 72479 Patch V0 Clearing flags on attachment: 72479 Committed r71007: <http://trac.webkit.org/changeset/71007> 302544 3 commit-queue 2010-10-31 19:54:47 -0700 All reviewed patches have been landed. Closing bug. 302792 4 72479 arv 2010-11-01 11:12:38 -0700 Comment on attachment 72479 Patch V0 View in context: https://bugs.webkit.org/attachment.cgi?id=72479&action=review Also, why do we need custom indexedPropertyGetter? It wasn't needed for classList. The codegen knows how to generate this. > WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp:39 > + return v8String(list->item(index)); This does not look right since we should return null when index is out of bounds. ([ConvertNullStringTo=Null] in the idl) 303255 5 bashi 2010-11-02 00:42:18 -0700 Hi Erik, Thank you for your comment. (In reply to comment #4) > Also, why do we need custom indexedPropertyGetter? It wasn't needed for classList. The codegen knows how to generate this. It looks like that the codegen for V8 bindings does not consider the inheritance of the interface and doesn't generate indexedPropertyGetter automatically. On the other hand, the codegen for JSC consider the inheritance of the interface and generate getter function automatically. To manage these two case, we need to custom function. > > WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp:39 > > + return v8String(list->item(index)); > > This does not look right since we should return null when index is out of bounds. ([ConvertNullStringTo=Null] in the idl) Yes, I've made a mistake and I'll fix it in the patch for https://bugs.webkit.org/show_bug.cgi?id=29363. Thank you for correcting. 72479 2010-10-31 17:46:53 -0700 2010-11-01 11:12:38 -0700 Patch V0 bug-47812-20101101094651.patch text/plain 1658 bashi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTIyZTMzNzEwOTM3ZmYzZmFkOWIyZWYxZjVmY2IxOTI2YWU1OGQwMy4uM2M4OTQ0Yjk2ZTY3Nzg2 MmMxOTFmN2E4OTkyNTEyMmIwOGZkYmYxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0zMSAgS2Vu aWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4IGJpbmRpbmcgZm9yIERPTVNldHRhYmxlVG9r ZW5MaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NzgxMgorCisgICAgICAgIFRlc3RzIGZvciB0aGlzIGNoYW5nZSB3aWxsIGJlIGluY2x1ZGVkIGlu IHRoZSBjaGFuZ2UgZm9yIHN1cHBvcnRpbmcKKyAgICAgICAgdGhlIDxvdXRwdXQ+IGVsZW1lbnQu CisgICAgICAgIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjkz NjMuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhET01TZXR0YWJsZVRva2VuTGlz dEN1c3RvbS5jcHA6IEltcGxlbWVudGVkLgorICAgICAgICAoV2ViQ29yZTo6VjhET01TZXR0YWJs ZVRva2VuTGlzdDo6aW5kZXhlZFByb3BlcnR5R2V0dGVyKTogSnVzdCBjYWxscyBET01TZXR0YWJs ZVRva2VuTGlzdDo6aXRlbShpbmRleCkuCisKIDIwMTAtMTAtMzEgIEFuZHJlYXMgS2xpbmcgIDxr bGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NU2V0dGFibGVUb2tlbkxp c3RDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01TZXR0YWJsZVRv a2VuTGlzdEN1c3RvbS5jcHAKaW5kZXggNGVlYjFlMGMyZDMyM2JkNWRlNjlhMDdmNzVjNjk0MDBi YWJkN2MzNy4uM2JjZjBmYzQwZDkwNjYzMDEwMzk2NWViNDM2MDc2ZmU2YmVlYWUxZCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01TZXR0YWJsZVRva2VuTGlzdEN1 c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01TZXR0YWJsZVRv a2VuTGlzdEN1c3RvbS5jcHAKQEAgLTM0LDggKzM0LDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01TZXR0YWJsZVRva2VuTGlzdDo6aW5kZXhlZFBy b3BlcnR5R2V0dGVyKHVpbnQzMl90IGluZGV4LCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZv KQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgdGhpcyBmdW5jdGlvbi4KLSAgICByZXR1cm4g djhTdHJpbmcoIiIpOworICAgIElOQ19TVEFUUygiRE9NLkRPTVNldHRhYmxlVG9rZW5MaXN0Lklu ZGV4ZWRQcm9wZXJ0eUdldHRlciIpOworICAgIERPTVNldHRhYmxlVG9rZW5MaXN0KiBsaXN0ID0g VjhET01TZXR0YWJsZVRva2VuTGlzdDo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7CisgICAgcmV0 dXJuIHY4U3RyaW5nKGxpc3QtPml0ZW0oaW5kZXgpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo=