47454 2010-10-09 10:53:40 -0700 FileWriter sends write event instead of progress event 2010-10-09 19:16:16 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 44358 1 ericu ericu commit-queue kinuko kling michaeln oldest_to_newest 292137 0 ericu 2010-10-09 10:53:40 -0700 The FileWriter is currently sending the write event where it should be sending a progress event. Write happens only at the end of a successful truncate or write, whereas progress happens throughout an ongoing write. 292233 1 70381 ericu 2010-10-09 17:21:45 -0700 Created attachment 70381 Patch 292236 2 70381 kling 2010-10-09 18:55:51 -0700 Comment on attachment 70381 Patch According to the spec, readyState should be DONE when the "write" event fires: http://www.w3.org/TR/file-writer-api/#widl-FileWriter-write (steps 6, 7 and 8.) 292237 3 70381 kling 2010-10-09 18:59:18 -0700 Comment on attachment 70381 Patch D'oh, that's my bad. I was looking at an outdated version of the spec. Here's the relevant one: http://dev.w3.org/2009/dap/file-system/file-writer.html#widl-FileWriter-write r=me 292238 4 70381 commit-queue 2010-10-09 19:16:11 -0700 Comment on attachment 70381 Patch Clearing flags on attachment: 70381 Committed r69463: <http://trac.webkit.org/changeset/69463> 292239 5 commit-queue 2010-10-09 19:16:16 -0700 All reviewed patches have been landed. Closing bug. 70381 2010-10-09 17:21:45 -0700 2010-10-09 19:16:11 -0700 Patch bug-47454-20101009172144.patch text/plain 1307 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMDkgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aWxlV3JpdGVyIHNlbmRzIHdyaXRlIGV2ZW50IGluc3RlYWQgb2YgcHJvZ3Jlc3MgZXZlbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDU0CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzOyBGaWxlV3JpdGVyIHRlc3RzIHdpbGwgYmUgYWRkZWQgc2hvcnRs eSwgYnV0IGN1cnJlbnRseQorICAgICAgICB0aGVyZSdzIG5vIGltcGxlbWVudGF0aW9uIGNhcGFi bGUgb2YgcnVubmluZyB0aGVtLgorCisgICAgICAgICogZmlsZWFwaS9GaWxlV3JpdGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZpbGVXcml0ZXI6OmRpZFdyaXRlKToKKwogMjAxMC0xMC0wOSAg QW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJDb3JlL2ZpbGVhcGkvRmlsZVdy aXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuY3BwCShy ZXZpc2lvbiA2OTM3MSkKKysrIFdlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTY3LDggKzE2Nyw5IEBAIHZvaWQgRmlsZVdyaXRlcjo6ZGlkV3JpdGUobG9u ZyBsb25nIGJ5dGUKICAgICBtX3Bvc2l0aW9uICs9IGJ5dGVzOwogICAgIGlmIChtX3Bvc2l0aW9u ID4gbV9sZW5ndGgpCiAgICAgICAgIG1fbGVuZ3RoID0gbV9wb3NpdGlvbjsKLSAgICBmaXJlRXZl bnQoZXZlbnROYW1lcygpLndyaXRlRXZlbnQpOworICAgIGZpcmVFdmVudChldmVudE5hbWVzKCku cHJvZ3Jlc3NFdmVudCk7CiAgICAgaWYgKGNvbXBsZXRlKSB7CisgICAgICAgIGZpcmVFdmVudChl dmVudE5hbWVzKCkud3JpdGVFdmVudCk7CiAgICAgICAgIG1fcmVhZHlTdGF0ZSA9IERPTkU7CiAg ICAgICAgIGZpcmVFdmVudChldmVudE5hbWVzKCkud3JpdGVlbmRFdmVudCk7CiAgICAgfQo=