<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>47426</bug_id>
          
          <creation_ts>2010-10-08 11:18:53 -0700</creation_ts>
          <short_desc>[Qt] Editing commands should not be executed on non-editable content.</short_desc>
          <delta_ts>2010-10-15 07:04:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>46905</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yael">yael</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ossy</cc>
    
    <cc>staikos</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>291768</commentid>
    <comment_count>0</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 11:18:53 -0700</bug_when>
    <thetext>EditorClientQt is trying to execute edit commands even if it is not in editable content. It is not clear to me why this is necessary.
e.g. clicking somewhere (not editable content) in the page can generate a selection start. Based on existence of selection start we call editing commands and consume the key events, but then we can&apos;t scroll.

This scenario is not very predictable so it would be difficult to provide a good layout test. 
I ran all editing layout tests with and without this change, and did not observe any difference in the results.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291801</commentid>
    <comment_count>1</comment_count>
      <attachid>70274</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 12:11:14 -0700</bug_when>
    <thetext>Created attachment 70274
Patch

Remove the calls to editor()-&gt;command() when not in editable mode.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291802</commentid>
    <comment_count>2</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 12:15:08 -0700</bug_when>
    <thetext>SVN blame seems to indicate that this code was originally added in r23545. Would be great to know if this is still needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291803</commentid>
    <comment_count>3</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 12:16:48 -0700</bug_when>
    <thetext>Not a Spatial Navigation issue, but it impacts the testing of Spatial Navigation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291828</commentid>
    <comment_count>4</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 13:20:09 -0700</bug_when>
    <thetext>Example page that shows the problem:
&lt;html&gt;
&lt;style&gt;
&lt;/style&gt;
&lt;body&gt;
&lt;input type=&quot;radio&quot; id=&quot;myradiobutton&quot;&gt;
&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;
&lt;span tabindex=1 id=&quot;r&quot;&gt;My span&lt;/span&gt;
&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;
&lt;/body&gt;
&lt;/html&gt;


Click the span, and after that, it is not possible to scroll.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291835</commentid>
    <comment_count>5</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 13:25:30 -0700</bug_when>
    <thetext>Callstack was asked for this issue:

0	WebCore::EditorClientQt::handleKeyboardEvent	EditorClientQt.cpp	460	0x01e26134	
1	WebCore::Editor::handleKeyboardEvent	Editor.cpp	125	0x018a454d	
2	WebCore::EventHandler::defaultKeyboardEventHandler	EventHandler.cpp	2369	0x01b3f838	
3	WebCore::Node::defaultEventHandler	Node.cpp	2964	0x0182572b	
4	WebCore::Node::dispatchGenericEvent	Node.cpp	2693	0x018239de	
5	WebCore::Node::dispatchEvent	Node.cpp	2577	0x018231c8	
6	WebCore::EventTarget::dispatchEvent	EventTarget.cpp	278	0x01808c63	
7	WebCore::EventHandler::keyEvent	EventHandler.cpp	2310	0x01b3f06e	
8	QWebPagePrivate::keyPressEvent	qwebpage.cpp	945	0x01e59396	
9	QWebPage::event	qwebpage.cpp	2856	0x01e61ca2	
10	QWebView::keyPressEvent	qwebview.cpp	1033	0x01e673fe	
11	QWidget::event	qwidget.cpp	8222	0x03723a03	
12	QWebView::event	qwebview.cpp	834	0x01e66eba	
13	QApplicationPrivate::notify_helper	qapplication.cpp	4396	0x036b67b6	
14	QApplication::notify	qapplication.cpp	3857	0x036b42f9	
15	QCoreApplication::notifyInternal	qcoreapplication.cpp	732	0x0439e62f	
16	QCoreApplication::sendSpontaneousEvent	qcoreapplication.h	218	0x036b9023	
17	qt_sendSpontaneousEvent	qapplication.cpp	5388	0x036b6b27	
18	QKeyMapper::sendKeyEvent	qkeymapper_x11.cpp	1867	0x0378f030	
19	QKeyMapperPrivate::translateKeyEvent	qkeymapper_x11.cpp	1837	0x0378ed2c	
20	QApplication::x11ProcessEvent	qapplication_x11.cpp	3429	0x03757d6b	
...	&lt;More&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291867</commentid>
    <comment_count>6</comment_count>
      <attachid>70289</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 14:33:41 -0700</bug_when>
    <thetext>Created attachment 70289
Pat

Added test.
In an e-mail exchange with the originator of this code, he was ok with removing it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291897</commentid>
    <comment_count>7</comment_count>
      <attachid>70298</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-10-08 15:16:24 -0700</bug_when>
    <thetext>Created attachment 70298
Patch

Modified the test to check that any scrolling happened instead of exactly 40 pixels. Different platforms may have different settings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>292926</commentid>
    <comment_count>8</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-10-12 06:54:15 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Created an attachment (id=70289) [details]
&gt; Pat
&gt; 
&gt; Added test.
&gt; In an e-mail exchange with the originator of this code, he was ok with removing it.

The code clean up proposed generally looks good. I am just double checking with Yael if there is not any case not checked by the LayoutTests in Qt&apos;s DRT that we might be missing, for example Document::inDesignMode cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>292934</commentid>
    <comment_count>9</comment_count>
      <attachid>70298</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-10-12 07:15:01 -0700</bug_when>
    <thetext>Comment on attachment 70298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70298&amp;action=review

&gt; WebKit/qt/ChangeLog:10
&gt; +        A layout test would be very frigile, as the bad behavior is not consistent.

Please lets remove this line since we now have a layout test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>292946</commentid>
    <comment_count>10</comment_count>
      <attachid>70530</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-10-12 07:32:57 -0700</bug_when>
    <thetext>Created attachment 70530
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>292947</commentid>
    <comment_count>11</comment_count>
      <attachid>70530</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-10-12 07:33:52 -0700</bug_when>
    <thetext>Comment on attachment 70530
Patch

Removed the line about not having tests, now that we do have a test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>292952</commentid>
    <comment_count>12</comment_count>
      <attachid>70530</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-12 07:47:38 -0700</bug_when>
    <thetext>Comment on attachment 70530
Patch

Clearing flags on attachment: 70530

Committed r69582: &lt;http://trac.webkit.org/changeset/69582&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294737</commentid>
    <comment_count>13</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2010-10-15 07:04:18 -0700</bug_when>
    <thetext>Revision r69582 cherry-picked into qtwebkit-2.1 with commit a5266b9 &lt;http://gitorious.org/webkit/qtwebkit/commit/a5266b9&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70274</attachid>
            <date>2010-10-08 12:11:14 -0700</date>
            <delta_ts>2010-10-08 14:33:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>47426.patch</filename>
            <type>text/plain</type>
            <size>2509</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNjk0MTMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy
b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF0gRWRpdGluZyBjb21tYW5kcyBzaG91bGQgbm90IGJlIGV4ZWN1dGVkIG9uIG5v
bi1lZGl0YWJsZSBjb250ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NDc0MjYKKworICAgICAgICBSZW1vdmUgY2FsbHMgdG8gZWRpdG9yKCktPmNv
bW1hbmQoKSB3aGVuIHdlIGFyZSBub3QgaW4gZWRpdGFibGUgY29udGVudC4KKyAgICAgICAgVGhl
cmUgaXMgbm8gdmFsdWUgaW4gZG9pbmcgdGhhdCwgYW5kIGluIHNvbWUgY2FzZXMsIGl0IHByZXZl
bnRzIHNjcm9sbGluZy4KKyAgICAgICAgQSBsYXlvdXQgdGVzdCB3b3VsZCBiZSB2ZXJ5IGZyaWdp
bGUsIGFzIHRoZSBiYWQgYmVoYXZpb3IgaXMgbm90IGNvbnNpc3RlbnQuCisKKyAgICAgICAgKiBX
ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0
b3JDbGllbnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTAtMDggIEh1aSBIdWFu
ZyAgPGh1aS4yLmh1YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI
YXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0
LmNwcAkocmV2aXNpb24gNjkzNDkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9y
Q2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTcsMzkgKzQ1Nyw3IEBAIHZvaWQgRWRp
dG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICAgICAgICAgIG1fcGFnZS0+dHJp
Z2dlckFjdGlvbihRV2ViUGFnZTo6Q29weSk7CiAgICAgICAgIGVsc2UKICNlbmRpZiAvLyBRVF9O
T19TSE9SVENVVAotICAgICAgICBzd2l0Y2ggKGtldmVudC0+d2luZG93c1ZpcnR1YWxLZXlDb2Rl
KCkpIHsKLSAgICAgICAgY2FzZSBWS19VUDoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+
Y29tbWFuZCgiTW92ZVVwIikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAg
IGNhc2UgVktfRE9XTjoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92
ZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBWS19Q
UklPUjogLy8gUGFnZVVwCi0gICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1v
dmVQYWdlVXAiKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBW
S19ORVhUOiAvLyBQYWdlRG93bgotICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k
KCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAg
Y2FzZSBWS19IT01FOgotICAgICAgICAgICAgaWYgKGtldmVudC0+Y3RybEtleSgpKQotICAgICAg
ICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVRvQmVnaW5uaW5nT2ZEb2N1
bWVudCIpLmV4ZWN1dGUoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIFZLX0VO
RDoKLSAgICAgICAgICAgIGlmIChrZXZlbnQtPmN0cmxLZXkoKSkKLSAgICAgICAgICAgICAgICBm
cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVUb0VuZE9mRG9jdW1lbnQiKS5leGVjdXRlKCk7
Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGlmIChr
ZXZlbnQtPmN0cmxLZXkoKSkgewotICAgICAgICAgICAgICAgIHN3aXRjaCAoa2V2ZW50LT53aW5k
b3dzVmlydHVhbEtleUNvZGUoKSkgewotICAgICAgICAgICAgICAgIGNhc2UgVktfQToKLSAgICAg
ICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJTZWxlY3RBbGwiKS5leGVj
dXRlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIGRlZmF1
bHQ6Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgICAgICB9Ci0gICAg
ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KKyAgICAg
ICAgICAgIHJldHVybjsKICAgICB9CiAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiB9
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70289</attachid>
            <date>2010-10-08 14:33:41 -0700</date>
            <delta_ts>2010-10-08 15:16:24 -0700</delta_ts>
            <desc>Pat</desc>
            <filename>47426.patch</filename>
            <type>text/plain</type>
            <size>5161</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNjk0MjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy
b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF0gRWRpdGluZyBjb21tYW5kcyBzaG91bGQgbm90IGJlIGV4ZWN1dGVkIG9uIG5v
bi1lZGl0YWJsZSBjb250ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NDc0MjYKKworICAgICAgICBSZW1vdmUgY2FsbHMgdG8gZWRpdG9yKCktPmNv
bW1hbmQoKSB3aGVuIHdlIGFyZSBub3QgaW4gZWRpdGFibGUgY29udGVudC4KKyAgICAgICAgVGhl
cmUgaXMgbm8gdmFsdWUgaW4gZG9pbmcgdGhhdCwgYW5kIGluIHNvbWUgY2FzZXMsIGl0IHByZXZl
bnRzIHNjcm9sbGluZy4KKyAgICAgICAgQSBsYXlvdXQgdGVzdCB3b3VsZCBiZSB2ZXJ5IGZyaWdp
bGUsIGFzIHRoZSBiYWQgYmVoYXZpb3IgaXMgbm90IGNvbnNpc3RlbnQuCisKKyAgICAgICAgKiBX
ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0
b3JDbGllbnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTAtMDggIEh1aSBIdWFu
ZyAgPGh1aS4yLmh1YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI
YXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0
LmNwcAkocmV2aXNpb24gNjkzNDkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9y
Q2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTcsMzkgKzQ1Nyw3IEBAIHZvaWQgRWRp
dG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICAgICAgICAgIG1fcGFnZS0+dHJp
Z2dlckFjdGlvbihRV2ViUGFnZTo6Q29weSk7CiAgICAgICAgIGVsc2UKICNlbmRpZiAvLyBRVF9O
T19TSE9SVENVVAotICAgICAgICBzd2l0Y2ggKGtldmVudC0+d2luZG93c1ZpcnR1YWxLZXlDb2Rl
KCkpIHsKLSAgICAgICAgY2FzZSBWS19VUDoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+
Y29tbWFuZCgiTW92ZVVwIikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAg
IGNhc2UgVktfRE9XTjoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92
ZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBWS19Q
UklPUjogLy8gUGFnZVVwCi0gICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1v
dmVQYWdlVXAiKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBW
S19ORVhUOiAvLyBQYWdlRG93bgotICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k
KCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAg
Y2FzZSBWS19IT01FOgotICAgICAgICAgICAgaWYgKGtldmVudC0+Y3RybEtleSgpKQotICAgICAg
ICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVRvQmVnaW5uaW5nT2ZEb2N1
bWVudCIpLmV4ZWN1dGUoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIFZLX0VO
RDoKLSAgICAgICAgICAgIGlmIChrZXZlbnQtPmN0cmxLZXkoKSkKLSAgICAgICAgICAgICAgICBm
cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVUb0VuZE9mRG9jdW1lbnQiKS5leGVjdXRlKCk7
Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGlmIChr
ZXZlbnQtPmN0cmxLZXkoKSkgewotICAgICAgICAgICAgICAgIHN3aXRjaCAoa2V2ZW50LT53aW5k
b3dzVmlydHVhbEtleUNvZGUoKSkgewotICAgICAgICAgICAgICAgIGNhc2UgVktfQToKLSAgICAg
ICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJTZWxlY3RBbGwiKS5leGVj
dXRlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIGRlZmF1
bHQ6Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgICAgICB9Ci0gICAg
ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KKyAgICAg
ICAgICAgIHJldHVybjsKICAgICB9CiAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiB9
CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCShyZXZpc2lvbiA2OTQyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y
a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTA4ICBZYWVsIEFoYXJvbiAgPHlh
ZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBbUXRdIEVkaXRpbmcgY29tbWFuZHMgc2hvdWxkIG5vdCBiZSBleGVjdXRl
ZCBvbiBub24tZWRpdGFibGUgY29udGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ3NDI2CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9zY3JvbGwt
YWZ0ZXItY2xpY2stb24tdGFiLWluZGV4LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog
ZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC5odG1sOiBBZGRlZC4K
KwogMjAxMC0xMC0wOCAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVu
dHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC1leHBlY3RlZC50eHQKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1p
bmRleC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50
cy9zY3JvbGwtYWZ0ZXItY2xpY2stb24tdGFiLWluZGV4LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g
MCkKQEAgLTAsMCArMSwzOSBAQAorQUxFUlQ6IFNjcm9sbCBwb3NpdGlvbiAwCitBTEVSVDogU2Ny
b2xsIHBvc2l0aW9uIDQwCitDbGljayB0aGUgdGV4dCBiZWxvdyBhbmQgdGhlbiB0cnkgdG8gc2Ny
b2xsLiAKKworCisKKworCisKKworCisKK015IHNwYW4gCisKKworCisKKworCisKKworCisKKwor
CisKKworCisKKworCisKKworCisKKworCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVu
dHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC5odG1sCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1jbGljay1vbi10YWItaW5kZXguaHRt
bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1j
bGljay1vbi10YWItaW5kZXguaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NSBAQAorPGh0
bWw+Cis8c2NyaXB0PgorCitmdW5jdGlvbiBnZXRDZW50ZXJGb3IoZWxlbWVudCkKK3sKKyAgdmFy
IHJlY3QgPSBlbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICByZXR1cm4geyB4IDog
cGFyc2VJbnQoKHJlY3QubGVmdCArIHJlY3QucmlnaHQpIC8gMikgLCB5IDogcGFyc2VJbnQoKHJl
Y3QudG9wICsgcmVjdC5ib3R0b20pIC8gMil9OworfQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sK
KyAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgcmV0dXJuOworICBpZiAo
IXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICByZXR1cm47CisKKyAgbGF5b3V0VGVzdENvbnRyb2xs
ZXIud2FpdFVudGlsRG9uZSgpOworICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7
CisKKyAgYWxlcnQoIlNjcm9sbCBwb3NpdGlvbiAiICsgZG9jdW1lbnQuYm9keS5zY3JvbGxUb3Ap
OworICBjZW50ZXIgPSBnZXRDZW50ZXJGb3IoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNwIikp
OworICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhjZW50ZXIueCwgY2VudGVyLnkpOworICBldmVu
dFNlbmRlci5tb3VzZURvd24oKTsKKyAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworICBldmVudFNl
bmRlci5rZXlEb3duKCJkb3duQXJyb3ciKTsKKyAgc2V0VGltZW91dCh2ZXJpZnlTY3JvbGxpbmcs
IDE1KTsKK30KKworZnVuY3Rpb24gdmVyaWZ5U2Nyb2xsaW5nKCkKK3sKKyAgYWxlcnQoIlNjcm9s
bCBwb3NpdGlvbiAiICsgZG9jdW1lbnQuYm9keS5zY3JvbGxUb3ApOworICBsYXlvdXRUZXN0Q29u
dHJvbGxlci5ub3RpZnlEb25lKCk7Cit9CisKKzwvc2NyaXB0PgorPHN0eWxlPgorPC9zdHlsZT4K
Kzxib2R5IG9ubG9hZD0icnVuVGVzdCgpOyI+Cis8aW5wdXQgdHlwZT0icmFkaW8iIGlkPSJteXJh
ZGlvIj5DbGljayB0aGUgdGV4dCBiZWxvdyBhbmQgdGhlbiB0cnkgdG8gc2Nyb2xsLgorPGJyPjxi
cj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPgorPHNwYW4gdGFiaW5kZXg9MSBpZD0i
c3AiPk15IHNwYW48L3NwYW4+Cis8YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48
YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxi
cj48YnI+PGJyPgorPC9ib2R5PgorPC9odG1sPgorCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70298</attachid>
            <date>2010-10-08 15:16:24 -0700</date>
            <delta_ts>2010-10-12 07:15:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>47426.patch</filename>
            <type>text/plain</type>
            <size>5474</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNjk0MjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy
b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF0gRWRpdGluZyBjb21tYW5kcyBzaG91bGQgbm90IGJlIGV4ZWN1dGVkIG9uIG5v
bi1lZGl0YWJsZSBjb250ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NDc0MjYKKworICAgICAgICBSZW1vdmUgY2FsbHMgdG8gZWRpdG9yKCktPmNv
bW1hbmQoKSB3aGVuIHdlIGFyZSBub3QgaW4gZWRpdGFibGUgY29udGVudC4KKyAgICAgICAgVGhl
cmUgaXMgbm8gdmFsdWUgaW4gZG9pbmcgdGhhdCwgYW5kIGluIHNvbWUgY2FzZXMsIGl0IHByZXZl
bnRzIHNjcm9sbGluZy4KKyAgICAgICAgQSBsYXlvdXQgdGVzdCB3b3VsZCBiZSB2ZXJ5IGZyaWdp
bGUsIGFzIHRoZSBiYWQgYmVoYXZpb3IgaXMgbm90IGNvbnNpc3RlbnQuCisKKyAgICAgICAgKiBX
ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0
b3JDbGllbnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTAtMDggIEh1aSBIdWFu
ZyAgPGh1aS4yLmh1YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI
YXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0
LmNwcAkocmV2aXNpb24gNjkzNDkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9y
Q2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTcsMzkgKzQ1Nyw3IEBAIHZvaWQgRWRp
dG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICAgICAgICAgIG1fcGFnZS0+dHJp
Z2dlckFjdGlvbihRV2ViUGFnZTo6Q29weSk7CiAgICAgICAgIGVsc2UKICNlbmRpZiAvLyBRVF9O
T19TSE9SVENVVAotICAgICAgICBzd2l0Y2ggKGtldmVudC0+d2luZG93c1ZpcnR1YWxLZXlDb2Rl
KCkpIHsKLSAgICAgICAgY2FzZSBWS19VUDoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+
Y29tbWFuZCgiTW92ZVVwIikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAg
IGNhc2UgVktfRE9XTjoKLSAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92
ZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBWS19Q
UklPUjogLy8gUGFnZVVwCi0gICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1v
dmVQYWdlVXAiKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBW
S19ORVhUOiAvLyBQYWdlRG93bgotICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k
KCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAg
Y2FzZSBWS19IT01FOgotICAgICAgICAgICAgaWYgKGtldmVudC0+Y3RybEtleSgpKQotICAgICAg
ICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVRvQmVnaW5uaW5nT2ZEb2N1
bWVudCIpLmV4ZWN1dGUoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIFZLX0VO
RDoKLSAgICAgICAgICAgIGlmIChrZXZlbnQtPmN0cmxLZXkoKSkKLSAgICAgICAgICAgICAgICBm
cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVUb0VuZE9mRG9jdW1lbnQiKS5leGVjdXRlKCk7
Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGlmIChr
ZXZlbnQtPmN0cmxLZXkoKSkgewotICAgICAgICAgICAgICAgIHN3aXRjaCAoa2V2ZW50LT53aW5k
b3dzVmlydHVhbEtleUNvZGUoKSkgewotICAgICAgICAgICAgICAgIGNhc2UgVktfQToKLSAgICAg
ICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJTZWxlY3RBbGwiKS5leGVj
dXRlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIGRlZmF1
bHQ6Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgICAgICB9Ci0gICAg
ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KKyAgICAg
ICAgICAgIHJldHVybjsKICAgICB9CiAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiB9
CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCShyZXZpc2lvbiA2OTQyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y
a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTA4ICBZYWVsIEFoYXJvbiAgPHlh
ZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBbUXRdIEVkaXRpbmcgY29tbWFuZHMgc2hvdWxkIG5vdCBiZSBleGVjdXRl
ZCBvbiBub24tZWRpdGFibGUgY29udGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ3NDI2CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9zY3JvbGwt
YWZ0ZXItY2xpY2stb24tdGFiLWluZGV4LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog
ZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC5odG1sOiBBZGRlZC4K
KwogMjAxMC0xMC0wOCAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVu
dHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC1leHBlY3RlZC50eHQKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1p
bmRleC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50
cy9zY3JvbGwtYWZ0ZXItY2xpY2stb24tdGFiLWluZGV4LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g
MCkKQEAgLTAsMCArMSw0NCBAQAorQUxFUlQ6IFNjcm9sbCBwb3NpdGlvbiAwCitDbGljayB0aGUg
dGV4dCBiZWxvdyBhbmQgdGhlbiB0cnkgdG8gc2Nyb2xsLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJz
ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitTY3JvbGwgcG9zaXRpb24gaXMgbW9yZSB0aGFu
IDAKK1BBU1MgZG9jdW1lbnQuYm9keS5zY3JvbGxUb3AgPiAwIGlzIHRydWUKKworCisKKworCisK
KworCisKKworTXkgc3BhbiAKKworCisKKworCisKKworCisKKworCisKKworCisKKworCisKKwor
CisKKworCisKKworCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtYWZ0ZXIt
Y2xpY2stb24tdGFiLWluZGV4Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9l
dmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC5odG1sCShyZXZpc2lvbiAwKQor
KysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRl
eC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUwIEBACis8aHRtbD4KKzxzY3JpcHQgc3Jj
PSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1
bmN0aW9uIGdldENlbnRlckZvcihlbGVtZW50KQoreworICB2YXIgcmVjdCA9IGVsZW1lbnQuZ2V0
Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgIHJldHVybiB7IHggOiBwYXJzZUludCgocmVjdC5sZWZ0
ICsgcmVjdC5yaWdodCkgLyAyKSAsIHkgOiBwYXJzZUludCgocmVjdC50b3AgKyByZWN0LmJvdHRv
bSkgLyAyKX07Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICBpZiAoIXdpbmRvdy5sYXlv
dXRUZXN0Q29udHJvbGxlcikKKyAgICByZXR1cm47CisgIGlmICghd2luZG93LmV2ZW50U2VuZGVy
KQorICAgIHJldHVybjsKKworICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7
CisgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICBhbGVydCgiU2Nyb2xs
IHBvc2l0aW9uICIgKyBkb2N1bWVudC5ib2R5LnNjcm9sbFRvcCk7CisgIGNlbnRlciA9IGdldENl
bnRlckZvcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3AiKSk7CisgIGV2ZW50U2VuZGVyLm1v
dXNlTW92ZVRvKGNlbnRlci54LCBjZW50ZXIueSk7CisgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigp
OworICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgIGV2ZW50U2VuZGVyLmtleURvd24oImRvd25B
cnJvdyIpOworICBzZXRUaW1lb3V0KHZlcmlmeVNjcm9sbGluZywgMTUpOworfQorCitmdW5jdGlv
biB2ZXJpZnlTY3JvbGxpbmcoKQoreworICBkZWJ1ZygiU2Nyb2xsIHBvc2l0aW9uIGlzIG1vcmUg
dGhhbiAwIik7CisgIHNob3VsZEJlKCJkb2N1bWVudC5ib2R5LnNjcm9sbFRvcCA+IDAiLCAidHJ1
ZSIpOworICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9CisKK3ZhciBzdWNj
ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCis8L3NjcmlwdD4KKzxzdHlsZT4KKzwvc3R5bGU+Cis8
Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorPGlucHV0IHR5cGU9InJhZGlvIiBpZD0ibXlyYWRp
byI+Q2xpY2sgdGhlIHRleHQgYmVsb3cgYW5kIHRoZW4gdHJ5IHRvIHNjcm9sbC48YnI+Cis8ZGl2
IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVz
dC1wb3N0LmpzIj48L3NjcmlwdD4KKzxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJy
Pjxicj4KKzxzcGFuIHRhYmluZGV4PTEgaWQ9InNwIj5NeSBzcGFuPC9zcGFuPgorPGJyPjxicj48
YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxi
cj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj4KKzwvYm9keT4KKzwvaHRtbD4K
Kwo=
</data>
<flag name="review"
          id="60118"
          type_id="1"
          status="+"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70530</attachid>
            <date>2010-10-12 07:32:57 -0700</date>
            <delta_ts>2010-10-12 07:47:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>47426.patch</filename>
            <type>text/plain</type>
            <size>5436</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNjk1ODApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMTIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy
b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCisKKyAg
ICAgICAgW1F0XSBFZGl0aW5nIGNvbW1hbmRzIHNob3VsZCBub3QgYmUgZXhlY3V0ZWQgb24gbm9u
LWVkaXRhYmxlIGNvbnRlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD00NzQyNgorCisgICAgICAgIFJlbW92ZSBjYWxscyB0byBlZGl0b3IoKS0+Y29t
bWFuZCgpIHdoZW4gd2UgYXJlIG5vdCBpbiBlZGl0YWJsZSBjb250ZW50LgorICAgICAgICBUaGVy
ZSBpcyBubyB2YWx1ZSBpbiBkb2luZyB0aGF0LCBhbmQgaW4gc29tZSBjYXNlcywgaXQgcHJldmVu
dHMgc2Nyb2xsaW5nLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZl
bnQpOgorCiAyMDEwLTEwLTA4ICBIdWkgSHVhbmcgIDxodWkuMi5odWFuZ0Bub2tpYS5jb20+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJLaXQvcXQvV2Vi
Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9X
ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHAJKHJldmlzaW9uIDY5NTgwKQorKysgV2Vi
S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpA
QCAtNDU3LDM5ICs0NTcsNyBAQCB2b2lkIEVkaXRvckNsaWVudFF0OjpoYW5kbGVLZXlib2FyZEV2
ZW50CiAgICAgICAgICAgICBtX3BhZ2UtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkNvcHkpOwog
ICAgICAgICBlbHNlCiAjZW5kaWYgLy8gUVRfTk9fU0hPUlRDVVQKLSAgICAgICAgc3dpdGNoIChr
ZXZlbnQtPndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpKSB7Ci0gICAgICAgIGNhc2UgVktfVVA6Ci0g
ICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVVcCIpLmV4ZWN1dGUoKTsK
LSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIFZLX0RPV046Ci0gICAgICAgICAgICBm
cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVEb3duIikuZXhlY3V0ZSgpOwotICAgICAgICAg
ICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgVktfUFJJT1I6IC8vIFBhZ2VVcAotICAgICAgICAgICAg
ZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZVVwIikuZXhlY3V0ZSgpOwotICAgICAg
ICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgVktfTkVYVDogLy8gUGFnZURvd24KLSAgICAgICAg
ICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VEb3duIikuZXhlY3V0ZSgpOwot
ICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgVktfSE9NRToKLSAgICAgICAgICAgIGlm
IChrZXZlbnQtPmN0cmxLZXkoKSkKLSAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNv
bW1hbmQoIk1vdmVUb0JlZ2lubmluZ09mRG9jdW1lbnQiKS5leGVjdXRlKCk7Ci0gICAgICAgICAg
ICBicmVhazsKLSAgICAgICAgY2FzZSBWS19FTkQ6Ci0gICAgICAgICAgICBpZiAoa2V2ZW50LT5j
dHJsS2V5KCkpCi0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3Zl
VG9FbmRPZkRvY3VtZW50IikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAg
IGRlZmF1bHQ6Ci0gICAgICAgICAgICBpZiAoa2V2ZW50LT5jdHJsS2V5KCkpIHsKLSAgICAgICAg
ICAgICAgICBzd2l0Y2ggKGtldmVudC0+d2luZG93c1ZpcnR1YWxLZXlDb2RlKCkpIHsKLSAgICAg
ICAgICAgICAgICBjYXNlIFZLX0E6Ci0gICAgICAgICAgICAgICAgICAgIGZyYW1lLT5lZGl0b3Io
KS0+Y29tbWFuZCgiU2VsZWN0QWxsIikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgICAgICAgICBi
cmVhazsKLSAgICAgICAgICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgICAgICAgICByZXR1
cm47Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAg
ICAgcmV0dXJuOwotICAgICAgICB9CisgICAgICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGV2
ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjk1ODApCisr
KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor
MjAxMC0xMC0xMiAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KKworICAgICAgICBbUXRdIEVkaXRpbmcgY29t
bWFuZHMgc2hvdWxkIG5vdCBiZSBleGVjdXRlZCBvbiBub24tZWRpdGFibGUgY29udGVudC4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDI2CisKKyAg
ICAgICAgKiBmYXN0L2V2ZW50cy9zY3JvbGwtYWZ0ZXItY2xpY2stb24tdGFiLWluZGV4LWV4cGVj
dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNr
LW9uLXRhYi1pbmRleC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0xMiAgQWxleGFuZGVyIFBhdmxv
diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdl
ZCwgY2xlYW4gdXAgY2hyb21pdW0td2luIFNWRyB0ZXN0IGV4cGVjdGF0aW9ucy4KSW5kZXg6IExh
eW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1jbGljay1vbi10YWItaW5kZXgtZXhw
ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1h
ZnRlci1jbGljay1vbi10YWItaW5kZXgtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5
b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC1leHBl
Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDQgQEAKK0FMRVJUOiBTY3JvbGwgcG9z
aXRpb24gMAorQ2xpY2sgdGhlIHRleHQgYmVsb3cgYW5kIHRoZW4gdHJ5IHRvIHNjcm9sbC4KK1BB
U1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorU2Nyb2xsIHBv
c2l0aW9uIGlzIG1vcmUgdGhhbiAwCitQQVNTIGRvY3VtZW50LmJvZHkuc2Nyb2xsVG9wID4gMCBp
cyB0cnVlCisKKworCisKKworCisKKworCisKK015IHNwYW4gCisKKworCisKKworCisKKworCisK
KworCisKKworCisKKworCisKKworCisKKworCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9l
dmVudHMvc2Nyb2xsLWFmdGVyLWNsaWNrLW9uLXRhYi1pbmRleC5odG1sCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1jbGljay1vbi10YWItaW5kZXgu
aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1hZnRl
ci1jbGljay1vbi10YWItaW5kZXguaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1MCBAQAor
PGh0bWw+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj
cmlwdD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBnZXRDZW50ZXJGb3IoZWxlbWVudCkKK3sKKyAgdmFy
IHJlY3QgPSBlbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICByZXR1cm4geyB4IDog
cGFyc2VJbnQoKHJlY3QubGVmdCArIHJlY3QucmlnaHQpIC8gMikgLCB5IDogcGFyc2VJbnQoKHJl
Y3QudG9wICsgcmVjdC5ib3R0b20pIC8gMil9OworfQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sK
KyAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgcmV0dXJuOworICBpZiAo
IXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICByZXR1cm47CisKKyAgbGF5b3V0VGVzdENvbnRyb2xs
ZXIud2FpdFVudGlsRG9uZSgpOworICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7
CisKKyAgYWxlcnQoIlNjcm9sbCBwb3NpdGlvbiAiICsgZG9jdW1lbnQuYm9keS5zY3JvbGxUb3Ap
OworICBjZW50ZXIgPSBnZXRDZW50ZXJGb3IoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNwIikp
OworICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhjZW50ZXIueCwgY2VudGVyLnkpOworICBldmVu
dFNlbmRlci5tb3VzZURvd24oKTsKKyAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworICBldmVudFNl
bmRlci5rZXlEb3duKCJkb3duQXJyb3ciKTsKKyAgc2V0VGltZW91dCh2ZXJpZnlTY3JvbGxpbmcs
IDE1KTsKK30KKworZnVuY3Rpb24gdmVyaWZ5U2Nyb2xsaW5nKCkKK3sKKyAgZGVidWcoIlNjcm9s
bCBwb3NpdGlvbiBpcyBtb3JlIHRoYW4gMCIpOworICBzaG91bGRCZSgiZG9jdW1lbnQuYm9keS5z
Y3JvbGxUb3AgPiAwIiwgInRydWUiKTsKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u
ZSgpOworfQorCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+Cis8
c3R5bGU+Cis8L3N0eWxlPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCk7Ij4KKzxpbnB1dCB0eXBl
PSJyYWRpbyIgaWQ9Im15cmFkaW8iPkNsaWNrIHRoZSB0ZXh0IGJlbG93IGFuZCB0aGVuIHRyeSB0
byBzY3JvbGwuPGJyPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0iLi4v
anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8YnI+PGJyPjxicj48YnI+
PGJyPjxicj48YnI+PGJyPjxicj48YnI+Cis8c3BhbiB0YWJpbmRleD0xIGlkPSJzcCI+TXkgc3Bh
bjwvc3Bhbj4KKzxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJy
Pjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+
Cis8L2JvZHk+Cis8L2h0bWw+CisK
</data>

          </attachment>
      

    </bug>

</bugzilla>