47291 2010-10-06 12:14:16 -0700 [Mac] [DRT] implement setSpatialNavigationEnabled 2010-10-07 21:58:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46905 1 tonikitoo tonikitoo abarth eric simon.fraser webkit.review.bot oldest_to_newest 290508 0 tonikitoo 2010-10-06 12:14:16 -0700 It would make possible to the current spatial navigation 20 layout tests to run on Mac. They currently run on Gtk and Qt only. 290987 1 70082 tonikitoo 2010-10-07 07:18:39 -0700 Created attachment 70082 (committed r69373, r=smfr) patch v1 Implement setSpatialNavigationEnabled to Mac's DRT. It also required additions to WebPreferencesPrivate and WebView in WebKit/Mac side. 291028 2 tonikitoo 2010-10-07 08:35:05 -0700 Simon, we need a Mac guy here. Mind to have a review? 291036 3 70082 simon.fraser 2010-10-07 08:54:06 -0700 Comment on attachment 70082 (committed r69373, r=smfr) patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review > LayoutTests/platform/mac/Skipped:331 > +# Spatial Navigation: test can be affected by font metric differences. > +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html > +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html This is unfortunate. Can the tests be rewritten to avoid this? > WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222 > + // Has mac implementation. This comment seems redundant. 291047 4 tonikitoo 2010-10-07 09:22:57 -0700 (In reply to comment #3) > (From update of attachment 70082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review > > > LayoutTests/platform/mac/Skipped:331 > > +# Spatial Navigation: test can be affected by font metric differences. > > +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html > > +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html > > This is unfortunate. Can the tests be rewritten to avoid this? I am going to do this in a follow up, yes. It has some high priority on my list. I am right now thinking of a smart way we could avoid stuff like this ... > > WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222 > > + // Has mac implementation. > > This comment seems redundant. Many other methods have this, Simon. Ones even have "Has Mac and windows implementation". 291429 5 70082 tonikitoo 2010-10-07 20:57:14 -0700 Comment on attachment 70082 (committed r69373, r=smfr) patch v1 Clearing flags on attachment: 70082. Committed r69373: <http://trac.webkit.org/changeset/69373> 291444 6 webkit.review.bot 2010-10-07 21:58:00 -0700 http://trac.webkit.org/changeset/69373 might have broken SnowLeopard Intel Release (Tests) 70082 2010-10-07 07:18:39 -0700 2010-10-07 20:57:14 -0700 (committed r69373, r=smfr) patch v1 0001-Mac-DRT-implement-setSpatialNavigationEnabled.patch text/plain 12004 tonikitoo RnJvbSBlNjI5ZjA2MTFmZTNlYjY5NzEwNTU2ODA0MzUzYjUwYTA3ZjM1YmMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCA3IE9jdCAyMDEwIDEwOjE0OjA2IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW01h Y10gW0RSVF0gaW1wbGVtZW50IHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZAogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjkxCgpQYXRjaCBieSBBbnRvbmlvIEdv bWVzIDxhZ29tZXNAcmltLmNvbT4gb24gMjAxMC0xMC0wNwpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCldlYkNvcmU6CgpBZGRlZCBTZXR0aW5nczo6c2V0U3BhdGlhbE5hdmlnYXRpb25FbmFi bGVkIHN5bWJvbHMgdG8gV2ViS2l0LmV4cC5pbgpzbyBpdCBjYW4gYmUgdXNlZCBmcm9tIFdlYktp dC9tYWMuCgoqIFdlYkNvcmUuZXhwLmluOgoKV2ViS2l0L21hYzoKCkFkZGVkIHRoZSBuZWVkZWQg Yml0cyB0byBtYWtlIGl0IHBvc3NpYmxlIHRvIGVuYWJsZWQgc3BhdGlhbCBuYXZpZ2F0aW9uCmZv ciB0aGUgTWFjIHBvcnQuIEZvciBub3cgaXQgaXMgYmVpbmcgb25seSB1c2VkIGJ5IERSVC4KCiog V2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaDoKKiBXZWJWaWV3L1dlYlByZWZlcmVu Y2VzLm1tOgooK1tXZWJQcmVmZXJlbmNlcyBpbml0aWFsaXplXSk6CigtW1dlYlByZWZlcmVuY2Vz IGlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkXSk6CigtW1dlYlByZWZlcmVuY2VzIHNldFNwYXRp YWxOYXZpZ2F0aW9uRW5hYmxlZDpdKToKKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5o OgoqIFdlYlZpZXcvV2ViVmlldy5tbToKKC1bV2ViVmlldyBfcHJlZmVyZW5jZXNDaGFuZ2VkTm90 aWZpY2F0aW9uOl0pOgoKV2ViS2l0VG9vbHM6CgpJbXBsZW1lbnRlZCBMYXlvdXRUZXN0Q29udHJv bGxlcjo6c2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkIGZvciBNYWMncyBEUlQKc28gaXQgY2Fu IHRyYWNrIHJlZ3Jlc3Npb24gb24gdGhlIGV4aXN0aW5nIGltcGxlbWVudGF0aW9uIGFuZCBmdXR1 cmUgaW1wcm92ZW1lbnRzCndlIGFyZSBtYWtpbmcuCgoqIER1bXBSZW5kZXJUcmVlL21hYy9MYXlv dXRUZXN0Q29udHJvbGxlck1hYy5tbToKKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFs TmF2aWdhdGlvbkVuYWJsZWQpOgoKTGF5b3V0VGVzdHM6CgpVbnNraXBpbmcgYWxsIHNwYXRpYWwt bmF2aWdhdGlvbiB0ZXN0cyBpbiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24gYnV0IHR3 bwooc25hdi1pZnJhbWUtd2l0aC1vZmZzY3JlZW4tZm9jdXNhYmxlLWVsZW1lbnQuaHRtbCBhbmQg c25hdi11bml0LW92ZXJmbG93LWFuZC1zY3JvbGwtaW4tZGlyZWN0aW9uLmh0bWwpLgpUaGVzZSB3 aWxsIGJlIGZpeGVkIG9uIHRoZWlyIG93biBidWdzLgoKKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoK LS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQgICAg ICAgICAgICAgICAgICAgfCAgICA3ICsrKystLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUvV2Vi Q29yZS5leHAuaW4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMSArCiBXZWJLaXQv bWFjL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysr KysrKysrKysrKysrKwogV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0 ZS5oICAgICAgfCAgICAxICsKIFdlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbSAg ICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViS2l0L21hYy9XZWJWaWV3L1dlYlBy ZWZlcmVuY2VzUHJpdmF0ZS5oICAgICAgICAgfCAgICAzICsrKwogV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlZpZXcubW0gICAgICAgICAgICAgICAgICAgICAgfCAgICAxICsKIFdlYktpdFRvb2xzL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysr KwogLi4uL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcCAgICAgICAgfCAg ICAxICsKIC4uLi9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENvbnRyb2xsZXJNYWMubW0g IHwgICAgMiArLQogMTIgZmlsZXMgY2hhbmdlZCwgODEgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggMzE3YWNjNi4uOWFkMDZjZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEwLTEwLTA3ICBBbnRvbmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW01hY10gW0RSVF0gaW1wbGVtZW50 IHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcyOTEKKworICAgICAgICBVbnNraXBpbmcgYWxsIHNwYXRp YWwtbmF2aWdhdGlvbiB0ZXN0cyBpbiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24gYnV0 IHR3bworICAgICAgICAoc25hdi1pZnJhbWUtd2l0aC1vZmZzY3JlZW4tZm9jdXNhYmxlLWVsZW1l bnQuaHRtbCBhbmQgc25hdi11bml0LW92ZXJmbG93LWFuZC1zY3JvbGwtaW4tZGlyZWN0aW9uLmh0 bWwpLgorICAgICAgICBUaGVzZSB3aWxsIGJlIGZpeGVkIG9uIHRoZWlyIG93biBidWdzLgorCisg ICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6CisKIDIwMTAtMTAtMDYgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHRlc3QgZXhwZWN0 YXRpb24gdXBkYXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBw ZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAppbmRleCAwZjIwMWQwLi44NzYy ZjYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApAQCAtMTIyLDkgKzEyMiw2IEBAIGh0dHAv dGVzdHMvbWlzYy9pbWFnZS1jaGVja3MtZm9yLWFjY2VwdC5odG1sCiAjIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTYzMQogc3ZnL2N1c3RvbS90aWxpbmctcmVndWxh ci1oZXhhZ29uYWwtY3Jhc2guc3ZnCiAKLSMgTmVlZCB0byBhZGQgZnVuY3Rpb25hbGl0eSB0byBE dW1wUmVuZGVyVHJlZSB0byBoYW5kbGUgZW5hYmxlL2Rpc2FibGUgU3BhdGlhbCBOYXZpZ2F0aW9u Ci1mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24KLQogIyBGb3Igc29tZSByZWFzb24gY3Jh c2hlcyB3aGVuIHJ1biB3aXRoIGFsbCB0ZXN0cy4gUGFzc2VzIGluZGl2aWR1YWxseS4KIGZhc3Qv Zm9ybXMvbXVsdGlwbGUtZm9ybS1zdWJtaXNzaW9uLXByb3RlY3Rpb24tbW91c2UuaHRtbAogCkBA IC0zMjgsMyArMzI1LDcgQEAgcGx1Z2lucy9pZnJhbWUtc2hpbXMuaHRtbAogIyBUaGlzIG5ldyB0 ZXN0IHJ1bnMgZGlmZmVyZW50bHkgb24gdGhlIGJ1aWxkYm90IHRoYW4gaXQgZG9lc24gb24gdXNl cgogIyBtYWNoaW5lcy4gIEknbGwgYXNrIGpuZCB0byBmaXggaXQgb25jZSBoZSdzIGJhY2sgZnJv bSB2YWNhdGlvbi4KIHBsdWdpbnMvcGx1Z2luLWluaXRpYXRlLXBvcHVwLXdpbmRvdy5odG1sCisK KyMgU3BhdGlhbCBOYXZpZ2F0aW9uOiB0ZXN0IGNhbiBiZSBhZmZlY3RlZCBieSBmb250IG1ldHJp YyBkaWZmZXJlbmNlcy4KK2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWlmcmFt ZS13aXRoLW9mZnNjcmVlbi1mb2N1c2FibGUtZWxlbWVudC5odG1sCitmYXN0L2V2ZW50cy9zcGF0 aWFsLW5hdmlnYXRpb24vc25hdi11bml0LW92ZXJmbG93LWFuZC1zY3JvbGwtaW4tZGlyZWN0aW9u Lmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggNmJmZmQ1Mi4uNmM3Y2ViZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0wNyAgQW50b25p byBHb21lcyAgPGFnb21lc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtNYWNdIFtEUlRdIGltcGxlbWVudCBzZXRTcGF0aWFsTmF2aWdh dGlvbkVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ3MjkxCisKKyAgICAgICAgQWRkZWQgU2V0dGluZ3M6OnNldFNwYXRpYWxOYXZpZ2F0aW9u RW5hYmxlZCBzeW1ib2xzIHRvIFdlYktpdC5leHAuaW4KKyAgICAgICAgc28gaXQgY2FuIGJlIHVz ZWQgZnJvbSBXZWJLaXQvbWFjLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTAt MTAtMDYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5leHAu aW4gYi9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IDY1ZDJhZTkuLmFmNzVjYWMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvV2ViQ29yZS9XZWJDb3JlLmV4cC5p bgpAQCAtNzI4LDYgKzcyOCw3IEBAIF9fWk43V2ViQ29yZThTZXR0aW5nczI0c2V0RE5TUHJlZmV0 Y2hpbmdFbmFibGVkRWIKIF9fWk43V2ViQ29yZThTZXR0aW5nczI0c2V0VGV4dEFyZWFzQXJlUmVz aXphYmxlRWIKIF9fWk43V2ViQ29yZThTZXR0aW5nczI1c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxl ZEViCiBfX1pON1dlYkNvcmU4U2V0dGluZ3MyNXNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWRFYgor X19aTjdXZWJDb3JlOFNldHRpbmdzMjdzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWRFYgogX19a TjdXZWJDb3JlOFNldHRpbmdzMjVzZXRNaW5pbXVtTG9naWNhbEZvbnRTaXplRWkKIF9fWk43V2Vi Q29yZThTZXR0aW5nczI1c2V0TmVlZHNMZW9wYXJkTWFpbFF1aXJrc0ViCiBfX1pON1dlYkNvcmU4 U2V0dGluZ3MyNXNldFByaXZhdGVCcm93c2luZ0VuYWJsZWRFYgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCBkNDIwYmVmLi5lZGQz YjQyIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9XZWJLaXQvbWFjL0No YW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEwLTEwLTA3ICBBbnRvbmlvIEdvbWVzICA8YWdv bWVzQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW01hY10gW0RSVF0gaW1wbGVtZW50IHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcyOTEKKwor ICAgICAgICBBZGRlZCB0aGUgbmVlZGVkIGJpdHMgdG8gbWFrZSBpdCBwb3NzaWJsZSB0byBlbmFi bGVkIHNwYXRpYWwgbmF2aWdhdGlvbgorICAgICAgICBmb3IgdGhlIE1hYyBwb3J0LiBGb3Igbm93 IGl0IGlzIGJlaW5nIG9ubHkgdXNlZCBieSBEUlQuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlBy ZWZlcmVuY2VLZXlzUHJpdmF0ZS5oOgorICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXMu bW06CisgICAgICAgICgrW1dlYlByZWZlcmVuY2VzIGluaXRpYWxpemVdKToKKyAgICAgICAgKC1b V2ViUHJlZmVyZW5jZXMgaXNTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWRdKToKKyAgICAgICAgKC1b V2ViUHJlZmVyZW5jZXMgc2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkOl0pOgorICAgICAgICAq IFdlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmg6CisgICAgICAgICogV2ViVmlldy9XZWJW aWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9wcmVmZXJlbmNlc0NoYW5nZWROb3RpZmljYXRp b246XSk6CisKIDIwMTAtMTAtMDUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBh L1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaCBiL1dlYktpdC9t YWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAppbmRleCA4MTE5NjQ5Li5jZDll ZDhmIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2 YXRlLmgKKysrIGIvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5o CkBAIC05Niw2ICs5Niw3IEBACiAjZGVmaW5lIFdlYktpdFVzZXNQcm94aWVkT3BlblBhbmVsUHJl ZmVyZW5jZUtleSBAIldlYktpdFVzZXNQcm94aWVkT3BlblBhbmVsIgogI2RlZmluZSBXZWJLaXRQ bHVnaW5BbGxvd2VkUnVuVGltZVByZWZlcmVuY2VLZXkgQCJXZWJLaXRQbHVnaW5BbGxvd2VkUnVu VGltZSIKICNkZWZpbmUgV2ViS2l0RnJhbWVGbGF0dGVuaW5nRW5hYmxlZFByZWZlcmVuY2VLZXkg QCJXZWJLaXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVkIgorI2RlZmluZSBXZWJLaXRTcGF0aWFsTmF2 aWdhdGlvbkVuYWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0U3BhdGlhbE5hdmlnYXRpb25FbmFi bGVkIgogI2RlZmluZSBXZWJLaXRQYWdpbmF0ZUR1cmluZ0xheW91dEVuYWJsZWRQcmVmZXJlbmNl S2V5IEAiV2ViS2l0UGFnaW5hdGVEdXJpbmdMYXlvdXRFbmFibGVkIgogI2RlZmluZSBXZWJLaXRE TlNQcmVmZXRjaGluZ0VuYWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0RE5TUHJlZmV0Y2hpbmdF bmFibGVkIgogI2RlZmluZSBXZWJLaXRGdWxsU2NyZWVuRW5hYmxlZFByZWZlcmVuY2VLZXkgQCJX ZWJLaXRGdWxsU2NyZWVuRW5hYmxlZCIKZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJQcmVmZXJlbmNlcy5tbSBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQpp bmRleCAyZGRkOGIzLi5jY2ZiNjMyIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi UHJlZmVyZW5jZXMubW0KKysrIGIvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1t CkBAIC0zNjUsNiArMzY1LDcgQEAgc3RhdGljIFdlYkNhY2hlTW9kZWwgY2FjaGVNb2RlbEZvck1h aW5CdW5kbGUodm9pZCkKICAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOk5PXSwgICBX ZWJLaXRVc2VzUHJveGllZE9wZW5QYW5lbFByZWZlcmVuY2VLZXksCiAgICAgICAgIFtOU051bWJl ciBudW1iZXJXaXRoVW5zaWduZWRJbnQ6NF0sIFdlYktpdFBsdWdpbkFsbG93ZWRSdW5UaW1lUHJl ZmVyZW5jZUtleSwKICAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOk5PXSwgICBXZWJL aXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVkUHJlZmVyZW5jZUtleSwKKyAgICAgICAgW05TTnVtYmVy IG51bWJlcldpdGhCb29sOk5PXSwgICBXZWJLaXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWRQcmVm ZXJlbmNlS2V5LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6WUVTXSwgIFdlYktp dEROU1ByZWZldGNoaW5nRW5hYmxlZFByZWZlcmVuY2VLZXksCiAgICAgICAgIFtOU051bWJlciBu dW1iZXJXaXRoQm9vbDpOT10sICAgV2ViS2l0RnVsbFNjcmVlbkVuYWJsZWRQcmVmZXJlbmNlS2V5 LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6Tk9dLCAgIFdlYktpdE1lbW9yeUlu Zm9FbmFibGVkUHJlZmVyZW5jZUtleSwKQEAgLTEzMTMsNiArMTMxNCwxNiBAQCBzdGF0aWMgTlNT dHJpbmcgKmNsYXNzSUJDcmVhdG9ySUQgPSBuaWw7CiAgICAgW3NlbGYgX3NldEJvb2xWYWx1ZTpm bGFnIGZvcktleTpXZWJLaXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVkUHJlZmVyZW5jZUtleV07CiB9 CiAKKy0gKEJPT0wpaXNTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQKK3sKKyAgICByZXR1cm4gW3Nl bGYgX2Jvb2xWYWx1ZUZvcktleTpXZWJLaXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWRQcmVmZXJl bmNlS2V5XTsKK30KKworLSAodm9pZClzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQ6KEJPT0wp ZmxhZworeworICAgIFtzZWxmIF9zZXRCb29sVmFsdWU6ZmxhZyBmb3JLZXk6V2ViS2l0U3BhdGlh bE5hdmlnYXRpb25FbmFibGVkUHJlZmVyZW5jZUtleV07Cit9CisKIC0gKEJPT0wpcGFnaW5hdGVE dXJpbmdMYXlvdXRFbmFibGVkCiB7CiAgICAgcmV0dXJuIFtzZWxmIF9ib29sVmFsdWVGb3JLZXk6 V2ViS2l0UGFnaW5hdGVEdXJpbmdMYXlvdXRFbmFibGVkUHJlZmVyZW5jZUtleV07CmRpZmYgLS1n aXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmggYi9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgKaW5kZXggYmI1MjVjZC4uNDdlNmQ3 MSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5o CisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaApAQCAtMTMw LDYgKzEzMCw5IEBAIGV4dGVybiBOU1N0cmluZyAqV2ViUHJlZmVyZW5jZXNSZW1vdmVkTm90aWZp Y2F0aW9uOwogLSAoQk9PTClpc0ZyYW1lRmxhdHRlbmluZ0VuYWJsZWQ7CiAtICh2b2lkKXNldEZy YW1lRmxhdHRlbmluZ0VuYWJsZWQ6KEJPT0wpZmxhZzsKIAorLSAoQk9PTClpc1NwYXRpYWxOYXZp Z2F0aW9uRW5hYmxlZDsKKy0gKHZvaWQpc2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkOihCT09M KWZsYWc7CisKIC8vIHplcm8gbWVhbnMgZG8gQXV0b1NjYWxlCiAtIChmbG9hdClQREZTY2FsZUZh Y3RvcjsKIC0gKHZvaWQpc2V0UERGU2NhbGVGYWN0b3I6KGZsb2F0KXNjYWxlOwpkaWZmIC0tZ2l0 IGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi Vmlldy5tbQppbmRleCAxMjdkNzIyLi4zMjgzNzQyIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViVmlldy5tbQorKysgYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQpAQCAt MTQ3Miw2ICsxNDcyLDcgQEAgc3RhdGljIGJvb2wgZmFzdERvY3VtZW50VGVhcmRvd25FbmFibGVk KCkKICAgICBzZXR0aW5ncy0+c2V0QWNjZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWQoW3ByZWZlcmVu Y2VzIGFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkXSk7CiAgICAgc2V0dGluZ3MtPnNldExvYWRE ZWZlcnJpbmdFbmFibGVkKHNob3VsZEVuYWJsZUxvYWREZWZlcnJpbmcoKSk7CiAgICAgc2V0dGlu Z3MtPnNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoW3ByZWZlcmVuY2VzIGlzRnJhbWVGbGF0dGVu aW5nRW5hYmxlZF0pOworICAgIHNldHRpbmdzLT5zZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQo W3ByZWZlcmVuY2VzIGlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkXSk7CiAgICAgc2V0dGluZ3Mt PnNldFBhZ2luYXRlRHVyaW5nTGF5b3V0RW5hYmxlZChbcHJlZmVyZW5jZXMgcGFnaW5hdGVEdXJp bmdMYXlvdXRFbmFibGVkXSk7CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogICAgIHNldHRp bmdzLT5zZXRGdWxsU2NyZWVuRW5hYmxlZChbcHJlZmVyZW5jZXMgZnVsbFNjcmVlbkVuYWJsZWRd KTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5n ZUxvZwppbmRleCBiMDU1M2EzLi4wYTFlMTdiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAt MTAtMDcgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbTWFjXSBbRFJUXSBpbXBsZW1lbnQgc2V0 U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NzI5MQorCisgICAgICAgIEltcGxlbWVudGVkIExheW91dFRlc3RD b250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQgZm9yIE1hYydzIERSVAorICAg ICAgICBzbyBpdCBjYW4gdHJhY2sgcmVncmVzc2lvbiBvbiB0aGUgZXhpc3RpbmcgaW1wbGVtZW50 YXRpb24gYW5kIGZ1dHVyZSBpbXByb3ZlbWVudHMKKyAgICAgICAgd2UgYXJlIG1ha2luZy4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbToK KyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJs ZWQpOgorCiAyMDEwLTEwLTA2ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGVlNDQzMjUu LjBhN2MxMWYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRl c3RDb250cm9sbGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlvdXRU ZXN0Q29udHJvbGxlci5jcHAKQEAgLTEyMTksNiArMTIxOSw3IEBAIHN0YXRpYyBKU1ZhbHVlUmVm IHNldFhTU0F1ZGl0b3JFbmFibGVkQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2Jq ZWN0UmVmCiAKIHN0YXRpYyBKU1ZhbHVlUmVmIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZENh bGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmpl Y3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYg YXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKIHsKKyAgICAvLyBIYXMgbWFjIGlt cGxlbWVudGF0aW9uLgogICAgIGlmIChhcmd1bWVudENvdW50IDwgMSkKICAgICAgICAgcmV0dXJu IEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENvbnRyb2xsZXJNYWMubW0gYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENvbnRyb2xsZXJNYWMubW0KaW5kZXgg ZDJhNmY3OS4uYzY2YzlkYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv bWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbQpAQCAtNDIyLDcgKzQyMiw3IEBA IHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoYm9v bCBlbmFibGVkKQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdh dGlvbkVuYWJsZWQoYm9vbCBlbmFibGVkKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgZm9y IFNwYXRpYWxOYXZpZ2F0aW9uIGxheW91dCB0ZXN0cy4KKyAgICBbW1ttYWluRnJhbWUgd2ViVmll d10gcHJlZmVyZW5jZXNdIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZDplbmFibGVkXTsKIH0K IAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9t RmlsZVVSTHMoYm9vbCBlbmFibGVkKQotLSAKMS43LjMKCg==