<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>4714</bug_id>
          
          <creation_ts>2005-08-28 11:16:32 -0700</creation_ts>
          <short_desc>NodeIterator does not handle exceptions from the filter function (affects Acid3)</short_desc>
          <delta_ts>2019-02-06 09:03:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>17064</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Adler">darin</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          <cc>cdumez</cc>
    
    <cc>eric</cc>
    
    <cc>ian</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>17811</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-08-28 11:16:32 -0700</bug_when>
    <thetext>Looking at the NodeIterator code, it&apos;s clear that it doesn&apos;t do the right thing in the presence of exceptions. 
If the filter function raises an exception, the standard says that the exception should be propagated to the 
caller of nextNode or previousNode.

But our NodeIterator implementation does not attempt to do that. Also, it calls the filter function from the 
&quot;node removed&quot; hook; it&apos;s not at all clear if it&apos;s appropriate to do so, nor what happens if the filter function 
raises an exception in that case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66575</commentid>
    <comment_count>1</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-01-08 13:02:43 -0800</bug_when>
    <thetext>*** Bug 16744 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66577</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-01-08 13:04:08 -0800</bug_when>
    <thetext>*** Bug 16743 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66578</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-01-08 13:04:35 -0800</bug_when>
    <thetext>Need to make sure when fixing this that we pass both test cases from Acid3, the one in bug 16743 and the one in bug 16744.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66635</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-01-08 22:52:21 -0800</bug_when>
    <thetext>Bug 3492 now has a patch that addresses this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>69759</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-02-08 02:36:07 -0800</bug_when>
    <thetext>Committed revision 30089.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502921</commentid>
    <comment_count>6</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2019-02-06 09:03:11 -0800</bug_when>
    <thetext>Mass moving XML DOM bugs to the &quot;DOM&quot; Component.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>